106364 2013-01-08 12:29:59 -0800 [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses 2013-01-08 13:26:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan eric oldest_to_newest 802505 0 zan 2013-01-08 12:29:59 -0800 [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses 802510 1 181729 zan 2013-01-08 12:32:45 -0800 Created attachment 181729 Patch 802519 2 181729 eric 2013-01-08 12:40:22 -0800 Comment on attachment 181729 Patch LGTM. 802573 3 zan 2013-01-08 13:26:43 -0800 Committed r139102: <http://trac.webkit.org/changeset/139102> 181729 2013-01-08 12:32:45 -0800 2013-01-08 12:40:22 -0800 Patch bug-106364-20130108212950.patch text/plain 3126 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDIwZDgzNmE2YjE0MzBiYzE4MTc5MTNmZDZlZDdiOTI1 YTc3ODNmNy4uZmYwZGMxZTM1OWIxYzc5MGU5YmI5NGU4MDJlMjhkODYzNTA0MTBjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDEzLTAxLTA4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAK KyAgICAgICAgW3dlYmtpdHB5XSBDYWxsIHNldHVwX3Rlc3RfcnVuIG1ldGhvZCBvZiB0aGUgcGFy ZW50IFBvcnQgaW50ZXJmYWNlIHdoZW4gbWV0aG9kIGlzIGNhbGxlZCBvbiBzdWJjbGFzc2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYzNjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBz ZXR1cF90ZXN0X3J1biBtZXRob2QgaXMgY2FsbGVkIG9uIHRoZSBzdWJjbGFzc2VzIG9mIHRoZSBi YXNlIFBvcnQKKyAgICAgICAgaW50ZXJmYWNlLCB0aGUgcGFyZW50IG1ldGhvZCBzaG91bGQgYWxz byBiZSBjYWxsZWQgdmlhIHN1cGVyKCksIGRlc3BpdGUgdGhlCisgICAgICAgIHBhcmVudCBtZXRo b2Qgbm90IGRvaW5nIGFueXRoaW5nIGF0IHRoZSBtb21lbnQuCisKKyAgICAgICAgVGhlIGFjY29y ZGluZyBjYWxscyB0byBzdXBlcigpIGFyZSByZXF1aXJlZCBpbiB0aGUgQ2hyb21pdW1Qb3J0LCBF ZmxQb3J0CisgICAgICAgIGFuZCBHdGtQb3J0IGltcGxlbWVudGF0aW9ucy4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHk6CisgICAgICAg IChDaHJvbWl1bVBvcnQuc2V0dXBfdGVzdF9ydW4pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5OgorICAgICAgICAoRWZsUG9ydC5zZXR1cF90ZXN0 X3J1bik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsu cHk6CisgICAgICAgIChHdGtQb3J0LnNldHVwX3Rlc3RfcnVuKToKKworMjAxMy0wMS0wOCAgWmFu IERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCiAgICAgICAgIFtHVEtdIExvd2Vy IHRoZSBkZWZhdWx0IHRpbWVvdXQgdmFsdWUgZm9yIFdlYktpdFRlc3RSdW5uZXIKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjM1MwogCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpp bmRleCA2MTVhNWViNDZhMGQxMWQ4NmQ4YTQ3ZmRmNzRkOTI4ZTdiODRmMTIzLi5jMmE4YWQ5M2Qw ZTM3NTgwOTc2ZThiYTg2ZmY4M2ZlNTMzYjNmYjEzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKQEAgLTI4OCw2ICsyODgs NyBAQCBjbGFzcyBDaHJvbWl1bVBvcnQoUG9ydCk6CiAgICAgICAgIH0KIAogICAgIGRlZiBzZXR1 cF90ZXN0X3J1bihzZWxmKToKKyAgICAgICAgc3VwZXIoQ2hyb21pdW1Qb3J0LCBzZWxmKS5zZXR1 cF90ZXN0X3J1bigpCiAgICAgICAgICMgRGVsZXRlIHRoZSBkaXNrIGNhY2hlIGlmIGFueSB0byBl bnN1cmUgYSBjbGVhbiB0ZXN0IHJ1bi4KICAgICAgICAgZHVtcF9yZW5kZXJfdHJlZV9iaW5hcnlf cGF0aCA9IHNlbGYuX3BhdGhfdG9fZHJpdmVyKCkKICAgICAgICAgY2FjaGVkaXIgPSBzZWxmLl9m aWxlc3lzdGVtLmRpcm5hbWUoZHVtcF9yZW5kZXJfdHJlZV9iaW5hcnlfcGF0aCkKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwucHkKaW5kZXggMGM5YWNk OGQ4ZGVmODEwZmU0MDQzMmY0Yzg2OGFkMzYxNDQyYTljMC4uNzJjMDVjYTYxM2RmMmU5NTkyMTc5 ZDJmZTFkNDYyMTY2YjU4YzFkNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9lZmwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9lZmwucHkKQEAgLTQ5LDYgKzQ5LDcgQEAgY2xhc3MgRWZsUG9ydChQb3J0 LCBQdWxzZUF1ZGlvU2FuaXRpemVyKToKICAgICAgICAgcmV0dXJuICItLWVmbCIKIAogICAgIGRl ZiBzZXR1cF90ZXN0X3J1bihzZWxmKToKKyAgICAgICAgc3VwZXIoRWZsUG9ydCwgc2VsZikuc2V0 dXBfdGVzdF9ydW4oKQogICAgICAgICBzZWxmLl91bmxvYWRfcHVsc2VhdWRpb19tb2R1bGUoKQog CiAgICAgZGVmIHNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZWxmLCBzZXJ2ZXJfbmFtZT1Ob25l KToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Z3RrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkK aW5kZXggY2Q3Y2JiMjFiN2QwMGZhMzA3NzJhNDhhY2I5NDMwMDBlNjk0MDc2Ni4uMDUyMmNmODdj ZmVjYWU0Mjg2NzU3ZjFkYWQ0N2JkMGQyZmUzNTllZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKQEAgLTUzLDYgKzUzLDcgQEAgY2xhc3Mg R3RrUG9ydChQb3J0LCBQdWxzZUF1ZGlvU2FuaXRpemVyKToKICAgICAgICAgcmV0dXJuIDYgKiAx MDAwCiAKICAgICBkZWYgc2V0dXBfdGVzdF9ydW4oc2VsZik6CisgICAgICAgIHN1cGVyKEd0a1Bv cnQsIHNlbGYpLnNldHVwX3Rlc3RfcnVuKCkKICAgICAgICAgc2VsZi5fdW5sb2FkX3B1bHNlYXVk aW9fbW9kdWxlKCkKIAogICAgIGRlZiBjbGVhbl91cF90ZXN0X3J1bihzZWxmKToK