106356 2013-01-08 11:32:55 -0800 Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders 2013-01-08 12:34:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth dpranke ojan tony webkit.review.bot oldest_to_newest 802437 0 jparent 2013-01-08 11:32:55 -0800 Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders 802442 1 181716 jparent 2013-01-08 11:37:03 -0800 Created attachment 181716 Patch 802457 2 181716 dpranke 2013-01-08 11:54:29 -0800 Comment on attachment 181716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181716&action=review > Tools/TestResultServer/static-dashboards/loader.js:81 > + resourceLoadingComplete(this._getLoadingErrorMessages()); I probably would've just inlined _getLoadingErrorMessages() here; it looks like this is the only caller, right? 802461 3 181716 jparent 2013-01-08 11:56:58 -0800 Comment on attachment 181716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181716&action=review >> Tools/TestResultServer/static-dashboards/loader.js:81 >> + resourceLoadingComplete(this._getLoadingErrorMessages()); > > I probably would've just inlined _getLoadingErrorMessages() here; it looks like this is the only caller, right? Yeah, it is the only caller. It seemed cleaner to me to have it separate, particularly as I was imagining a future world where we might have more robust or numerous errors, and having all of that logic dumped inside of here would clog it up. Happy to make that change if you prefer though. 802480 4 dpranke 2013-01-08 12:12:16 -0800 it's up to you. 802513 5 181716 webkit.review.bot 2013-01-08 12:34:30 -0800 Comment on attachment 181716 Patch Clearing flags on attachment: 181716 Committed r139097: <http://trac.webkit.org/changeset/139097> 802514 6 webkit.review.bot 2013-01-08 12:34:33 -0800 All reviewed patches have been landed. Closing bug. 181716 2013-01-08 11:37:03 -0800 2013-01-08 12:34:30 -0800 Patch bug-106356-20130108113407.patch text/plain 8647 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGU4NzQwY2UyMDRiMjUxYWIxNTQ1NzkzM2JjODA3Y2I5 ODA4MDRhOC4uMzY3NzNiM2RjNmI3NzE1ZmVmYTU4NTY0NmIxMTM0MGFkYzZjNWU5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5 IEBACiAyMDEzLTAxLTA4ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KIAor ICAgICAgICBEYXNoYm9hcmQgY2xlYW51cDogUmVtb3ZlIGdsb2JhbHMgZ19idWlsZGVyc1RoYXRG YWlsZWRUb0xvYWQgYW5kIGdfc3RhbGVCdWlsZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MzU2CisKKyAgICAgICAgZ19idWlsZGVyc1RoYXRG YWlsZWRUb0xvYWQgYW5kIGdfc3RhbGVCdWlsZGVycyB3ZXJlIGdsb2JhbHMgZGVmaW5lZCBpbgor ICAgICAgICBkYXNoYm9hcmRfYmFzZSwgYXNzaWduZWQgYnkgTG9hZGVyLCBhbmQgdXNlZCBvbmx5 IGJ5IGRhc2hib2FyZF9iYXNlIHRvCisgICAgICAgIGNyZWF0ZSBlcnJvciBtZXNzYWdlcy4gIE1v dmVkIHRoZSB2YXJpYWJsZXMgdG8gYmUgcHJpdmF0ZXMgb24gdGhlIExvYWRlcgorICAgICAgICBv YmplY3QsIG1vdmVkIGVycm9yIG1lc3NhZ2UgY3JlYXRpb24gdG8gX2dldExvYWRpbmdFcnJvck1l c3NhZ2VzIG9uIHRoZQorICAgICAgICBMb2FkZXIgb2JqZWN0LCBhbmQgbm93IHBhc3MgdGhlIGVy cm9ycyBiYWNrIHRvIGRhc2hib2FyZCBiYXNlIHZpYSB0aGUKKyAgICAgICAgcmVzb3VyY2VMb2Fk aW5nQ29tcGxldGUgY2FsbGJhY2suCisgICAgICAgIAorICAgICAgICBBbHNvIHJlbW92ZWQgdGhl IG5vdyB1bnVzZWQgY2xlYXJFcnJvciBmdW5jdGlvbiwgaXQgd2FzIG9ubHkgYmVpbmcgdXNlZAor ICAgICAgICBieSB1bml0IHRlc3RzIHRvIGNsZWFuIHVwIGdsb2JhbCBzdGF0ZS4KKyAgICAgICAg CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qczoKKyAgICAgICAg KHJlc291cmNlTG9hZGluZ0NvbXBsZXRlKToKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0 YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzOgorICAgICAg ICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVyLmpzOgorICAgICAg ICAoLik6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2Fk ZXJfdW5pdHRlc3RzLmpzOgorCisyMDEzLTAxLTA4ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNo cm9taXVtLm9yZz4KKwogICAgICAgICBEYXNoYm9hcmQgQ2xlYW51cDogUmVtb3ZlIGdfaGFzRG9u ZUluaXRpYWxQYWdlR2VuZXJhdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA2MjU0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMgYi9Ub29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzCmluZGV4IDI0MjBiYjFh NmVkNzM3NzViMjczZjE4ZDg4ZmQ4NzM3NDU0OTFmNjguLjlmODVjMzBlYTUzM2FkYWQ1NTNkOGYx YjgyNWUwYTg1ZmMwNzBmOWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3Rh dGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcwpAQCAtNDI5LDggKzQyOSw2 IEBAIGZ1bmN0aW9uIGlzVGlwT2ZUcmVlV2ViS2l0QnVpbGRlcigpCiAKIHZhciBnX3Jlc3VsdHNC eUJ1aWxkZXIgPSB7fTsKIHZhciBnX2V4cGVjdGF0aW9uc0J5UGxhdGZvcm0gPSB7fTsKLXZhciBn X3N0YWxlQnVpbGRlcnMgPSBbXTsKLXZhciBnX2J1aWxkZXJzVGhhdEZhaWxlZFRvTG9hZCA9IFtd OwogCiAvLyBUT0RPKGFib3hoYWxsKTogZmlndXJlIG91dCB3aGV0aGVyIHRoaXMgaXMgYSBwZXJm b3JtYW5jZSBib3R0bGVuZWNrIGFuZAogLy8gY2hhbmdlIGNhbGxpbmcgY29kZSB0byB1bmRlcnN0 YW5kIHRoZSB0cmllIHN0cnVjdHVyZSBpbnN0ZWFkIGlmIG5lY2Vzc2FyeS4KQEAgLTQ3MiwxMSAr NDcwLDYgQEAgZnVuY3Rpb24gYWRkRXJyb3IoZXJyb3JNc2cpCiAgICAgZ19lcnJvck1lc3NhZ2Vz ICs9IGVycm9yTXNnICsgJzxicj4nOwogfQogCi0vLyBDbGVhciBvdXQgZXJyb3IgYW5kIHdhcm5p bmcgbWVzc2FnZXMuCi1mdW5jdGlvbiBjbGVhckVycm9ycygpCi17Ci0gICAgZ19lcnJvck1lc3Nh Z2VzID0gJyc7Ci19CiAKIC8vIElmIHRoZXJlIGFyZSBlcnJvcnMsIHNob3cgYmlnIGFuZCByZWQg VUkgZm9yIGVycm9ycyBzbyBhcyB0byBiZSBub3RpY2VkLgogZnVuY3Rpb24gc2hvd0Vycm9ycygp CkBAIC00OTksMTkgKzQ5MiwxMyBAQCBmdW5jdGlvbiBzaG93RXJyb3JzKCkKICAgICBlcnJvcnMu aW5uZXJIVE1MID0gZ19lcnJvck1lc3NhZ2VzOwogfQogCi1mdW5jdGlvbiBhZGRCdWlsZGVyTG9h ZEVycm9ycygpCi17Ci0gICAgaWYgKGdfYnVpbGRlcnNUaGF0RmFpbGVkVG9Mb2FkLmxlbmd0aCkK LSAgICAgICAgYWRkRXJyb3IoJ0VSUk9SOiBGYWlsZWQgdG8gZ2V0IGRhdGEgZnJvbSAnICsgZ19i dWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQudG9TdHJpbmcoKSArICcuJyk7Ci0KLSAgICBpZiAoZ19z dGFsZUJ1aWxkZXJzLmxlbmd0aCkKLSAgICAgICAgYWRkRXJyb3IoJ0VSUk9SOiBEYXRhIGZyb20g JyArIGdfc3RhbGVCdWlsZGVycy50b1N0cmluZygpICsgJyBpcyBtb3JlIHRoYW4gMSBkYXkgc3Rh bGUuJyk7Ci19Ci0KLWZ1bmN0aW9uIHJlc291cmNlTG9hZGluZ0NvbXBsZXRlKCkKK2Z1bmN0aW9u IHJlc291cmNlTG9hZGluZ0NvbXBsZXRlKGVycm9yTXNncykKIHsKICAgICBnX3Jlc291cmNlTG9h ZGVyID0gbnVsbDsKLSAgICBhZGRCdWlsZGVyTG9hZEVycm9ycygpOworICAgIAorICAgIGlmIChl cnJvck1zZ3MpCisgICAgICAgIGFkZEVycm9yKGVycm9yTXNncykKKwogICAgIGhhbmRsZUxvY2F0 aW9uQ2hhbmdlKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3Rh dGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMgYi9Ub29scy9U ZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5p dHRlc3RzLmpzCmluZGV4IDliMTY4ZjI4NWNjMWEwMWFjZWY4MGU2Y2UwOTE4NTRlODQ5NjA2ZjUu LmI1NzJjN2EyYzc0OTdiOGZiODRlMGE1ZTI2YTE5MzAwMTZjMjc4M2QgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2Fy ZF91bml0dGVzdHMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJv YXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcwpAQCAtNTk3LDEzICs1OTcsNiBA QCB0ZXN0KCdkaWZmU3RhdGVzJywgNSwgZnVuY3Rpb24oKSB7CiAgICAgZGVlcEVxdWFsKGRpZmZT dGF0ZXMob2xkU3RhdGUsIG5ld1N0YXRlKSwge2E6IDEsIGI6IDJ9KTsKIH0pOwogCi10ZXN0KCdh ZGRCdWlsZGVyTG9hZEVycm9ycycsIDEsIGZ1bmN0aW9uKCkgewotICAgIGNsZWFyRXJyb3JzKCk7 Ci0gICAgZ19idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQgPSBbJ2J1aWxkZXIxJywgJ2J1aWxkZXIy J107Ci0gICAgZ19zdGFsZUJ1aWxkZXJzID0gWydzdGFsZUJ1aWxkZXIxJ107Ci0gICAgYWRkQnVp bGRlckxvYWRFcnJvcnMoKTsKLSAgICBlcXVhbChnX2Vycm9yTWVzc2FnZXMsICdFUlJPUjogRmFp bGVkIHRvIGdldCBkYXRhIGZyb20gYnVpbGRlcjEsYnVpbGRlcjIuPGJyPkVSUk9SOiBEYXRhIGZy b20gc3RhbGVCdWlsZGVyMSBpcyBtb3JlIHRoYW4gMSBkYXkgc3RhbGUuPGJyPicpOwotfSk7CiAK IHRlc3QoJ2J1aWxkZXJHcm91cElzVG9UV2ViS2l0QXR0cmlidXRlJywgMiwgZnVuY3Rpb24oKSB7 CiAgICAgdmFyIGR1bW15TWFzdGVyID0gbmV3IGJ1aWxkZXJzLkJ1aWxkZXJNYXN0ZXIoJ0Nocm9t aXVtJywgJ2R1bW15dXJsJywgeydsYXlvdXQtdGVzdHMnOiB7J2J1aWxkZXJzJzogWydXZWJLaXQg TGludXgnLCAnV2ViS2l0IExpbnV4IChkYmcpJywgJ1dlYktpdCBNYWMxMC43JywgJ1dlYktpdCBX aW4nXX19KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hi b2FyZHMvbG9hZGVyLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk cy9sb2FkZXIuanMKaW5kZXggODQ5YzljOWFlOTA3NGI2ZGRhYzY2MDFkM2JjOWNiMmU5NThiYzQw My4uZWQzYzRmNzg5OGFlZWRiODc0ZGM4MjI2ZjQwN2ZiMDRiYzYzZTNmYyAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXIuanMKKysrIGIv VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXIuanMKQEAgLTY0 LDYgKzY0LDkgQEAgbG9hZGVyLkxvYWRlciA9IGZ1bmN0aW9uKCkKICAgICAgICAgdGhpcy5fbG9h ZFJlc3VsdHNGaWxlcywKICAgICAgICAgdGhpcy5fbG9hZEV4cGVjdGF0aW9uc0ZpbGVzLAogICAg IF07CisKKyAgICB0aGlzLl9idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQgPSBbXTsKKyAgICB0aGlz Ll9zdGFsZUJ1aWxkZXJzID0gW107CiB9CiAKIGxvYWRlci5Mb2FkZXIucHJvdG90eXBlID0gewpA QCAtNzUsNyArNzgsNyBAQCBsb2FkZXIuTG9hZGVyLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAg ICAgIHZhciBsb2FkaW5nU3RlcCA9IHRoaXMuX2xvYWRpbmdTdGVwcy5zaGlmdCgpOwogICAgICAg ICBpZiAoIWxvYWRpbmdTdGVwKSB7Ci0gICAgICAgICAgICByZXNvdXJjZUxvYWRpbmdDb21wbGV0 ZSgpOworICAgICAgICAgICAgcmVzb3VyY2VMb2FkaW5nQ29tcGxldGUodGhpcy5fZ2V0TG9hZGlu Z0Vycm9yTWVzc2FnZXMoKSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAg ICAgbG9hZGluZ1N0ZXAuYXBwbHkodGhpcyk7CkBAIC0xNTAsNyArMTUzLDcgQEAgbG9hZGVyLkxv YWRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAg ICAgIGlmICgoRGF0ZS5ub3coKSAvIDEwMDApIC0gbGFzdFJ1blNlY29uZHMgPiBPTkVfREFZX1NF Q09ORFMpCi0gICAgICAgICAgICAgICAgZ19zdGFsZUJ1aWxkZXJzLnB1c2goYnVpbGRlck5hbWUp OworICAgICAgICAgICAgICAgIHRoaXMuX3N0YWxlQnVpbGRlcnMucHVzaChidWlsZGVyTmFtZSk7 CiAKICAgICAgICAgICAgIGlmIChqc29uX3ZlcnNpb24gPj0gNCkKICAgICAgICAgICAgICAgICBi dWlsZHNbYnVpbGRlck5hbWVdW1RFU1RTX0tFWV0gPSBmbGF0dGVuVHJpZShidWlsZHNbYnVpbGRl ck5hbWVdW1RFU1RTX0tFWV0pOwpAQCAtMTYyLDcgKzE2NSw3IEBAIGxvYWRlci5Mb2FkZXIucHJv dG90eXBlID0gewogICAgICAgICBjb25zb2xlLmVycm9yKCdGYWlsZWQgdG8gbG9hZCByZXN1bHRz IGZpbGUgZm9yICcgKyBidWlsZGVyTmFtZSArICcuJyk7CiAKICAgICAgICAgLy8gRklYTUU6IGxv YWRlciBzaG91bGRuJ3QgZGVwZW5kIG9uIHN0YXRlIGRlZmluZWQgaW4gZGFzaGJvYXJkX2Jhc2Uu anMuCi0gICAgICAgIGdfYnVpbGRlcnNUaGF0RmFpbGVkVG9Mb2FkLnB1c2goYnVpbGRlck5hbWUp OworICAgICAgICB0aGlzLl9idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQucHVzaChidWlsZGVyTmFt ZSk7CiAKICAgICAgICAgLy8gUmVtb3ZlIHRoaXMgYnVpbGRlciBmcm9tIGJ1aWxkZXJzLCBzbyB3 ZSBkb24ndCB0cnkgdG8gdXNlIHRoZQogICAgICAgICAvLyBkYXRhIHRoYXQgaXNuJ3QgdGhlcmUu CkBAIC0yMjcsNiArMjMwLDE3IEBAIGxvYWRlci5Mb2FkZXIucHJvdG90eXBlID0gewogICAgICAg ICAgICAgICAgICAgICBwYXJ0aWFsKGZ1bmN0aW9uKHBsYXRmb3JtTmFtZSwgeGhyKSB7CiAgICAg ICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmVycm9yKCdDb3VsZCBub3QgbG9hZCBleHBlY3Rh dGlvbnMgZmlsZSBmb3IgJyArIHBsYXRmb3JtTmFtZSk7CiAgICAgICAgICAgICAgICAgICAgIH0s IHBsYXRmb3JtV2l0aEV4cGVjdGF0aW9ucykpOworICAgIH0sCisgICAgX2dldExvYWRpbmdFcnJv ck1lc3NhZ2VzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB2YXIgZXJyb3JNc2dzID0gJyc7 CisgICAgICAgIGlmICh0aGlzLl9idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQubGVuZ3RoKQorICAg ICAgICAgICAgZXJyb3JNc2dzICs9ICdFUlJPUjogRmFpbGVkIHRvIGdldCBkYXRhIGZyb20gJyAr IHRoaXMuX2J1aWxkZXJzVGhhdEZhaWxlZFRvTG9hZC50b1N0cmluZygpICsgJy48YnI+JzsKKwor ICAgICAgICBpZiAodGhpcy5fc3RhbGVCdWlsZGVycy5sZW5ndGgpCisgICAgICAgICAgICBlcnJv ck1zZ3MgKz0nRVJST1I6IERhdGEgZnJvbSAnICsgdGhpcy5fc3RhbGVCdWlsZGVycy50b1N0cmlu ZygpICsgJyBpcyBtb3JlIHRoYW4gMSBkYXkgc3RhbGUuPGJyPic7CisKKyAgICAgICAgcmV0dXJu IGVycm9yTXNnczsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVyX3VuaXR0ZXN0cy5qcyBiL1Rvb2xzL1Rlc3RSZXN1 bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVyX3VuaXR0ZXN0cy5qcwppbmRleCBjYjVi NzhiNmZmM2I0YzQzN2Q5YjQzYmY4Yzk5MjE3NmQzZjQ3YjYzLi44NmQ3YmVlYzFiYzdhMjRmYTAz ODgwMmQ4M2RhZTk1N2ZiYzYzMzQ4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0U2VydmVy L3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlcl91bml0dGVzdHMuanMKKysrIGIvVG9vbHMvVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXJfdW5pdHRlc3RzLmpzCkBAIC0xMTMs OSArMTEzLDYgQEAgdGVzdCgncmVzdWx0cyBmaWxlIGZhaWxpbmcgdG8gbG9hZCcsIDIsIGZ1bmN0 aW9uKCkgewogICAgIHJlc2V0R2xvYmFscygpOwogICAgIGxvYWRCdWlsZGVyc0xpc3QoJ0BUb1Qg LSBjaHJvbWl1bS5vcmcnLCAnbGF5b3V0LXRlc3RzJyk7CiAgICAgCi0gICAgLy8gRklYTUU6IGxv YWRlciBzaG91bGRuJ3QgZGVwZW5kIG9uIHN0YXRlIGRlZmluZWQgaW4gZGFzaGJvYXJkX2Jhc2Uu anMuCi0gICAgZ19idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQgPSBbXTsKLQogICAgIHZhciByZXNv dXJjZUxvYWRlciA9IG5ldyBsb2FkZXIuTG9hZGVyKCk7CiAgICAgdmFyIHJlc291cmNlTG9hZENv dW50ID0gMDsKICAgICByZXNvdXJjZUxvYWRlci5faGFuZGxlUmVzb3VyY2VMb2FkID0gZnVuY3Rp b24oKSB7CkBAIC0xMzAsNyArMTI3LDcgQEAgdGVzdCgncmVzdWx0cyBmaWxlIGZhaWxpbmcgdG8g bG9hZCcsIDIsIGZ1bmN0aW9uKCkgewogICAgIGN1cnJlbnRCdWlsZGVycygpW2J1aWxkZXIyXSA9 IHRydWU7CiAgICAgcmVzb3VyY2VMb2FkZXIuX2hhbmRsZVJlc3VsdHNGaWxlTG9hZEVycm9yKGJ1 aWxkZXIyKTsKIAotICAgIGRlZXBFcXVhbChnX2J1aWxkZXJzVGhhdEZhaWxlZFRvTG9hZCwgW2J1 aWxkZXIxLCBidWlsZGVyMl0pOworICAgIGRlZXBFcXVhbChyZXNvdXJjZUxvYWRlci5fYnVpbGRl cnNUaGF0RmFpbGVkVG9Mb2FkLCBbYnVpbGRlcjEsIGJ1aWxkZXIyXSk7CiAgICAgZXF1YWwocmVz b3VyY2VMb2FkQ291bnQsIDIpOwogCiB9KTsKQEAgLTE0OSw0ICsxNDYsMTEgQEAgdGVzdCgnRGVm YXVsdCBidWlsZGVyIGdldHMgc2V0LicsIDMsIGZ1bmN0aW9uKCkgewogICAgIHZhciBuZXdEZWZh dWx0QnVpbGRlciA9IGN1cnJlbnRCdWlsZGVyR3JvdXAoKS5kZWZhdWx0QnVpbGRlcigpOwogICAg IG9rKG5ld0RlZmF1bHRCdWlsZGVyLCAiVGhlcmUgc2hvdWxkIHN0aWxsIGJlIGEgZGVmYXVsdCBi dWlsZGVyLiIpOwogICAgIG5vdEVxdWFsKG5ld0RlZmF1bHRCdWlsZGVyLCBkZWZhdWx0QnVpbGRl ciwgIkRlZmF1bHQgYnVpbGRlciBzaG91bGQgbm90IGJlIHRoZSBvbGQgZGVmYXVsdCBidWlsZGVy Iik7Cit9KTsKKwordGVzdCgnYWRkQnVpbGRlckxvYWRFcnJvcnMnLCAxLCBmdW5jdGlvbigpIHsK KyAgICB2YXIgcmVzb3VyY2VMb2FkZXIgPSBuZXcgbG9hZGVyLkxvYWRlcigpOworICAgIHJlc291 cmNlTG9hZGVyLl9idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQgPSBbJ2J1aWxkZXIxJywgJ2J1aWxk ZXIyJ107CisgICAgcmVzb3VyY2VMb2FkZXIuX3N0YWxlQnVpbGRlcnMgPSBbJ3N0YWxlQnVpbGRl cjEnXTsKKyAgICBlcXVhbChyZXNvdXJjZUxvYWRlci5fZ2V0TG9hZGluZ0Vycm9yTWVzc2FnZXMo KSwgJ0VSUk9SOiBGYWlsZWQgdG8gZ2V0IGRhdGEgZnJvbSBidWlsZGVyMSxidWlsZGVyMi48YnI+ RVJST1I6IERhdGEgZnJvbSBzdGFsZUJ1aWxkZXIxIGlzIG1vcmUgdGhhbiAxIGRheSBzdGFsZS48 YnI+Jyk7CiB9KTsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==