106354 2013-01-08 11:18:12 -0800 [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort 2013-01-08 12:25:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth dpranke d-r eric webkit.review.bot oldest_to_newest 802419 0 zan 2013-01-08 11:18:12 -0800 As Eric put it in https://bugs.webkit.org/show_bug.cgi?id=101261#c13 > But eventually we should fix that. A port "is not" a PulseAudioSanitizer, it might "have a", but the usage of inheritance here is wrong IMO. :) The EflPort and GtkPort interfaces currently inherit from PulseAudioSanitizer. This also makes the mocking of the latter in unit tests a bit clearer. 802470 1 181721 zan 2013-01-08 12:06:41 -0800 Created attachment 181721 Patch 802483 2 181721 eric 2013-01-08 12:14:33 -0800 Comment on attachment 181721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181721&action=review Thanks. > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > def setup_test_run(self): > - self._unload_pulseaudio_module() Should this be calling super? 802486 3 zan 2013-01-08 12:17:18 -0800 (In reply to comment #2) > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > def setup_test_run(self): > > - self._unload_pulseaudio_module() > > Should this be calling super? That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 A new patch or can I just put the call in in this one? What works best for you? 802492 4 eric 2013-01-08 12:20:04 -0800 (In reply to comment #3) > (In reply to comment #2) > > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > > def setup_test_run(self): > > > - self._unload_pulseaudio_module() > > > > Should this be calling super? > > That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 > > A new patch or can I just put the call in in this one? What works best for you? Doesn't matter to me in the slightest. :) I'm happy to approve it either way. 802497 5 zan 2013-01-08 12:23:20 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > > > def setup_test_run(self): > > > > - self._unload_pulseaudio_module() > > > > > > Should this be calling super? > > > > That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 > > > > A new patch or can I just put the call in in this one? What works best for you? > > Doesn't matter to me in the slightest. :) I'm happy to approve it either way. The ChromiumPort interface behaves the same way, so a new patch is more appropriate. 802499 6 181721 zan 2013-01-08 12:25:00 -0800 Comment on attachment 181721 Patch Clearing flags on attachment: 181721 Committed r139095: <http://trac.webkit.org/changeset/139095> 802500 7 zan 2013-01-08 12:25:05 -0800 All reviewed patches have been landed. Closing bug. 181721 2013-01-08 12:06:41 -0800 2013-01-08 12:25:00 -0800 Patch bug-106354-20130108210345.patch text/plain 11596 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDIwZDgzNmE2YjE0MzBiYzE4MTc5MTNmZDZlZDdiOTI1 YTc3ODNmNy4uNzhiYTRhZjljNzgxYWRlYzAwYzdmYmNlOTA1OGYyMTU5YzYzMTY3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQw IEBACiAyMDEzLTAxLTA4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAK KyAgICAgICAgW0VGTF1bR1RLXSBNYWtlIHRoZSBQdWxzZUF1ZGlvU2FuaXRpemVyIGFuIG9iamVj dCBvbiB0aGUgRWZsUG9ydCwgR3RrUG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHV0IHRoZSBQdWxzZUF1ZGlvU2FuaXRpemVyIG9iamVjdCBvbiB0 aGUgRWZsUG9ydCBhbmQgR3RrUG9ydCBpbnRlcmZhY2VzCisgICAgICAgIGluc3RlYWQgb2YgdGhv c2UgdHdvIGluaGVyaXRpbmcgZnJvbSBpdC4gQWxzbyBhZGQgYSBtb2NrIG9iamVjdCBvZiB0aGUK KyAgICAgICAgc2FuaXRpemVyIHRoYXQncyB1c2VkIGluIHVuaXQgdGVzdHMuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weToKKyAgICAgICAgKEVm bFBvcnQpOgorICAgICAgICAoRWZsUG9ydC5fX2luaXRfXyk6CisgICAgICAgIChFZmxQb3J0LnNl dHVwX3Rlc3RfcnVuKToKKyAgICAgICAgKEVmbFBvcnQuY2xlYW5fdXBfdGVzdF9ydW4pOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsX3VuaXR0ZXN0LnB5 OiBBbHNvIGNvcnJlY3QgdGhlCisgICAgICAgIGltcG9ydGluZyBvcmRlci4KKyAgICAgICAgKEVm bFBvcnRUZXN0Lm1ha2VfcG9ydCk6IFB1dCBhIG1vY2sgUHVsc2VBdWRpb1Nhbml0aXplciBvbiB0 aGUgaW5zdGFuY2UuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9ndGsucHk6CisgICAgICAgIChHdGtQb3J0KToKKyAgICAgICAgKEd0a1BvcnQuX19pbml0X18p OgorICAgICAgICAoR3RrUG9ydC5zZXR1cF90ZXN0X3J1bik6CisgICAgICAgIChHdGtQb3J0LmNs ZWFuX3VwX3Rlc3RfcnVuKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2d0a191bml0dGVzdC5weTogQWxzbyBjb3JyZWN0IHRoZQorICAgICAgICBpbXBvcnRp bmcgb3JkZXIuCisgICAgICAgIChHdGtQb3J0VGVzdC5tYWtlX3BvcnQpOiBQdXQgYSBtb2NrIFB1 bHNlQXVkaW9TYW5pdGl6ZXIgb24gdGhlIGluc3RhbmNlLgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcHVsc2VhdWRpb19zYW5pdGl6ZXIucHk6CisgICAgICAg IChQdWxzZUF1ZGlvU2FuaXRpemVyLnVubG9hZF9wdWxzZWF1ZGlvX21vZHVsZSk6IFN0eWxpemUg dGhlIG1ldGhvZCBhcyBwdWJsaWMuCisgICAgICAgIChQdWxzZUF1ZGlvU2FuaXRpemVyLnJlc3Rv cmVfcHVsc2VhdWRpb19tb2R1bGUpOiBEaXR0by4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L3B1bHNlYXVkaW9fc2FuaXRpemVyX21vY2sucHk6IEFkZGVkLgor ICAgICAgICAoUHVsc2VBdWRpb1Nhbml0aXplck1vY2spOiBBIHNpbXBsZSBtb2NrIGludGVyZmFj ZSBmb3IgUHVsc2VBdWRpb1Nhbml0aXplci4KKyAgICAgICAgKFB1bHNlQXVkaW9TYW5pdGl6ZXJN b2NrLnVubG9hZF9wdWxzZWF1ZGlvX21vZHVsZSk6CisgICAgICAgIChQdWxzZUF1ZGlvU2FuaXRp emVyTW9jay5yZXN0b3JlX3B1bHNlYXVkaW9fbW9kdWxlKToKKworMjAxMy0wMS0wOCAgWmFuIERv YmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCiAgICAgICAgIFtHVEtdIExvd2VyIHRo ZSBkZWZhdWx0IHRpbWVvdXQgdmFsdWUgZm9yIFdlYktpdFRlc3RSdW5uZXIKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjM1MwogCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CmluZGV4IDBjOWFjZDhk OGRlZjgxMGZlNDA0MzJmNGM4NjhhZDM2MTQ0MmE5YzAuLjIwODgxMzcxMDU0NmRlYWJiYmE1YjY3 ZDhlZTJmMTU0MjY2MWM2OTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvZWZsLnB5CkBAIC0zNCw3ICszNCw4IEBAIGZyb20gd2Via2l0cHkubGF5b3V0 X3Rlc3RzLnBvcnQuYmFzZSBpbXBvcnQgUG9ydAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMu cG9ydC5wdWxzZWF1ZGlvX3Nhbml0aXplciBpbXBvcnQgUHVsc2VBdWRpb1Nhbml0aXplcgogZnJv bSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC54dmZiZHJpdmVyIGltcG9ydCBYdmZiRHJpdmVy CiAKLWNsYXNzIEVmbFBvcnQoUG9ydCwgUHVsc2VBdWRpb1Nhbml0aXplcik6CisKK2NsYXNzIEVm bFBvcnQoUG9ydCk6CiAgICAgcG9ydF9uYW1lID0gJ2VmbCcKIAogICAgIGRlZiBfX2luaXRfXyhz ZWxmLCAqYXJncywgKiprd2FyZ3MpOgpAQCAtNDUsMTEgKzQ2LDEzIEBAIGNsYXNzIEVmbFBvcnQo UG9ydCwgUHVsc2VBdWRpb1Nhbml0aXplcik6CiAgICAgICAgIHNlbGYuc2V0X29wdGlvbl9kZWZh dWx0KCd3cmFwcGVyJywgc2VsZi5famhidWlsZF93cmFwcGVyX3BhdGgpCiAgICAgICAgIHNlbGYu d2VicHJvY2Vzc19jbWRfcHJlZml4ID0gc2VsZi5nZXRfb3B0aW9uKCd3ZWJwcm9jZXNzX2NtZF9w cmVmaXgnKQogCisgICAgICAgIHNlbGYuX3B1bHNlYXVkaW9fc2FuaXRpemVyID0gUHVsc2VBdWRp b1Nhbml0aXplcigpCisKICAgICBkZWYgX3BvcnRfZmxhZ19mb3Jfc2NyaXB0cyhzZWxmKToKICAg ICAgICAgcmV0dXJuICItLWVmbCIKIAogICAgIGRlZiBzZXR1cF90ZXN0X3J1bihzZWxmKToKLSAg ICAgICAgc2VsZi5fdW5sb2FkX3B1bHNlYXVkaW9fbW9kdWxlKCkKKyAgICAgICAgc2VsZi5fcHVs c2VhdWRpb19zYW5pdGl6ZXIudW5sb2FkX3B1bHNlYXVkaW9fbW9kdWxlKCkKIAogICAgIGRlZiBz ZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2VsZiwgc2VydmVyX25hbWU9Tm9uZSk6CiAgICAgICAg IGVudiA9IHN1cGVyKEVmbFBvcnQsIHNlbGYpLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZXJ2 ZXJfbmFtZSkKQEAgLTczLDcgKzc2LDcgQEAgY2xhc3MgRWZsUG9ydChQb3J0LCBQdWxzZUF1ZGlv U2FuaXRpemVyKToKIAogICAgIGRlZiBjbGVhbl91cF90ZXN0X3J1bihzZWxmKToKICAgICAgICAg c3VwZXIoRWZsUG9ydCwgc2VsZikuY2xlYW5fdXBfdGVzdF9ydW4oKQotICAgICAgICBzZWxmLl9y ZXN0b3JlX3B1bHNlYXVkaW9fbW9kdWxlKCkKKyAgICAgICAgc2VsZi5fcHVsc2VhdWRpb19zYW5p dGl6ZXIucmVzdG9yZV9wdWxzZWF1ZGlvX21vZHVsZSgpCiAKICAgICBkZWYgX2dlbmVyYXRlX2Fs bF90ZXN0X2NvbmZpZ3VyYXRpb25zKHNlbGYpOgogICAgICAgICByZXR1cm4gW1Rlc3RDb25maWd1 cmF0aW9uKHZlcnNpb249c2VsZi5fdmVyc2lvbiwgYXJjaGl0ZWN0dXJlPSd4ODYnLCBidWlsZF90 eXBlPWJ1aWxkX3R5cGUpIGZvciBidWlsZF90eXBlIGluIHNlbGYuQUxMX0JVSUxEX1RZUEVTXQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmxf dW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Vm bF91bml0dGVzdC5weQppbmRleCBiNGUyMWFiNmI3NGJiNDQxMzk4ZjMyYTdmODhhODgwNWZjMjNm NGZmLi45NGJlNDhiYmE1YTY2NzZhM2E3MjBjNTU0MzIzNmM3YzUxMjMyYjQzIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbF91bml0dGVzdC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbF91bml0 dGVzdC5weQpAQCAtMjYsMTAgKzI2LDExIEBACiAKIGltcG9ydCB1bml0dGVzdAogCitmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlX21vY2sgaW1wb3J0IE1vY2tFeGVjdXRpdmUK IGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRwdXRD YXB0dXJlCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LmVmbCBpbXBvcnQgRWZsUG9y dAorZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5wdWxzZWF1ZGlvX3Nhbml0aXplcl9t b2NrIGltcG9ydCBQdWxzZUF1ZGlvU2FuaXRpemVyTW9jawogZnJvbSB3ZWJraXRweS5sYXlvdXRf dGVzdHMucG9ydCBpbXBvcnQgcG9ydF90ZXN0Y2FzZQotZnJvbSB3ZWJraXRweS5jb21tb24uc3lz dGVtLmV4ZWN1dGl2ZV9tb2NrIGltcG9ydCBNb2NrRXhlY3V0aXZlCiAKIAogY2xhc3MgRWZsUG9y dFRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgpAQCAtMzksOCArNDAsNyBAQCBjbGFz cyBFZmxQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgIyBBZGRpdGlv bmFsbHkgbW9ja3Mgb3V0IHRoZSBQdWxzZUF1ZGlvU2FuaXRpemVyIG1ldGhvZHMuCiAgICAgZGVm IG1ha2VfcG9ydChzZWxmLCBob3N0PU5vbmUsIHBvcnRfbmFtZT1Ob25lLCBvcHRpb25zPU5vbmUs IG9zX25hbWU9Tm9uZSwgb3NfdmVyc2lvbj1Ob25lLCAqKmt3YXJncyk6CiAgICAgICAgIHBvcnQg PSBzdXBlcihFZmxQb3J0VGVzdCwgc2VsZikubWFrZV9wb3J0KGhvc3QsIHBvcnRfbmFtZSwgb3B0 aW9ucywgb3NfbmFtZSwgb3NfdmVyc2lvbiwgKiprd2FyZ3MpCi0gICAgICAgIHBvcnQuX3VubG9h ZF9wdWxzZWF1ZGlvX21vZHVsZSA9IGxhbWJkYTogTm9uZQotICAgICAgICBwb3J0Ll9yZXN0b3Jl X3B1bHNlYXVkaW9fbW9kdWxlID0gbGFtYmRhOiBOb25lCisgICAgICAgIHBvcnQuX3B1bHNlYXVk aW9fc2FuaXRpemVyID0gUHVsc2VBdWRpb1Nhbml0aXplck1vY2soKQogICAgICAgICByZXR1cm4g cG9ydAogCiAgICAgZGVmIHRlc3Rfc2hvd19yZXN1bHRzX2h0bWxfZmlsZShzZWxmKToKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKaW5kZXggY2Q3 Y2JiMjFiN2QwMGZhMzA3NzJhNDhhY2I5NDMwMDBlNjk0MDc2Ni4uMTEyMzhmNzg1NDg0NWI2ZDBi MTkyYTJhNDA3MmYxNzQyNjU4NWJhMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKQEAgLTM1LDkgKzM1LDEzIEBAIGZyb20gd2Via2l0cHku bGF5b3V0X3Rlc3RzLnBvcnQucHVsc2VhdWRpb19zYW5pdGl6ZXIgaW1wb3J0IFB1bHNlQXVkaW9T YW5pdGl6ZXIKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQueHZmYmRyaXZlciBpbXBv cnQgWHZmYkRyaXZlcgogCiAKLWNsYXNzIEd0a1BvcnQoUG9ydCwgUHVsc2VBdWRpb1Nhbml0aXpl cik6CitjbGFzcyBHdGtQb3J0KFBvcnQpOgogICAgIHBvcnRfbmFtZSA9ICJndGsiCiAKKyAgICBk ZWYgX19pbml0X18oc2VsZiwgKmFyZ3MsICoqa3dhcmdzKToKKyAgICAgICAgc3VwZXIoR3RrUG9y dCwgc2VsZikuX19pbml0X18oKmFyZ3MsICoqa3dhcmdzKQorICAgICAgICBzZWxmLl9wdWxzZWF1 ZGlvX3Nhbml0aXplciA9IFB1bHNlQXVkaW9TYW5pdGl6ZXIoKQorCiAgICAgZGVmIHdhcm5faWZf YnVnX21pc3NpbmdfaW5fdGVzdF9leHBlY3RhdGlvbnMoc2VsZik6CiAgICAgICAgIHJldHVybiBU cnVlCiAKQEAgLTUzLDExICs1NywxMSBAQCBjbGFzcyBHdGtQb3J0KFBvcnQsIFB1bHNlQXVkaW9T YW5pdGl6ZXIpOgogICAgICAgICByZXR1cm4gNiAqIDEwMDAKIAogICAgIGRlZiBzZXR1cF90ZXN0 X3J1bihzZWxmKToKLSAgICAgICAgc2VsZi5fdW5sb2FkX3B1bHNlYXVkaW9fbW9kdWxlKCkKKyAg ICAgICAgc2VsZi5fcHVsc2VhdWRpb19zYW5pdGl6ZXIudW5sb2FkX3B1bHNlYXVkaW9fbW9kdWxl KCkKIAogICAgIGRlZiBjbGVhbl91cF90ZXN0X3J1bihzZWxmKToKICAgICAgICAgc3VwZXIoR3Rr UG9ydCwgc2VsZikuY2xlYW5fdXBfdGVzdF9ydW4oKQotICAgICAgICBzZWxmLl9yZXN0b3JlX3B1 bHNlYXVkaW9fbW9kdWxlKCkKKyAgICAgICAgc2VsZi5fcHVsc2VhdWRpb19zYW5pdGl6ZXIucmVz dG9yZV9wdWxzZWF1ZGlvX21vZHVsZSgpCiAKICAgICBkZWYgc2V0dXBfZW52aXJvbl9mb3Jfc2Vy dmVyKHNlbGYsIHNlcnZlcl9uYW1lPU5vbmUpOgogICAgICAgICBlbnZpcm9ubWVudCA9IHN1cGVy KEd0a1BvcnQsIHNlbGYpLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZXJ2ZXJfbmFtZSkKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrX3Vu aXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtf dW5pdHRlc3QucHkKaW5kZXggN2I4NTk2NDZmOWFmMGViYTFiNzE0ZGJmNzhhYzBjZjZkZjk4M2Q3 My4uZGJiMTg1MjhmZDVmMWZiYzI5YjkxZDUzYzgyNzIxOGZhNTYzNTVlMSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRl c3QucHkKQEAgLTMwLDEyICszMCwxMyBAQCBpbXBvcnQgdW5pdHRlc3QKIGltcG9ydCBzeXMKIGlt cG9ydCBvcwogCitmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlX21vY2sgaW1w b3J0IE1vY2tFeGVjdXRpdmUKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVt X21vY2sgaW1wb3J0IE1vY2tGaWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0u b3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQogZnJvbSB3ZWJraXRweS5sYXlvdXRf dGVzdHMucG9ydC5ndGsgaW1wb3J0IEd0a1BvcnQKK2Zyb20gd2Via2l0cHkubGF5b3V0X3Rlc3Rz LnBvcnQucHVsc2VhdWRpb19zYW5pdGl6ZXJfbW9jayBpbXBvcnQgUHVsc2VBdWRpb1Nhbml0aXpl ck1vY2sKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IHBvcnRfdGVzdGNh c2UKLWZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmVfbW9jayBpbXBvcnQgTW9j a0V4ZWN1dGl2ZQogZnJvbSB3ZWJraXRweS50aGlyZHBhcnR5Lm1vY2sgaW1wb3J0IE1vY2sKLWZy b20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtX21vY2sgaW1wb3J0IE1vY2tGaWxl U3lzdGVtCiBmcm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1wb3J0IE1vY2tPcHRpb25zCiAK IApAQCAtNDYsOCArNDcsNyBAQCBjbGFzcyBHdGtQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRU ZXN0Q2FzZSk6CiAgICAgIyBBZGRpdGlvbmFsbHkgbW9ja3Mgb3V0IHRoZSBQdWxzZUF1ZGlvU2Fu aXRpemVyIG1ldGhvZHMuCiAgICAgZGVmIG1ha2VfcG9ydChzZWxmLCBob3N0PU5vbmUsIHBvcnRf bmFtZT1Ob25lLCBvcHRpb25zPU5vbmUsIG9zX25hbWU9Tm9uZSwgb3NfdmVyc2lvbj1Ob25lLCAq Kmt3YXJncyk6CiAgICAgICAgIHBvcnQgPSBzdXBlcihHdGtQb3J0VGVzdCwgc2VsZikubWFrZV9w b3J0KGhvc3QsIHBvcnRfbmFtZSwgb3B0aW9ucywgb3NfbmFtZSwgb3NfdmVyc2lvbiwgKiprd2Fy Z3MpCi0gICAgICAgIHBvcnQuX3VubG9hZF9wdWxzZWF1ZGlvX21vZHVsZSA9IGxhbWJkYTogTm9u ZQotICAgICAgICBwb3J0Ll9yZXN0b3JlX3B1bHNlYXVkaW9fbW9kdWxlID0gbGFtYmRhOiBOb25l CisgICAgICAgIHBvcnQuX3B1bHNlYXVkaW9fc2FuaXRpemVyID0gUHVsc2VBdWRpb1Nhbml0aXpl ck1vY2soKQogICAgICAgICByZXR1cm4gcG9ydAogCiAgICAgZGVmIHRlc3RfZXhwZWN0YXRpb25z X2ZpbGVzKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9wdWxzZWF1ZGlvX3Nhbml0aXplci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcHVsc2VhdWRpb19zYW5pdGl6ZXIucHkKaW5kZXggZjQ1NzRh OTJmNjhmMTQ0OGI2OTZlNTlkNGQ2OGQxYjQxMzZhZGE5NC4uNDY1YjkyMTU4MTBlMjE4YTYzZjkw YjJjOWRmMDc3ZGI3NjQ3ZDIxOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9wdWxzZWF1ZGlvX3Nhbml0aXplci5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3B1bHNlYXVkaW9fc2FuaXRpemVyLnB5CkBA IC0zNyw3ICszNyw3IEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKIAogIyBT aGFyZWQgYnkgR1RLIGFuZCBFRkwgZm9yIHB1bHNlYXVkaW8gc2FuaXRpemluZyBiZWZvcmUgcnVu bmluZyB0ZXN0cy4KIGNsYXNzIFB1bHNlQXVkaW9TYW5pdGl6ZXI6Ci0gICAgZGVmIF91bmxvYWRf cHVsc2VhdWRpb19tb2R1bGUoc2VsZik6CisgICAgZGVmIHVubG9hZF9wdWxzZWF1ZGlvX21vZHVs ZShzZWxmKToKICAgICAgICAgIyBVbmxvYWQgcHVsc2VhdWRpbydzIG1vZHVsZS1zdHJlYW0tcmVz dG9yZSwgc2luY2UgaXQgcmVtZW1iZXJzCiAgICAgICAgICMgdm9sdW1lIHNldHRpbmdzIGZyb20g ZGlmZmVyZW50IHJ1bnMsIGFuZCBjb3VsZCBhZmZlY3QKICAgICAgICAgIyBtdWx0aW1lZGlhIHRl c3RzIHJlc3VsdHMKQEAgLTcxLDcgKzcxLDcgQEAgY2xhc3MgUHVsc2VBdWRpb1Nhbml0aXplcjoK ICAgICAgICAgICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoJ1VuYWJsZSB0byBwYXJzZSBtb2R1 bGUgaW5kZXguIFBsZWFzZSBjaGVjayBpZiB5b3VyIHB1bHNlYXVkaW8tdXRpbHMgdmVyc2lvbiBp cyB0b28gb2xkLicpCiAgICAgICAgICAgICAgICAgcmV0dXJuCiAKLSAgICBkZWYgX3Jlc3RvcmVf cHVsc2VhdWRpb19tb2R1bGUoc2VsZik6CisgICAgZGVmIHJlc3RvcmVfcHVsc2VhdWRpb19tb2R1 bGUoc2VsZik6CiAgICAgICAgICMgSWYgcHVsc2VhdWRpbydzIG1vZHVsZS1zdHJlYW0tcmVzdG9y ZSB3YXMgcHJldmlvdXNseSB1bmxvYWRlZCwKICAgICAgICAgIyByZXN0b3JlIGl0IGJhY2suIFdl IHNob3VsZG4ndCBuZWVkIGV4dHJhIGNoZWNrcyBoZXJlLCBzaW5jZSBhbgogICAgICAgICAjIGlu ZGV4ICE9IC0xIGhlcmUgbWVhbnMgd2Ugc3VjY2Vzc2Z1bGx5IHVubG9hZGVkIGl0IHByZXZpb3Vz bHkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3B1bHNlYXVkaW9fc2FuaXRpemVyX21vY2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3B1bHNlYXVkaW9fc2FuaXRpemVyX21vY2sucHkKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ODhhOTYyYTJlNGFjNjNmMjU1OTIzNmY3OWJiZTNjNjczMzAwNWY2ZgotLS0gL2Rldi9udWxsCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcHVsc2VhdWRpb19z YW5pdGl6ZXJfbW9jay5weQpAQCAtMCwwICsxLDM1IEBACisjIENvcHlyaWd0aCAoQykgMjAxMyBa YW4gRG9iZXJzZWsgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKyMKKyMgUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucyBhcmUKKyMgbWV0OgorIworIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNl IGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJl ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMg Y29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp YWxzIHByb3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0 aGUgR29vZ2xlIG5hbWUgbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyMgY29udHJpYnV0b3JzIG1heSBi ZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyMgdGhp cyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMK KyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5E IENPTlRSSUJVVE9SUworIyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJB TlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJS QU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFS IFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQK KyMgT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJF Q1QsIElOQ0lERU5UQUwsCisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBE QU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBS T0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFO WQorIyBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCisKK2NsYXNz IFB1bHNlQXVkaW9TYW5pdGl6ZXJNb2NrOgorICAgIGRlZiB1bmxvYWRfcHVsc2VhdWRpb19tb2R1 bGUoc2VsZik6CisgICAgICAgIHBhc3MKKworICAgIGRlZiByZXN0b3JlX3B1bHNlYXVkaW9fbW9k dWxlKHNlbGYpOgorICAgICAgICBwYXNzCg==