106312 2013-01-08 01:35:29 -0800 [Chromium] Hiding popups on mouse wheel should be handled by WebViewImpl 2013-01-08 17:42:38 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 802135 0 keishi 2013-01-08 01:35:29 -0800 We had to removed the code that closed popups on mouse wheel events from content::RenderWidgetHostViewMac because we no longer had access to child popups. This should be handled by WebViewImpl. https://src.chromium.org/viewvc/chrome?view=rev&revision=175488 802145 1 181672 keishi 2013-01-08 01:48:23 -0800 Created attachment 181672 Patch 802151 2 181672 tkent 2013-01-08 01:58:00 -0800 Comment on attachment 181672 Patch looks good 802179 3 181672 webkit.review.bot 2013-01-08 02:56:05 -0800 Comment on attachment 181672 Patch Rejecting attachment 181672 from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15755125 802849 4 181672 webkit.review.bot 2013-01-08 17:42:35 -0800 Comment on attachment 181672 Patch Clearing flags on attachment: 181672 Committed r139139: <http://trac.webkit.org/changeset/139139> 802850 5 webkit.review.bot 2013-01-08 17:42:38 -0800 All reviewed patches have been landed. Closing bug. 181672 2013-01-08 01:48:23 -0800 2013-01-08 17:42:35 -0800 Patch bug-106312-20130108184527.patch text/plain 2730 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAwMDQ3ZjY3MWVhYmU2YTVhN2YxMTU2ZDBjZTdiOGIxODA1YzlhYmQuLjgwODBhZDQ0YTkzNjU4 MzhlY2VmN2JkZDEyNGI1ODA5ODY4YzQzNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTMtMDEtMDggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBIaWRpbmcgcG9wdXBzIG9uIG1vdXNlIHdoZWVs IHNob3VsZCBiZSBoYW5kbGVkIGJ5IFdlYlZpZXdJbXBsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYzMTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYWQgdG8gcmVtb3ZlZCB0aGUgY29kZSB0aGF0 IGNsb3NlZCBwb3B1cHMgb24gbW91c2Ugd2hlZWwgZXZlbnRzIGZyb20KKyAgICAgICAgY29udGVu dDo6UmVuZGVyV2lkZ2V0SG9zdFZpZXdNYWMgYmVjYXVzZSBpdCBubyBsb25nZXIgaGFkIGFjY2Vz cyB0bworICAgICAgICBjaGlsZCBwb3B1cHMuIFdlYlZpZXdJbXBsIHdpbGwgaGlkZSB0aGUgcG9w dXBzIG9uIG1vdXNlIHdoZWVsIGV2ZW50cyBzbworICAgICAgICB3ZSBjYW4gbWFpbnRhaW4gdGhl IHNhbWUgYmVoYXZpb3IuCisKKyAgICAgICAgaHR0cHM6Ly9zcmMuY2hyb21pdW0ub3JnL3ZpZXd2 Yy9jaHJvbWU/dmlldz1yZXYmcmV2aXNpb249MTc1NDg4CisKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aGFuZGxlTW91c2VXaGVl bCk6IE92ZXJyaWRpbmcgc28gd2UgY2FuIGhpZGUgcG9wdXBzLgorICAgICAgICAoV2ViS2l0KToK KyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMy0wMS0wNyAgU3RldmUgQmxvY2sg IDxzdGV2ZWJsb2NrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVc2UgdG9TaXplKCkgdG8gY29u dmVydCBmcm9tIEludC9GbG9hdFBvaW50IHRvIEludC9GbG9hdFNpemUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA0MTE4ODM4ZjRjZmIxNzk3NjE2NzMw M2JlNDdjZmY5NDU4ZjU4OThlLi5iYTEyZjBjZDVkM2E5NzkzYWI3MDBiMzJmMTFjODViZGU2OTJj ZTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC02 NDksNiArNjQ5LDEyIEBAIHZvaWQgV2ViVmlld0ltcGw6OmhhbmRsZU1vdXNlVXAoRnJhbWUmIG1h aW5GcmFtZSwgY29uc3QgV2ViTW91c2VFdmVudCYgZXZlbnQpCiAjZW5kaWYKIH0KIAorYm9vbCBX ZWJWaWV3SW1wbDo6aGFuZGxlTW91c2VXaGVlbChGcmFtZSYgbWFpbkZyYW1lLCBjb25zdCBXZWJN b3VzZVdoZWVsRXZlbnQmIGV2ZW50KQoreworICAgIGhpZGVQb3B1cHMoKTsKKyAgICByZXR1cm4g UGFnZVdpZGdldEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VXaGVlbChtYWluRnJhbWUsIGV2ZW50 KTsKK30KKwogdm9pZCBXZWJWaWV3SW1wbDo6c2Nyb2xsQnkoY29uc3QgV2ViUG9pbnQmIGRlbHRh KQogewogICAgIFdlYk1vdXNlV2hlZWxFdmVudCBzeW50aGV0aWNXaGVlbDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDAwNjFiZjJiZjQ2NDdiY2ZiYTI4M2Y4 OWQ5ZjFlZTYwNGI4NzU4OWIuLmY2OTk3NTg2ZGIxMjMxZjA2MjdkYjFmZmE0YTE5M2M2NTdmOGNm MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtNjc0LDYg KzY3NCw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZU1vdXNlTGVhdmUoV2Vi Q29yZTo6RnJhbWUmLCBjb25zdCBXZWJNb3VzZUV2ZW50JikgT1ZFUlJJREU7CiAgICAgdmlydHVh bCB2b2lkIGhhbmRsZU1vdXNlRG93bihXZWJDb3JlOjpGcmFtZSYsIGNvbnN0IFdlYk1vdXNlRXZl bnQmKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlTW91c2VVcChXZWJDb3JlOjpG cmFtZSYsIGNvbnN0IFdlYk1vdXNlRXZlbnQmKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIGJvb2wg aGFuZGxlTW91c2VXaGVlbChXZWJDb3JlOjpGcmFtZSYsIGNvbnN0IFdlYk1vdXNlV2hlZWxFdmVu dCYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3Qg V2ViR2VzdHVyZUV2ZW50JikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBib29sIGhhbmRsZUtleUV2 ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQmKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIGJvb2wg aGFuZGxlQ2hhckV2ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQmKSBPVkVSUklERTsK