106311 2013-01-08 00:29:38 -0800 REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function 2013-01-08 00:41:46 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106212 1 jochen jochen ksakamoto tkent oldest_to_newest 802111 0 jochen 2013-01-08 00:29:38 -0800 Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h:52:10: error: 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function [-Werror,-Woverloaded-virtual] bool isInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; } ^ ../../Source/WebCore/dom/Element.h:416:18: note: hidden overloaded virtual function 'WebCore::Element::isInRange' declared here virtual bool isInRange() const { return false; } 802112 1 181665 jochen 2013-01-08 00:39:54 -0800 Created attachment 181665 Patch 802114 2 181665 jochen 2013-01-08 00:41:29 -0800 Comment on attachment 181665 Patch Clearing flags on attachment: 181665 Committed r139043: <http://trac.webkit.org/changeset/139043> 802115 3 jochen 2013-01-08 00:41:34 -0800 All reviewed patches have been landed. Closing bug. 802116 4 181665 tkent 2013-01-08 00:41:46 -0800 Comment on attachment 181665 Patch LGTM 181665 2013-01-08 00:39:54 -0800 2013-01-08 00:41:46 -0800 Patch bug-106311-20130108093658.patch text/plain 2882 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY1ZGJmYWQ4NTExOWEz NmVjNzM1NWM1MDJiOWQzZmM3ZDBhZDZmNi4uM2QwZmIzMzE4MDg4ZGQ0MjRlOGYzNmQwZTYwYWUz MjcwODBmMjFiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTA4ICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjEzOTAzNik6ICdXZWJDb3JlOjpEYXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50Ojppc0luUmFu Z2UnIGhpZGVzIG92ZXJsb2FkZWQgdmlydHVhbCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MzExCisKKyAgICAgICAgVW5yZXZpZXdl ZCBidWlsZCBmaXguCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRlVGltZVN5bWJvbGljRmll bGRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lU3ltYm9saWNGaWVsZEVs ZW1lbnQ6OnN0ZXBEb3duKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lU3ltYm9saWNGaWVs ZEVsZW1lbnQ6OnN0ZXBVcCk6CisgICAgICAgICogaHRtbC9zaGFkb3cvRGF0ZVRpbWVTeW1ib2xp Y0ZpZWxkRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RGF0ZVRpbWVTeW1ib2xpY0ZpZWxk RWxlbWVudDo6aW5kZXhJc0luUmFuZ2UpOiByZW5hbWVkIG1ldGhvZCB0byBhdm9pZCBoaWRpbmcg RWxlbWVudDo6aXNJblJhbmdlCisKIDIwMTMtMDEtMDcgIEt1bmloaWtvIFNha2Ftb3RvICA8a3Nh a2Ftb3RvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJTlBVVF9NVUxUSVBMRV9GSUVMRFNfVUk6 IFN0ZXAtdXAvLWRvd24gb2YgbW9udGgvZGF5IGZpZWxkIHNob3VsZCByZXNwZWN0IG1pbi9tYXgg YXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRp bWVTeW1ib2xpY0ZpZWxkRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9E YXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50LmNwcAppbmRleCBiYzEwZDYyY2EwOTdiNDU1Mzkw NjQ2MmM2ZWU5NTc2NDQzNDMzNzI0Li5hZGQ2N2M2YjM3NzlhMmRhNWY2MmY3NDY0MmVhN2M3OThk NzQ0NWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZVN5 bWJvbGljRmllbGRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9E YXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50LmNwcApAQCAtMTE5LDcgKzExOSw3IEBAIHZvaWQg RGF0ZVRpbWVTeW1ib2xpY0ZpZWxkRWxlbWVudDo6c2V0VmFsdWVBc0ludGVnZXIoaW50IG5ld1Nl bGVjdGVkSW5kZXgsIEV2ZW50CiB2b2lkIERhdGVUaW1lU3ltYm9saWNGaWVsZEVsZW1lbnQ6OnN0 ZXBEb3duKCkKIHsKICAgICBpZiAoaGFzVmFsdWUoKSkgewotICAgICAgICBpZiAoIWlzSW5SYW5n ZSgtLW1fc2VsZWN0ZWRJbmRleCkpCisgICAgICAgIGlmICghaW5kZXhJc0luUmFuZ2UoLS1tX3Nl bGVjdGVkSW5kZXgpKQogICAgICAgICAgICAgbV9zZWxlY3RlZEluZGV4ID0gbV9tYXhpbXVtSW5k ZXg7CiAgICAgfSBlbHNlCiAgICAgICAgIG1fc2VsZWN0ZWRJbmRleCA9IG1fbWF4aW11bUluZGV4 OwpAQCAtMTI5LDcgKzEyOSw3IEBAIHZvaWQgRGF0ZVRpbWVTeW1ib2xpY0ZpZWxkRWxlbWVudDo6 c3RlcERvd24oKQogdm9pZCBEYXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50OjpzdGVwVXAoKQog ewogICAgIGlmIChoYXNWYWx1ZSgpKSB7Ci0gICAgICAgIGlmICghaXNJblJhbmdlKCsrbV9zZWxl Y3RlZEluZGV4KSkKKyAgICAgICAgaWYgKCFpbmRleElzSW5SYW5nZSgrK21fc2VsZWN0ZWRJbmRl eCkpCiAgICAgICAgICAgICBtX3NlbGVjdGVkSW5kZXggPSBtX21pbmltdW1JbmRleDsKICAgICB9 IGVsc2UKICAgICAgICAgbV9zZWxlY3RlZEluZGV4ID0gbV9taW5pbXVtSW5kZXg7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZVN5bWJvbGljRmllbGRFbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZVN5bWJvbGljRmllbGRF bGVtZW50LmgKaW5kZXggMTNkNzY2ZmNkMzYxMTFiMTdhYTY5OGU1MDE3YjM3ZGI5MDk1YmJhOC4u M2I0NzcyNjVhZjM5N2YxOWU3NDFjNThhZWQxMTVmMDdmM2Y1NTU0NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRpbWVTeW1ib2xpY0ZpZWxkRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lU3ltYm9saWNGaWVsZEVsZW1l bnQuaApAQCAtNDksNyArNDksNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBjb25zdCBpbnQgaW52 YWxpZEluZGV4ID0gLTE7CiAKICAgICBTdHJpbmcgdmlzaWJsZUVtcHR5VmFsdWUoKSBjb25zdDsK LSAgICBib29sIGlzSW5SYW5nZShpbnQgaW5kZXgpIGNvbnN0IHsgcmV0dXJuIGluZGV4ID49IG1f bWluaW11bUluZGV4ICYmIGluZGV4IDw9IG1fbWF4aW11bUluZGV4OyB9CisgICAgYm9vbCBpbmRl eElzSW5SYW5nZShpbnQgaW5kZXgpIGNvbnN0IHsgcmV0dXJuIGluZGV4ID49IG1fbWluaW11bUlu ZGV4ICYmIGluZGV4IDw9IG1fbWF4aW11bUluZGV4OyB9CiAKICAgICAvLyBEYXRlVGltZUZpZWxk RWxlbWVudCBmdW5jdGlvbnMuCiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZUtleWJvYXJkRXZlbnQo S2V5Ym9hcmRFdmVudCopIE9WRVJSSURFIEZJTkFMOwo=