106297 2013-01-07 21:09:42 -0800 Every cached image is an error 2013-01-09 16:21:11 -0800 1 1 1 Unclassified WebKit Images 420+ Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 pdr pdr abarth ap beidson dglazkov eric japhet webkit.review.bot oldest_to_newest 801990 0 pdr 2013-01-07 21:09:42 -0800 Every cached image load causes the following error: CachedImage::data(...) ... error(errorOccurred() ? status() : DecodeError); http://trac.webkit.org/browser/trunk/Source/WebCore/loader/cache/CachedImage.cpp?rev=138976#L381 The culprit is cache revalidation. When loading cached resources we revalidate the cache by sending a request to the server and waiting for the 304 not modified response. Behind the scenes we actually hold two CachedImages: the cached cached image (sorry!) and the revalidating cached image. If revalidation succeeds with a 304 we throw away the revalidating image and use the cached image. If revalidation fails (server resource changed) we evict the cached cached image and continue to load the revalidating image. Every cached image load causes an error because, in the success case, we do not cancel the revalidation request once we receive a 304 not modified response. The revalidating cached image continues to load in its merry way: CachedImage::data() is called which creates a new BitmapImage that ends up throwing an error, and ultimately this cached image is freed in the SubResourceLoader because it has no references. Patch forthcoming. 801997 1 181634 pdr 2013-01-07 21:31:28 -0800 Created attachment 181634 First pass 802020 2 181634 buildbot 2013-01-07 22:05:38 -0800 Comment on attachment 181634 First pass Attachment 181634 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15734979 New failing tests: http/tests/inspector/resource-tree/resource-request-content-while-loading.html 802033 3 181634 webkit.review.bot 2013-01-07 22:29:12 -0800 Comment on attachment 181634 First pass Attachment 181634 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15733986 New failing tests: http/tests/inspector/compiler-source-mapping-debug.html http/tests/inspector/resource-tree/resource-tree-reload.html 802362 4 ap 2013-01-08 10:41:41 -0800 These broken tests look related to the proposed change, at least at a first glance. 803781 5 pdr 2013-01-09 15:25:37 -0800 (In reply to comment #4) > These broken tests look related to the proposed change, at least at a first glance. The tests are correctly failing. As strange as it seems, error() needs to be called during cache revalidation :/ I've filed a separate bug and put up a patch for the narrower issue of CreateImage() being called on revalidation requests for images: https://bugs.webkit.org/show_bug.cgi?id=106156 181634 2013-01-07 21:31:28 -0800 2013-01-09 16:21:11 -0800 First pass 106297.1.patch text/plain 1788 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTAzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTA3ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgQ2FuY2VsIHN1Y2Nlc3NmdWwgcmV2 YWxpZGF0aW9uIHJlcXVlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDYyOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHBhdGNoIGltbWVkaWF0ZWx5IGNhbmNlbHMgc3VjY2Vzc2Z1bCByZXZh bGlkYXRpb24gcmVxdWVzdHMgYmVjYXVzZSBvbmNlIGEgY2FjaGVkCisgICAgICAgIHJlc291cmNl IGhhcyBiZWVuIHJldmFsaWRhdGVkICgzMDQgbm90IG1vZGlmaWVkKSwgdGhlIHJlcXVlc3QgZG9l cyBub3QgbmVlZCB0byBjb250aW51ZQorICAgICAgICBsb2FkaW5nLiBQcmV2aW91c2x5LCBieSBu b3QgY2FuY2VsaW5nIHN1Y2Nlc3NmdWwgcmV2YWxpZGF0aW9uIHJlcXVlc3RzLCBldmVyeSBjYWNo ZWQgaW1hZ2UKKyAgICAgICAgbG9hZCB3b3VsZCBjYWxsIHRocm91Z2ggQ2FjaGVkSW1hZ2U6OmNy ZWF0ZUltYWdlLCBjcmVhdGUgYW4gdW5uZWNlc3NhcnkgQml0bWFwSW1hZ2UsIGFuZAorICAgICAg ICB1bHRpbWF0ZWx5IHRocm93IGFuIGVycm9yLiBXaXRoIHRoaXMgcGF0Y2ggdGhpcyB1c2VsZXNz IHdvcmsgaXMgc2tpcHBlZC4KKworICAgICAgICBUaGlzIHBhdGNoIGhhcyBubyBvYnNlcnZhYmxl IGNoYW5nZXMuCisKKyAgICAgICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U3VicmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisK IDIwMTMtMDEtMDcgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPHNsLm9zdGFwZW5rb0BzYW1zdW5n LmNvbT4KIAogICAgICAgICBbRUZMXVtXZWJHTF0gQ3Jhc2ggb2YgV2ViS2l0VGVzdFJ1bm5lciB3 aGVuIHJ1bm5pbmcgd2ViZ2wgbGF5b3V0IHRlc3RzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xv YWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDEzODg3OSkKKysrIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3 NSw2ICsxNzUsNyBAQCB2b2lkIFN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uCiAg ICAgICAgICAgICBtZW1vcnlDYWNoZSgpLT5yZXZhbGlkYXRpb25TdWNjZWVkZWQobV9yZXNvdXJj ZSwgcmVzcG9uc2UpOwogICAgICAgICAgICAgaWYgKCFyZWFjaGVkVGVybWluYWxTdGF0ZSgpKQog ICAgICAgICAgICAgICAgIFJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UocmVzcG9u c2UpOworICAgICAgICAgICAgY2FuY2VsKCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IH0KICAgICAgICAgLy8gRGlkIG5vdCBnZXQgMzA0IHJlc3BvbnNlLCBjb250aW51ZSBhcyBhIHJl Z3VsYXIgcmVzb3VyY2UgbG9hZC4K