106272 2013-01-07 15:57:32 -0800 [chromium] Don't use double tap zoom if minimum and maximum page scale is the same 2013-01-07 17:10:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yusufo yusufo aelias jamesr webkit.review.bot yusufo oldest_to_newest 801765 0 yusufo 2013-01-07 15:57:32 -0800 Don't use double tap zoom if minimum and maximum page scale is the same 801766 1 181588 yusufo 2013-01-07 15:58:04 -0800 Created attachment 181588 Patch 801779 2 181588 jamesr 2013-01-07 16:07:59 -0800 Comment on attachment 181588 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181588&action=review > Source/WebKit/chromium/ChangeLog:10 > +We should only try to computed relevant scale and scrollOffset and start the animation > +if the page is zoomable. This now creates an undesired animation for mobile pages which > +are not zoomable. nit: this should be 8-space indented 801792 3 181594 yusufo 2013-01-07 16:22:28 -0800 Created attachment 181594 Patch 801856 4 181594 webkit.review.bot 2013-01-07 17:10:24 -0800 Comment on attachment 181594 Patch Clearing flags on attachment: 181594 Committed r139017: <http://trac.webkit.org/changeset/139017> 801857 5 webkit.review.bot 2013-01-07 17:10:27 -0800 All reviewed patches have been landed. Closing bug. 181588 2013-01-07 15:58:04 -0800 2013-01-07 16:22:26 -0800 Patch bug-106272-20130107155508.patch text/plain 1738 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDE2ZGZhZWVlMTU4YTg0YjA5NzY5ZTliMjEwYjIzNWM5YzQ0Yjg4YjEuLjZkMzQyZDJiMTdjYjM2 MGU4YjQ2MzYxZmQ0OTFjNGZjMmZkNzBiMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMDcgIFl1c3VmIE96dXlzYWwgIDx5dXN1Zm9AZ29vZ2xl LmNvbT4KKworICAgICAgICBEb24ndCB1c2UgZG91YmxlIHRhcCB6b29tIGlmIG1pbmltdW0gYW5k IG1heGltdW0gcGFnZSBzY2FsZSBpcyB0aGUgc2FtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKK1dlIHNob3VsZCBvbmx5IHRyeSB0byBjb21wdXRlZCByZWxldmFudCBz Y2FsZSBhbmQgc2Nyb2xsT2Zmc2V0IGFuZCBzdGFydCB0aGUgYW5pbWF0aW9uCitpZiB0aGUgcGFn ZSBpcyB6b29tYWJsZS4gVGhpcyBub3cgY3JlYXRlcyBhbiB1bmRlc2lyZWQgYW5pbWF0aW9uIGZv ciBtb2JpbGUgcGFnZXMgd2hpY2gKK2FyZSBub3Qgem9vbWFibGUuCisKKyAgICAgICAgKiBzcmMv V2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aGFuZGxlR2Vz dHVyZUV2ZW50KToKKwogMjAxMy0wMS0wNCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIFdlYldpZGdldDo6bGF5ZXJUcmVl VmlldygpLCBvd25lcnNoaXAgaXMgdGhlIG90aGVyIHdheSBhcm91bmQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBkNGZjYzRjYjIwOThhMzdlNTUzN2Ji NzlmM2U4Y2QxYjUzOWQyZTAyLi40MTE4ODM4ZjRjZmIxNzk3NjE2NzMwM2JlNDdjZmY5NDU4ZjU4 OThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC03 NzUsNyArNzc1LDcgQEAgYm9vbCBXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0 IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNl IFdlYklucHV0RXZlbnQ6Okdlc3R1cmVEb3VibGVUYXA6Ci0gICAgICAgIGlmIChtX3dlYlNldHRp bmdzLT5kb3VibGVUYXBUb1pvb21FbmFibGVkKCkpIHsKKyAgICAgICAgaWYgKG1fd2ViU2V0dGlu Z3MtPmRvdWJsZVRhcFRvWm9vbUVuYWJsZWQoKSAmJiBtX21pbmltdW1QYWdlU2NhbGVGYWN0b3Ig IT0gbV9tYXhpbXVtUGFnZVNjYWxlRmFjdG9yKSB7CiAgICAgICAgICAgICBtX2NsaWVudC0+Y2Fu Y2VsU2NoZWR1bGVkQ29udGVudEludGVudHMoKTsKICAgICAgICAgICAgIGFuaW1hdGVab29tQXJv dW5kUG9pbnQoV2ViUG9pbnQoZXZlbnQueCwgZXZlbnQueSksIERvdWJsZVRhcCk7CiAgICAgICAg ICAgICBldmVudFN3YWxsb3dlZCA9IHRydWU7Cg== 181594 2013-01-07 16:22:28 -0800 2013-01-07 17:10:24 -0800 Patch bug-106272-20130107161933.patch text/plain 1762 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDE2ZGZhZWVlMTU4YTg0YjA5NzY5ZTliMjEwYjIzNWM5YzQ0Yjg4YjEuLmM0YWZkYzZjNTMxOTI3 YzVhNjJkNmZmY2JlNTJkMjZmMGY0NDdiOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMDcgIFl1c3VmIE96dXlzYWwgIDx5dXN1Zm9AZ29vZ2xl LmNvbT4KKworICAgICAgICBEb24ndCB1c2UgZG91YmxlIHRhcCB6b29tIGlmIG1pbmltdW0gYW5k IG1heGltdW0gcGFnZSBzY2FsZSBpcyB0aGUgc2FtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIG9ubHkgdHJ5IHRvIGNvbXB1dGVkIHJl bGV2YW50IHNjYWxlIGFuZCBzY3JvbGxPZmZzZXQgYW5kIHN0YXJ0IHRoZSBhbmltYXRpb24KKyAg ICAgICAgaWYgdGhlIHBhZ2UgaXMgem9vbWFibGUuIFRoaXMgbm93IGNyZWF0ZXMgYW4gdW5kZXNp cmVkIGFuaW1hdGlvbiBmb3IgbW9iaWxlIHBhZ2VzIHdoaWNoCisgICAgICAgIGFyZSBub3Qgem9v bWFibGUuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3SW1wbDo6aGFuZGxlR2VzdHVyZUV2ZW50KToKKwogMjAxMy0wMS0wNCAgSmFtZXMg Um9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIFdlYldpZGdldDo6bGF5ZXJUcmVlVmlldygpLCBvd25lcnNoaXAgaXMgdGhlIG90aGVyIHdh eSBhcm91bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRl eCBkNGZjYzRjYjIwOThhMzdlNTUzN2JiNzlmM2U4Y2QxYjUzOWQyZTAyLi40MTE4ODM4ZjRjZmIx Nzk3NjE2NzMwM2JlNDdjZmY5NDU4ZjU4OThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCkBAIC03NzUsNyArNzc1LDcgQEAgYm9vbCBXZWJWaWV3SW1wbDo6 aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiAgICAgICAg IGJyZWFrOwogICAgIH0KICAgICBjYXNlIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVEb3VibGVUYXA6 Ci0gICAgICAgIGlmIChtX3dlYlNldHRpbmdzLT5kb3VibGVUYXBUb1pvb21FbmFibGVkKCkpIHsK KyAgICAgICAgaWYgKG1fd2ViU2V0dGluZ3MtPmRvdWJsZVRhcFRvWm9vbUVuYWJsZWQoKSAmJiBt X21pbmltdW1QYWdlU2NhbGVGYWN0b3IgIT0gbV9tYXhpbXVtUGFnZVNjYWxlRmFjdG9yKSB7CiAg ICAgICAgICAgICBtX2NsaWVudC0+Y2FuY2VsU2NoZWR1bGVkQ29udGVudEludGVudHMoKTsKICAg ICAgICAgICAgIGFuaW1hdGVab29tQXJvdW5kUG9pbnQoV2ViUG9pbnQoZXZlbnQueCwgZXZlbnQu eSksIERvdWJsZVRhcCk7CiAgICAgICAgICAgICBldmVudFN3YWxsb3dlZCA9IHRydWU7Cg==