106267 2013-01-07 15:38:49 -0800 [chromium] Add OpaqueRegionSkia::currentTrackingOpaqueRect 2013-01-08 11:17:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alokp alokp danakj enne junov senorblanco webkit.review.bot oldest_to_newest 801735 0 alokp 2013-01-07 15:38:49 -0800 Minor implementation cleanup. Make currentTrackingOpaqueRect() a member function of OpaqueRegionSkia so that we do not need to pass member variables everywhere. 801774 1 181590 alokp 2013-01-07 16:03:31 -0800 Created attachment 181590 Patch 802321 2 181590 danakj 2013-01-08 10:06:39 -0800 Comment on attachment 181590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181590&action=review > Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp:431 > +SkRect& OpaqueRegionSkia::currentTrackingOpaqueRect() This is fine.. it's adding an extra function call to the stack though, instead of using the inline method. Is this worth it for some reason? I'm not sure of the motivation here. What's wrong with the current method? 802357 3 alokp 2013-01-08 10:38:49 -0800 This patch comes from https://bugs.webkit.org/show_bug.cgi?id=105051, which I decided to abandon. I am trying to extract all the minor cleanup changes and land them separately. The motivation is to reduce duplicated code and potential for bugs. The function arguments (m_opaqueRect, m_canvasLayerStack) are duplicated in all call sites. 802361 4 danakj 2013-01-08 10:40:39 -0800 (In reply to comment #3) > This patch comes from https://bugs.webkit.org/show_bug.cgi?id=105051, which I decided to abandon. I am trying to extract all the minor cleanup changes and land them separately. > > The motivation is to reduce duplicated code and potential for bugs. The function arguments (m_opaqueRect, m_canvasLayerStack) are duplicated in all call sites. I don't see this as a particularly dangerous pattern, but I don't feel strongly either way. I'll defer to senorblanco. 802396 5 181590 senorblanco 2013-01-08 11:02:05 -0800 Comment on attachment 181590 Patch Seems ok. r=me 802416 6 181590 webkit.review.bot 2013-01-08 11:17:18 -0800 Comment on attachment 181590 Patch Clearing flags on attachment: 181590 Committed r139083: <http://trac.webkit.org/changeset/139083> 802417 7 webkit.review.bot 2013-01-08 11:17:21 -0800 All reviewed patches have been landed. Closing bug. 181590 2013-01-07 16:03:31 -0800 2013-01-08 11:17:17 -0800 Patch bug-106267-20130107160036.patch text/plain 4770 alokp U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI1YjMzNTVmYzA1Y2Nl YmFiNjYzYTk1OTdlOTE2NmM5ZTdlM2RhNC4uOWNkZWE0ZWNlNjVhYjE1NTRkMTUzNzdjYTNiMjZh OGExYzE5NDViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTA3ICBBbG9r IFByaXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZGVkIE9wYXF1 ZVJlZ2lvblNraWE6OmN1cnJlbnRUcmFja2luZ09wYXF1ZVJlY3QKKworICAgICAgICBbY2hyb21p dW1dIEFkZCBPcGFxdWVSZWdpb25Ta2lhOjpjdXJyZW50VHJhY2tpbmdPcGFxdWVSZWN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYyNjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLiBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3NraWEvT3BhcXVlUmVnaW9uU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpP cGFxdWVSZWdpb25Ta2lhOjphcHBseU9wYXF1ZVJlZ2lvbkZyb21MYXllcik6CisgICAgICAgIChX ZWJDb3JlOjpPcGFxdWVSZWdpb25Ta2lhOjptYXJrUmVjdEFzT3BhcXVlKToKKyAgICAgICAgKFdl YkNvcmU6Ok9wYXF1ZVJlZ2lvblNraWE6Om1hcmtSZWN0QXNOb25PcGFxdWUpOgorICAgICAgICAo V2ViQ29yZTo6T3BhcXVlUmVnaW9uU2tpYTo6bWFya0FsbEFzTm9uT3BhcXVlKToKKyAgICAgICAg KFdlYkNvcmU6Ok9wYXF1ZVJlZ2lvblNraWE6OmN1cnJlbnRUcmFja2luZ09wYXF1ZVJlY3QpOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9PcGFx dWVSZWdpb25Ta2lhLmg6CisgICAgICAgIChPcGFxdWVSZWdpb25Ta2lhKToKKwogMjAxMy0wMS0w NyAgVG9tIFNlcGV6ICA8dHNlcGV6QGNocm9taXVtLm9yZz4KIAogICAgICAgICBEb2N1bWVudDo6 aW5pdFNlY3VyaXR5Q29udGV4dCgpIGdpdmVzIHBhcmVudCBzZWN1cml0eSBjb250ZXh0IHRvIGlm cmFtZXMgd2l0aCBpbnZhbGlkIFVSTHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL09wYXF1ZVJlZ2lvblNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9PcGFxdWVSZWdpb25Ta2lhLmNwcAppbmRleCBiZTRiZmJj NDMyMzhiNjRlOGE1ZTA0MjA3MDlkNDQ2MDliYjA0OTM4Li42OGU4ZDMwNDY0MzNhMTM2YTZiNjgz NDI0OGM0YjIwMTVhMjk1NzRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9za2lhL09wYXF1ZVJlZ2lvblNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvT3BhcXVlUmVnaW9uU2tpYS5jcHAKQEAgLTE2NCwxNCArMTY0 LDYgQEAgc3RhdGljIGlubGluZSBib29sIGdldERldmljZUNsaXBBc1JlY3QoY29uc3QgUGxhdGZv cm1Db250ZXh0U2tpYSogY29udGV4dCwgU2tSZWMKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotc3Rh dGljIGlubGluZSBTa1JlY3QmIGN1cnJlbnRUcmFja2luZ09wYXF1ZVJlY3QoU2tSZWN0JiByb290 T3BhcXVlUmVjdCwgVmVjdG9yPE9wYXF1ZVJlZ2lvblNraWE6OkNhbnZhc0xheWVyU3RhdGUsIDM+ JiBjYW52YXNMYXllclN0YWNrKQotewotICAgIC8vIElmIHdlIGFyZSBkcmF3aW5nIGludG8gYSBj YW52YXMgbGF5ZXIsIHRoZW4gdHJhY2sgdGhlIG9wYXF1ZSByZWN0IGluIHRoYXQgbGF5ZXIuCi0g ICAgaWYgKCFjYW52YXNMYXllclN0YWNrLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIGNhbnZh c0xheWVyU3RhY2subGFzdCgpLm9wYXF1ZVJlY3Q7Ci0gICAgcmV0dXJuIHJvb3RPcGFxdWVSZWN0 OwotfQotCiB2b2lkIE9wYXF1ZVJlZ2lvblNraWE6OnB1c2hDYW52YXNMYXllcihjb25zdCBTa1Bh aW50KiBwYWludCkKIHsKICAgICBDYW52YXNMYXllclN0YXRlIHN0YXRlOwpAQCAtMzMzLDcgKzMy NSw3IEBAIHZvaWQgT3BhcXVlUmVnaW9uU2tpYTo6YXBwbHlPcGFxdWVSZWdpb25Gcm9tTGF5ZXIo Y29uc3QgUGxhdGZvcm1Db250ZXh0U2tpYSogY29uCiAKICAgICBTa1JlY3Qgc291cmNlT3BhcXVl UmVjdCA9IGxheWVyT3BhcXVlUmVjdDsKICAgICAvLyBTYXZlIHRoZSBvcGFxdWUgYXJlYSBpbiB0 aGUgZGVzdGluYXRpb24sIHNvIHdlIGNhbiBwcmVzZXJ2ZSB0aGUgcGFydHMgb2YgaXQgdW5kZXIg dGhlIHNvdXJjZSBvcGFxdWUgYXJlYSBpZiBwb3NzaWJsZS4KLSAgICBTa1JlY3QgZGVzdGluYXRp b25PcGFxdWVSZWN0ID0gY3VycmVudFRyYWNraW5nT3BhcXVlUmVjdChtX29wYXF1ZVJlY3QsIG1f Y2FudmFzTGF5ZXJTdGFjayk7CisgICAgU2tSZWN0IGRlc3RpbmF0aW9uT3BhcXVlUmVjdCA9IGN1 cnJlbnRUcmFja2luZ09wYXF1ZVJlY3QoKTsKIAogICAgIGJvb2wgb3V0c2lkZVNvdXJjZU9wYXF1 ZVJlY3RQcmVzZXJ2ZXNPcGFxdWUgPSB4ZmVybW9kZVByZXNlcnZlc09wYXF1ZShwYWludCwgZmFs c2UpOwogICAgIGlmICghb3V0c2lkZVNvdXJjZU9wYXF1ZVJlY3RQcmVzZXJ2ZXNPcGFxdWUpCkBA IC0zNjMsNyArMzU1LDcgQEAgdm9pZCBPcGFxdWVSZWdpb25Ta2lhOjptYXJrUmVjdEFzT3BhcXVl KGNvbnN0IFNrUmVjdCYgcmVjdCkKICAgICAvLyByZWN0YW5nbGUgdGhlbiB3ZSBkbyB0aGF0LCBh cyB0aGF0IGlzIHRoZSBjaGVhcGVzdCB3YXkgdG8gaW5jcmVhc2UgdGhlIGFyZWEgcmV0dXJuZWQK ICAgICAvLyB3aXRob3V0IGluY3JlYXNpbmcgdGhlIGNvbXBsZXhpdHkuCiAKLSAgICBTa1JlY3Qm IG9wYXF1ZVJlY3QgPSBjdXJyZW50VHJhY2tpbmdPcGFxdWVSZWN0KG1fb3BhcXVlUmVjdCwgbV9j YW52YXNMYXllclN0YWNrKTsKKyAgICBTa1JlY3QmIG9wYXF1ZVJlY3QgPSBjdXJyZW50VHJhY2tp bmdPcGFxdWVSZWN0KCk7CiAKICAgICBpZiAocmVjdC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVy bjsKQEAgLTM5Nyw3ICszODksNyBAQCB2b2lkIE9wYXF1ZVJlZ2lvblNraWE6Om1hcmtSZWN0QXNO b25PcGFxdWUoY29uc3QgU2tSZWN0JiByZWN0KQogICAgIC8vIFdlIHdhbnQgdG8ga2VlcCBhcyBt dWNoIG9mIHRoZSBjdXJyZW50IG9wYXF1ZSByZWN0YW5nbGUgYXMgd2UgY2FuLCBzbyBmaW5kIHRo ZSBvbmUgbGFyZ2VzdAogICAgIC8vIHJlY3RhbmdsZSBpbnNpZGUgbV9vcGFxdWVSZWN0IHRoYXQg ZG9lcyBub3QgaW50ZXJzZWN0IHdpdGggfHJlY3R8LgogCi0gICAgU2tSZWN0JiBvcGFxdWVSZWN0 ID0gY3VycmVudFRyYWNraW5nT3BhcXVlUmVjdChtX29wYXF1ZVJlY3QsIG1fY2FudmFzTGF5ZXJT dGFjayk7CisgICAgU2tSZWN0JiBvcGFxdWVSZWN0ID0gY3VycmVudFRyYWNraW5nT3BhcXVlUmVj dCgpOwogCiAgICAgaWYgKCFTa1JlY3Q6OkludGVyc2VjdHMocmVjdCwgb3BhcXVlUmVjdCkpCiAg ICAgICAgIHJldHVybjsKQEAgLTQzMiw4ICs0MjQsMTQgQEAgdm9pZCBPcGFxdWVSZWdpb25Ta2lh OjptYXJrUmVjdEFzTm9uT3BhcXVlKGNvbnN0IFNrUmVjdCYgcmVjdCkKIAogdm9pZCBPcGFxdWVS ZWdpb25Ta2lhOjptYXJrQWxsQXNOb25PcGFxdWUoKQogewotICAgIFNrUmVjdCYgb3BhcXVlUmVj dCA9IGN1cnJlbnRUcmFja2luZ09wYXF1ZVJlY3QobV9vcGFxdWVSZWN0LCBtX2NhbnZhc0xheWVy U3RhY2spOworICAgIFNrUmVjdCYgb3BhcXVlUmVjdCA9IGN1cnJlbnRUcmFja2luZ09wYXF1ZVJl Y3QoKTsKICAgICBvcGFxdWVSZWN0LnNldEVtcHR5KCk7CiB9CiAKK1NrUmVjdCYgT3BhcXVlUmVn aW9uU2tpYTo6Y3VycmVudFRyYWNraW5nT3BhcXVlUmVjdCgpCit7CisgICAgLy8gSWYgd2UgYXJl IGRyYXdpbmcgaW50byBhIGNhbnZhcyBsYXllciwgdGhlbiB0cmFjayB0aGUgb3BhcXVlIHJlY3Qg aW4gdGhhdCBsYXllci4KKyAgICByZXR1cm4gbV9jYW52YXNMYXllclN0YWNrLmlzRW1wdHkoKSA/ IG1fb3BhcXVlUmVjdCA6IG1fY2FudmFzTGF5ZXJTdGFjay5sYXN0KCkub3BhcXVlUmVjdDsKK30K KwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9PcGFxdWVSZWdpb25Ta2lhLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL09wYXF1ZVJlZ2lvblNraWEuaAppbmRleCBkY2MxZmNiOTc4 ZjY1N2Q4NTc0Njc0YjE1ZmRiNjI2ZTU5Y2E1NjNmLi5lOGNiM2M0YmJkY2U2OTIyMThhYWRjODky YWVjZTk2ZTZhMTUxZjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL09wYXF1ZVJlZ2lvblNraWEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9za2lhL09wYXF1ZVJlZ2lvblNraWEuaApAQCAtOTEsNiArOTEsOCBAQCBwcml2 YXRlOgogICAgIHZvaWQgbWFya1JlY3RBc05vbk9wYXF1ZShjb25zdCBTa1JlY3QmKTsKICAgICB2 b2lkIG1hcmtBbGxBc05vbk9wYXF1ZSgpOwogCisgICAgU2tSZWN0JiBjdXJyZW50VHJhY2tpbmdP cGFxdWVSZWN0KCk7CisKICAgICBTa1JlY3QgbV9vcGFxdWVSZWN0OwogCiAgICAgVmVjdG9yPENh bnZhc0xheWVyU3RhdGUsIDM+IG1fY2FudmFzTGF5ZXJTdGFjazsK