106258 2013-01-07 14:55:43 -0800 Tiled-layer TileCaches shouldn't unparent offscreen tiles 2013-01-07 22:58:37 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned andersca bdakin eric esprehn kevin ojan.autocc simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 801687 0 thorton 2013-01-07 14:55:43 -0800 Secondary TileCaches shouldn't unparent offscreen tiles, because m_isInWindow is inaccurate (never set to true) for them, so the entirety of this feature doesn't work. 801689 1 webkit-bug-importer 2013-01-07 14:56:01 -0800 <rdar://problem/12969116> 801698 2 181572 thorton 2013-01-07 15:06:24 -0800 Created attachment 181572 patch 801702 3 181572 simon.fraser 2013-01-07 15:09:03 -0800 Comment on attachment 181572 patch View in context: https://bugs.webkit.org/attachment.cgi?id=181572&action=review > Source/WebCore/ChangeLog:10 > + the TileCache should unparent offscreen tiles. We can't use this behavior for secondary TileCaches Let's call these something other than "secondary". How about "tiled layer TileCaches". 801713 4 thorton 2013-01-07 15:19:17 -0800 http://trac.webkit.org/changeset/138997 801716 5 thorton 2013-01-07 15:21:35 -0800 *** Bug 106205 has been marked as a duplicate of this bug. *** 801790 6 simon.fraser 2013-01-07 16:21:14 -0800 *** Bug 106265 has been marked as a duplicate of this bug. *** 802056 7 simon.fraser 2013-01-07 22:58:37 -0800 *** Bug 106205 has been marked as a duplicate of this bug. *** 181572 2013-01-07 15:06:24 -0800 2013-01-07 15:09:03 -0800 patch secondary.diff text/plain 7288 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYmIwNjY5Li45YjMyZGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTMtMDEtMDcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgU2Vjb25kYXJ5IFRpbGVDYWNoZXMgc2hvdWxkbid0IHVucGFyZW50IG9mZnNjcmVl biB0aWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA2MjU4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMjk2OTExNj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzZXR0aW5nIG9uIFRpbGVk QmFja2luZyAoaW1wbGVtZW50ZWQgb24gVGlsZUNhY2hlKSB0aGF0IGNvbnRyb2xzIHdoZXRoZXIg b3Igbm90CisgICAgICAgIHRoZSBUaWxlQ2FjaGUgc2hvdWxkIHVucGFyZW50IG9mZnNjcmVlbiB0 aWxlcy4gV2UgY2FuJ3QgdXNlIHRoaXMgYmVoYXZpb3IgZm9yIHNlY29uZGFyeSBUaWxlQ2FjaGVz CisgICAgICAgIGN1cnJlbnRseSBiZWNhdXNlIG1faXNJbldpbmRvdyBpcyBub3QgdXBkYXRlZCBm b3Igc2Vjb25kYXJ5IFRpbGVDYWNoZXMsIGFuZCBiZWNhdXNlIHdlIGhhdmVuJ3QKKyAgICAgICAg ZGVjaWRlZCBleGFjdGx5IHdoYXQgdGhlaXIgYmVoYXZpb3Igc2hvdWxkIGJlLiBTbywgcmV2ZXJ0 IHRvIHRoZSBvbGQgYmVoYXZpb3IgZm9yIHRoZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9UaWxlZEJhY2tpbmcuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMv VGlsZUNhY2hlLmg6CisgICAgICAgIChUaWxlQ2FjaGUpOiBBZGQgc2V0VW5wYXJlbnRzT2Zmc2Ny ZWVuVGlsZXMvdW5wYXJlbnRzT2Zmc2NyZWVuVGlsZXMuCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVDYWNoZTo6 VGlsZUNhY2hlKTogbV91bnBhcmVudHNPZmZzY3JlZW5UaWxlcyBkZWZhdWx0cyB0byBmYWxzZS4K KyAgICAgICAgKFdlYkNvcmU6OlRpbGVDYWNoZTo6cmV2YWxpZGF0ZVRpbGVzKToKKyAgICAgICAg UmV0dXJuIHRvIHRoZSBvbGQgYmVoYXZpb3Igb2YgYWx3YXlzIGFkZGluZyBuZXcgbGF5ZXJzIHRv IHRoZSBsYXllciB0cmVlIHJlZ2FyZGxlc3Mgb2YgbV9pc0luV2luZG93IGlmIG1fdW5wYXJlbnRz T2Zmc2NyZWVuVGlsZXMgaXMgZmFsc2UuCisgICAgICAgIFJldHVybiB0byB0aGUgb2xkIGJlaGF2 aW9yIG9mIG5ldmVyIHVucGFyZW50aW5nIHRpbGVzIHJlZ2FyZGxlc3Mgb2YgbV9pc0luV2luZG93 IGlmIG1fdW5wYXJlbnRzT2Zmc2NyZWVuVGlsZXMgaXMgZmFsc2UuCisgICAgICAgIChXZWJDb3Jl OjpUaWxlQ2FjaGU6OmVuc3VyZVRpbGVzRm9yUmVjdCk6IFJldHVybiB0byB0aGUgb2xkIGJlaGF2 aW9yIG9mIGFsd2F5cyBlbnN1cmluZyB0aWxlcyByZWdhcmRsZXNzIG9mIG1faXNJbldpbmRvdyBp ZiBtX3VucGFyZW50c09mZnNjcmVlblRpbGVzIGlzIGZhbHNlLgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJC YWNraW5nOjpSZW5kZXJMYXllckJhY2tpbmcpOiBUZWxsIHByaW1hcnkgVGlsZUNhY2hlcyB0aGF0 IGl0J3MgT0sgdG8gdW5wYXJlbnQgb2Zmc2NyZWVuIHRpbGVzLgorCiAyMDEzLTAxLTA0ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBPcHRpbWl6ZSBU cmFuc2Zvcm1hdGlvbk1hdHJpeDo6bXVsdGlwbHkoKSBmb3IgeDg2XzY0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmcuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZy5oCmluZGV4IGJmZjFhN2YuLjQx YjMzNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVk QmFja2luZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFj a2luZy5oCkBAIC03Miw2ICs3Miw5IEBAIHB1YmxpYzoKICAgICAKICAgICB2aXJ0dWFsIHZvaWQg c2V0QWdncmVzc2l2ZWx5UmV0YWluc1RpbGVzKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wg YWdncmVzc2l2ZWx5UmV0YWluc1RpbGVzKCkgY29uc3QgPSAwOworICAgIAorICAgIHZpcnR1YWwg dm9pZCBzZXRVbnBhcmVudHNPZmZzY3JlZW5UaWxlcyhib29sKSA9IDA7CisgICAgdmlydHVhbCBi b29sIHVucGFyZW50c09mZnNjcmVlblRpbGVzKCkgY29uc3QgPSAwOwogCiAgICAgLy8gRXhwb3Nl ZCBmb3IgdGVzdGluZwogICAgIHZpcnR1YWwgSW50UmVjdCB0aWxlQ292ZXJhZ2VSZWN0KCkgY29u c3QgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Ev bWFjL1RpbGVDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFj L1RpbGVDYWNoZS5oCmluZGV4IGY0MDE5M2EuLmFlMDQ3ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ2FjaGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLmgKQEAgLTExNyw2ICsx MTcsOCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBzY3JvbGxpbmdQZXJmb3JtYW5jZUxv Z2dpbmdFbmFibGVkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gbV9zY3JvbGxpbmdQZXJmb3Jt YW5jZUxvZ2dpbmdFbmFibGVkOyB9CiAgICAgdmlydHVhbCB2b2lkIHNldEFnZ3Jlc3NpdmVseVJl dGFpbnNUaWxlcyhib29sIGZsYWcpIE9WRVJSSURFIHsgbV9hZ2dyZXNzaXZlbHlSZXRhaW5zVGls ZXMgPSBmbGFnOyB9CiAgICAgdmlydHVhbCBib29sIGFnZ3Jlc3NpdmVseVJldGFpbnNUaWxlcygp IGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIG1fYWdncmVzc2l2ZWx5UmV0YWluc1RpbGVzOyB9Cisg ICAgdmlydHVhbCB2b2lkIHNldFVucGFyZW50c09mZnNjcmVlblRpbGVzKGJvb2wgZmxhZykgT1ZF UlJJREUgeyBtX3VucGFyZW50c09mZnNjcmVlblRpbGVzID0gZmxhZzsgfQorICAgIHZpcnR1YWwg Ym9vbCB1bnBhcmVudHNPZmZzY3JlZW5UaWxlcygpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIG1f dW5wYXJlbnRzT2Zmc2NyZWVuVGlsZXM7IH0KICAgICB2aXJ0dWFsIEludFJlY3QgdGlsZUNvdmVy YWdlUmVjdCgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgQ0FMYXllciAqdGlsZWRTY3Jv bGxpbmdJbmRpY2F0b3JMYXllcigpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBzZXRTY3Jv bGxpbmdNb2RlSW5kaWNhdGlvbihTY3JvbGxpbmdNb2RlSW5kaWNhdGlvbikgT1ZFUlJJREU7CkBA IC0xOTIsNiArMTk0LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1faXNJbldpbmRvdzsKICAgICBi b29sIG1fc2Nyb2xsaW5nUGVyZm9ybWFuY2VMb2dnaW5nRW5hYmxlZDsKICAgICBib29sIG1fYWdn cmVzc2l2ZWx5UmV0YWluc1RpbGVzOworICAgIGJvb2wgbV91bnBhcmVudHNPZmZzY3JlZW5UaWxl czsKICAgICBib29sIG1fYWNjZWxlcmF0ZXNEcmF3aW5nOwogICAgIGJvb2wgbV90aWxlc0FyZU9w YXF1ZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Ev bWFjL1RpbGVDYWNoZS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21h Yy9UaWxlQ2FjaGUubW0KaW5kZXggN2VmYzk1Yy4uYTZkM2UyNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tCkBAIC0xMDYs NiArMTA2LDcgQEAgVGlsZUNhY2hlOjpUaWxlQ2FjaGUoV2ViVGlsZUNhY2hlTGF5ZXIqIHRpbGVD YWNoZUxheWVyKQogICAgICwgbV9pc0luV2luZG93KGZhbHNlKQogICAgICwgbV9zY3JvbGxpbmdQ ZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkKGZhbHNlKQogICAgICwgbV9hZ2dyZXNzaXZlbHlSZXRh aW5zVGlsZXMoZmFsc2UpCisgICAgLCBtX3VucGFyZW50c09mZnNjcmVlblRpbGVzKGZhbHNlKQog ICAgICwgbV9hY2NlbGVyYXRlc0RyYXdpbmcoZmFsc2UpCiAgICAgLCBtX3RpbGVzQXJlT3BhcXVl KGZhbHNlKQogICAgICwgbV90aWxlRGVidWdCb3JkZXJXaWR0aCgwKQpAQCAtNTg2LDcgKzU4Nyw5 IEBAIHZvaWQgVGlsZUNhY2hlOjpyZXZhbGlkYXRlVGlsZXMoVGlsZVZhbGlkYXRpb25Qb2xpY3lG bGFncyBmb3JlZ3JvdW5kVmFsaWRhdGlvblBvCiAgICAgICAgICAgICAgICAgaWYgKHRpbGVJbmZv LmNvaG9ydCA9PSBWaXNpYmxlVGlsZUNvaG9ydCkgewogICAgICAgICAgICAgICAgICAgICB0aWxl SW5mby5jb2hvcnQgPSBjdXJyQ29ob3J0OwogICAgICAgICAgICAgICAgICAgICArK3RpbGVzSW5D b2hvcnQ7Ci0gICAgICAgICAgICAgICAgICAgIFt0aWxlSW5mby5sYXllci5nZXQoKSByZW1vdmVG cm9tU3VwZXJsYXllcl07CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgICAg ICBpZiAobV91bnBhcmVudHNPZmZzY3JlZW5UaWxlcykKKyAgICAgICAgICAgICAgICAgICAgICAg IFt0aWxlSW5mby5sYXllci5nZXQoKSByZW1vdmVGcm9tU3VwZXJsYXllcl07CiAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC02MTcsMTAgKzYyMCwxMCBAQCB2 b2lkIFRpbGVDYWNoZTo6cmV2YWxpZGF0ZVRpbGVzKFRpbGVWYWxpZGF0aW9uUG9saWN5RmxhZ3Mg Zm9yZWdyb3VuZFZhbGlkYXRpb25QbwogICAgICAgICAgICAgVGlsZUluZm8mIHRpbGVJbmZvID0g bV90aWxlcy5hZGQodGlsZUluZGV4LCBUaWxlSW5mbygpKS5pdGVyYXRvci0+dmFsdWU7CiAgICAg ICAgICAgICBpZiAoIXRpbGVJbmZvLmxheWVyKSB7CiAgICAgICAgICAgICAgICAgdGlsZUluZm8u bGF5ZXIgPSBjcmVhdGVUaWxlTGF5ZXIodGlsZVJlY3QpOwotICAgICAgICAgICAgICAgIGlmICht X2lzSW5XaW5kb3cpCisgICAgICAgICAgICAgICAgaWYgKCFtX3VucGFyZW50c09mZnNjcmVlblRp bGVzIHx8IG1faXNJbldpbmRvdykKICAgICAgICAgICAgICAgICAgICAgW21fdGlsZUNvbnRhaW5l ckxheWVyLmdldCgpIGFkZFN1YmxheWVyOnRpbGVJbmZvLmxheWVyLmdldCgpXTsKICAgICAgICAg ICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgaWYgKG1faXNJbldpbmRvdyAmJiAhW3RpbGVJ bmZvLmxheWVyLmdldCgpIHN1cGVybGF5ZXJdKQorICAgICAgICAgICAgICAgIGlmICgoIW1fdW5w YXJlbnRzT2Zmc2NyZWVuVGlsZXMgfHwgbV9pc0luV2luZG93KSAmJiAhW3RpbGVJbmZvLmxheWVy LmdldCgpIHN1cGVybGF5ZXJdKQogICAgICAgICAgICAgICAgICAgICBbbV90aWxlQ29udGFpbmVy TGF5ZXIuZ2V0KCkgYWRkU3VibGF5ZXI6dGlsZUluZm8ubGF5ZXIuZ2V0KCldOwogCiAgICAgICAg ICAgICAgICAgLy8gV2UgYWxyZWFkeSBoYXZlIGEgbGF5ZXIgZm9yIHRoaXMgdGlsZS4gRW5zdXJl IHRoYXQgaXRzIHNpemUgaXMgY29ycmVjdC4KQEAgLTY0Miw3ICs2NDUsNyBAQCB2b2lkIFRpbGVD YWNoZTo6cmV2YWxpZGF0ZVRpbGVzKFRpbGVWYWxpZGF0aW9uUG9saWN5RmxhZ3MgZm9yZWdyb3Vu ZFZhbGlkYXRpb25QbwogICAgICAgICBtX2NvaG9ydExpc3QuY2xlYXIoKTsKICAgICB9CiAKLSAg ICBpZiAodmFsaWRhdGlvblBvbGljeSAmIFVucGFyZW50QWxsVGlsZXMpIHsKKyAgICBpZiAobV91 bnBhcmVudHNPZmZzY3JlZW5UaWxlcyAmJiAodmFsaWRhdGlvblBvbGljeSAmIFVucGFyZW50QWxs VGlsZXMpKSB7CiAgICAgICAgIGZvciAoVGlsZU1hcDo6aXRlcmF0b3IgaXQgPSBtX3RpbGVzLmJl Z2luKCksIGVuZCA9IG1fdGlsZXMuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkKICAgICAgICAgICAg IFtpdC0+dmFsdWUubGF5ZXIuZ2V0KCkgcmVtb3ZlRnJvbVN1cGVybGF5ZXJdOwogICAgIH0KQEAg LTcxMCw3ICs3MTMsNyBAQCB2b2lkIFRpbGVDYWNoZTo6Y29ob3J0UmVtb3ZhbFRpbWVyRmlyZWQo VGltZXI8VGlsZUNhY2hlPiopCiAKIHZvaWQgVGlsZUNhY2hlOjplbnN1cmVUaWxlc0ZvclJlY3Qo Y29uc3QgSW50UmVjdCYgcmVjdCkKIHsKLSAgICBpZiAoIW1faXNJbldpbmRvdykKKyAgICBpZiAo bV91bnBhcmVudHNPZmZzY3JlZW5UaWxlcyAmJiAhbV9pc0luV2luZG93KQogICAgICAgICByZXR1 cm47CiAKICAgICBQbGF0Zm9ybUNBTGF5ZXIqIHBsYXRmb3JtTGF5ZXIgPSBQbGF0Zm9ybUNBTGF5 ZXI6OnBsYXRmb3JtQ0FMYXllcihtX3RpbGVDYWNoZUxheWVyKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggZTMyNjIyYy4uMDY5MGJj ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKQEAgLTEzMCw2ICsxMzAsMTAgQEAgUmVuZGVyTGF5ZXJCYWNraW5nOjpSZW5kZXJMYXllckJh Y2tpbmcoUmVuZGVyTGF5ZXIqIGxheWVyKQogICAgICAgICBpZiAoUGFnZSogcGFnZSA9IHJlbmRl cmVyKCktPmZyYW1lKCktPnBhZ2UoKSkgewogICAgICAgICAgICAgRnJhbWUqIGZyYW1lID0gcmVu ZGVyZXIoKS0+ZnJhbWUoKTsKICAgICAgICAgICAgIHRpbGVkQmFja2luZy0+c2V0SXNJbldpbmRv dyhwYWdlLT5pc09uc2NyZWVuKCkpOworCisgICAgICAgICAgICBpZiAobV9pc01haW5GcmFtZVJl bmRlclZpZXdMYXllcikKKyAgICAgICAgICAgICAgICB0aWxlZEJhY2tpbmctPnNldFVucGFyZW50 c09mZnNjcmVlblRpbGVzKHRydWUpOworCiAgICAgICAgICAgICB0aWxlZEJhY2tpbmctPnNldFNj cm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQoZnJhbWUtPnNldHRpbmdzKCkgJiYgZnJh bWUtPnNldHRpbmdzKCktPnNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQoKSk7CiAg ICAgICAgICAgICBhZGp1c3RUaWxlQ2FjaGVDb3ZlcmFnZSgpOwogICAgICAgICB9Cg==