106254 2013-01-07 14:27:12 -0800 Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration 2013-01-08 11:02:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth dpranke ojan tony webkit.review.bot oldest_to_newest 801665 0 jparent 2013-01-07 14:27:12 -0800 Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration 801674 1 181568 jparent 2013-01-07 14:32:38 -0800 Created attachment 181568 Patch 801818 2 181568 abarth 2013-01-07 16:47:13 -0800 Comment on attachment 181568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181568&action=review > Tools/ChangeLog:5 > + Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration > + https://bugs.webkit.org/show_bug.cgi?id=106254 > + Typically it's a good idea to leave the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so that the bots can replace it with the name of the person who actually reviewed this change. 801820 3 abarth 2013-01-07 16:47:31 -0800 I wanted to r=me this patch, but I didn't quite feel like I understood the code well enough. 802280 4 181701 jparent 2013-01-08 08:48:54 -0800 Created attachment 181701 Patch 802282 5 jparent 2013-01-08 08:50:54 -0800 Fixed the ChangeLog, I didn't mean to remove the Reviewed by line. Can someone else more familiar with the code take a look at this? It is actually a pretty simple change, I outlined the logic behind it in the ChangeLog (the fact that it doesn't look obvious is exactly why I'm doing this cleanup ... there is a lot of logic flow in the dashboards controlled by completely unintuitive global variables!) 802394 6 181701 webkit.review.bot 2013-01-08 11:01:55 -0800 Comment on attachment 181701 Patch Clearing flags on attachment: 181701 Committed r139082: <http://trac.webkit.org/changeset/139082> 802395 7 webkit.review.bot 2013-01-08 11:02:00 -0800 All reviewed patches have been landed. Closing bug. 181568 2013-01-07 14:32:38 -0800 2013-01-08 08:48:52 -0800 Patch bug-106254-20130107142943.patch text/plain 3388 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjJkMDNlMTE0NmQ0OWFmOWY0YWIzYTI1YTdiMWJlMjM4 YWE1Y2NhMi4uY2IyOWEwYTQzY2NmOGQxMWFlMTA5NGFmYTAzNzQ2NjAyZWY1MmU0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEzLTAxLTA3ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBEYXNoYm9hcmQgQ2xlYW51cDogUmVtb3ZlIGdfaGFzRG9uZUluaXRpYWxQYWdlR2Vu ZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA2MjU0CisKKyAgICAgICAgUmVtb3ZlIHRoZSBnbG9iYWwgdmFyaWFibGUgZ19oYXNEb25lSW5p dGlhbFBhZ2VHZW5lcmF0aW9uLiAgSXQgd2FzCisgICAgICAgIHVzZWQgb25seSB0byBmaWd1cmUg b3V0IGlmIHdlIHNob3VsZCBjYWxsIGFkZEJ1aWxkZXJMb2FkRXJyb3JzIGR1cmluZworICAgICAg ICBoYW5kbGVMb2NhdGlvbkNoYW5nZSwgd2hpY2ggd2FzIGNhbGxlZCB3aGVuIHRoZSBsb2FkZXIg Y29tcGxldGVkIGFuZAorICAgICAgICBvbiBhbnkgaGFzaCBjaGFuZ2UsIGJ1dCB3ZSBvbmx5IGV2 ZXIgd2FudGVkIHRvIGNhbGwgYWRkQnVpbGRlckxvYWRFcnJvcnMKKyAgICAgICAgb24gdGhlIGlu aXRpYWwgbG9hZGVyIGxvYWQuICBNb3ZlZCB0aGUgY2FsbCBvZiBhZGRCdWlsZGVyTG9hZEVycm9y cyB0bworICAgICAgICByZXNvdXJjZUxvYWRpbmdDb21wbGV0ZSByYXRoZXIgdGhhbiBoYW5kbGVM b2NhdGlvbkNoYW5nZSwgc28gbm93CisgICAgICAgIHdlIG9ubHkgY2FsbCBpdCB3aGVuIHdlIHdh bnQgdG8sIGFuZCB0aGUgY2hlY2sgY2FuIGdvIGF3YXkgY29tcGxldGVseS4KKworICAgICAgICAq IFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanM6Cisg ICAgICAgIChhZGRCdWlsZGVyTG9hZEVycm9ycyk6CisgICAgICAgIChyZXNvdXJjZUxvYWRpbmdD b21wbGV0ZSk6CisgICAgICAgIChoYW5kbGVMb2NhdGlvbkNoYW5nZSk6CisgICAgICAgICogVGVz dFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0 ZXN0cy5qczoKKwogMjAxMy0wMS0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBCdWlsZCBmaXggYXR0ZW1wdCBhZnRlciByMTM4ODEwLgpkaWZmIC0tZ2l0IGEv VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5q cyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jh c2UuanMKaW5kZXggNTRiMDc3YWZhMzVkZDY2MjZhZmU2ZjU4NDhjODBiODg4N2ZhOTkwMi4uMjQy MGJiMWE2ZWQ3Mzc3NWIyNzNmMThkODhmZDg3Mzc0NTQ5MWY2OCAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcworKysg Yi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNl LmpzCkBAIC00NjIsNyArNDYyLDYgQEAgZnVuY3Rpb24gaXNGbGFraW5lc3NEYXNoYm9hcmQoKQog ICAgIHJldHVybiBlbmRzV2l0aCh3aW5kb3cubG9jYXRpb24ucGF0aG5hbWUsICdmbGFraW5lc3Nf ZGFzaGJvYXJkLmh0bWwnKTsKIH0KIAotdmFyIGdfaGFzRG9uZUluaXRpYWxQYWdlR2VuZXJhdGlv biA9IGZhbHNlOwogLy8gU3RyaW5nIG9mIGVycm9yIG1lc3NhZ2VzIHRvIGRpc3BsYXkgdG8gdGhl IHVzZXIuCiB2YXIgZ19lcnJvck1lc3NhZ2VzID0gJyc7CiAKQEAgLTUwMiw5ICs1MDEsNiBAQCBm dW5jdGlvbiBzaG93RXJyb3JzKCkKIAogZnVuY3Rpb24gYWRkQnVpbGRlckxvYWRFcnJvcnMoKQog ewotICAgIGlmIChnX2hhc0RvbmVJbml0aWFsUGFnZUdlbmVyYXRpb24pCi0gICAgICAgIHJldHVy bjsKLQogICAgIGlmIChnX2J1aWxkZXJzVGhhdEZhaWxlZFRvTG9hZC5sZW5ndGgpCiAgICAgICAg IGFkZEVycm9yKCdFUlJPUjogRmFpbGVkIHRvIGdldCBkYXRhIGZyb20gJyArIGdfYnVpbGRlcnNU aGF0RmFpbGVkVG9Mb2FkLnRvU3RyaW5nKCkgKyAnLicpOwogCkBAIC01MTUsNiArNTExLDcgQEAg ZnVuY3Rpb24gYWRkQnVpbGRlckxvYWRFcnJvcnMoKQogZnVuY3Rpb24gcmVzb3VyY2VMb2FkaW5n Q29tcGxldGUoKQogewogICAgIGdfcmVzb3VyY2VMb2FkZXIgPSBudWxsOworICAgIGFkZEJ1aWxk ZXJMb2FkRXJyb3JzKCk7CiAgICAgaGFuZGxlTG9jYXRpb25DaGFuZ2UoKTsKIH0KIApAQCAtNTIz LDkgKzUyMCw2IEBAIGZ1bmN0aW9uIGhhbmRsZUxvY2F0aW9uQ2hhbmdlKCkKICAgICBpZiAoZ19y ZXNvdXJjZUxvYWRlcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgYWRkQnVpbGRlckxvYWRFcnJv cnMoKTsKLSAgICBnX2hhc0RvbmVJbml0aWFsUGFnZUdlbmVyYXRpb24gPSB0cnVlOwotCiAgICAg dmFyIHBhcmFtcyA9IHBhcnNlUGFyYW1ldGVycygpOwogICAgIHZhciBzaG91bGRHZW5lcmF0ZVBh Z2UgPSB0cnVlOwogICAgIGlmIChPYmplY3Qua2V5cyhwYXJhbXMpLmxlbmd0aCkKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rh c2hib2FyZF91bml0dGVzdHMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNo Ym9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzCmluZGV4IDJkYTYzNDFiYjc4 YWZhYmM2ZGJiNzgwZTFhOTgyZGVlYTViMTRhOTYuLjliMTY4ZjI4NWNjMWEwMWFjZWY4MGU2Y2Uw OTE4NTRlODQ5NjA2ZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMKKysrIGIvVG9vbHMv VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Vu aXR0ZXN0cy5qcwpAQCAtNTk5LDcgKzU5OSw2IEBAIHRlc3QoJ2RpZmZTdGF0ZXMnLCA1LCBmdW5j dGlvbigpIHsKIAogdGVzdCgnYWRkQnVpbGRlckxvYWRFcnJvcnMnLCAxLCBmdW5jdGlvbigpIHsK ICAgICBjbGVhckVycm9ycygpOwotICAgIGdfaGFzRG9uZUluaXRpYWxQYWdlR2VuZXJhdGlvbiA9 IGZhbHNlOwogICAgIGdfYnVpbGRlcnNUaGF0RmFpbGVkVG9Mb2FkID0gWydidWlsZGVyMScsICdi dWlsZGVyMiddOwogICAgIGdfc3RhbGVCdWlsZGVycyA9IFsnc3RhbGVCdWlsZGVyMSddOwogICAg IGFkZEJ1aWxkZXJMb2FkRXJyb3JzKCk7Cg== 181701 2013-01-08 08:48:54 -0800 2013-01-08 11:01:55 -0800 Patch bug-106254-20130108084558.patch text/plain 3427 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjJkMDNlMTE0NmQ0OWFmOWY0YWIzYTI1YTdiMWJlMjM4 YWE1Y2NhMi4uYjQzZjRjYjRmZjY3OGNiYjE4ZjYxODEwYmUwYmIzYTdiOTU2NzA2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEzLTAxLTA4ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBEYXNoYm9hcmQgQ2xlYW51cDogUmVtb3ZlIGdfaGFzRG9uZUluaXRpYWxQYWdlR2Vu ZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA2MjU0CisKKyAgICAgICAgUmVtb3ZlIHRoZSBnbG9iYWwgdmFyaWFibGUgZ19oYXNEb25lSW5p dGlhbFBhZ2VHZW5lcmF0aW9uLiAgSXQgd2FzIHVzZWQKKyAgICAgICAgb25seSB0byBmaWd1cmUg b3V0IGlmIHdlIHNob3VsZCBjYWxsIGFkZEJ1aWxkZXJMb2FkRXJyb3JzIGR1cmluZworICAgICAg ICBoYW5kbGVMb2NhdGlvbkNoYW5nZSwgd2hpY2ggd2FzIGNhbGxlZCB3aGVuIHRoZSBsb2FkZXIg Y29tcGxldGVkIGFuZCBvbgorICAgICAgICBhbnkgaGFzaCBjaGFuZ2UsIGJ1dCB3ZSBvbmx5IGV2 ZXIgd2FudGVkIHRvIGNhbGwgYWRkQnVpbGRlckxvYWRFcnJvcnMKKyAgICAgICAgb24gdGhlIGlu aXRpYWwgbG9hZGVyIGxvYWQuICBNb3ZlZCB0aGUgY2FsbCBvZiBhZGRCdWlsZGVyTG9hZEVycm9y cyB0bworICAgICAgICByZXNvdXJjZUxvYWRpbmdDb21wbGV0ZSByYXRoZXIgdGhhbiBoYW5kbGVM b2NhdGlvbkNoYW5nZSwgc28gbm93IHdlCisgICAgICAgIG9ubHkgY2FsbCBpdCB3aGVuIHdlIHdh bnQgdG8sIGFuZCB0aGUgY2hlY2sgY2FuIGdvIGF3YXkgY29tcGxldGVseS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanM6CisgICAgICAgIChhZGRCdWlsZGVy TG9hZEVycm9ycyk6CisgICAgICAgIChyZXNvdXJjZUxvYWRpbmdDb21wbGV0ZSk6CisgICAgICAg IChoYW5kbGVMb2NhdGlvbkNoYW5nZSk6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0 aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qczoKKwogMjAxMy0w MS0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBm aXggYXR0ZW1wdCBhZnRlciByMTM4ODEwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcyBiL1Rvb2xzL1Rlc3RSZXN1 bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMKaW5kZXggNTRiMDc3 YWZhMzVkZDY2MjZhZmU2ZjU4NDhjODBiODg4N2ZhOTkwMi4uMjQyMGJiMWE2ZWQ3Mzc3NWIyNzNm MThkODhmZDg3Mzc0NTQ5MWY2OCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzCkBAIC00NjIsNyArNDYy LDYgQEAgZnVuY3Rpb24gaXNGbGFraW5lc3NEYXNoYm9hcmQoKQogICAgIHJldHVybiBlbmRzV2l0 aCh3aW5kb3cubG9jYXRpb24ucGF0aG5hbWUsICdmbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwnKTsK IH0KIAotdmFyIGdfaGFzRG9uZUluaXRpYWxQYWdlR2VuZXJhdGlvbiA9IGZhbHNlOwogLy8gU3Ry aW5nIG9mIGVycm9yIG1lc3NhZ2VzIHRvIGRpc3BsYXkgdG8gdGhlIHVzZXIuCiB2YXIgZ19lcnJv ck1lc3NhZ2VzID0gJyc7CiAKQEAgLTUwMiw5ICs1MDEsNiBAQCBmdW5jdGlvbiBzaG93RXJyb3Jz KCkKIAogZnVuY3Rpb24gYWRkQnVpbGRlckxvYWRFcnJvcnMoKQogewotICAgIGlmIChnX2hhc0Rv bmVJbml0aWFsUGFnZUdlbmVyYXRpb24pCi0gICAgICAgIHJldHVybjsKLQogICAgIGlmIChnX2J1 aWxkZXJzVGhhdEZhaWxlZFRvTG9hZC5sZW5ndGgpCiAgICAgICAgIGFkZEVycm9yKCdFUlJPUjog RmFpbGVkIHRvIGdldCBkYXRhIGZyb20gJyArIGdfYnVpbGRlcnNUaGF0RmFpbGVkVG9Mb2FkLnRv U3RyaW5nKCkgKyAnLicpOwogCkBAIC01MTUsNiArNTExLDcgQEAgZnVuY3Rpb24gYWRkQnVpbGRl ckxvYWRFcnJvcnMoKQogZnVuY3Rpb24gcmVzb3VyY2VMb2FkaW5nQ29tcGxldGUoKQogewogICAg IGdfcmVzb3VyY2VMb2FkZXIgPSBudWxsOworICAgIGFkZEJ1aWxkZXJMb2FkRXJyb3JzKCk7CiAg ICAgaGFuZGxlTG9jYXRpb25DaGFuZ2UoKTsKIH0KIApAQCAtNTIzLDkgKzUyMCw2IEBAIGZ1bmN0 aW9uIGhhbmRsZUxvY2F0aW9uQ2hhbmdlKCkKICAgICBpZiAoZ19yZXNvdXJjZUxvYWRlcikKICAg ICAgICAgcmV0dXJuOwogCi0gICAgYWRkQnVpbGRlckxvYWRFcnJvcnMoKTsKLSAgICBnX2hhc0Rv bmVJbml0aWFsUGFnZUdlbmVyYXRpb24gPSB0cnVlOwotCiAgICAgdmFyIHBhcmFtcyA9IHBhcnNl UGFyYW1ldGVycygpOwogICAgIHZhciBzaG91bGRHZW5lcmF0ZVBhZ2UgPSB0cnVlOwogICAgIGlm IChPYmplY3Qua2V5cyhwYXJhbXMpLmxlbmd0aCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1 bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMu anMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19k YXNoYm9hcmRfdW5pdHRlc3RzLmpzCmluZGV4IDJkYTYzNDFiYjc4YWZhYmM2ZGJiNzgwZTFhOTgy ZGVlYTViMTRhOTYuLjliMTY4ZjI4NWNjMWEwMWFjZWY4MGU2Y2UwOTE4NTRlODQ5NjA2ZjUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2lu ZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcwpAQCAtNTk5 LDcgKzU5OSw2IEBAIHRlc3QoJ2RpZmZTdGF0ZXMnLCA1LCBmdW5jdGlvbigpIHsKIAogdGVzdCgn YWRkQnVpbGRlckxvYWRFcnJvcnMnLCAxLCBmdW5jdGlvbigpIHsKICAgICBjbGVhckVycm9ycygp OwotICAgIGdfaGFzRG9uZUluaXRpYWxQYWdlR2VuZXJhdGlvbiA9IGZhbHNlOwogICAgIGdfYnVp bGRlcnNUaGF0RmFpbGVkVG9Mb2FkID0gWydidWlsZGVyMScsICdidWlsZGVyMiddOwogICAgIGdf c3RhbGVCdWlsZGVycyA9IFsnc3RhbGVCdWlsZGVyMSddOwogICAgIGFkZEJ1aWxkZXJMb2FkRXJy b3JzKCk7Cg==