106239 2013-01-07 11:45:19 -0800 LayoutUnit(unsigned long long value) compile failure 2013-01-07 12:56:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson webkit-unassigned rniwa webkit-bug-importer oldest_to_newest 801491 0 eric.carlson 2013-01-07 11:45:19 -0800 The LayoutUnit constructor which takes an unsigned long long fails to compile on some platforms when SATURATED_LAYOUT_ARITHMETIC is not defined because storing the result of ('unsigned long long' * 'int') into an int loses precision: Source/WebCore/platform/LayoutUnit.h:89:25: error: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Werror,-Wshorten-64-to-32] m_value = value * kEffectiveFixedPointDenominator; ~ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 801492 1 webkit-bug-importer 2013-01-07 11:45:51 -0800 <rdar://problem/12967415> 801518 2 181541 eric.carlson 2013-01-07 12:00:45 -0800 Created attachment 181541 Proposed patch 801538 3 181541 eric.carlson 2013-01-07 12:15:10 -0800 Comment on attachment 181541 Proposed patch This is the wrong approach, new patch coming shortly. 801563 4 181546 eric.carlson 2013-01-07 12:46:10 -0800 Created attachment 181546 Updated patch 801573 5 eric.carlson 2013-01-07 12:55:44 -0800 Committed r138978: <http://trac.webkit.org/changeset/138978> 181541 2013-01-07 12:00:45 -0800 2013-01-07 12:15:09 -0800 Proposed patch layout_unit_compile_fail_patch.txt text/plain 1366 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODk3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTA3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFVuaXQodW5z aWduZWQgbG9uZyBsb25nIHZhbHVlKSBjb21waWxlIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjIzOQorCisgICAgICAgIENsYW1wIHRo ZSByZXN1bHQgb2YgKCd1bnNpZ25lZCBsb25nIGxvbmcnICogJ2ludCcpIHRvIGFuIGludCBiZWZv cmUgc3RvcmluZyBpbiBhbgorICAgICAgICBpbnQgdG8gYXZvaWQgY29tcGlsZSBmYWlsdXJlIG9u IHNvbWUgcGxhdGZvcm1zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vTGF5b3V0VW5pdC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0VW5pdDo6TGF5b3V0VW5pdCk6IENsYW1wIHRvIGludCBhZnRlciBtdWx0aXBsaWNhdGlvbi4K KwogMjAxMy0wMS0wNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEzNzYzMi4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9MYXlvdXRVbml0LmgJKHJldmlzaW9uIDEzODk2NykKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAkod29ya2luZyBjb3B5KQpAQCAtODYsNyArODYs NyBAQCBwdWJsaWM6CiAgICAgICAgIG1fdmFsdWUgPSBjbGFtcFRvPGludD4odmFsdWUgKiBrRWZm ZWN0aXZlRml4ZWRQb2ludERlbm9taW5hdG9yKTsKICNlbHNlCiAgICAgICAgIFJFUE9SVF9PVkVS RkxPVyhpc0luQm91bmRzKHN0YXRpY19jYXN0PHVuc2lnbmVkPih2YWx1ZSkpKTsKLSAgICAgICAg bV92YWx1ZSA9IHZhbHVlICoga0VmZmVjdGl2ZUZpeGVkUG9pbnREZW5vbWluYXRvcjsKKyAgICAg ICAgbV92YWx1ZSA9IGNsYW1wVG88aW50Pih2YWx1ZSAqIGtFZmZlY3RpdmVGaXhlZFBvaW50RGVu b21pbmF0b3IpOwogI2VuZGlmCiAgICAgfQogICAgIExheW91dFVuaXQoZmxvYXQgdmFsdWUpCg== 181546 2013-01-07 12:46:10 -0800 2013-01-07 12:56:43 -0800 Updated patch layout_unit_compile_fail_patch_2.txt text/plain 1384 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODk3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTA3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFVuaXQodW5z aWduZWQgbG9uZyBsb25nIHZhbHVlKSBjb21waWxlIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjIzOQorCisgICAgICAgIENhc3QgdGhl IHJlc3VsdCBvZiAoJ3Vuc2lnbmVkIGxvbmcgbG9uZycgKiAnaW50JykgdG8gYW4gaW50IGJlZm9y ZSBzdG9yaW5nIGluIG1fdmFsdWUKKyAgICAgICAgdG8gYXZvaWQgY29tcGlsZSBmYWlsdXJlIG9u IHNvbWUgcGxhdGZvcm1zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vTGF5b3V0VW5pdC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0VW5pdDo6TGF5b3V0VW5pdCk6IENhc3QgdG8gaW50IGFmdGVyIG11bHRpcGxpY2F0aW9uLgor CiAyMDEzLTAxLTA3ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAgICAgICAg Q2xlYXIgcGVuZGluZyBjb250YWluZXIgc2l6ZSByZXF1ZXN0cyBhcyBlYXJseSBhcyBwb3NzaWJs ZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAkocmV2aXNpb24gMTM4OTY3 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCSh3b3JraW5nIGNvcHkp CkBAIC04Niw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICAgICAgbV92YWx1ZSA9IGNsYW1wVG88aW50 Pih2YWx1ZSAqIGtFZmZlY3RpdmVGaXhlZFBvaW50RGVub21pbmF0b3IpOwogI2Vsc2UKICAgICAg ICAgUkVQT1JUX09WRVJGTE9XKGlzSW5Cb3VuZHMoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHZhbHVl KSkpOwotICAgICAgICBtX3ZhbHVlID0gdmFsdWUgKiBrRWZmZWN0aXZlRml4ZWRQb2ludERlbm9t aW5hdG9yOworICAgICAgICBtX3ZhbHVlID0gc3RhdGljX2Nhc3Q8aW50Pih2YWx1ZSAqIGtFZmZl Y3RpdmVGaXhlZFBvaW50RGVub21pbmF0b3IpOwogI2VuZGlmCiAgICAgfQogICAgIExheW91dFVu aXQoZmxvYXQgdmFsdWUpCg==