106233 2013-01-07 10:35:22 -0800 [BlackBerry] notifyAuthReceived interface changed 2013-01-07 12:50:19 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 801404 0 joenotcharles 2013-01-07 10:35:22 -0800 We have added a new AuthRetry result code to the FilterStream::notifyAuthReceived interface, so NetworkJob needs to be updated to implement the new interface. 801413 1 181526 joenotcharles 2013-01-07 10:38:19 -0800 Created attachment 181526 patch 801539 2 181526 rwlbuis 2013-01-07 12:15:46 -0800 Comment on attachment 181526 patch LGTM. 801566 3 181526 webkit.review.bot 2013-01-07 12:50:16 -0800 Comment on attachment 181526 patch Clearing flags on attachment: 181526 Committed r138977: <http://trac.webkit.org/changeset/138977> 801567 4 webkit.review.bot 2013-01-07 12:50:19 -0800 All reviewed patches have been landed. Closing bug. 181526 2013-01-07 10:38:19 -0800 2013-01-07 12:50:16 -0800 patch 0001-BlackBerry-Handle-the-new-AuthRetry-result-code-in-N.patch text/plain 5095 joenotcharles RnJvbSA4YjdiNDllODdiZThkYzg4MDNlZDVkMDkzYTNlYTBlN2E3ZWM1MWYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBNb24s IDcgSmFuIDIwMTMgMTM6MzQ6MjggLTA1MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g SGFuZGxlIHRoZSBuZXcgQXV0aFJldHJ5IHJlc3VsdCBjb2RlIGluCiBOZXR3b3JrSm9iOjpub3Rp ZnlBdXRoUmVjZWl2ZWQKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDYyMzMKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKSW50ZXJuYWwgUFI6IDI3MDY4MwpG aWx0ZXJTdHJlYW06Om5vdGlmeUF1dGhSZWNlaXZlZCBoYXMgYSBuZXcgcmVzdWx0IGNvZGUsIEF1 dGhSZXRyeS4gV2hlbiBpdCdzIHJlY2VpdmVkIHdlCm5lZWQgdG8gaGFuZGxlIGl0IGJ5IHJlc2Vu ZGluZyB0aGUgcmVxdWVzdCB3aXRoIHRoZSBzYW1lIGNyZWRlbnRpYWxzLgoKUmV2aWV3ZWQgaW50 ZXJuYWxseSBieSBMZW8gWWFuZy4KCiogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtKb2IuY3BwOgooV2ViQ29yZTo6TmV0d29ya0pvYjo6bm90aWZ5QXV0aFJlY2VpdmVkKToKKiBw bGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5oOgooTmV0d29ya0pvYik6Ci0t LQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDE4ICsrKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcCAgICAgfCAgIDE1ICsrKysrKysrKy0tLS0tLQogLi4uL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmggICAgICAgfCAgICAyICstCiAzIGZpbGVzIGNo YW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcx YTA1NWYuLjQxYTAyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wMS0wNyAg Sm9lIE1hc29uICA8am1hc29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEhhbmRs ZSB0aGUgbmV3IEF1dGhSZXRyeSByZXN1bHQgY29kZSBpbiBOZXR3b3JrSm9iOjpub3RpZnlBdXRo UmVjZWl2ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNjIzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEludGVybmFsIFBSOiAyNzA2ODMKKyAgICAgICAgRmlsdGVyU3RyZWFtOjpub3RpZnlBdXRoUmVj ZWl2ZWQgaGFzIGEgbmV3IHJlc3VsdCBjb2RlLCBBdXRoUmV0cnkuIFdoZW4gaXQncyByZWNlaXZl ZCB3ZQorICAgICAgICBuZWVkIHRvIGhhbmRsZSBpdCBieSByZXNlbmRpbmcgdGhlIHJlcXVlc3Qg d2l0aCB0aGUgc2FtZSBjcmVkZW50aWFscy4KKworICAgICAgICBSZXZpZXdlZCBpbnRlcm5hbGx5 IGJ5IExlbyBZYW5nLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6bm90aWZ5QXV0aFJl Y2VpdmVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5oOgorICAgICAgICAoTmV0d29ya0pvYik6CisKIDIwMTItMTEtMzAgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHBvdGVudGlhbCBjcmFzaCB3 aGVuIGNhbmNlbGluZyBhbmltYXRpb25zIG9uIHJlbmRlcmVycyB3aXRoIG5vIG5vZGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3 b3JrSm9iLmNwcAppbmRleCAxMTQxNTRlLi4wOTk5YTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBA IC0yNTIsNyArMjUyLDcgQEAgdm9pZCBOZXR3b3JrSm9iOjpub3RpZnlNdWx0aXBhcnRIZWFkZXJS ZWNlaXZlZChjb25zdCBjaGFyKiBrZXksIGNvbnN0IGNoYXIqIHZhbHUKICAgICAgICAgaGFuZGxl Tm90aWZ5TXVsdGlwYXJ0SGVhZGVyUmVjZWl2ZWQoa2V5LCB2YWx1ZSk7CiB9CiAKLXZvaWQgTmV0 d29ya0pvYjo6bm90aWZ5QXV0aFJlY2VpdmVkKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3Jr UmVxdWVzdDo6QXV0aFR5cGUgYXV0aFR5cGUsIGNvbnN0IGNoYXIqIHJlYWxtLCBib29sIHN1Y2Nl c3MsIGJvb2wgcmVxdWlyZUNyZWRlbnRpYWxzKQordm9pZCBOZXR3b3JrSm9iOjpub3RpZnlBdXRo UmVjZWl2ZWQoQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0OjpBdXRoVHlwZSBh dXRoVHlwZSwgY29uc3QgY2hhciogcmVhbG0sIEF1dGhSZXN1bHQgcmVzdWx0LCBib29sIHJlcXVp cmVDcmVkZW50aWFscykKIHsKICAgICB1c2luZyBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmV0d29y a1JlcXVlc3Q7CiAKQEAgLTI5Miw3ICsyOTIsMTIgQEAgdm9pZCBOZXR3b3JrSm9iOjpub3RpZnlB dXRoUmVjZWl2ZWQoQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0OjpBdXRoVHkK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChzdWNjZXNzKSB7CisgICAgLy8gT24g c3VjY2VzcywgdXBkYXRlIHN0b3JlZCBjcmVkZW50aWFscyBpZiBuZWNlc3NhcnkKKyAgICAvLyBP biBmYWlsdXJlLCBwdXJnZSBjcmVkZW50aWFscyBhbmQgc2VuZCBuZXcgcmVxdWVzdAorICAgIC8v IE9uIHJldHJ5LCB1cGRhdGUgc3RvcmVkIGNyZWRlbnRpYWxzIGlmIG5lY2Vzc2FyeSBhbmQgc2Vu ZCBuZXcgcmVxdWVzdAorICAgIGlmIChyZXN1bHQgPT0gQXV0aFJlc3VsdEZhaWx1cmUpCisgICAg ICAgIHB1cmdlQ3JlZGVudGlhbHMoKTsKKyAgICBlbHNlIHsKICAgICAgICAgLy8gVXBkYXRlIHRo ZSBjcmVkZW50aWFscyB0aGF0IHdpbGwgYmUgc3RvcmVkIHRvIG1hdGNoIHRoZSBzY2hlbWUgdGhh dCB3YXMgYWN0dWFsbHkgdXNlZAogICAgICAgICBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgY2hh bGxlbmdlID0gbV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fY3VycmVudFdlYkNoYWxsZW5nZTsK ICAgICAgICAgaWYgKCFjaGFsbGVuZ2UuaXNOdWxsKCkpIHsKQEAgLTMwNywxMSArMzEyLDkgQEAg dm9pZCBOZXR3b3JrSm9iOjpub3RpZnlBdXRoUmVjZWl2ZWQoQmxhY2tCZXJyeTo6UGxhdGZvcm06 Ok5ldHdvcmtSZXF1ZXN0OjpBdXRoVHkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAg ICBzdG9yZUNyZWRlbnRpYWxzKCk7Ci0gICAgICAgIHJldHVybjsKICAgICB9Ci0KLSAgICBwdXJn ZUNyZWRlbnRpYWxzKCk7Ci0gICAgbV9uZXdKb2JXaXRoQ3JlZGVudGlhbHNTdGFydGVkID0gc2Vu ZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoc2VydmVyVHlwZSwgc2NoZW1lLCByZWFsbSwgcmVxdWly ZUNyZWRlbnRpYWxzKTsKKyAgICBpZiAocmVzdWx0ICE9IEF1dGhSZXN1bHRTdWNjZXNzKQorICAg ICAgICBtX25ld0pvYldpdGhDcmVkZW50aWFsc1N0YXJ0ZWQgPSBzZW5kUmVxdWVzdFdpdGhDcmVk ZW50aWFscyhzZXJ2ZXJUeXBlLCBzY2hlbWUsIHJlYWxtLCByZXF1aXJlQ3JlZGVudGlhbHMpOwog fQogCiB2b2lkIE5ldHdvcmtKb2I6Om5vdGlmeVN0cmluZ0hlYWRlclJlY2VpdmVkKGNvbnN0IFN0 cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmgKaW5kZXggY2RhMDkx OC4uMTdiNGUyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5oCkBAIC03Myw3ICs3Myw3IEBAIHB1YmxpYzoKICAg ICB2b2lkIGhhbmRsZU5vdGlmeVN0YXR1c1JlY2VpdmVkKGludCBzdGF0dXMsIGNvbnN0IFN0cmlu ZyYgbWVzc2FnZSk7CiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUhlYWRlcnNSZWNlaXZlZChjb25z dCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmV0d29ya1JlcXVlc3Q6OkhlYWRlckxpc3QmIGhlYWRl cnMpOwogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlNdWx0aXBhcnRIZWFkZXJSZWNlaXZlZChjb25z dCBjaGFyKiBrZXksIGNvbnN0IGNoYXIqIHZhbHVlKTsKLSAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5 QXV0aFJlY2VpdmVkKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3JrUmVxdWVzdDo6QXV0aFR5 cGUsIGNvbnN0IGNoYXIqIHJlYWxtLCBib29sIHN1Y2Nlc3MsIGJvb2wgcmVxdWlyZUNyZWRlbnRp YWxzKTsKKyAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5QXV0aFJlY2VpdmVkKEJsYWNrQmVycnk6OlBs YXRmb3JtOjpOZXR3b3JrUmVxdWVzdDo6QXV0aFR5cGUsIGNvbnN0IGNoYXIqIHJlYWxtLCBBdXRo UmVzdWx0LCBib29sIHJlcXVpcmVDcmVkZW50aWFscyk7CiAgICAgLy8gbm90aWZ5U3RyaW5nSGVh ZGVyUmVjZWl2ZWQgZXhpc3RzIG9ubHkgdG8gcmVzb2x2ZSBhbWJpZ3VpdHkgYmV0d2VlbiBjaGFy KiBhbmQgU3RyaW5nIHBhcmFtZXRlcnMKICAgICB2b2lkIG5vdGlmeVN0cmluZ0hlYWRlclJlY2Vp dmVkKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKTsKICAgICB2b2lkIGhh bmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcm IHZhbHVlKTsKLS0gCjEuNy41LjQKCg==