106230 2013-01-07 10:15:53 -0800 media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536 2013-01-10 09:47:09 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 graouts vcarbune eric.carlson feature-media-reviews ojan.autocc silviapf silviapfeiffer1 vcarbune webkit-bug-importer webkit.review.bot oldest_to_newest 801376 0 graouts 2013-01-07 10:15:53 -0800 The test at media/video-controls-captions.html fails upon fixing the bug at https://bugs.webkit.org/show_bug.cgi?id=105536. Alas, this test appears to be Chrome-specific and I can't diagnose the issue from the bots output. 801378 1 webkit-bug-importer 2013-01-07 10:16:03 -0800 <rdar://problem/12966324> 801570 2 vcarbune 2013-01-07 12:52:11 -0800 I applied your patch from bug 105536 and the test is failing because with the patch applied the toggling the captions button has no effect anymore (e.g. a user can't disable track rendering). I didn't look yet in the code for the cause. 801660 3 eric.carlson 2013-01-07 14:22:11 -0800 (In reply to comment #2) > I applied your patch from bug 105536 and the test is failing because with the > patch applied the toggling the captions button has no effect anymore (e.g. a user > can't disable track rendering). I didn't look yet in the code for the cause. It fails because clicking the captions button in a port without a captions menu eventually ends up in HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured, which depends on the code removed from HTMLMediaElement::configureTextTrackGroup by bug 105536 to choose the most appropriate default track. 801667 4 silviapfeiffer1 2013-01-07 14:28:35 -0800 OK, I will work on introducing the caption menu for Chrome today. 804419 5 182151 vcarbune 2013-01-10 08:58:29 -0800 Created attachment 182151 Fix 804434 6 eric.carlson 2013-01-10 09:22:05 -0800 *** Bug 106433 has been marked as a duplicate of this bug. *** 804463 7 182151 webkit.review.bot 2013-01-10 09:47:05 -0800 Comment on attachment 182151 Fix Clearing flags on attachment: 182151 Committed r139326: <http://trac.webkit.org/changeset/139326> 804464 8 webkit.review.bot 2013-01-10 09:47:09 -0800 All reviewed patches have been landed. Closing bug. 182151 2013-01-10 08:58:29 -0800 2013-01-10 09:47:05 -0800 Fix bug-106230-20130110185532.patch text/plain 4661 vcarbune U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTM0NjEyYzFlY2U5MmFl ZGY2YmNkYTA1NTZhNTQ1YTA0NWU4ODdiYy4uOTFiMDJjNGMyM2UwZGI5ZDdjNGZhMjMxZThjM2Rj NjU3ZTFjZjc1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTEwICBWaWN0 b3IgQ2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgorCisgICAgICAgIG1lZGlhL3ZpZGVvLWNv bnRyb2xzLWNhcHRpb25zLmh0bWwgZmFpbHMgYWZ0ZXIgZml4aW5nIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1MzYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVudGlsIENocm9taXVtIGhhcyBwcm9wZXIgY29udHJvbHMg Zm9yIGxpc3RzIG9mIHRleHQgdHJhY2tzLCB0aGUgY2FwdGlvbiBidXR0b24KKyAgICAgICAgbmVl ZHMgdG8gcHJlc2VydmUgaXRzIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgVXBkYXRlZCBUZXN0 RXhwZWN0YXRpb25zIHRvIHJlYWN0aXZhdGUgdGVzdC4KKworICAgICAgICAqIGh0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZXRD bG9zZWRDYXB0aW9uc1Zpc2libGUpOiBBZGRlZCBleHBsaWNpdCBjYWxsIHRvIHVwZGF0ZVRleHRU cmFja0Rpc3BsYXkuCisgICAgICAgIFRoaXMgZW5hYmxlcyBoaWRpbmcgdGhlIHRyYWNrcyBpbW1l ZGlhdGVseS4KKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50 Ojp1cGRhdGVEaXNwbGF5KTogQWRkZWQgZXh0cmEgY2hlY2sgYmVmb3JlIHJlbmRlcmluZworICAg ICAgICB0aGF0IGNhcHRpb25zIHNob3VsZCBhY3R1YWxseSBiZSBkaXNwbGF5ZWQuCisKIDIwMTMt MDEtMTAgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IE5hdGl2ZSBNZW1vcnkgSW5zdHJ1bWVudGF0aW9uOiBmaXggaW5zdHJ1 bWVudGF0aW9uIGZvciBhbHJlYWR5IGluc3RydW1lbnRlZCBjbGFzc2VzIDIvTgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMDllMzEwMWE0YjFiNjJhYzg4OTJm Njg0YjVlNDBlZDUxZjNmMGMxNS4uN2FjYTc5ZDNhNGExYTcxMmIyYTQ4NDFmYzBkN2FiZjc2YTQ1 ZjViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC00MTM2 LDYgKzQxMzYsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldENsb3NlZENhcHRpb25zVmlz aWJsZShib29sIGNsb3NlZENhcHRpb25WaXNpYmxlKQogICAgICAgICBtX2Rpc2FibGVDYXB0aW9u cyA9ICFtX2Nsb3NlZENhcHRpb25zVmlzaWJsZTsKIAogICAgICAgICBtYXJrQ2FwdGlvbkFuZFN1 YnRpdGxlVHJhY2tzQXNVbmNvbmZpZ3VyZWQoKTsKKyAgICAgICAgbWVkaWFDb250cm9scygpLT51 cGRhdGVUZXh0VHJhY2tEaXNwbGF5KCk7CiAgICAgfQogI2Vsc2UKICAgICBpZiAoaGFzTWVkaWFD b250cm9scygpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFD b250cm9sRWxlbWVudHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250 cm9sRWxlbWVudHMuY3BwCmluZGV4IDJlZmMwN2E3ZGU5ZDY2NWY4NGRlNjgxZjZiNTY1MDcxZWQ3 YTIxZDkuLjI5MzQ0OTY1ZDZhODdjMzcxMTE5NmY3ZTJjZWMxZTgyMDNkZjFiNDggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAK QEAgLTEyNDcsMTIgKzEyNDcsMTYgQEAgY29uc3QgQXRvbWljU3RyaW5nJiBNZWRpYUNvbnRyb2xU ZXh0VHJhY2tDb250YWluZXJFbGVtZW50OjpzaGFkb3dQc2V1ZG9JZCgpIGNvbnMKIAogdm9pZCBN ZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVEaXNwbGF5KCkKIHsK LSAgICBIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQgPSB0b1BhcmVudE1lZGlhRWxlbWVu dCh0aGlzKTsKKyAgICBpZiAoIW1lZGlhQ29udHJvbGxlcigpLT5jbG9zZWRDYXB0aW9uc1Zpc2li bGUoKSkgeworICAgICAgICBtX2N1ZUNvbnRhaW5lci0+cmVtb3ZlQ2hpbGRyZW4oKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KIAorICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCA9 IHRvUGFyZW50TWVkaWFFbGVtZW50KHRoaXMpOwogICAgIC8vIDEuIElmIHRoZSBtZWRpYSBlbGVt ZW50IGlzIGFuIGF1ZGlvIGVsZW1lbnQsIG9yIGlzIGFub3RoZXIgcGxheWJhY2sKICAgICAvLyBt ZWNoYW5pc20gd2l0aCBubyByZW5kZXJpbmcgYXJlYSwgYWJvcnQgdGhlc2Ugc3RlcHMuIFRoZXJl IGlzIG5vdGhpbmcgdG8KICAgICAvLyByZW5kZXIuCi0gICAgaWYgKCFtZWRpYUVsZW1lbnQtPmlz VmlkZW8oKSkKKyAgICBpZiAoIW1lZGlhRWxlbWVudCB8fCAhbWVkaWFFbGVtZW50LT5pc1ZpZGVv KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIDIuIExldCB2aWRlbyBiZSB0aGUgbWVkaWEg ZWxlbWVudCBvciBvdGhlciBwbGF5YmFjayBtZWNoYW5pc20uCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2VhZjUwNWVjNDRh NzU3M2E4ZDdjOTdlMTY3MzQzYmQ2YWU0ZWE4MS4uNTAxYjkyNWM3YWFmM2Q3MThlNzE1OWMwMzUx NmQxYjNlM2RhNTY1YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTEwICBWaWN0b3Ig Q2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgorCisgICAgICAgIG1lZGlhL3ZpZGVvLWNvbnRy b2xzLWNhcHRpb25zLmh0bWwgZmFpbHMgYWZ0ZXIgZml4aW5nIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1MzYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNjIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczog UmVhY3RpdmF0ZWQgdGVzdC4KKwogMjAxMy0wMS0xMCAgTm9lbCBHb3Jkb24gIDxub2VsLmdvcmRv bkBnbWFpbC5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBGaXggaWV0ZXN0Y2VudGVyL2NzczMv Ym9yZGVyc2JhY2tncm91bmRzL2JvcmRlci1yYWRpdXMtY2xpcC0wMDIuaHRtIGV4cGVjdGF0aW9u IGxpbmVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9u cwppbmRleCAyZGI4YjA4MGYyZGYzMmZlMDk1NzJjNTBhYTJiY2MxYjNjNmU3OWYzLi5hNmYxY2Ri NDE1ZjU5MGQ4MWVhMzU0NTc5ZTJkYmI0NTQ0MDNmOTU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMwODYsOSArMzA4Niw2IEBAIHdl YmtpdC5vcmcvYi8xMDM5MjYgbWVkaWEvdHJhY2svb3BlcmEvdHJhY2svd2VidnR0L3BhcnNpbmct Y3VlLWRhdGEvdGVzdHMvdHJlZS1iCiB3ZWJraXQub3JnL2IvMTAzOTI2IG1lZGlhL3RyYWNrL29w ZXJhL3RyYWNrL3dlYnZ0dC9yZW5kZXJpbmcvYWRob2MvY3VlX2ZvbnRfc2l6ZV90cmFuc2l0aW9u Lmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMDM5MjYgbWVkaWEvdHJhY2svb3BlcmEvdHJh Y2svd2VidnR0L3JlbmRlcmluZy9hZGhvYy92b2ljZV93aXRoX2V2aWxfdGltZXN0YW1wLmh0bWwg WyBTa2lwIF0KIAotIyBTdGFydGVkIGZhaWxpbmcgdXBvbiBmaXhpbmcgd2Via2l0Lm9yZy9iLzEw NTUzNgotd2Via2l0Lm9yZy9iLzEwNjIzMCBtZWRpYS92aWRlby1jb250cm9scy1jYXB0aW9ucy5o dG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi83MjI3MSBbIFNub3dMZW9wYXJkIERlYnVn IF0gZmFzdC9kb20vbm9kZS1pdGVyYXRvci1yZWZlcmVuY2Utbm9kZS1tb3ZlZC1jcmFzaC5odG1s IFsgQ3Jhc2ggUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi83MjM3NiBbIFdpbiBdIGZhc3QvZm9ybXMv ZmlsZS9pbnB1dC1maWxlLWxhYmVsLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQo=