106217 2013-01-07 06:59:32 -0800 [Qt] Webkit debug builds links against release binaries of ANGLE libEGL, libGLESv2 2013-01-24 04:21:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P1 Normal --- 0 kai.koehne webkit-unassigned hausmann jturcotte michael.bruning net147 webkit.review.bot oldest_to_newest 801270 0 kai.koehne 2013-01-07 06:59:32 -0800 When angle is compiled in QtBase both debug and release versions of libEGL[d], libGLESv2[d] are created. However, webkit always links against the release versions, even for the debug build. 801272 1 181503 kai.koehne 2013-01-07 07:05:05 -0800 Created attachment 181503 Patch fixing debug only compilation 814010 2 kai.koehne 2013-01-23 01:54:15 -0800 WIthout this patch all 'pure debug' builds of Qt on windows will fail to link. Can we please get this reviewed? 814020 3 kai.koehne 2013-01-23 02:04:59 -0800 ... and preferably merged into the 'release' branch :) 815147 4 kai.koehne 2013-01-23 23:45:40 -0800 This reportedly fixes crashes too: Even if linking succeeds due to release dlls being available, we'll load both debug and release libs of the libEGL, libGLESv2 into memory at runtime. 815289 5 181503 jturcotte 2013-01-24 03:11:39 -0800 Comment on attachment 181503 Patch fixing debug only compilation Arf, I saw that bug before but I assumed that the bug was in Qt... Thanks for the fix, I'll pick it in the 5.0.x branch once it landed. 815293 6 181503 webkit.review.bot 2013-01-24 03:22:24 -0800 Comment on attachment 181503 Patch fixing debug only compilation Rejecting attachment 181503 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 181503, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patch: **** Can't create file /tmp/pp8rM352 : No space left on device patch: **** Can't create file /tmp/ppPs7OY3 : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16079646 815320 7 michael.bruning 2013-01-24 04:21:28 -0800 Committed r140675: <http://trac.webkit.org/changeset/140675> 181503 2013-01-07 07:05:05 -0800 2013-01-24 04:21:59 -0800 Patch fixing debug only compilation anglefix.patch text/plain 1464 kai.koehne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YjNkNzBiLi5mYzYwZjRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMDEtMDcgIEthaSBLb2VobmUgIDxrYWkua29laG5lQGRpZ2lhLmNvbT4KKworICAg ICAgICBbUXRdIFdlYmtpdCBkZWJ1ZyBidWlsZCBsaW5rcyBhZ2FpbnN0IHJlbGVhc2UgYmluYXJp ZXMgb2YgQU5HTEUgbGliRUdMLCBsaWJHTEVTdjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBsaWJFR0xkLCBsaWJFR0xTdjJkIGlmIHF0YmFzZSB3 YXMgY29tcGlsZWQgd2l0aCBBTkdMRS4KKworICAgICAgICAqIFdlYkNvcmUucHJpOiBNaXJyb3Ig bG9naWMgb2YgcXRiYXNlXG1rc3BlY3NcZmVhdHVyZXNcd2luMzJcb3BlbmdsLnByZgorCiAyMDEy LTEyLTE5ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4sIEplZHJ6 ZWogTm93YWNraSA8amVkcnplai5ub3dhY2tpQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIEpT IGJyaWRnZSBkb2VzIG5vdCB0cmFuc21pdCBRVmFyaWFudHMgYW55bW9yZSBpbiBRdDUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5wcmkKaW5kZXggNjYwOGZhYS4uNmM4MzEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKQEAgLTIxMyw3ICsy MTMsMTEgQEAgdXNlPygzRF9HUkFQSElDUykgewogICAgICAgICB3aW4zMi1nKys6IHsKICAgICAg ICAgICAgICMgTWFrZSBzdXJlIE9wZW5HTCBsaWJzIGFyZSBhZnRlciB0aGUgd2ViY29yZSBsaWIg c28gTWluR1cgY2FuIHJlc29sdmUgc3ltYm9scwogICAgICAgICAgICAgY29udGFpbnMoUVRfQ09O RklHLCBvcGVuZ2xlczIpIHsKLSAgICAgICAgICAgICAgICBMSUJTICs9ICQkUU1BS0VfTElCU19P UEVOR0xfRVMyCisgICAgICAgICAgICAgICAgQ09ORklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKTpj b250YWlucyhRVF9DT05GSUcsIGFuZ2xlKSB7CisgICAgICAgICAgICAgICAgICAgIExJQlMgKz0g JCRRTUFLRV9MSUJTX09QRU5HTF9FUzJfREVCVUcKKyAgICAgICAgICAgICAgICB9IGVsc2Ugewor ICAgICAgICAgICAgICAgICAgICBMSUJTICs9ICQkUU1BS0VfTElCU19PUEVOR0xfRVMyCisgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBMSUJT ICs9ICQkUU1BS0VfTElCU19PUEVOR0wKICAgICAgICAgICAgIH0K