106206 2013-01-06 20:12:19 -0800 CachedResource::switchClientsToRevalidatedResource() fails to properly remove clients 2013-01-07 10:33:42 -0800 1 1 1 Unclassified WebKit SVG 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr abarth ap beidson japhet koivisto webkit.review.bot zimmermann oldest_to_newest 801139 0 pdr 2013-01-06 20:12:19 -0800 CachedResource::switchClientsToRevalidatedResource() contains the following: 710 // Equivalent of calling removeClient() for all clients 711 m_clients.clear(); http://trac.webkit.org/browser/trunk/Source/WebCore/loader/cache/CachedResource.cpp?rev=138921#L710 This comment is a lie; m_clients.clear() fails to call didRemoveClient(...) for each client which can lead to clients leaving state around (e.g., CachedImage does cleanup in didRemoveClient(...)). 801142 1 181470 pdr 2013-01-06 20:46:51 -0800 Created attachment 181470 First pass 801371 2 181470 japhet 2013-01-07 10:12:41 -0800 Comment on attachment 181470 First pass To be fair, the comment was true when this code was written :) 801377 3 181470 pdr 2013-01-07 10:15:55 -0800 Comment on attachment 181470 First pass Thanks for the review! 801399 4 181470 webkit.review.bot 2013-01-07 10:33:37 -0800 Comment on attachment 181470 First pass Clearing flags on attachment: 181470 Committed r138958: <http://trac.webkit.org/changeset/138958> 801401 5 webkit.review.bot 2013-01-07 10:33:42 -0800 All reviewed patches have been landed. Closing bug. 181470 2013-01-06 20:46:51 -0800 2013-01-07 10:33:37 -0800 First pass 106206.1.patch text/plain 1963 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTA2ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVmYWN0b3IgY2xpZW50IHJlbW92 YWwgaW4gQ2FjaGVkUmVzb3VyY2U6OnN3aXRjaENsaWVudHNUb1JldmFsaWRhdGVkUmVzb3VyY2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjIwNgor CisgICAgICAgIFByZXZpb3VzbHkgc3dpdGNoQ2xpZW50c1RvUmV2YWxpZGF0ZWRSZXNvdXJjZSgp IGZhaWxlZCB0byBjYWxsIGRpZFJlbW92ZUNsaWVudCgpIGZvciBlYWNoCisgICAgICAgIGNsaWVu dCBhbmQgaW5zdGVhZCBzaW1wbHkgY2xlYXJlZCBtX2NsaWVudHMuIFRoaXMgcGF0Y2ggcmVtb3Zl cyBhbiBpbmNvcnJlY3QgY29tbWVudCBhbmQKKyAgICAgICAgcmVmYWN0b3JzIHRoZSBjb2RlIHNv IHRoYXQgcmVtb3ZlQ2xpZW50KCkgYW5kIGRpZFJlbW92ZUNsaWVudCgpIGFyZSBwcm9wZXJseSBj YWxsZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGFzIHRoZXJlIGFyZSBubyBvYnNlcnZhYmxlIGNoYW5nZXMgZnJvbSB0aGlz IHJlZmFjdG9yaW5nLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjpzd2l0Y2hDbGllbnRzVG9SZXZh bGlkYXRlZFJlc291cmNlKToKKwogMjAxMy0wMS0wNiAgU2ViYXN0aWFuIERyw7ZnZSAgPHNlYmFz dGlhbi5kcm9lZ2VAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIEJ1Z8KgMTA2MTc3IC0gW0dT dHJlYW1lcl0gRG9uJ3QgY2FsbCBnc3RfdmlkZW9faW5mb19mcm9tX2NhcHMoKSB3aXRoIG5vbi1m aXhlZCBjYXBzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRS ZXNvdXJjZS5jcHAJKHJldmlzaW9uIDEzODY3MykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwNywxMSArNzA3LDEz IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6OnN3aXRjaENsaWVudHNUb1JldmEKICAgICAgICAgICAg IC0tY291bnQ7CiAgICAgICAgIH0KICAgICB9Ci0gICAgLy8gRXF1aXZhbGVudCBvZiBjYWxsaW5n IHJlbW92ZUNsaWVudCgpIGZvciBhbGwgY2xpZW50cwotICAgIG1fY2xpZW50cy5jbGVhcigpOwog CiAgICAgdW5zaWduZWQgbW92ZUNvdW50ID0gY2xpZW50c1RvTW92ZS5zaXplKCk7CiAgICAgZm9y ICh1bnNpZ25lZCBuID0gMDsgbiA8IG1vdmVDb3VudDsgKytuKQorICAgICAgICByZW1vdmVDbGll bnQoY2xpZW50c1RvTW92ZVtuXSk7CisgICAgQVNTRVJUKG1fY2xpZW50cy5pc0VtcHR5KCkpOwor CisgICAgZm9yICh1bnNpZ25lZCBuID0gMDsgbiA8IG1vdmVDb3VudDsgKytuKQogICAgICAgICBt X3Jlc291cmNlVG9SZXZhbGlkYXRlLT5hZGRDbGllbnRUb1NldChjbGllbnRzVG9Nb3ZlW25dKTsK ICAgICBmb3IgKHVuc2lnbmVkIG4gPSAwOyBuIDwgbW92ZUNvdW50OyArK24pIHsKICAgICAgICAg Ly8gQ2FsbGluZyBkaWRBZGRDbGllbnQgbWF5IGRvIGFueXRoaW5nLCBpbmNsdWRpbmcgdHJ5aW5n IHRvIGNhbmNlbCByZXZhbGlkYXRpb24uCg==