106199 2013-01-06 15:04:38 -0800 [Track] Rendering crash 2013-01-07 11:22:31 -0800 1 1 1 Unclassified WebKit Media 525.x (Safari 3.2) All All RESOLVED FIXED P2 Normal --- 1 vcarbune vcarbune eric.carlson feature-media-reviews ojan.autocc silviapf webkit.review.bot oldest_to_newest 801104 0 vcarbune 2013-01-06 15:04:38 -0800 I'm currently still looking at what recent changes might have generated this assertion fail (basically the first child is not necessarily inline rendered). #0 0x00007f81c0dde895 in WebCore::toRenderInline (object=0x7f81ac5c5eb8) at ../../third_party/WebKit/Source/WebCore/rendering/RenderInline.h:191 #1 0x00007f81c101ef63 in WebCore::RenderTextTrackCue::initializeLayoutParameters (this=0x7f81aca7ee18, firstLineBox=@0x7fff6049e4e0, step=..., position=...) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:60 #2 0x00007f81c101edce in WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:203 #3 0x00007f81c101ed5f in WebCore::RenderTextTrackCue::layout (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:49 #4 0x00007f81c0dbf156 in WebCore::RenderObject::layoutIfNeeded (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderObject.h:675 #5 0x00007f81c0e02c11 in WebCore::RenderBlock::layoutPositionedObjects (this=0x7f81ac2b6698, relayoutChildren=true) at ../../third_party/WebKit/Source/WebCore/rendering/RenderBlock.cpp:2646 #6 0x00007f81c0e002ea in WebCore::RenderBlock::layoutBlock (this=0x7f81ac2b6698, relayoutChildren=true, pageLogicalHeight=...) [...] 801105 1 181466 vcarbune 2013-01-06 15:05:48 -0800 Created attachment 181466 Track added through JS 801369 2 181518 vcarbune 2013-01-07 10:11:40 -0800 Created attachment 181518 Patch 801440 3 181518 eric.carlson 2013-01-07 10:55:14 -0800 Comment on attachment 181518 Patch Thanks! 801466 4 181518 webkit.review.bot 2013-01-07 11:22:28 -0800 Comment on attachment 181518 Patch Clearing flags on attachment: 181518 Committed r138966: <http://trac.webkit.org/changeset/138966> 801467 5 webkit.review.bot 2013-01-07 11:22:31 -0800 All reviewed patches have been landed. Closing bug. 181466 2013-01-06 15:05:48 -0800 2013-01-06 15:05:48 -0800 Track added through JS test3.html text/html 363 vcarbune PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBhZGRUcmFjaygpIHsKdmFyIHYgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgndicpOwp2YXIgdCA9IHYuYWRkVGV4dFRyYWNrKCdjYXB0aW9u cycsICdFbmdsaXNoJywgJ2VuJyk7CnQuYWRkQ3VlKG5ldyBUZXh0VHJhY2tDdWUoMC4wLCAxMC4w LCAnd293IHdvdycpKTsKdC5tb2RlID0gInNob3dpbmciOwp9Cjwvc2NyaXB0Pgo8L2hlYWQ+Cjxi b2R5IG9ubG9hZD0iYWRkVHJhY2soKSI+Cjx2aWRlbyBpZD0idiIgYXV0b3BsYXkgY29udHJvbHM9 ImNvbnRyb2xzIiB2YWxpZ249InRvcCIgc3JjPSIuLi9jaG9jb2xhdGVfcmFpbi53ZWJtIj48L3Zp ZGVvPgo8L2JvZHk+CjwvaHRtbD4K 181518 2013-01-07 10:11:40 -0800 2013-01-07 11:22:27 -0800 Patch bug-106199-20130107200844.patch text/plain 5651 vcarbune U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVlMzU0M2Q5ZWM1Mzcz YTg5NjY0NGJkNDE4YTNmMGQ3Nzk3ZTlhNS4uMjYzNmJkZmZhZTQyNThiYWEzY2M2YTY4YjVkNjBm NmM1NWJkZDg5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTA3ICBWaWN0 b3IgQ2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgorCisgICAgICAgIFtUcmFja10gUmVuZGVy aW5nIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDYxOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgYnJvd3NlciBpcyBjcmFzaGluZyBpZiBhIHRleHQgdHJhY2sgaXMgYWRkZWQgdGhyb3Vn aCBKYXZhU2NyaXB0LAorICAgICAgICBkdWUgdG8gdGhlIGZhY3QgdGhhdCB0aGUgY29udGFpbmlu ZyBibG9jayBpcyBub3QgbWFya2VkIGFzIGlubGluZSBhdAorICAgICAgICB0aGUgdGltZSBSZW5k ZXJUZXh0VHJhY2tDdWU6OmxheW91dCgpIGlzIGNhbGxlZC4gVGhlIGZpeCBjb25zaXN0cworICAg ICAgICBvZiBlbnN1cmluZyB0aGF0IHRoZSBwc2V1ZG8gaWQgaXMgc2V0LCBldmVuIGlmIHRoZSB0 cmFjayBpc24ndAorICAgICAgICB5ZXQgdmlzaWJsZS4KKworICAgICAgICBUZXN0OiBtZWRpYS90 cmFjay90cmFjay1jdWUtaW5saW5lLWFzc2VydGlvbi1jcmFzaC5odG1sCisKKyAgICAgICAgKiBo dG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0VHJhY2tD dWU6OnVwZGF0ZURpc3BsYXlUcmVlKTogVGhlIHBzZXVkby1pZCBzaG91bGQKKyAgICAgICAgYmUg c2V0IHdoZW4gdGhlIGRpc3BsYXkgdHJlZSBpcyBnZW5lcmF0ZWQuCisgICAgICAgIChXZWJDb3Jl OjpUZXh0VHJhY2tDdWU6OmdldERpc3BsYXlUcmVlKTogQWRkZWQgZXh0cmEgY2hlY2sgdG8gbm90 CisgICAgICAgIGRvIHVubmVjY2Vzc2FyeSBsb2dpYyBpZiB0aGUgdHJhY2sgd2lsbCBuZXZlciBi ZSBkaXNwbGF5ZWQuCisKIDIwMTMtMDEtMDcgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgog CiAgICAgICAgIE1pc3NpbmcgYW1lbmRtZW50cyB0byByMTM4OTI3LiBBbWVuZCBDaGFuZ2Vsb2cg dG8gcmVtb3ZlIGl0ZW0gYWJvdXQgVGltZXIuaCwgd2hpY2ggd2FzIG5vdCBjaGFuZ2VkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuY3BwCmluZGV4IDMyYjRmNGY3NWU5 MDAwMmMzMThlYmU0MWE2OWRkOGE4YjVhZTk4ZDYuLmE1YzhmMDA3N2Y3NzgyYTU3MDkwZDUxMjYy NmZmODJmOGUyNzk4MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4 dFRyYWNrQ3VlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0N1 ZS5jcHAKQEAgLTY5NSwxMCArNjk1LDggQEAgdm9pZCBUZXh0VHJhY2tDdWU6OnVwZGF0ZURpc3Bs YXlUcmVlKGZsb2F0IG1vdmllVGltZSkKICAgICBpZiAoIXRyYWNrKCktPmlzUmVuZGVyZWQoKSkK ICAgICAgIHJldHVybjsKIAotCiAgICAgLy8gQ2xlYXIgdGhlIGNvbnRlbnRzIG9mIHRoZSBzZXQu CiAgICAgbV9hbGxEb2N1bWVudE5vZGVzLT5yZW1vdmVDaGlsZHJlbigpOwotICAgIG1fYWxsRG9j dW1lbnROb2Rlcy0+c2V0UHNldWRvKGFsbE5vZGVzU2hhZG93UHNldWRvSWQoKSk7CiAKICAgICAv LyBVcGRhdGUgdGhlIHR3byBzZXRzIGNvbnRhaW5pbmcgcGFzdCBhbmQgZnV0dXJlIFdlYlZUVCBv YmplY3RzLgogICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiByZWZlcmVuY2VUcmVlID0gZ2V0 Q3VlQXNIVE1MKCk7CkBAIC03MDksNyArNzA3LDcgQEAgdm9pZCBUZXh0VHJhY2tDdWU6OnVwZGF0 ZURpc3BsYXlUcmVlKGZsb2F0IG1vdmllVGltZSkKIAogUGFzc1JlZlB0cjxUZXh0VHJhY2tDdWVC b3g+IFRleHRUcmFja0N1ZTo6Z2V0RGlzcGxheVRyZWUoKQogewotICAgIGlmICghbV9kaXNwbGF5 VHJlZVNob3VsZENoYW5nZSkKKyAgICBpZiAoIW1fZGlzcGxheVRyZWVTaG91bGRDaGFuZ2UgfHwg IXRyYWNrKCktPmlzUmVuZGVyZWQoKSkKICAgICAgICAgcmV0dXJuIG1fZGlzcGxheVRyZWU7CiAK ICAgICAvLyAxMC4xIC0gMTAuMTAKQEAgLTcyNyw2ICs3MjUsNyBAQCBQYXNzUmVmUHRyPFRleHRU cmFja0N1ZUJveD4gVGV4dFRyYWNrQ3VlOjpnZXREaXNwbGF5VHJlZSgpCiAgICAgLy8gYmFja2dy b3VuZCBib3guCiAKICAgICAvLyBOb3RlOiBUaGlzIGlzIGNvbnRhaW5lZCBieSBkZWZhdWx0IGlu IG1fYWxsRG9jdW1lbnROb2Rlcy4KKyAgICBtX2FsbERvY3VtZW50Tm9kZXMtPnNldFBzZXVkbyhh bGxOb2Rlc1NoYWRvd1BzZXVkb0lkKCkpOwogICAgIG1fZGlzcGxheVRyZWUtPmFwcGVuZENoaWxk KG1fYWxsRG9jdW1lbnROb2RlcywgQVNTRVJUX05PX0VYQ0VQVElPTiwgdHJ1ZSk7CiAKICAgICAv LyBGSVhNRShCVUcgNzk5MTYpOiBSdW5zIG9mIGNoaWxkcmVuIG9mIFdlYlZUVCBSdWJ5IE9iamVj dHMgdGhhdCBhcmUgbm90CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGIyZjVhNDAxZmEzYmM5YmI2MjUxOWFjNDA2OTUxY2M1 NDA0ODQxZS4uNzRiZWYyMDJlNDYwNTIyMTE5ZjZkMjk3NjE2NjQ0NGExMzlmMWZjYyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTA3ICBWaWN0b3IgQ2FyYnVuZSAgPHZpY3RvckByb3Nl ZHUub3JnPgorCisgICAgICAgIFtUcmFja10gUmVuZGVyaW5nIGNyYXNoCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYxOTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLWN1 ZS1pbmxpbmUtYXNzZXJ0aW9uLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog bWVkaWEvdHJhY2svdHJhY2stY3VlLWlubGluZS1hc3NlcnRpb24tY3Jhc2guaHRtbDogQWRkZWQu CisKIDIwMTMtMDEtMDYgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBIZWFwLXVzZS1hZnRlci1mcmVlIGluIERvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGlu ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLWlubGluZS1h c3NlcnRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJh Y2stY3VlLWlubGluZS1hc3NlcnRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhi ZDViNDkzNTk1YzQ1ZDQyMTYzNDcwZjgyNzkwYzNjMzc5YjRkMWIKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtaW5saW5lLWFzc2VydGlvbi1jcmFz aC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAorVGVzdHMgdGhhdCBhZGRpbmcgYSB0cmFj ayBhbmQgY2hhbmdpbmcgaXRzIG1vZGUgdGhyb3VnaCBKUyBkb2Vzbid0IGNyYXNoIHRoZSBicm93 c2VyLgorCisqKiBBZGQgYSB0ZXh0IHRyYWNrIHRocm91Z2ggSlMgdG8gdGhlIHZpZGVvIGVsZW1l bnQgKioKKyoqIEFkZCBjdWUgdG8gdGhlIHRleHQgdHJhY2sgKioKKyoqIFNldCB0aGUgdHJhY2sg bW9kZSB0byBzaG93aW5nICoqCisKK05vIGNyYXNoLiBQQVNTLgorCitFTkQgT0YgVEVTVAorCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtaW5saW5lLWFzc2Vy dGlvbi1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLWlubGlu ZS1hc3NlcnRpb24tY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZTk0YTY3ZDI1OTBjNTAzMWY3YWE2 YTM5MzZhM2MyM2NhZDE5ZGM2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svdHJhY2stY3VlLWlubGluZS1hc3NlcnRpb24tY3Jhc2guaHRtbApAQCAtMCwwICsxLDQw IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8bWV0YSBo dHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYt OCIgLz4KKworICAgICAgICA8c2NyaXB0IHNyYz0uLi9tZWRpYS1maWxlLmpzPjwvc2NyaXB0Pgor ICAgICAgICA8c2NyaXB0IHNyYz0uLi92aWRlby10ZXN0LmpzPjwvc2NyaXB0PgorCisgICAgICAg IDxzY3JpcHQ+CisgICAgICAgIGZ1bmN0aW9uIHN0YXJ0VGVzdCgpCisgICAgICAgIHsKKyAgICAg ICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKworICAgICAgICAgICAgY29uc29sZVdyaXRlKCIq KiBBZGQgYSB0ZXh0IHRyYWNrIHRocm91Z2ggSlMgdG8gdGhlIHZpZGVvIGVsZW1lbnQgKioiKTsK KyAgICAgICAgICAgIHZhciB0ID0gdmlkZW8uYWRkVGV4dFRyYWNrKCdjYXB0aW9ucycsICdFbmds aXNoJywgJ2VuJyk7CisKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiKiogQWRkIGN1ZSB0byB0 aGUgdGV4dCB0cmFjayAqKiIpOworICAgICAgICAgICAgdC5hZGRDdWUobmV3IFRleHRUcmFja0N1 ZSgwLjAsIDEwLjAsICd3b3cgd293JykpOworCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIioq IFNldCB0aGUgdHJhY2sgbW9kZSB0byBzaG93aW5nICoqIik7CisgICAgICAgICAgICB0Lm1vZGUg PSAic2hvd2luZyI7CisKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAg ICBjb25zb2xlV3JpdGUoIk5vIGNyYXNoLiBQQVNTLiIpOworICAgICAgICAgICAgY29uc29sZVdy aXRlKCIiKTsKKworICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICB9CisgICAgICAgIDwv c2NyaXB0PgorICAgIDwvaGVhZD4KKworICAgIDxib2R5IG9ubG9hZD0ic3RhcnRUZXN0KCkiPgor ICAgICAgICA8cD5UZXN0cyB0aGF0IGFkZGluZyBhIHRyYWNrIGFuZCBjaGFuZ2luZyBpdHMgbW9k ZSB0aHJvdWdoIEpTIGRvZXNuJ3QgY3Jhc2ggdGhlIGJyb3dzZXIuPC9wPgorICAgICAgICA8dmlk ZW8gY29udHJvbHM+CisgICAgICAgICAgICA8IS0tIElmIHRoZSBzcmMgaXMgc3BlY2lmaWVkIHRo cm91Z2ggSlMgYWZ0ZXIgdGhlIGJvZHkgbG9hZCwgdGhlIHRlc3QgZG9lc24ndCBjcmFzaCBhbnlt b3JlLiAtLT4KKyAgICAgICAgICAgIDxzb3VyY2Ugc3JjPSIuLi9jb250ZW50L3Rlc3QubXA0IiB0 eXBlPSJ2aWRlby9tcDQiPgorICAgICAgICAgICAgPHNvdXJjZSBzcmM9Ii4uL2NvbnRlbnQvdGVz dC5vZ3YiIHR5cGU9InZpZGVvL29nZyI+CisgICAgICAgIDwvdmlkZW8+CisgICAgPC9ib2R5Pgor PC9odG1sPgo=