106177 2013-01-05 07:22:59 -0800 [GStreamer] Don't call gst_video_info_from_caps() with non-fixed caps 2013-01-06 12:27:47 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 slomo webkit-unassigned gustavo menard mrobinson pnormand slomo webkit.review.bot oldest_to_newest 800915 0 181437 slomo 2013-01-05 07:22:59 -0800 Created attachment 181437 Don't call gst_video_info_from_caps() with non-fixed caps See summary and patch, doing so will cause an assertion. 800927 1 mrobinson 2013-01-05 09:30:47 -0800 Hi! Do you mind also generating a ChangeLog with Tools/Scripts/prepare-Changelog. If you upload your patch with Tools/Script/webkit-patch it will do this automatically. 801069 2 181457 slomo 2013-01-06 05:25:17 -0800 Created attachment 181457 Don't call gst_video_info_from_caps() with non-fixed caps 801087 3 181457 webkit.review.bot 2013-01-06 12:27:43 -0800 Comment on attachment 181457 Don't call gst_video_info_from_caps() with non-fixed caps Clearing flags on attachment: 181457 Committed r138919: <http://trac.webkit.org/changeset/138919> 801088 4 webkit.review.bot 2013-01-06 12:27:47 -0800 All reviewed patches have been landed. Closing bug. 181437 2013-01-05 07:22:59 -0800 2013-01-06 05:25:17 -0800 Don't call gst_video_info_from_caps() with non-fixed caps 0004-Don-t-call-gst_video_info_from_caps-for-non-fixed-ca.patch text/plain 1083 slomo RnJvbSA0ZGVlMGM0ZWMwMWRjMDA1OWZiYjhjNzE3MTcyNTcwNzJmNmY0OTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogU2F0LCA1IEphbiAyMDEzIDE2 OjA3OjI0ICswMTAwClN1YmplY3Q6IFtQQVRDSCA0LzVdIERvbid0IGNhbGwgZ3N0X3ZpZGVvX2lu Zm9fZnJvbV9jYXBzKCkgZm9yIG5vbi1maXhlZCBjYXBzCgotLS0KIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmNwcCB8ICAgIDMg KystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJl YW1lclZlcnNpb25pbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL0dTdHJlYW1lclZlcnNpb25pbmcuY3BwCmluZGV4IDNjM2YzNjcuLjdmYzYxZDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3Ry ZWFtZXJWZXJzaW9uaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvR1N0cmVhbWVyVmVyc2lvbmluZy5jcHAKQEAgLTU0LDcgKzU0LDggQEAgYm9v bCBnZXRWaWRlb1NpemVBbmRGb3JtYXRGcm9tQ2FwcyhHc3RDYXBzKiBjYXBzLCBXZWJDb3JlOjpJ bnRTaXplJiBzaXplLCBHc3RWaWQKIHsKICNpZmRlZiBHU1RfQVBJX1ZFUlNJT05fMQogICAgIEdz dFZpZGVvSW5mbyBpbmZvOwotICAgIGlmICghZ3N0X3ZpZGVvX2luZm9fZnJvbV9jYXBzKCZpbmZv LCBjYXBzKSkKKworICAgIGlmICghZ3N0X2NhcHNfaXNfZml4ZWQoY2FwcykgfHwgIWdzdF92aWRl b19pbmZvX2Zyb21fY2FwcygmaW5mbywgY2FwcykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAog ICAgIGZvcm1hdCA9IEdTVF9WSURFT19JTkZPX0ZPUk1BVCgmaW5mbyk7Ci0tIAoxLjcuMTAuNAoK 181457 2013-01-06 05:25:17 -0800 2013-01-06 12:27:43 -0800 Don't call gst_video_info_from_caps() with non-fixed caps 0001-Don-t-call-gst_video_info_from_caps-for-non-fixed-ca.patch text/plain 1939 slomo RnJvbSBkNDQ3Y2Y3YjY1Nzk5M2Y0YjFmMjc2YmU1MWQ0NzhkMjI0NjkwN2E2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogU2F0LCA1IEphbiAyMDEzIDE2 OjA3OjI0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgY2FsbCBnc3RfdmlkZW9faW5mb19m cm9tX2NhcHMoKSBmb3Igbm9uLWZpeGVkIGNhcHMKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysr CiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclZlcnNpb25pbmcuY3Bw ICAgIHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYmE0ZTZiLi5mMjRmMzFiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTMtMDEtMDYgIFNlYmFzdGlhbiBEcsO2Z2UgIDxzZWJhc3RpYW4uZHJv ZWdlQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBCdWfCoDEwNjE3NyAtIFtHU3RyZWFtZXJd IERvbid0IGNhbGwgZ3N0X3ZpZGVvX2luZm9fZnJvbV9jYXBzKCkgd2l0aCBub24tZml4ZWQgY2Fw cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MTc3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVmVyc2lvbmluZy5jcHA6CisgICAgICAg IChnZXRWaWRlb1NpemVBbmRGb3JtYXRGcm9tQ2Fwcyk6CisgICAgICAgIERvbid0IGNhbGwgZ3N0 X3ZpZGVvX2luZm9fZnJvbV9jYXBzKCkgd2l0aCBub24tZml4ZWQgY2FwcyBhcworICAgICAgICBp dCB3aWxsIGNhdXNlIGFzc2VydGlvbnMuCisKIDIwMTItMDktMTkgIEpvbmF0aGFuIERvbmcgIDxq b25hdGhhbi5kb25nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g QWRkIGZ1bmN0aW9uIHBsYXllcklkKCkgaW4gY2xhc3MgUGFnZUNsaWVudEJsYWNrQmVycnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3Ry ZWFtZXJWZXJzaW9uaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmNwcAppbmRleCAzYzNmMzY3Li43ZmM2MWQwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0 cmVhbWVyVmVyc2lvbmluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL0dTdHJlYW1lclZlcnNpb25pbmcuY3BwCkBAIC01NCw3ICs1NCw4IEBAIGJv b2wgZ2V0VmlkZW9TaXplQW5kRm9ybWF0RnJvbUNhcHMoR3N0Q2FwcyogY2FwcywgV2ViQ29yZTo6 SW50U2l6ZSYgc2l6ZSwgR3N0VmlkCiB7CiAjaWZkZWYgR1NUX0FQSV9WRVJTSU9OXzEKICAgICBH c3RWaWRlb0luZm8gaW5mbzsKLSAgICBpZiAoIWdzdF92aWRlb19pbmZvX2Zyb21fY2FwcygmaW5m bywgY2FwcykpCisKKyAgICBpZiAoIWdzdF9jYXBzX2lzX2ZpeGVkKGNhcHMpIHx8ICFnc3Rfdmlk ZW9faW5mb19mcm9tX2NhcHMoJmluZm8sIGNhcHMpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICBmb3JtYXQgPSBHU1RfVklERU9fSU5GT19GT1JNQVQoJmluZm8pOwotLSAKMS43LjEwLjQK Cg==