106169 2013-01-05 01:22:58 -0800 Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent 2013-01-05 13:08:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P5 Trivial --- 1 mkwst mkwst dglazkov eric ojan.autocc webkit.review.bot oldest_to_newest 800883 0 mkwst 2013-01-05 01:22:58 -0800 Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent 800885 1 181431 mkwst 2013-01-05 01:24:12 -0800 Created attachment 181431 Patch 800886 2 mkwst 2013-01-05 01:26:11 -0800 I typo'd this twice while working on an earlier patch; adverbial forms matter! Note that Document::shouldDisplaySeamlesslyWithParent was already correct. :) Eric, mind taking a quick look at this trivial change? 800887 3 181431 eric 2013-01-05 01:32:02 -0800 Comment on attachment 181431 Patch OK. Be aware hyatt may have a patch in flight, would be nice not to break him. I'm not sure if his column + seamless patch from earlier today landed or not. 800888 4 mkwst 2013-01-05 01:34:08 -0800 This is a loooow priority patch; I'm happy to wait till next week to land it. Thanks for the warning. 800895 5 181431 webkit.review.bot 2013-01-05 02:54:45 -0800 Comment on attachment 181431 Patch Attachment 181431 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15708765 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 800980 6 181431 webkit.review.bot 2013-01-05 13:08:24 -0800 Comment on attachment 181431 Patch Clearing flags on attachment: 181431 Committed r138906: <http://trac.webkit.org/changeset/138906> 800981 7 webkit.review.bot 2013-01-05 13:08:28 -0800 All reviewed patches have been landed. Closing bug. 181431 2013-01-05 01:24:12 -0800 2013-01-05 13:08:24 -0800 Patch bug-106169-20130105102117.patch text/plain 3413 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU5YTQ3YjNlNjI2YzA0 MzMxZmNhMWE1MDhlODMxMzliOTdiMjYxMi4uOTNhMzU3MDIxYTA1MGVlNzEzYTllMmIzYjcxNWYz NDNhODc0YjhmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAxLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2xlYW51cDogbWF5RGlzcGxh eVNlYW1sZXNzV2l0aFBhcmVudCAtPiBtYXlEaXNwbGF5U2VhbWxlc3NfbHlfV2l0aFBhcmVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MTY5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRj aCByZW5hbWVzIFNlY3VyaXR5Q29udGV4dCdzICdtX21heURpc3BsYXlTZWFtbGVzc1dpdGhQYXJl bnQnIHRvCisgICAgICAgICdtX21heURpc3BsYXlTZWFtbGVzc2x5V2l0aFBhcmVudCcuIEJlY2F1 c2UgYWR2ZXJicyBtYXR0ZXIuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmluaXRTZWN1cml0eUNvbnRleHQpOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OnNob3VsZERpc3BsYXlTZWFtbGVzc2x5V2l0aFBhcmVudCk6CisgICAg ICAgICogZG9tL1NlY3VyaXR5Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWN1cml0 eUNvbnRleHQ6OlNlY3VyaXR5Q29udGV4dCk6CisgICAgICAgICogZG9tL1NlY3VyaXR5Q29udGV4 dC5oOgorICAgICAgICAoU2VjdXJpdHlDb250ZXh0KToKKwogMjAxMy0wMS0wNCAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDaHJvbWl1bSB3aW5kb3dzIGNvbXBp bGUgZmFpbHMgYmVjYXVzZSBvZiB0aGUgYXNzZXJ0aW9uIGluIE5vZGVSYXJlRGF0YQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKaW5kZXggYjg0ZGVlMDA0ZGQxZDJhZGZkOWM0MTg5YjBkMjYyYzRmMTFk MGE2OS4uMTE1YjNmNjkzN2IwNWQ4OGUyYzIyNTBkYTIyZmRlYzBkMTg2OTYzOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCkBAIC00NTgzLDcgKzQ1ODMsNyBAQCB2b2lkIERvY3VtZW50Ojppbml0 U2VjdXJpdHlDb250ZXh0KCkKIAogICAgIC8vIEZJWE1FOiBXaGF0IGhhcHBlbnMgaWYgd2UgaW5o ZXJpdCB0aGUgc2VjdXJpdHkgb3JpZ2luPyBUaGlzIGNoZWNrIG1heSBuZWVkIHRvIGJlIGxhdGVy LgogICAgIC8vIDxpZnJhbWUgc2VhbWxlc3Mgc3JjPSJhYm91dDpibGFuayI+IGxpa2VseSB3b24n dCB3b3JrIGFzLWlzLgotICAgIG1fbWF5RGlzcGxheVNlYW1sZXNzV2l0aFBhcmVudCA9IGlzRWxp Z2libGVGb3JTZWFtbGVzcyhwYXJlbnREb2N1bWVudCwgdGhpcyk7CisgICAgbV9tYXlEaXNwbGF5 U2VhbWxlc3NseVdpdGhQYXJlbnQgPSBpc0VsaWdpYmxlRm9yU2VhbWxlc3MocGFyZW50RG9jdW1l bnQsIHRoaXMpOwogCiAgICAgaWYgKCFzaG91bGRJbmhlcml0U2VjdXJpdHlPcmlnaW5Gcm9tT3du ZXIobV91cmwpKQogICAgICAgICByZXR1cm47CkBAIC01NjYxLDcgKzU2NjEsNyBAQCBib29sIERv Y3VtZW50OjpzaG91bGREaXNwbGF5U2VhbWxlc3NseVdpdGhQYXJlbnQoKSBjb25zdAogICAgIEhU TUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJFbGVtZW50ID0gdGhpcy0+b3duZXJFbGVtZW50KCk7 CiAgICAgaWYgKCFvd25lckVsZW1lbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1 cm4gbV9tYXlEaXNwbGF5U2VhbWxlc3NXaXRoUGFyZW50ICYmIG93bmVyRWxlbWVudC0+aGFzVGFn TmFtZShpZnJhbWVUYWcpICYmIG93bmVyRWxlbWVudC0+ZmFzdEhhc0F0dHJpYnV0ZShzZWFtbGVz c0F0dHIpOworICAgIHJldHVybiBtX21heURpc3BsYXlTZWFtbGVzc2x5V2l0aFBhcmVudCAmJiBv d25lckVsZW1lbnQtPmhhc1RhZ05hbWUoaWZyYW1lVGFnKSAmJiBvd25lckVsZW1lbnQtPmZhc3RI YXNBdHRyaWJ1dGUoc2VhbWxlc3NBdHRyKTsKICNlbHNlCiAgICAgcmV0dXJuIGZhbHNlOwogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2VjdXJpdHlDb250ZXh0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9TZWN1cml0eUNvbnRleHQuY3BwCmluZGV4IDM5NjNjNWJkMzA1 NjE5MGMzNGJhNTcwZWM2YmZiYTc5YmE1MjJkYTkuLmI3MDJkNGQxZjIyZDEzYjY3MWQ5OGNmY2I2 MzUzYWM2NTNiODQ1OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWN1cml0eUNv bnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWN1cml0eUNvbnRleHQuY3BwCkBA IC0zNiw3ICszNiw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFNlY3VyaXR5Q29udGV4dDo6 U2VjdXJpdHlDb250ZXh0KCkKLSAgICA6IG1fbWF5RGlzcGxheVNlYW1sZXNzV2l0aFBhcmVudChm YWxzZSkKKyAgICA6IG1fbWF5RGlzcGxheVNlYW1sZXNzbHlXaXRoUGFyZW50KGZhbHNlKQogICAg ICwgbV9oYXZlSW5pdGlhbGl6ZWRTZWN1cml0eU9yaWdpbihmYWxzZSkKICAgICAsIG1fc2FuZGJv eEZsYWdzKFNhbmRib3hOb25lKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1Nl Y3VyaXR5Q29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1NlY3VyaXR5Q29udGV4dC5oCmlu ZGV4IDhkNzExMDRlM2I1MTViODlkMjYxNzI5NGIzNGM3MjczNzc4ZjMyNmQuLjYxZjBlNmE0MTM4 ZTA0NWRmMDZlMmZiNzgxMTBkNjAwNTFkOGFiZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9TZWN1cml0eUNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2VjdXJpdHlD b250ZXh0LmgKQEAgLTg4LDcgKzg4LDcgQEAgcHJvdGVjdGVkOgogCiAgICAgLy8gU2V0IGluIERv Y3VtZW50Ojppbml0U2VjdXJpdHlDb250ZXh0KCkgYXQgRG9jdW1lbnQgY3JlYXRpb24sIHBlcjoK ICAgICAvLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3Jr LyNhdHRyLWlmcmFtZS1zZWFtbGVzcwotICAgIGJvb2wgbV9tYXlEaXNwbGF5U2VhbWxlc3NXaXRo UGFyZW50OworICAgIGJvb2wgbV9tYXlEaXNwbGF5U2VhbWxlc3NseVdpdGhQYXJlbnQ7CiAKIHBy aXZhdGU6CiAgICAgYm9vbCBtX2hhdmVJbml0aWFsaXplZFNlY3VyaXR5T3JpZ2luOwo=