106156 2013-01-04 18:13:34 -0800 SVG images not created in CachedImage::CreateImage() due to blank mimetype 2013-01-11 12:25:13 -0800 1 1 1 Unclassified WebKit SVG 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr japhet thorton webkit.review.bot zimmermann oldest_to_newest 800797 0 pdr 2013-01-04 18:13:34 -0800 If we load a cached SVG image in an html page (<img src="svg.svg">), CachedImage::createImage() will use a blank mimetype which will not create an SVGImage on the first pass. This bypasses the SVGImageCache entirely. 803756 1 181994 pdr 2013-01-09 15:02:26 -0800 Created attachment 181994 First pass 805525 2 181994 webkit.review.bot 2013-01-11 12:25:10 -0800 Comment on attachment 181994 First pass Clearing flags on attachment: 181994 Committed r139484: <http://trac.webkit.org/changeset/139484> 805526 3 webkit.review.bot 2013-01-11 12:25:13 -0800 All reviewed patches have been landed. Closing bug. 181994 2013-01-09 15:02:26 -0800 2013-01-11 12:25:10 -0800 First pass 106156.1.patch text/plain 3041 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTI0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTA5ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgU2tpcCBDYWNoZWRJbWFnZTo6Q3Jl YXRlSW1hZ2UgaWYgd2UgZG9uJ3QgaGF2ZSBpbWFnZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYxNTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHNraXBzIGltYWdlIGNyZWF0 aW9uIGlmIHdlIGRvIG5vdCBoYXZlIGltYWdlIGRhdGEuIFRoaXMgY2FuIG9jY3VyIGR1cmluZwor ICAgICAgICBjYWNoZSByZXZhbGlkYXRpb24gd2hlbiB0aGUgcmV2YWxpZGF0aW9uIHJlcXVlc3Qg KDMwNCBub3QgbW9kaWZpZWQpIGNvbWVzIGJhY2sgd2l0aG91dAorICAgICAgICBhbnkgY29udGVu dC4gSW4gdGhpcyByZXZhbGlkYXRpb24gY2FzZSwgdGhlIGh0dHAgc3BlYyByZXF1aXJlcyB0aGF0 IGEgbWltZXR5cGUgbm90IGJlIHNldAorICAgICAgICBvbiB0aGUgcmVzcG9uc2UgdG8gcHJldmVu dCBhIGNhY2hlZCByZXNvdXJjZSBmcm9tIGhhdmluZyBhIGRpZmZlcmVudCBtaW1ldHlwZQorICAg ICAgICBmcm9tIHRoZSByZXZhbGlkYXRlZCByZXNvdXJjZS4gQmVjYXVzZSByZXZhbGlkYXRpb24g cmVxdWVzdHMgZG8gbm90IGhhdmUgYSBtaW1ldHlwZSwKKyAgICAgICAgQ2FjaGVkSW1hZ2U6OkNy ZWF0ZUltYWdlKCkgd2lsbCBmYWlsIG9uIFNWRyBpbWFnZXMuIFRoaXMgcGF0Y2ggcHJldmVudHMK KyAgICAgICAgQ2FjaGVkSW1hZ2U6OkNyZWF0ZUltYWdlKCkgZnJvbSBiZWluZyBjYWxsZWQgZHVy aW5nIHJldmFsaWRhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgYXJlIG5v IG9ic2VydmFibGUgY2hhbmdlcyBmcm9tIHRoaXMgcGF0Y2guCisKKyAgICAgICAgKiBsb2FkZXIv Y2FjaGUvQ2FjaGVkSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkSW1hZ2U6OmRh dGEpOgorCiAyMDEzLTAxLTA5ICBEYW4gV2luc2hpcCAgPGRhbndAZ25vbWUub3JnPgogCiAgICAg ICAgIFtTb3VwXSBIYW5kbGUgcmVkaXJlY3Rpb24gaW5zaWRlIFdlYktpdApJbmRleDogU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuY3BwCShyZXZpc2lvbiAxMzg4Nzkp CisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNTgsMTQgKzM1OCwxNiBAQCB2b2lkIENhY2hlZEltYWdlOjpkYXRhKFBhc3NS ZWZQdHI8UmVzb3VyCiB7CiAgICAgbV9kYXRhID0gZGF0YTsKIAotICAgIGNyZWF0ZUltYWdlKCk7 CisgICAgaWYgKG1fZGF0YSkKKyAgICAgICAgY3JlYXRlSW1hZ2UoKTsKIAogICAgIGJvb2wgc2l6 ZUF2YWlsYWJsZSA9IGZhbHNlOwogCiAgICAgLy8gSGF2ZSB0aGUgaW1hZ2UgdXBkYXRlIGl0cyBk YXRhIGZyb20gaXRzIGludGVybmFsIGJ1ZmZlci4KICAgICAvLyBJdCB3aWxsIG5vdCBkbyBhbnl0 aGluZyBub3csIGJ1dCB3aWxsIGRlbGF5IGRlY29kaW5nIHVudGlsIAogICAgIC8vIHF1ZXJpZWQg Zm9yIGluZm8gKGxpa2Ugc2l6ZSBvciBzcGVjaWZpYyBpbWFnZSBmcmFtZXMpLgotICAgIHNpemVB dmFpbGFibGUgPSBtX2ltYWdlLT5zZXREYXRhKG1fZGF0YSA/IG1fZGF0YS0+c2hhcmVkQnVmZmVy KCkgOiAwLCBhbGxEYXRhUmVjZWl2ZWQpOworICAgIGlmIChtX2ltYWdlKQorICAgICAgICBzaXpl QXZhaWxhYmxlID0gbV9pbWFnZS0+c2V0RGF0YShtX2RhdGEgPyBtX2RhdGEtPnNoYXJlZEJ1ZmZl cigpIDogMCwgYWxsRGF0YVJlY2VpdmVkKTsKIAogICAgIC8vIEdvIGFoZWFkIGFuZCB0ZWxsIG91 ciBvYnNlcnZlcnMgdG8gdHJ5IHRvIGRyYXcgaWYgd2UgaGF2ZSBlaXRoZXIKICAgICAvLyByZWNl aXZlZCBhbGwgdGhlIGRhdGEgb3IgdGhlIHNpemUgaXMga25vd24uICBFYWNoIGNodW5rIGZyb20g dGhlCkBAIC0zNzMsOSArMzc1LDkgQEAgdm9pZCBDYWNoZWRJbWFnZTo6ZGF0YShQYXNzUmVmUHRy PFJlc291cgogICAgIC8vIHRvIGRlY29kZS4KICAgICBpZiAoc2l6ZUF2YWlsYWJsZSB8fCBhbGxE YXRhUmVjZWl2ZWQpIHsKICAgICAgICAgc2l6ZV90IG1heERlY29kZWRJbWFnZVNpemUgPSBtYXhp bXVtRGVjb2RlZEltYWdlU2l6ZSgpOwotICAgICAgICBJbnRTaXplIHMgPSBtX2ltYWdlLT5zaXpl KCk7CisgICAgICAgIEludFNpemUgcyA9IG1faW1hZ2UgPyBtX2ltYWdlLT5zaXplKCkgOiBJbnRT aXplKCk7CiAgICAgICAgIHNpemVfdCBlc3RpbWF0ZWREZWNvZGVkSW1hZ2VTaXplID0gcy53aWR0 aCgpICogcy5oZWlnaHQoKSAqIDQ7IC8vIG5vIG92ZXJmbG93IGNoZWNrCi0gICAgICAgIGlmICht X2ltYWdlLT5pc051bGwoKSB8fCAobWF4RGVjb2RlZEltYWdlU2l6ZSA+IDAgJiYgZXN0aW1hdGVk RGVjb2RlZEltYWdlU2l6ZSA+IG1heERlY29kZWRJbWFnZVNpemUpKSB7CisgICAgICAgIGlmICgh bV9pbWFnZSB8fCBtX2ltYWdlLT5pc051bGwoKSB8fCAobWF4RGVjb2RlZEltYWdlU2l6ZSA+IDAg JiYgZXN0aW1hdGVkRGVjb2RlZEltYWdlU2l6ZSA+IG1heERlY29kZWRJbWFnZVNpemUpKSB7CiAg ICAgICAgICAgICBlcnJvcihlcnJvck9jY3VycmVkKCkgPyBzdGF0dXMoKSA6IERlY29kZUVycm9y KTsKICAgICAgICAgICAgIGlmIChpbkNhY2hlKCkpCiAgICAgICAgICAgICAgICAgbWVtb3J5Q2Fj aGUoKS0+cmVtb3ZlKHRoaXMpOwo=