106154 2013-01-04 18:03:27 -0800 [GTK] Fix build error on GTK due to r138836 2013-01-04 19:21:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 michael webkit-unassigned abarth haraken jsbell rniwa webkit.review.bot zan oldest_to_newest 800789 0 michael 2013-01-04 18:03:27 -0800 The changes in r138836 for bug 105927 appear to have broken the GTK build. 800790 1 181416 michael 2013-01-04 18:04:02 -0800 Created attachment 181416 Patch 800799 2 181417 michael 2013-01-04 18:16:46 -0800 Created attachment 181417 Patch 800805 3 jsbell 2013-01-04 18:30:52 -0800 *sigh*. Looks okay to me. Ask a committee on IRC to land-cowboy to fix the build? 800816 4 181417 haraken 2013-01-04 18:55:57 -0800 Comment on attachment 181417 Patch Looks OK 800820 5 181417 rniwa 2013-01-04 19:21:50 -0800 Comment on attachment 181417 Patch Clearing flags on attachment: 181417 Committed r138882: <http://trac.webkit.org/changeset/138882> 800821 6 rniwa 2013-01-04 19:21:52 -0800 All reviewed patches have been landed. Closing bug. 181416 2013-01-04 18:04:02 -0800 2013-01-04 18:16:46 -0800 Patch gtk-build-fix.patch text/plain 1853 michael RnJvbSA0YmE2YjYwMDUyODBmYWIxMmY2MDg4NDlkNDIwYjI0NjI0YzgzNzg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFBydWV0dCA8bWljaGFlbEA2OGsub3JnPgpEYXRl OiBGcmksIDQgSmFuIDIwMTMgMTc6NTg6NDUgLTA4MDAKU3ViamVjdDogW0dUS10gRml4IGJ1aWxk IGVycm9yIG9uIEdUSyBkdWUgdG8gcjEzODgzNgoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICB8 ICAgIDkgKysrKysrKysrCiBUb29scy9HTlVtYWtlZmlsZS5hbSB8ICAgIDUgKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMGFiZjkzLi42MDZmZGE1 IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTMtMDEtMDQgIE1pY2hhZWwgUHJ1ZXR0ICA8bWljaGFlbEA2OGsub3Jn PgorCisgICAgICAgIFtHVEtdIEZpeCBidWlsZCBlcnJvciBvbiBHVEsgZHVlIHRvIHIxMzg4MzYK KyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTMtMDEt MDMgIE1pY2hhZWwgUHJ1ZXR0ICA8bWljaGFlbEA2OGsub3JnPgogCiAgICAgICAgIFtXSzJdIEFk ZCBzdXBwb3J0IGZvciBzZXR0aW5nIEluZGV4ZWREQiBkYXRhYmFzZSBwYXRoIGluIFdLMgpkaWZm IC0tZ2l0IGEvVG9vbHMvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9HTlVtYWtlZmlsZS5hbQppbmRl eCBhOWJhYjkwLi4zNjBiYWY0IDEwMDY0NAotLS0gYS9Ub29scy9HTlVtYWtlZmlsZS5hbQorKysg Yi9Ub29scy9HTlVtYWtlZmlsZS5hbQpAQCAtNTQsNiArNTQsNyBAQCBsaWJXZWJDb3JlSW50ZXJu YWxzX2xhX1NPVVJDRVMgPSBcCiAJU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRp bmdzLmggXAogCVNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvTW9ja1BhZ2VQb3B1cERyaXZlci5jcHAg XAogCVNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvTW9ja1BhZ2VQb3B1cERyaXZlci5oIFwKKwlTb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL1R5cGVDb252ZXJzaW9ucy5oIFwKIAlTb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9ydC5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3Rlc3Rp bmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgKIApAQCAtNjcsNyArNjgsOSBAQCBsaWJ3ZWJjb3Jl aW50ZXJuYWxzX2J1aWx0X3NvdXJjZXMgKz0gXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNJ bnRlcm5hbFNldHRpbmdzLmNwcCBcCiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU0ludGVybmFs U2V0dGluZ3MuaCAgIFwKIAlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTSW50ZXJuYWxTZXR0aW5n c0dlbmVyYXRlZC5jcHAgXAotCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNJbnRlcm5hbFNldHRp bmdzR2VuZXJhdGVkLmgKKwlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTSW50ZXJuYWxTZXR0aW5n c0dlbmVyYXRlZC5oIFwKKwlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTVHlwZUNvbnZlcnNpb25z LmNwcCBcCisJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU1R5cGVDb252ZXJzaW9ucy5oCiAKIG5v ZGlzdF9saWJXZWJDb3JlSW50ZXJuYWxzX2xhX1NPVVJDRVMgPSAkKGxpYndlYmNvcmVpbnRlcm5h bHNfYnVpbHRfc291cmNlcykKIEJVSUxUX1NPVVJDRVMgKz0gJChsaWJ3ZWJjb3JlaW50ZXJuYWxz X2J1aWx0X3NvdXJjZXMpCi0tIAoxLjcuOS41Cgo= 181417 2013-01-04 18:16:46 -0800 2013-01-04 19:21:49 -0800 Patch gtk-build-fix.patch text/plain 1803 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogRnJpLCA0IEphbiAy MDEzIDE4OjEzOjE4IC0wODAwClN1YmplY3Q6IFtHVEtdIEZpeCBidWlsZCBlcnJvciBvbiBHVEsg ZHVlIHRvIHIxMzg4MzYKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgfCAgICA5ICsrKysrKysr KwogVG9vbHMvR05VbWFrZWZpbGUuYW0gfCAgICA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQsIDEz IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjBhYmY5My4uYjI0MGNmMCAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDEzLTAxLTA0ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KKworICAgICAgICBb R1RLXSBGaXggYnVpbGQgZXJyb3Igb24gR1RLIGR1ZSB0byByMTM4ODM2CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYxNTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAy MDEzLTAxLTAzICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KIAogICAgICAgICBb V0syXSBBZGQgc3VwcG9ydCBmb3Igc2V0dGluZyBJbmRleGVkREIgZGF0YWJhc2UgcGF0aCBpbiBX SzIKZGlmZiAtLWdpdCBhL1Rvb2xzL0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMvR05VbWFrZWZpbGUu YW0KaW5kZXggYTliYWI5MC4uMzYwYmFmNCAxMDA2NDQKLS0tIGEvVG9vbHMvR05VbWFrZWZpbGUu YW0KKysrIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0KQEAgLTU0LDYgKzU0LDcgQEAgbGliV2ViQ29y ZUludGVybmFsc19sYV9TT1VSQ0VTID0gXAogCVNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxTZXR0aW5ncy5oIFwKIAlTb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tQYWdlUG9wdXBEcml2 ZXIuY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tQYWdlUG9wdXBEcml2ZXIuaCBc CisJU291cmNlL1dlYkNvcmUvdGVzdGluZy9UeXBlQ29udmVyc2lvbnMuaCBcCiAJU291cmNlL1dl YkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuY3BwIFwKIAlTb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9ydC5oCiAKQEAgLTY3LDcgKzY4LDkgQEAgbGli d2ViY29yZWludGVybmFsc19idWlsdF9zb3VyY2VzICs9IFwKIAlEZXJpdmVkU291cmNlcy9XZWJD b3JlL0pTSW50ZXJuYWxTZXR0aW5ncy5jcHAgXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNJ bnRlcm5hbFNldHRpbmdzLmggICBcCiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU0ludGVybmFs U2V0dGluZ3NHZW5lcmF0ZWQuY3BwIFwKLQlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTSW50ZXJu YWxTZXR0aW5nc0dlbmVyYXRlZC5oCisJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU0ludGVybmFs U2V0dGluZ3NHZW5lcmF0ZWQuaCBcCisJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU1R5cGVDb252 ZXJzaW9ucy5jcHAgXAorCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNUeXBlQ29udmVyc2lvbnMu aAogCiBub2Rpc3RfbGliV2ViQ29yZUludGVybmFsc19sYV9TT1VSQ0VTID0gJChsaWJ3ZWJjb3Jl aW50ZXJuYWxzX2J1aWx0X3NvdXJjZXMpCiBCVUlMVF9TT1VSQ0VTICs9ICQobGlid2ViY29yZWlu dGVybmFsc19idWlsdF9zb3VyY2VzKQotLSAKMS43LjkuNQoK