106141 2013-01-04 15:38:32 -0800 [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link 2013-01-05 13:03:40 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 800694 0 andchen 2013-01-04 15:38:32 -0800 Use the last fat finger result instead of selecting text again. Otherwise, it would get similar fat finger result as the last one, only difference is the target type. 800807 1 181419 andchen 2013-01-04 18:34:20 -0800 Created attachment 181419 Patch 800961 2 181419 rwlbuis 2013-01-05 12:24:54 -0800 Comment on attachment 181419 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181419&action=review LGTM. > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:587 > +bool SelectionHandler::selectNodeIfFatFingersResultIsLink(FatFingersResult fatFingersResult) A long name, but I can't suggest anything better/shorter. 800977 3 181419 webkit.review.bot 2013-01-05 13:03:37 -0800 Comment on attachment 181419 Patch Clearing flags on attachment: 181419 Committed r138905: <http://trac.webkit.org/changeset/138905> 800978 4 webkit.review.bot 2013-01-05 13:03:40 -0800 All reviewed patches have been landed. Closing bug. 181419 2013-01-04 18:34:20 -0800 2013-01-05 13:03:37 -0800 Patch bug-106141-20130104213126.patch text/plain 4660 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyZGYzYjNmYTYwNDhiYTIzMjBiYzljODAzOWMwMTc4MmYyOTQwNjQ3Li5jYWY1NmM0ODUz YjgwY2MzN2U2NDYyZGMxY2JiYzZkOTA3YTQyYzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wMS0wNCAgQW5keSBDaGVuICA8YW5kY2hlbkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3RB dFBvaW50IHNob3VsZCB1c2UgbGFzdCBmYXQgZmluZ2VyIHJlc3VsdCB3aGVuIGl0IGlzIGEgbGlu aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MTQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgbGFz dCBmYXQgZmluZ2VyIHJlc3VsdCBpcyBhIGxpbmssIHNlbGVjdCBpdCBkaXJlY3RseSB3aGVuCisg ICAgICAgIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdEF0UG9pbnQgaXMgY2FsbGVkLgorICAgICAg ICBQUiAyNjM0NDkKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbiBh bmQgWW9uZ3hpbiBEYWkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRs ZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpz ZWxlY3ROb2RlSWZGYXRGaW5nZXJzUmVzdWx0SXNMaW5rKToKKyAgICAgICAgKFdlYktpdCk6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdEF0UG9p bnQpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oOgorICAgICAg ICAoV2ViS2l0KToKKyAgICAgICAgKFNlbGVjdGlvbkhhbmRsZXIpOgorCiAyMDEzLTAxLTA0ICBN aWtlIExhdHRhbnppbyAgPG1sYXR0YW56aW9AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gTGFzdCB0ZXh0IGlucHV0IGNhcmV0IGxlZnQgdmlzaWJsZSB3aGVuIFdlYlZpZXcgZW50aXJl bHkgbG9zZXMgZm9jdXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IGJjMTYwMDdhMDNhNGFl MTNjMGVkZjQ0ZDMwYzkzMjA0OGM2MDBjMGMuLmI3MjQ2NDFmMDZhOTJmNGE3OTM4MGU0NjA0Nzdm NzY4YmIzZWNmZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC01ODQsNiArNTg0LDIwIEBA IHN0YXRpYyBOb2RlKiBlbmNsb3NpbmdMaW5rRXZlbnRQYXJlbnRGb3JOb2RlKE5vZGUqIG5vZGUp CiAgICAgcmV0dXJuIGxpbmtOb2RlICYmIGxpbmtOb2RlLT5pc0xpbmsoKSA/IGxpbmtOb2RlIDog MDsKIH0KIAorYm9vbCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3ROb2RlSWZGYXRGaW5nZXJzUmVz dWx0SXNMaW5rKEZhdEZpbmdlcnNSZXN1bHQgZmF0RmluZ2Vyc1Jlc3VsdCkKK3sKKyAgICBpZiAo IWZhdEZpbmdlcnNSZXN1bHQuaXNWYWxpZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg Tm9kZSogdGFyZ2V0Tm9kZSA9IGZhdEZpbmdlcnNSZXN1bHQubm9kZShGYXRGaW5nZXJzUmVzdWx0 OjpTaGFkb3dDb250ZW50Tm90QWxsb3dlZCk7CisgICAgQVNTRVJUKHRhcmdldE5vZGUpOworICAg IC8vIElmIHRoZSBub2RlIGF0IHRoZSBwb2ludCBpcyBhIGxpbmssIGZvY3VzIG9uIHRoZSBlbnRp cmUgbGluaywgbm90IGEgd29yZC4KKyAgICBpZiAoTm9kZSogbGluayA9IGVuY2xvc2luZ0xpbmtF dmVudFBhcmVudEZvck5vZGUodGFyZ2V0Tm9kZSkpIHsKKyAgICAgICAgc2VsZWN0T2JqZWN0KGxp bmspOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQor CiB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdEF0UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50 UG9pbnQmIGxvY2F0aW9uKQogewogICAgIC8vIElmIHBvaW50IGlzIGludmFsaWQgdHJpZ2dlciBz ZWxlY3Rpb24gYmFzZWQgZXhwYW5zaW9uLgpAQCAtNTkyLDEwICs2MDYsMTIgQEAgdm9pZCBTZWxl Y3Rpb25IYW5kbGVyOjpzZWxlY3RBdFBvaW50KGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBsb2Nh dGlvbikKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIE5vZGUqIHRhcmdldE5vZGU7CiAg ICAgV2ViQ29yZTo6SW50UG9pbnQgdGFyZ2V0UG9zaXRpb247CiAgICAgLy8gRklYTUU6IEZhY3Rv cnkgdGhpcyBnZXQgcmlnaHQgZmF0IGZpbmdlciBjb2RlIGludG8gYSBoZWxwZXIuCiAgICAgY29u c3QgRmF0RmluZ2Vyc1Jlc3VsdCBsYXN0RmF0RmluZ2Vyc1Jlc3VsdCA9IG1fd2ViUGFnZS0+bV90 b3VjaEV2ZW50SGFuZGxlci0+bGFzdEZhdEZpbmdlcnNSZXN1bHQoKTsKKyAgICBpZiAoc2VsZWN0 Tm9kZUlmRmF0RmluZ2Vyc1Jlc3VsdElzTGluayhsYXN0RmF0RmluZ2Vyc1Jlc3VsdCkpCisgICAg ICAgIHJldHVybjsKKwogICAgIGlmIChsYXN0RmF0RmluZ2Vyc1Jlc3VsdC5yZXN1bHRNYXRjaGVz KGxvY2F0aW9uLCBGYXRGaW5nZXJzOjpUZXh0KSAmJiBsYXN0RmF0RmluZ2Vyc1Jlc3VsdC5wb3Np dGlvbldhc0FkanVzdGVkKCkgJiYgbGFzdEZhdEZpbmdlcnNSZXN1bHQubm9kZUFzRWxlbWVudElm QXBwbGljYWJsZSgpKSB7CiAgICAgICAgIHRhcmdldE5vZGUgPSBsYXN0RmF0RmluZ2Vyc1Jlc3Vs dC5ub2RlKEZhdEZpbmdlcnNSZXN1bHQ6OlNoYWRvd0NvbnRlbnROb3RBbGxvd2VkKTsKICAgICAg ICAgdGFyZ2V0UG9zaXRpb24gPSBsYXN0RmF0RmluZ2Vyc1Jlc3VsdC5hZGp1c3RlZFBvc2l0aW9u KCk7CkBAIC02MDQsMTYgKzYyMCwxMCBAQCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdEF0 UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIGxvY2F0aW9uKQogICAgICAgICBpZiAoIW5l d0ZhdEZpbmdlcnNSZXN1bHQucG9zaXRpb25XYXNBZGp1c3RlZCgpKQogICAgICAgICAgICAgcmV0 dXJuOwogCi0gICAgICAgIHRhcmdldFBvc2l0aW9uID0gbmV3RmF0RmluZ2Vyc1Jlc3VsdC5hZGp1 c3RlZFBvc2l0aW9uKCk7Ci0gICAgICAgIHRhcmdldE5vZGUgPSBuZXdGYXRGaW5nZXJzUmVzdWx0 Lm5vZGUoRmF0RmluZ2Vyc1Jlc3VsdDo6U2hhZG93Q29udGVudE5vdEFsbG93ZWQpOwotICAgIH0K LQotICAgIEFTU0VSVCh0YXJnZXROb2RlKTsKKyAgICAgICAgaWYgKHNlbGVjdE5vZGVJZkZhdEZp bmdlcnNSZXN1bHRJc0xpbmsobmV3RmF0RmluZ2Vyc1Jlc3VsdCkpCisgICAgICAgICAgICByZXR1 cm47CiAKLSAgICAvLyBJZiB0aGUgbm9kZSBhdCB0aGUgcG9pbnQgaXMgYSBsaW5rLCBmb2N1cyBv biB0aGUgZW50aXJlIGxpbmssIG5vdCBhIHdvcmQuCi0gICAgaWYgKE5vZGUqIGxpbmsgPSBlbmNs b3NpbmdMaW5rRXZlbnRQYXJlbnRGb3JOb2RlKHRhcmdldE5vZGUpKSB7Ci0gICAgICAgIHNlbGVj dE9iamVjdChsaW5rKTsKLSAgICAgICAgcmV0dXJuOworICAgICAgICB0YXJnZXRQb3NpdGlvbiA9 IG5ld0ZhdEZpbmdlcnNSZXN1bHQuYWRqdXN0ZWRQb3NpdGlvbigpOwogICAgIH0KIAogICAgIC8v IHNlbGVjdEF0UG9pbnQgQVBJIGN1cnJlbnRseSBvbmx5IHN1cHBvcnRzIFdvcmRHcmFudWxhcml0 eSBidXQgbWF5IGJlIGV4dGVuZGVkIGluIHRoZSBmdXR1cmUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmggYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmgKaW5k ZXggYWNiYmQzMWI5NGQwMzZjNDYxZTkwM2Y0YjJhZjg2ZTdjY2FkMTlhMy4uYTU4ZTUxODZjY2Mx ZGM5ZWJiMTQyNTJkMTExZGEyN2ZlZDA5ZmFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuaApAQCAtNDYs NiArNDYsNyBAQCBjbGFzcyBTdHJpbmc7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCitjbGFzcyBG YXRGaW5nZXJzUmVzdWx0OwogY2xhc3MgV2ViUGFnZVByaXZhdGU7CiAKIGNsYXNzIFNlbGVjdGlv bkhhbmRsZXIgewpAQCAtODksNiArOTAsOCBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBpbnB1dE5v ZGVPdmVycmlkZXNUb3VjaCgpIGNvbnN0OwogCisgICAgYm9vbCBzZWxlY3ROb2RlSWZGYXRGaW5n ZXJzUmVzdWx0SXNMaW5rKEZhdEZpbmdlcnNSZXN1bHQpOworCiAgICAgV2ViUGFnZVByaXZhdGUq IG1fd2ViUGFnZTsKIAogICAgIGJvb2wgbV9zZWxlY3Rpb25BY3RpdmU7Cg==