106123 2013-01-04 12:05:07 -0800 REGRESSION(r138222?): [Mac WK1] http/tests/appcache/main-resource-redirect.html asserts in WebFrameLoaderClient::dispatchDidFinishLoading 2013-01-08 19:32:10 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 105591 106137 1 rniwa japhet ap beidson cdumez cgarcia eric.carlson japhet webkit-bug-importer webkit.review.bot oldest_to_newest 800483 0 rniwa 2013-01-04 12:05:07 -0800 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fappcache%2Fmain-resource-redirect.html http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r138809%20(4306)/results.html CRASHING TEST: /appcache/main-resource-redirect.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010533f7aa -[WebView(WebViewInternal) _removeObjectForIdentifier:] + 122 (WebView.mm:6229) 1 com.apple.WebKit 0x00000001052489b1 WebFrameLoaderClient::dispatchDidFinishLoading(WebCore::DocumentLoader*, unsigned long) + 225 (WebFrameLoaderClient.mm:477) 2 com.apple.WebCore 0x0000000106e2de7b WebCore::ResourceLoadNotifier::dispatchDidFinishLoading(WebCore::DocumentLoader*, unsigned long, double) + 91 (ResourceLoadNotifier.cpp:148) 3 com.apple.WebCore 0x00000001069a25c3 WebCore::MainResourceLoader::didFinishLoading(double) + 147 (MainResourceLoader.cpp:529) 4 com.apple.WebCore 0x00000001069a24f4 WebCore::MainResourceLoader::continueAfterContentPolicy(WebCore::PolicyAction, WebCore::ResourceResponse const&) + 1636 (MainResourceLoader.cpp:358) 5 com.apple.WebCore 0x00000001069a2846 WebCore::MainResourceLoader::continueAfterContentPolicy(WebCore::PolicyAction) + 166 (MainResourceLoader.cpp:373) 6 com.apple.WebCore 0x00000001069a278b WebCore::MainResourceLoader::callContinueAfterContentPolicy(void*, WebCore::PolicyAction) + 27 (MainResourceLoader.cpp:365) 7 com.apple.WebCore 0x0000000106afd919 WebCore::PolicyCallback::call(WebCore::PolicyAction) + 297 (PolicyCallback.cpp:115) 8 com.apple.WebCore 0x0000000106afe73d WebCore::PolicyChecker::continueAfterContentPolicy(WebCore::PolicyAction) + 93 (PolicyChecker.cpp:194) 9 com.apple.WebKit 0x000000010524dfda WebFrameLoaderClient::receivedPolicyDecison(WebCore::PolicyAction) + 410 (WebFrameLoaderClient.mm:1286) 10 com.apple.WebKit 0x0000000105252401 -[WebFramePolicyListener receivedPolicyDecision:] + 193 (WebFrameLoaderClient.mm:2025) 11 com.apple.WebKit 0x0000000105252510 -[WebFramePolicyListener use] + 48 (WebFrameLoaderClient.mm:2041) 12 com.apple.WebKit 0x000000010521f772 -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:] + 338 (WebDefaultPolicyDelegate.m:74) 13 com.apple.CoreFoundation 0x00007fff8a08763c __invoking___ + 140 14 com.apple.CoreFoundation 0x00007fff8a0874d7 -[NSInvocation invoke] + 263 15 com.apple.CoreFoundation 0x00007fff8a0876a9 -[NSInvocation invokeWithTarget:] + 57 16 com.apple.WebKit 0x000000010532bfa9 -[_WebSafeForwarder forwardInvocation:] + 361 (WebView.mm:3083) 17 com.apple.CoreFoundation 0x00007fff8a082737 ___forwarding___ + 775 18 com.apple.CoreFoundation 0x00007fff8a0823b8 _CF_forwarding_prep_0 + 232 19 com.apple.WebKit 0x0000000105249edb WebFrameLoaderClient::dispatchDecidePolicyForResponse(void (WebCore::PolicyChecker::*)(WebCore::PolicyAction), WebCore::ResourceResponse const&, WebCore::ResourceRequest const&) + 363 (WebFrameLoaderClient.mm:723) 20 com.apple.WebCore 0x0000000106afe6d7 WebCore::PolicyChecker::checkContentPolicy(WebCore::ResourceResponse const&, void (*)(void*, WebCore::PolicyAction), void*) + 183 (PolicyChecker.cpp:109) 21 com.apple.WebCore 0x00000001069a2fc4 WebCore::MainResourceLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&) + 1892 (MainResourceLoader.cpp:446) 22 com.apple.WebCore 0x00000001069a0de4 WebCore::MainResourceLoader::handleSubstituteDataLoadNow(WebCore::RunLoopTimer<WebCore::MainResourceLoader>*) + 436 (MainResourceLoader.cpp:600) 23 com.apple.WebCore 0x00000001069a4dc3 WebCore::RunLoopTimer<WebCore::MainResourceLoader>::fired() + 115 (RunLoopTimer.h:71) 24 com.apple.WebCore 0x0000000106e62e40 WebCore::timerFired(__CFRunLoopTimer*, void*) + 64 (RunLoopTimerCF.cpp:52) 25 com.apple.CoreFoundation 0x00007fff8a050da4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 26 com.apple.CoreFoundation 0x00007fff8a0508bd __CFRunLoopDoTimer + 557 27 com.apple.CoreFoundation 0x00007fff8a036099 __CFRunLoopRun + 1513 28 com.apple.CoreFoundation 0x00007fff8a0356b2 CFRunLoopRunSpecific + 290 29 com.apple.Foundation 0x00007fff8702389e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 268 30 DumpRenderTree 0x0000000103f20839 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 5017 (DumpRenderTree.mm:1381) 31 DumpRenderTree 0x0000000103f1f42a runTestingServerLoop() + 282 (DumpRenderTree.mm:846) 32 DumpRenderTree 0x0000000103f1ecf7 dumpRenderTree(int, char const**) + 391 (DumpRenderTree.mm:893) 800485 1 webkit-bug-importer 2013-01-04 12:05:28 -0800 <rdar://problem/12958827> 800486 2 rniwa 2013-01-04 12:05:35 -0800 It’s hard to tell whether this is a recent regression or something that existed for a long time. 800490 3 rniwa 2013-01-04 12:09:22 -0800 Oh, now I see what’s happening. http://trac.webkit.org/changeset/138782 tried to fix this crash but it didn’t. 800493 4 rniwa 2013-01-04 12:12:18 -0800 This is only happening in WebKit1. 800496 5 rniwa 2013-01-04 12:15:15 -0800 Updated test expectations in http://trac.webkit.org/changeset/138828. 800757 6 rniwa 2013-01-04 17:01:29 -0800 Turned out that this is an assertion failure: - (void)_removeObjectForIdentifier:(unsigned long)identifier { ASSERT(_private->identifierMap.contains(identifier)); << this guy. _private->identifierMap.remove(identifier); // If the identifier map is now empty it means we're no longer loading anything // and we should release the web view. Autorelease rather than release in order to // avoid re-entering this method beneath -dealloc with the same identifier. <rdar://problem/10523721> if (_private->identifierMap.isEmpty()) WebCFAutorelease(self); } 800889 7 cgarcia 2013-01-05 01:46:45 -0800 (In reply to comment #3) > Oh, now I see what’s happening. http://trac.webkit.org/changeset/138782 tried to fix this crash but it didn’t. Not exactly, they are actually different bugs. Bug #105591 fixed an assertion when the resource identifier is 0. The problem now is that for some reason, dispatchDidFailLoading() is called for a resource, but the load doesn't actually finish and dispatchDidReceiveResponse(), dispatchDidReceiveData() and dispatchDidFinishLoading() are called for the same resource after the dispatchDidFailLoading(). This is of course not expected, Mac removes the object from the map in both DidFailLoading and DidFinishLoading. 800896 8 181433 cgarcia 2013-01-05 02:57:53 -0800 Created attachment 181433 Patch The problem is that we are clearing the resource before continuing loading from the substitute data, which cancels the load. 801041 9 rniwa 2013-01-05 23:10:24 -0800 Apparently we can also get a timeout. http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r138916%20(5487)/http/tests/appcache/main-resource-redirect-pretty-diff.html 801358 10 ap 2013-01-07 09:58:33 -0800 Nate, Brady, who should review this? 801367 11 181433 japhet 2013-01-07 10:08:42 -0800 Comment on attachment 181433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181433&action=review This presumably should remove main-resource-redirect.html from the relevant TestExpectations files. > Source/WebCore/loader/MainResourceLoader.cpp:151 > + if (m_resource) { > + m_resource->setLoading(false); > + m_resource->stopLoading(); > + } > +} This is better than anything I've come up with in that it actually works, but it's still pretty hacky. I guess it's ok, though. 802123 12 181668 cgarcia 2013-01-08 01:02:05 -0800 Created attachment 181668 Unskip the test Updated patch to unskip the test 802171 13 181668 buildbot 2013-01-08 02:45:37 -0800 Comment on attachment 181668 Unskip the test Attachment 181668 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15763049 New failing tests: http/tests/appcache/manifest-containing-itself.html 802185 14 181668 buildbot 2013-01-08 03:14:55 -0800 Comment on attachment 181668 Unskip the test Attachment 181668 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15757070 New failing tests: http/tests/appcache/manifest-containing-itself.html 802485 15 181725 japhet 2013-01-08 12:14:44 -0800 Created attachment 181725 Fix by preventing ResourceLoader from sending callbacks The previous fix doesn't work because CachedResource::stopLoading() doesn't actually kill stop the ResourceLoader (renaming it is on my list of things to do). It appears we can get the right behavior by temporarily suppressing resource load callbacks, which will prevent WebFrameLoaderClient from receiving 2 end-of-load callbacks. 802785 16 181725 ap 2013-01-08 16:27:22 -0800 Comment on attachment 181725 Fix by preventing ResourceLoader from sending callbacks View in context: https://bugs.webkit.org/attachment.cgi?id=181725&action=review > Source/WebCore/loader/MainResourceLoader.cpp:185 > + // We need to remove our reference to the CachedResource (which will probably cancel its underlying ResourceLoader) Why is the cancellation just "probable"? If the load is not canceled now, will it be canceled later, outside the temporary DoNotSendCallbacks mode? > Source/WebCore/loader/MainResourceLoader.cpp:192 > + if (resourceLoader) > + resourceLoader->setSendCallbackPolicy(DoNotSendCallbacks); > clearResource(); > + resourceLoader->setSendCallbackPolicy(SendCallbacks); It looks wrong to have a null check the first time we dereference resourceLoader, but not the second time. If it's actually possible to not have a resourceLoader here, please add a regression test for this case. Also, is this expected to reset policy to original value? Can we assert that SendCallbacks is actually the original value? > Source/WebCore/ChangeLog:14 > + (WebCore::ResourceLoader::sendCallbackPolicy): Renamed from shouldSendResourceLoadCallbacks(), returns an enum value instead of a bool. I'm not sure why this is an improvement. A boolean gives the needed answer more directly, as evidenced by how you had to modify the call site. 802791 17 japhet 2013-01-08 16:32:01 -0800 (In reply to comment #16) > (From update of attachment 181725 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181725&action=review > > > Source/WebCore/loader/MainResourceLoader.cpp:185 > > + // We need to remove our reference to the CachedResource (which will probably cancel its underlying ResourceLoader) > > Why is the cancellation just "probable"? If the load is not canceled now, will it be canceled later, outside the temporary DoNotSendCallbacks mode? There is a tiny chance that multiple iframes will be loading the same src at the same exact time. In that case, the CachedResource will have multiple clients, so calling clearResource() won't actually trigger a cancellation of the ResourceLoader via CachedRawResource::cancelIfNotFinishing(). > > > Source/WebCore/loader/MainResourceLoader.cpp:192 > > + if (resourceLoader) > > + resourceLoader->setSendCallbackPolicy(DoNotSendCallbacks); > > clearResource(); > > + resourceLoader->setSendCallbackPolicy(SendCallbacks); > > It looks wrong to have a null check the first time we dereference resourceLoader, but not the second time. If it's actually possible to not have a resourceLoader here, please add a regression test for this case. Doh, will fix. > > Also, is this expected to reset policy to original value? Can we assert that SendCallbacks is actually the original value? Will do. > > > Source/WebCore/ChangeLog:14 > > + (WebCore::ResourceLoader::sendCallbackPolicy): Renamed from shouldSendResourceLoadCallbacks(), returns an enum value instead of a bool. > > I'm not sure why this is an improvement. A boolean gives the needed answer more directly, as evidenced by how you had to modify the call site. I was thinking that this was canonicalizing things, based on some feedback on a review a couple weeks ago. I'm totally fine with removing it. 802797 18 ap 2013-01-08 16:39:12 -0800 > There is a tiny chance that multiple iframes will be loading the same src at the same exact time. In that case, the CachedResource will have multiple clients, so calling clearResource() won't actually trigger a cancellation of the ResourceLoader via CachedRawResource::cancelIfNotFinishing(). This is probably worth explaining in a comment more directly. As well as how the switch to substitute data will happen in this case. There is a risk associated with such detailed comments, as they tend to become wrong and misleading very quickly. But a "probably" clause in a comment is quite annoying, too. 802806 19 181802 japhet 2013-01-08 16:47:27 -0800 Created attachment 181802 Address ap's comments 802819 20 181802 ap 2013-01-08 16:57:02 -0800 Comment on attachment 181802 Address ap's comments View in context: https://bugs.webkit.org/attachment.cgi?id=181802&action=review > Source/WebCore/loader/MainResourceLoader.cpp:193 > + if (resourceLoader) I asked Nate on IRC, and he doesn't know if this can actually happen in practice. It's very confusing to have unnecessary null checks just in case, but given the urgency, I guess I can grudgingly say r=me. > Source/WebCore/loader/ResourceLoader.h:143 > + void setSendCallbackPolicy(SendCallbackPolicy sendLoadCallbacks) { m_options.sendLoadCallbacks = sendLoadCallbacks; } Extra space before '{'. 802827 21 181808 japhet 2013-01-08 17:04:01 -0800 Created attachment 181808 Patch for landing 802914 22 181808 webkit.review.bot 2013-01-08 19:32:04 -0800 Comment on attachment 181808 Patch for landing Clearing flags on attachment: 181808 Committed r139150: <http://trac.webkit.org/changeset/139150> 802915 23 webkit.review.bot 2013-01-08 19:32:10 -0800 All reviewed patches have been landed. Closing bug. 181433 2013-01-05 02:57:53 -0800 2013-01-08 01:02:05 -0800 Patch wcore-loader-assertion.diff text/plain 2994 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYjM0Y2E1Li5mNjAyNWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzODIyMj8pOiBbTWFjIFdLMV0gaHR0cC90ZXN0cy9h cHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgYXNzZXJ0cyBpbiBXZWJGcmFtZUxv YWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGaW5pc2hMb2FkaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYxMjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGxvYWRpbmcgc3Vic3RpdHV0ZSBkYXRh IGR1ZSB0byBhIHJlZGlyZWN0aW9uLCB0aGUgaW5pdGlhbAorICAgICAgICBjYWNoZWQgcmVzb3Vy Y2UgaXMgY2xlYXJlZCB0cmlnZ2VyaW5nIGEgY2FuY2VsbGF0aW9uLiBUaGlzIHBhdGNoCisgICAg ICAgIGhhbmRsZXMgdGhpcyBjYXNlIGJ5IHN0b3BwaW5nIHRoZSByZXNvdXJjZSBsb2FkIHdpdGhv dXQgbm90aWZ5aW5nCisgICAgICAgIHRoZSBsb2FkZXIgY2xpZW50IGJlZm9yZSBjb250aW51aW5n IHRoZSBsb2FkIGZyb20gdGhlIHN1YnN0aXR1dGUKKyAgICAgICAgZGF0YS4KKworICAgICAgICBG aXhlcyBjcmFzaCBpbiB0ZXN0IGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRp cmVjdC5odG1sLgorCisgICAgICAgICogbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNYWluUmVzb3VyY2VMb2FkZXI6OnN0b3BSZXNvdXJjZUxvYWRGb3JS ZWRpcmVjdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNYWluUmVzb3VyY2VMb2FkZXI6OmNvbnRp bnVlQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5KToKKyAgICAgICAgKiBsb2FkZXIvTWFpblJlc291cmNl TG9hZGVyLmg6CisgICAgICAgIChNYWluUmVzb3VyY2VMb2FkZXIpOgorCiAyMDEzLTAxLTA0ICBI YW5zIE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9u c10gVGhlIEV4Y2x1c2lvblBvbHlnb24gY2xhc3NlcyBzaG91bGQgYWxsb3cgbW9yZSB0aGFuIG9u ZSB0eXBlIG9mICJFZGdlIiBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L01haW5SZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291 cmNlTG9hZGVyLmNwcAppbmRleCA5ZTA2MTFlLi5iMzRkYTZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcApAQCAtMTM5LDYgKzEzOSwxNyBAQCB2b2lk IE1haW5SZXNvdXJjZUxvYWRlcjo6Y2FuY2VsKGNvbnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQog I2VuZGlmCiB9CiAKK3ZvaWQgTWFpblJlc291cmNlTG9hZGVyOjpzdG9wUmVzb3VyY2VMb2FkRm9y UmVkaXJlY3Rpb24oKQoreworICAgIC8vIEluIGNhc2Ugb2YgcmVkaXJlY3Rpb24sIHdlIHdhbnQg dG8gc3RvcCB0aGUgY3VycmVudCBsb2FkLAorICAgIC8vIHdpdGhvdXQgbm90aWZ5aW5nIHRoZSBs b2FkZXIgY2xpZW50LCBiZWNhdXNlIHRoZSBsb2FkIHdpbGwKKyAgICAvLyBjb250aW51ZSBmcm9t IHN1YnN0aXR1dGUgZGF0YS4KKyAgICBpZiAobV9yZXNvdXJjZSkgeworICAgICAgICBtX3Jlc291 cmNlLT5zZXRMb2FkaW5nKGZhbHNlKTsKKyAgICAgICAgbV9yZXNvdXJjZS0+c3RvcExvYWRpbmco KTsKKyAgICB9Cit9CisKIHZvaWQgTWFpblJlc291cmNlTG9hZGVyOjpjbGVhclJlc291cmNlKCkK IHsKICAgICBpZiAobV9yZXNvdXJjZSkgewpAQCAtMTgxLDYgKzE5Miw5IEBAIHZvaWQgTWFpblJl c291cmNlTG9hZGVyOjpjb250aW51ZUFmdGVyTmF2aWdhdGlvblBvbGljeShjb25zdCBSZXNvdXJj ZVJlcXVlc3QmIHJlCiAgICAgZWxzZSBpZiAobV9zdWJzdGl0dXRlRGF0YS5pc1ZhbGlkKCkpIHsK ICAgICAgICAgLy8gQSByZWRpcmVjdCByZXN1bHRlZCBpbiBsb2FkaW5nIHN1YnN0aXR1dGUgZGF0 YS4KICAgICAgICAgQVNTRVJUKGRvY3VtZW50TG9hZGVyKCktPnRpbWluZygpLT5yZWRpcmVjdENv dW50KCkpOworCisgICAgICAgIC8vIFN0b3AgdGhlIGxvYWQgYmVmb3JlIGNsZWFyaW5nIHRoZSBy ZXNvdXJjZSBzbyB0aGF0IHRoZSBsb2FkIGlzIG5vdCBjYW5jZWxsZWQuCisgICAgICAgIHN0b3BS ZXNvdXJjZUxvYWRGb3JSZWRpcmVjdGlvbigpOwogICAgICAgICBjbGVhclJlc291cmNlKCk7CiAg ICAgICAgIGhhbmRsZVN1YnN0aXR1dGVEYXRhTG9hZFNvb24ocmVxdWVzdCk7CiAgICAgfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5oIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5oCmluZGV4IDVlN2ZkNTUuLmMw ZjAzMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2Fk ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmgKQEAg LTExMiw2ICsxMTIsNyBAQCBwcml2YXRlOgogICAgIERvY3VtZW50TG9hZGVyKiBkb2N1bWVudExv YWRlcigpIGNvbnN0IHsgcmV0dXJuIG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCk7IH0KIAogICAgIGNv bnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCgpIGNvbnN0OworICAgIHZvaWQgc3RvcFJlc291 cmNlTG9hZEZvclJlZGlyZWN0aW9uKCk7CiAgICAgdm9pZCBjbGVhclJlc291cmNlKCk7CiAKICAg ICBib29sIGRlZmVyc0xvYWRpbmcoKSBjb25zdDsK 181668 2013-01-08 01:02:05 -0800 2013-01-08 17:03:47 -0800 Unskip the test wcore-loader-crash.diff text/plain 5260 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2Y2RjYTI0Li41MDlmY2NmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDEt MDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjEzODIyMj8pOiBbTWFjIFdLMV0gaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWlu LXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgYXNzZXJ0cyBpbiBXZWJGcmFtZUxvYWRlckNsaWVudDo6 ZGlzcGF0Y2hEaWRGaW5pc2hMb2FkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDYxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVbnNraXAgaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNl LXJlZGlyZWN0Lmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMt MDEtMDggIFl1a2kgU2VraWd1Y2hpICA8eXVraS5zZWtpZ3VjaGlAYWNjZXNzLWNvbXBhbnkuY29t PgogCiAgICAgICAgIEZsb2F0IGJsb2NrJ3MgbG9naWNhbCB0b3AgbWFyZ2luIGlzIGlsbGVnYWwg aW4gdmVydGljYWwgd3JpdGluZyBtb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDUzYWViNWMuLjE2MDA2NmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMy0wMS0wOCAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM4MjIy Pyk6IFtNYWMgV0sxXSBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3Qu aHRtbCBhc3NlcnRzIGluIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZEZpbmlzaExv YWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjEyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gbG9hZGluZyBzdWJzdGl0dXRlIGRhdGEgZHVlIHRvIGEgcmVkaXJlY3Rpb24sIHRoZSBpbml0 aWFsCisgICAgICAgIGNhY2hlZCByZXNvdXJjZSBpcyBjbGVhcmVkIHRyaWdnZXJpbmcgYSBjYW5j ZWxsYXRpb24uIFRoaXMgcGF0Y2gKKyAgICAgICAgaGFuZGxlcyB0aGlzIGNhc2UgYnkgc3RvcHBp bmcgdGhlIHJlc291cmNlIGxvYWQgd2l0aG91dCBub3RpZnlpbmcKKyAgICAgICAgdGhlIGxvYWRl ciBjbGllbnQgYmVmb3JlIGNvbnRpbnVpbmcgdGhlIGxvYWQgZnJvbSB0aGUgc3Vic3RpdHV0ZQor ICAgICAgICBkYXRhLgorCisgICAgICAgIEZpeGVzIGNyYXNoIGluIHRlc3QgaHR0cC90ZXN0cy9h cHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwuCisKKyAgICAgICAgKiBsb2FkZXIv TWFpblJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1haW5SZXNvdXJjZUxv YWRlcjo6c3RvcFJlc291cmNlTG9hZEZvclJlZGlyZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6 Ok1haW5SZXNvdXJjZUxvYWRlcjo6Y29udGludWVBZnRlck5hdmlnYXRpb25Qb2xpY3kpOgorICAg ICAgICAqIGxvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuaDoKKyAgICAgICAgKE1haW5SZXNvdXJj ZUxvYWRlcik6CisKIDIwMTMtMDEtMDggIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTM5MDM2KTogJ1dlYkNvcmU6OkRhdGVUaW1l U3ltYm9saWNGaWVsZEVsZW1lbnQ6OmlzSW5SYW5nZScgaGlkZXMgb3ZlcmxvYWRlZCB2aXJ0dWFs IGZ1bmN0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggOWQ3MDkyNy4uN2I1OWRmYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjk1LDggKzI5NSw2IEBAIHdlYmtpdC5vcmcvYi8x MDU5OTggWyBNb3VudGFpbkxpb24gRGVidWcgXSBmYXN0L2Nzcy9zdGlja3kvc3RpY2t5LWJvdGgt c2lkZXMuaHRtCiAKIHdlYmtpdC5vcmcvYi85MzU1MiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0 aW9uLXN1Y2Nlc3MuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTA2MTIzIGh0dHAv dGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIFsgUGFzcyBdCi0KIHdl YmtpdC5vcmcvYi8xMDYxODcgcGxhdGZvcm0vbWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvYWJzb2x1 dGUtaW5zaWRlLW91dC1vZi12aWV3LWZpeGVkLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi8xMDYxODcgcGxhdGZvcm0vbWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvZm91ci1iYXJzLXpvb21l ZC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MTg3IHBsYXRmb3JtL21hYy90aWxl ZC1kcmF3aW5nL2ZpeGVkL25lZ2F0aXZlLXNjcm9sbC1vZmZzZXQuaHRtbCBbIEZhaWx1cmUgXQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhNDUxNDQ1Li44 YzE2MTg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAt MTI3Nyw4ICsxMjc3LDYgQEAgd2Via2l0Lm9yZy9iLzEwNjA2NCBmYXN0L2lubGluZS9jb250aW51 YXRpb24tb3V0bGluZXMtd2l0aC1sYXllcnMuaHRtbCBbIEZhaWx1cmUKIAogd2Via2l0Lm9yZy9i LzEwNjA3NSBbIERlYnVnIF0gZmFzdC9yZWdpb25zL2Z1bGwtc2NyZWVuLXZpZGVvLWZyb20tcmVn aW9uLmh0bWwgWyBDcmFzaCBdCiAKLXdlYmtpdC5vcmcvYi8xMDYxMjMgaHR0cC90ZXN0cy9hcHBj YWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgWyBDcmFzaCBdCi0KIHdlYmtpdC5vcmcv Yi8xMDYxNTEgWyBMaW9uIF0gaHR0cC90ZXN0cy9taXNjL2xpbmstcmVsLWljb24tYmVmb3JlbG9h ZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEwNjE4NSBmYXN0L2ZyYW1l cy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLWZpeGVkLWhlaWdodC5odG1sIFsgUGFzcyBG YWlsdXJlIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VM b2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAK aW5kZXggOWExZDY2Yi4uZmM4ZDI1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L01haW5SZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5S ZXNvdXJjZUxvYWRlci5jcHAKQEAgLTEzOSw2ICsxMzksMTcgQEAgdm9pZCBNYWluUmVzb3VyY2VM b2FkZXI6OmNhbmNlbChjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvcikKICNlbmRpZgogfQogCit2 b2lkIE1haW5SZXNvdXJjZUxvYWRlcjo6c3RvcFJlc291cmNlTG9hZEZvclJlZGlyZWN0aW9uKCkK K3sKKyAgICAvLyBJbiBjYXNlIG9mIHJlZGlyZWN0aW9uLCB3ZSB3YW50IHRvIHN0b3AgdGhlIGN1 cnJlbnQgbG9hZCwKKyAgICAvLyB3aXRob3V0IG5vdGlmeWluZyB0aGUgbG9hZGVyIGNsaWVudCwg YmVjYXVzZSB0aGUgbG9hZCB3aWxsCisgICAgLy8gY29udGludWUgZnJvbSBzdWJzdGl0dXRlIGRh dGEuCisgICAgaWYgKG1fcmVzb3VyY2UpIHsKKyAgICAgICAgbV9yZXNvdXJjZS0+c2V0TG9hZGlu ZyhmYWxzZSk7CisgICAgICAgIG1fcmVzb3VyY2UtPnN0b3BMb2FkaW5nKCk7CisgICAgfQorfQor CiB2b2lkIE1haW5SZXNvdXJjZUxvYWRlcjo6Y2xlYXJSZXNvdXJjZSgpCiB7CiAgICAgaWYgKG1f cmVzb3VyY2UpIHsKQEAgLTE4MSw2ICsxOTIsOSBAQCB2b2lkIE1haW5SZXNvdXJjZUxvYWRlcjo6 Y29udGludWVBZnRlck5hdmlnYXRpb25Qb2xpY3koY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZQog ICAgIGVsc2UgaWYgKG1fc3Vic3RpdHV0ZURhdGEuaXNWYWxpZCgpKSB7CiAgICAgICAgIC8vIEEg cmVkaXJlY3QgcmVzdWx0ZWQgaW4gbG9hZGluZyBzdWJzdGl0dXRlIGRhdGEuCiAgICAgICAgIEFT U0VSVChkb2N1bWVudExvYWRlcigpLT50aW1pbmcoKS0+cmVkaXJlY3RDb3VudCgpKTsKKworICAg ICAgICAvLyBTdG9wIHRoZSBsb2FkIGJlZm9yZSBjbGVhcmluZyB0aGUgcmVzb3VyY2Ugc28gdGhh dCB0aGUgbG9hZCBpcyBub3QgY2FuY2VsbGVkLgorICAgICAgICBzdG9wUmVzb3VyY2VMb2FkRm9y UmVkaXJlY3Rpb24oKTsKICAgICAgICAgY2xlYXJSZXNvdXJjZSgpOwogICAgICAgICBoYW5kbGVT dWJzdGl0dXRlRGF0YUxvYWRTb29uKHJlcXVlc3QpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9NYWluUmVzb3VyY2VMb2FkZXIuaAppbmRleCA1ZTdmZDU1Li5jMGYwMzA0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5oCkBAIC0xMTIsNiArMTEyLDcg QEAgcHJpdmF0ZToKICAgICBEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIoKSBjb25zdCB7 IHJldHVybiBtX2RvY3VtZW50TG9hZGVyLmdldCgpOyB9CiAKICAgICBjb25zdCBSZXNvdXJjZVJl cXVlc3QmIHJlcXVlc3QoKSBjb25zdDsKKyAgICB2b2lkIHN0b3BSZXNvdXJjZUxvYWRGb3JSZWRp cmVjdGlvbigpOwogICAgIHZvaWQgY2xlYXJSZXNvdXJjZSgpOwogCiAgICAgYm9vbCBkZWZlcnNM b2FkaW5nKCkgY29uc3Q7Cg== 181725 2013-01-08 12:14:44 -0800 2013-01-08 16:47:27 -0800 Fix by preventing ResourceLoader from sending callbacks mrr.txt text/plain 5971 japhet SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lv biAxMzkwNjMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwko d29ya2luZyBjb3B5KQpAQCAtMTI3NCw4ICsxMjc0LDYgQEAKIAogd2Via2l0Lm9yZy9iLzEwNjA3 NSBbIERlYnVnIF0gZmFzdC9yZWdpb25zL2Z1bGwtc2NyZWVuLXZpZGVvLWZyb20tcmVnaW9uLmh0 bWwgWyBDcmFzaCBdCiAKLXdlYmtpdC5vcmcvYi8xMDYxMjMgaHR0cC90ZXN0cy9hcHBjYWNoZS9t YWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgWyBDcmFzaCBdCi0KIHdlYmtpdC5vcmcvYi8xMDYx NTEgWyBMaW9uIF0gaHR0cC90ZXN0cy9taXNjL2xpbmstcmVsLWljb24tYmVmb3JlbG9hZC5odG1s IFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEwNjE4NSBmYXN0L2ZyYW1lcy9mbGF0 dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLWZpeGVkLWhlaWdodC5odG1sIFsgUGFzcyBGYWlsdXJl IF0KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMJKHJldmlzaW9uIDEzOTA2MykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVz dEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjk1LDggKzI5NSw2IEBACiAKIHdlYmtp dC5vcmcvYi85MzU1MiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3MuaHRtbCBb IEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTA2MTIzIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFp bi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIFsgUGFzcyBdCi0KIHdlYmtpdC5vcmcvYi8xMDYxODcg cGxhdGZvcm0vbWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvYWJzb2x1dGUtaW5zaWRlLW91dC1vZi12 aWV3LWZpeGVkLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDYxODcgcGxhdGZvcm0v bWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvZm91ci1iYXJzLXpvb21lZC5odG1sIFsgRmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMTA2MTg3IHBsYXRmb3JtL21hYy90aWxlZC1kcmF3aW5nL2ZpeGVkL25l Z2F0aXZlLXNjcm9sbC1vZmZzZXQuaHRtbCBbIEZhaWx1cmUgXQpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MTM5MDkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTMtMDEtMDggIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OKHIxMzgyMjI/KTogW01hYyBXSzFdIGh0dHAvdGVzdHMvYXBw Y2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIGFzc2VydHMgaW4gV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OmRpc3BhdGNoRGlkRmluaXNoTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6IG1haW4tcmVz b3VyY2UtcmVkaXJlY3QuaHRtbCBpcyBubyBsb25nZXIgY3Jhc2hpbmcuCisKIDIwMTMtMDEtMDgg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICB0ZXh0IGNvbnRyb2xz IGFyZSBzaXplZCB0b28gc21hbGwgd2hlbiBhIHBlcmNlbnRhZ2UgaGVpZ2h0IGlzIHNldApJbmRl eDogU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lv biAxMzkwNjMpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsNyArMjIzLDcgQEAKICAgICBhZGREYXRhKGRhdGEsIGxl bmd0aCwgYWxsQXRPbmNlKTsKICAgICBpZiAoIW1fbG9hZGluZ011bHRpcGFydENvbnRlbnQpCiAg ICAgICAgIHNlbmREYXRhVG9SZXNvdXJjZShkYXRhLCBsZW5ndGgpOwotICAgIGlmIChzaG91bGRT ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCkgJiYgbV9mcmFtZSkKKyAgICBpZiAoc2VuZENhbGxi YWNrUG9saWN5KCkgPT0gU2VuZENhbGxiYWNrcyAmJiBtX2ZyYW1lKQogICAgICAgICBmcmFtZUxv YWRlcigpLT5ub3RpZmllcigpLT5kaWRSZWNlaXZlRGF0YSh0aGlzLCBkYXRhLCBsZW5ndGgsIHN0 YXRpY19jYXN0PGludD4oZW5jb2RlZERhdGFMZW5ndGgpKTsKIH0KIApJbmRleDogU291cmNlL1dl YkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmgJKHJldmlzaW9uIDEzOTA2MykKKysrIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzksNyAr MTM5LDggQEAKIAogICAgIGNvbnN0IEtVUkwmIHVybCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVxdWVz dC51cmwoKTsgfSAKICAgICBSZXNvdXJjZUhhbmRsZSogaGFuZGxlKCkgY29uc3QgeyByZXR1cm4g bV9oYW5kbGUuZ2V0KCk7IH0KLSAgICBib29sIHNob3VsZFNlbmRSZXNvdXJjZUxvYWRDYWxsYmFj a3MoKSBjb25zdCB7IHJldHVybiBtX29wdGlvbnMuc2VuZExvYWRDYWxsYmFja3MgPT0gU2VuZENh bGxiYWNrczsgfQorICAgIFNlbmRDYWxsYmFja1BvbGljeSBzZW5kQ2FsbGJhY2tQb2xpY3koKSBj b25zdCB7IHJldHVybiBtX29wdGlvbnMuc2VuZExvYWRDYWxsYmFja3M7IH0KKyAgICB2b2lkIHNl dFNlbmRDYWxsYmFja1BvbGljeShTZW5kQ2FsbGJhY2tQb2xpY3kgc2VuZExvYWRDYWxsYmFja3Mp ICB7IG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyA9IHNlbmRMb2FkQ2FsbGJhY2tzOyB9CiAg ICAgYm9vbCBzaG91bGRTbmlmZkNvbnRlbnQoKSBjb25zdCB7IHJldHVybiBtX29wdGlvbnMuc25p ZmZDb250ZW50ID09IFNuaWZmQ29udGVudDsgfQogCiAgICAgYm9vbCByZWFjaGVkVGVybWluYWxT dGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVhY2hlZFRlcm1pbmFsU3RhdGU7IH0KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAx MzkwNjMpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTgxLDcgKzE4MSwxNSBAQAogICAgIGVsc2UgaWYgKG1fc3Vic3Rp dHV0ZURhdGEuaXNWYWxpZCgpKSB7CiAgICAgICAgIC8vIEEgcmVkaXJlY3QgcmVzdWx0ZWQgaW4g bG9hZGluZyBzdWJzdGl0dXRlIGRhdGEuCiAgICAgICAgIEFTU0VSVChkb2N1bWVudExvYWRlcigp LT50aW1pbmcoKS0+cmVkaXJlY3RDb3VudCgpKTsKKworICAgICAgICAvLyBXZSBuZWVkIHRvIHJl bW92ZSBvdXIgcmVmZXJlbmNlIHRvIHRoZSBDYWNoZWRSZXNvdXJjZSAod2hpY2ggd2lsbCBwcm9i YWJseSBjYW5jZWwgaXRzIHVuZGVybHlpbmcgUmVzb3VyY2VMb2FkZXIpCisgICAgICAgIC8vIGlu IGZhdm9yIG9mIGEgU3Vic3RpdHV0ZURhdGEgbG9hZC4gSG93ZXZlciwgZnJvbSBhbiBBUEkgcGVy c3BlY3RpdmUsIHRoaXMgaXNuJ3QgYSBjYW5jZWxsYXRpb24uCisgICAgICAgIC8vIFRoZXJlZm9y ZSwgY2FsbCBjbGVhclJlc291cmNlKCksIGJ1dCBwcmV2ZW50IHRoZSBSZXNvdXJjZUxvYWRlciBm cm9tIHNlbmRpbmcgUmVzb3VyY2VMb2FkTm90aWZpZXIgY2FsbGJhY2tzLgorICAgICAgICBSZWZQ dHI8UmVzb3VyY2VMb2FkZXI+IHJlc291cmNlTG9hZGVyID0gbG9hZGVyKCk7CisgICAgICAgIGlm IChyZXNvdXJjZUxvYWRlcikKKyAgICAgICAgICAgIHJlc291cmNlTG9hZGVyLT5zZXRTZW5kQ2Fs bGJhY2tQb2xpY3koRG9Ob3RTZW5kQ2FsbGJhY2tzKTsKICAgICAgICAgY2xlYXJSZXNvdXJjZSgp OworICAgICAgICByZXNvdXJjZUxvYWRlci0+c2V0U2VuZENhbGxiYWNrUG9saWN5KFNlbmRDYWxs YmFja3MpOwogICAgICAgICBoYW5kbGVTdWJzdGl0dXRlRGF0YUxvYWRTb29uKHJlcXVlc3QpOwog ICAgIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM5MDkxKQorKysgU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMDEtMDgg IE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O KHIxMzgyMjI/KTogW01hYyBXSzFdIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1y ZWRpcmVjdC5odG1sIGFzc2VydHMgaW4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlk RmluaXNoTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA2MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBmaXhpbmcgYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAq IGxvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFpblJl c291cmNlTG9hZGVyOjpjb250aW51ZUFmdGVyTmF2aWdhdGlvblBvbGljeSk6IEJlZm9yZSBjYWxs aW5nIG1fcmVzb3VyY2UtPnJlbW92ZUNsaWVudCh0aGlzKQorICAgICAgICAgICAgYW5kIHBvdGVu dGlhbGx5IGNhbmNlbGluZyB0aGUgUmVzb3VyY2VMb2FkZXIsIGVuc3VyZSBpdCB3b24ndCBzZW5k IHJlc291cmNlIGxvYWQgY2FsbGJhY2tzLgorICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRl ci5oOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OnNlbmRDYWxsYmFja1BvbGlj eSk6IFJlbmFtZWQgZnJvbSBzaG91bGRTZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCksIHJldHVy bnMgYW4gZW51bSB2YWx1ZSBpbnN0ZWFkIG9mIGEgYm9vbC4KKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlTG9hZGVyOjpzZXRTZW5kQ2FsbGJhY2tQb2xpY3kpOgorICAgICAgICAqIGxvYWRlci9T dWJyZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxvYWRl cjo6ZGlkUmVjZWl2ZURhdGEpOgorCiAyMDEzLTAxLTA4ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVp emFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IG5hdGl2ZSBwb3B1cCBidXR0b25zIHNob3Vs ZCBub3QgdXNlIHRleHRVbmRlckVsZW1lbnQgZm9yIHRoZWlyIHRpdGxlCg== 181802 2013-01-08 16:47:27 -0800 2013-01-08 17:03:51 -0800 Address ap's comments mrr2.txt text/plain 5484 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCShy ZXZpc2lvbiAxMzkxMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9h ZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgxLDcgKzE4MSwyMCBAQAogICAgIGVsc2UgaWYg KG1fc3Vic3RpdHV0ZURhdGEuaXNWYWxpZCgpKSB7CiAgICAgICAgIC8vIEEgcmVkaXJlY3QgcmVz dWx0ZWQgaW4gbG9hZGluZyBzdWJzdGl0dXRlIGRhdGEuCiAgICAgICAgIEFTU0VSVChkb2N1bWVu dExvYWRlcigpLT50aW1pbmcoKS0+cmVkaXJlY3RDb3VudCgpKTsKKworICAgICAgICAvLyBXZSBu ZWVkIHRvIHJlbW92ZSBvdXIgcmVmZXJlbmNlIHRvIHRoZSBDYWNoZWRSZXNvdXJjZSBpbiBmYXZv ciBvZiBhIFN1YnN0aXR1dGVEYXRhIGxvYWQuCisgICAgICAgIC8vIFRoaXMgd2lsbCBwcm9iYWJs eSB0cmlnZ2VyIHRoZSBjYW5jZWxsYXRpb24gb2YgdGhlIENhY2hlZFJlc291cmNlJ3MgdW5kZXJs eWluZyBSZXNvdXJjZUxvYWRlciwgdGhvdWdoIHRoZXJlIGlzIGEKKyAgICAgICAgLy8gc21hbGwg Y2hhbmNlIHRoYXQgdGhlIHJlc291cmNlIGlzIGJlaW5nIGxvYWRlZCBieSBhIGRpZmZlcmVudCBG cmFtZSwgcHJldmVudGluZyB0aGUgUmVzb3VyY2VMb2FkZXIgZnJvbSBiZWluZyBjYW5jZWxsZWQu CisgICAgICAgIC8vIElmIHRoZSBSZXNvdXJjZUxvYWRlciBpcyBpbmRlZWQgY2FuY2VsbGVkLCBp dCB3b3VsZCBub3JtYWxseSBzZW5kIHJlc291cmNlIGxvYWQgY2FsbGJhY2tzLgorICAgICAgICAv LyBIb3dldmVyLCBmcm9tIGFuIEFQSSBwZXJzcGVjdGl2ZSwgdGhpcyBpc24ndCBhIGNhbmNlbGxh dGlvbi4gVGhlcmVmb3JlLCBzZXZlciBvdXIgcmVsYXRpb25zaGlwIHdpdGggdGhlIG5ldHdvcmsg bG9hZCB2aWEgY2xlYXJSZXNvdXJjZSgpLAorICAgICAgICAvLyBidXQgcHJldmVudCB0aGUgUmVz b3VyY2VMb2FkZXIgZnJvbSBzZW5kaW5nIFJlc291cmNlTG9hZE5vdGlmaWVyIGNhbGxiYWNrcy4K KyAgICAgICAgUmVmUHRyPFJlc291cmNlTG9hZGVyPiByZXNvdXJjZUxvYWRlciA9IGxvYWRlcigp OworICAgICAgICBBU1NFUlQoIXJlc291cmNlTG9hZGVyIHx8IHJlc291cmNlTG9hZGVyLT5zaG91 bGRTZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCkpOworICAgICAgICBpZiAocmVzb3VyY2VMb2Fk ZXIpCisgICAgICAgICAgICByZXNvdXJjZUxvYWRlci0+c2V0U2VuZENhbGxiYWNrUG9saWN5KERv Tm90U2VuZENhbGxiYWNrcyk7CiAgICAgICAgIGNsZWFyUmVzb3VyY2UoKTsKKyAgICAgICAgaWYg KHJlc291cmNlTG9hZGVyKQorICAgICAgICAgICAgcmVzb3VyY2VMb2FkZXItPnNldFNlbmRDYWxs YmFja1BvbGljeShTZW5kQ2FsbGJhY2tzKTsKICAgICAgICAgaGFuZGxlU3Vic3RpdHV0ZURhdGFM b2FkU29vbihyZXF1ZXN0KTsKICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9S ZXNvdXJjZUxvYWRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNv dXJjZUxvYWRlci5oCShyZXZpc2lvbiAxMzkxMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTQwLDYgKzE0MCw3IEBACiAgICAg Y29uc3QgS1VSTCYgdXJsKCkgY29uc3QgeyByZXR1cm4gbV9yZXF1ZXN0LnVybCgpOyB9IAogICAg IFJlc291cmNlSGFuZGxlKiBoYW5kbGUoKSBjb25zdCB7IHJldHVybiBtX2hhbmRsZS5nZXQoKTsg fQogICAgIGJvb2wgc2hvdWxkU2VuZFJlc291cmNlTG9hZENhbGxiYWNrcygpIGNvbnN0IHsgcmV0 dXJuIG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyA9PSBTZW5kQ2FsbGJhY2tzOyB9CisgICAg dm9pZCBzZXRTZW5kQ2FsbGJhY2tQb2xpY3koU2VuZENhbGxiYWNrUG9saWN5IHNlbmRMb2FkQ2Fs bGJhY2tzKSAgeyBtX29wdGlvbnMuc2VuZExvYWRDYWxsYmFja3MgPSBzZW5kTG9hZENhbGxiYWNr czsgfQogICAgIGJvb2wgc2hvdWxkU25pZmZDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV9vcHRp b25zLnNuaWZmQ29udGVudCA9PSBTbmlmZkNvbnRlbnQ7IH0KIAogICAgIGJvb2wgcmVhY2hlZFRl cm1pbmFsU3RhdGUoKSBjb25zdCB7IHJldHVybiBtX3JlYWNoZWRUZXJtaW5hbFN0YXRlOyB9Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzkxMzEpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMS0wOCAgTmF0ZSBDaGFw aW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzODIyMj8p OiBbTWFjIFdLMV0gaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0 bWwgYXNzZXJ0cyBpbiBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGaW5pc2hMb2Fk aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYx MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIGZpeGluZyBhbiBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogbG9hZGVyL01h aW5SZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNYWluUmVzb3VyY2VMb2Fk ZXI6OmNvbnRpbnVlQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5KTogQmVmb3JlIGNhbGxpbmcgbV9yZXNv dXJjZS0+cmVtb3ZlQ2xpZW50KHRoaXMpCisgICAgICAgICAgICBhbmQgcG90ZW50aWFsbHkgY2Fu Y2VsaW5nIHRoZSBSZXNvdXJjZUxvYWRlciwgZW5zdXJlIGl0IHdvbid0IHNlbmQgcmVzb3VyY2Ug bG9hZCBjYWxsYmFja3MuCisgICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZGVyLmg6CisgICAg ICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcjo6c2V0U2VuZENhbGxiYWNrUG9saWN5KToKKwog MjAxMy0wMS0wOCAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAg ICAgW1NoYWRvdyBET01dIERpc3RyaWJ1dGlvbiByZWxhdGVkIGNvZGUgb24gU2hhZG93Um9vdCBz aG91bGQgYmUgbWluaW1pemVkLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9U ZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13 azIvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTM5MTExKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsOCAr Mjk1LDYgQEAKIAogd2Via2l0Lm9yZy9iLzkzNTUyIGluc3BlY3Rvci9kZXZpY2Utb3JpZW50YXRp b24tc3VjY2Vzcy5odG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xMDYxMjMgaHR0cC90 ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgWyBQYXNzIF0KLQogd2Vi a2l0Lm9yZy9iLzEwNjE4NyBwbGF0Zm9ybS9tYWMvdGlsZWQtZHJhd2luZy9maXhlZC9hYnNvbHV0 ZS1pbnNpZGUtb3V0LW9mLXZpZXctZml4ZWQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9i LzEwNjE4NyBwbGF0Zm9ybS9tYWMvdGlsZWQtZHJhd2luZy9maXhlZC9mb3VyLWJhcnMtem9vbWVk Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDYxODcgcGxhdGZvcm0vbWFjL3RpbGVk LWRyYXdpbmcvZml4ZWQvbmVnYXRpdmUtc2Nyb2xsLW9mZnNldC5odG1sIFsgRmFpbHVyZSBdCklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24g MTM5MTExKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHdv cmtpbmcgY29weSkKQEAgLTEyNjMsOCArMTI2Myw2IEBACiAKIHdlYmtpdC5vcmcvYi8xMDYwNzUg WyBEZWJ1ZyBdIGZhc3QvcmVnaW9ucy9mdWxsLXNjcmVlbi12aWRlby1mcm9tLXJlZ2lvbi5odG1s IFsgQ3Jhc2ggXQogCi13ZWJraXQub3JnL2IvMTA2MTIzIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFp bi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2IvMTA2MTUx IFsgTGlvbiBdIGh0dHAvdGVzdHMvbWlzYy9saW5rLXJlbC1pY29uLWJlZm9yZWxvYWQuaHRtbCBb IFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMDYxODUgZmFzdC9mcmFtZXMvZmxhdHRl bmluZy9pZnJhbWUtZmxhdHRlbmluZy1maXhlZC1oZWlnaHQuaHRtbCBbIFBhc3MgRmFpbHVyZSBd CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxMzkxMTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMS0wOCAgTmF0ZSBDaGFwaW4gIDxq YXBoZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzODIyMj8pOiBbTWFj IFdLMV0gaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgYXNz ZXJ0cyBpbiBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGaW5pc2hMb2FkaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYxMjMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9uczogbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIGlzIG5vIGxvbmdlciBjcmFz aGluZy4KKwogMjAxMy0wMS0wOCAgVG9tIFNlcGV6ICA8dHNlcGV6QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBDb3B5LXBhc3RlIHByZXNlcnZlcyA8ZW1iZWQ+IHRhZ3MgY29udGFpbmluZyBhY3Rp dmUgY29udGVudC4K 181808 2013-01-08 17:04:01 -0800 2013-01-08 19:32:04 -0800 Patch for landing bug-106123-20130108170105.patch text/plain 5617 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTEzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTA4ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM4MjIy Pyk6IFtNYWMgV0sxXSBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3Qu aHRtbCBhc3NlcnRzIGluIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZEZpbmlzaExv YWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjEyMworCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBmaXhpbmcgYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGxv YWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFpblJlc291 cmNlTG9hZGVyOjpjb250aW51ZUFmdGVyTmF2aWdhdGlvblBvbGljeSk6IEJlZm9yZSBjYWxsaW5n IG1fcmVzb3VyY2UtPnJlbW92ZUNsaWVudCh0aGlzKQorICAgICAgICAgICAgYW5kIHBvdGVudGlh bGx5IGNhbmNlbGluZyB0aGUgUmVzb3VyY2VMb2FkZXIsIGVuc3VyZSBpdCB3b24ndCBzZW5kIHJl c291cmNlIGxvYWQgY2FsbGJhY2tzLgorICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRlci5o OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OnNldFNlbmRDYWxsYmFja1BvbGlj eSk6CisKIDIwMTMtMDEtMDggIFJhZmFlbCBXZWluc3RlaW4gIDxyYWZhZWx3QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbSFRNTFRlbXBsYXRlRWxlbWVudF0gQWxsb3cgPHRlbXBsYXRlPiBjb250 ZW50IHRvIGJlIGluc3BlY3RlZApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNv dXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5S ZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDEzOTExMSkKKysrIFNvdXJjZS9XZWJDb3JlL2xv YWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODEsNyArMTgx LDIwIEBAIHZvaWQgTWFpblJlc291cmNlTG9hZGVyOjpjb250aW51ZUFmdGVyTmEKICAgICBlbHNl IGlmIChtX3N1YnN0aXR1dGVEYXRhLmlzVmFsaWQoKSkgewogICAgICAgICAvLyBBIHJlZGlyZWN0 IHJlc3VsdGVkIGluIGxvYWRpbmcgc3Vic3RpdHV0ZSBkYXRhLgogICAgICAgICBBU1NFUlQoZG9j dW1lbnRMb2FkZXIoKS0+dGltaW5nKCktPnJlZGlyZWN0Q291bnQoKSk7CisKKyAgICAgICAgLy8g V2UgbmVlZCB0byByZW1vdmUgb3VyIHJlZmVyZW5jZSB0byB0aGUgQ2FjaGVkUmVzb3VyY2UgaW4g ZmF2b3Igb2YgYSBTdWJzdGl0dXRlRGF0YSBsb2FkLgorICAgICAgICAvLyBUaGlzIHdpbGwgcHJv YmFibHkgdHJpZ2dlciB0aGUgY2FuY2VsbGF0aW9uIG9mIHRoZSBDYWNoZWRSZXNvdXJjZSdzIHVu ZGVybHlpbmcgUmVzb3VyY2VMb2FkZXIsIHRob3VnaCB0aGVyZSBpcyBhCisgICAgICAgIC8vIHNt YWxsIGNoYW5jZSB0aGF0IHRoZSByZXNvdXJjZSBpcyBiZWluZyBsb2FkZWQgYnkgYSBkaWZmZXJl bnQgRnJhbWUsIHByZXZlbnRpbmcgdGhlIFJlc291cmNlTG9hZGVyIGZyb20gYmVpbmcgY2FuY2Vs bGVkLgorICAgICAgICAvLyBJZiB0aGUgUmVzb3VyY2VMb2FkZXIgaXMgaW5kZWVkIGNhbmNlbGxl ZCwgaXQgd291bGQgbm9ybWFsbHkgc2VuZCByZXNvdXJjZSBsb2FkIGNhbGxiYWNrcy4KKyAgICAg ICAgLy8gSG93ZXZlciwgZnJvbSBhbiBBUEkgcGVyc3BlY3RpdmUsIHRoaXMgaXNuJ3QgYSBjYW5j ZWxsYXRpb24uIFRoZXJlZm9yZSwgc2V2ZXIgb3VyIHJlbGF0aW9uc2hpcCB3aXRoIHRoZSBuZXR3 b3JrIGxvYWQgdmlhIGNsZWFyUmVzb3VyY2UoKSwKKyAgICAgICAgLy8gYnV0IHByZXZlbnQgdGhl IFJlc291cmNlTG9hZGVyIGZyb20gc2VuZGluZyBSZXNvdXJjZUxvYWROb3RpZmllciBjYWxsYmFj a3MuCisgICAgICAgIFJlZlB0cjxSZXNvdXJjZUxvYWRlcj4gcmVzb3VyY2VMb2FkZXIgPSBsb2Fk ZXIoKTsKKyAgICAgICAgQVNTRVJUKCFyZXNvdXJjZUxvYWRlciB8fCByZXNvdXJjZUxvYWRlci0+ c2hvdWxkU2VuZFJlc291cmNlTG9hZENhbGxiYWNrcygpKTsKKyAgICAgICAgaWYgKHJlc291cmNl TG9hZGVyKQorICAgICAgICAgICAgcmVzb3VyY2VMb2FkZXItPnNldFNlbmRDYWxsYmFja1BvbGlj eShEb05vdFNlbmRDYWxsYmFja3MpOwogICAgICAgICBjbGVhclJlc291cmNlKCk7CisgICAgICAg IGlmIChyZXNvdXJjZUxvYWRlcikKKyAgICAgICAgICAgIHJlc291cmNlTG9hZGVyLT5zZXRTZW5k Q2FsbGJhY2tQb2xpY3koU2VuZENhbGxiYWNrcyk7CiAgICAgICAgIGhhbmRsZVN1YnN0aXR1dGVE YXRhTG9hZFNvb24ocmVxdWVzdCk7CiAgICAgfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvUmVzb3VyY2VMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkZXIuaAkocmV2aXNpb24gMTM5MTExKQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL1Jlc291cmNlTG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0MCw2ICsxNDAsNyBAQCBw dWJsaWM6CiAgICAgY29uc3QgS1VSTCYgdXJsKCkgY29uc3QgeyByZXR1cm4gbV9yZXF1ZXN0LnVy bCgpOyB9IAogICAgIFJlc291cmNlSGFuZGxlKiBoYW5kbGUoKSBjb25zdCB7IHJldHVybiBtX2hh bmRsZS5nZXQoKTsgfQogICAgIGJvb2wgc2hvdWxkU2VuZFJlc291cmNlTG9hZENhbGxiYWNrcygp IGNvbnN0IHsgcmV0dXJuIG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyA9PSBTZW5kQ2FsbGJh Y2tzOyB9CisgICAgdm9pZCBzZXRTZW5kQ2FsbGJhY2tQb2xpY3koU2VuZENhbGxiYWNrUG9saWN5 IHNlbmRMb2FkQ2FsbGJhY2tzKSB7IG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyA9IHNlbmRM b2FkQ2FsbGJhY2tzOyB9CiAgICAgYm9vbCBzaG91bGRTbmlmZkNvbnRlbnQoKSBjb25zdCB7IHJl dHVybiBtX29wdGlvbnMuc25pZmZDb250ZW50ID09IFNuaWZmQ29udGVudDsgfQogCiAgICAgYm9v bCByZWFjaGVkVGVybWluYWxTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVhY2hlZFRlcm1pbmFs U3RhdGU7IH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTExMSkKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTA4ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM4MjIy Pyk6IFtNYWMgV0sxXSBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3Qu aHRtbCBhc3NlcnRzIGluIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZEZpbmlzaExv YWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjEyMworCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6IG1haW4tcmVzb3VyY2UtcmVkaXJlY3QuaHRtbCBpcyBu byBsb25nZXIgY3Jhc2hpbmcuCisKIDIwMTMtMDEtMDggIFRvbSBTZXBleiAgPHRzZXBlekBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQ29weS1wYXN0ZSBwcmVzZXJ2ZXMgPGVtYmVkPiB0YWdzIGNv bnRhaW5pbmcgYWN0aXZlIGNvbnRlbnQuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxMzkxMTEpCisrKyBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTI5 NSw4ICsyOTUsNiBAQCB3ZWJraXQub3JnL2IvMTA1OTk4IFsgTW91bnRhaW5MaW9uIERlYnVnCiAK IHdlYmtpdC5vcmcvYi85MzU1MiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3Mu aHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTA2MTIzIGh0dHAvdGVzdHMvYXBwY2Fj aGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIFsgUGFzcyBdCi0KIHdlYmtpdC5vcmcvYi8x MDYxODcgcGxhdGZvcm0vbWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvYWJzb2x1dGUtaW5zaWRlLW91 dC1vZi12aWV3LWZpeGVkLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDYxODcgcGxh dGZvcm0vbWFjL3RpbGVkLWRyYXdpbmcvZml4ZWQvZm91ci1iYXJzLXpvb21lZC5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MTg3IHBsYXRmb3JtL21hYy90aWxlZC1kcmF3aW5nL2Zp eGVkL25lZ2F0aXZlLXNjcm9sbC1vZmZzZXQuaHRtbCBbIEZhaWx1cmUgXQpJbmRleDogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDEzOTExMSkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkp CkBAIC0xMjYzLDggKzEyNjMsNiBAQCB3ZWJraXQub3JnL2IvMTA2MDY0IGZhc3QvaW5saW5lL2Nv bnRpbnVhCiAKIHdlYmtpdC5vcmcvYi8xMDYwNzUgWyBEZWJ1ZyBdIGZhc3QvcmVnaW9ucy9mdWxs LXNjcmVlbi12aWRlby1mcm9tLXJlZ2lvbi5odG1sIFsgQ3Jhc2ggXQogCi13ZWJraXQub3JnL2Iv MTA2MTIzIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sIFsg Q3Jhc2ggXQotCiB3ZWJraXQub3JnL2IvMTA2MTUxIFsgTGlvbiBdIGh0dHAvdGVzdHMvbWlzYy9s aW5rLXJlbC1pY29uLWJlZm9yZWxvYWQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5v cmcvYi8xMDYxODUgZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmluZy1maXhl ZC1oZWlnaHQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==