106107 2013-01-04 10:39:31 -0800 REGRESSION(SUBPIXEL_LAYOUT): el.offsetWidth < el.clientWidth for elements of a certain size 2013-01-07 16:50:31 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bradavogel eae bradavogel eae eric leviw me ojan.autocc rniwa simon.fraser webkit.review.bot oldest_to_newest 800368 0 bradavogel 2013-01-04 10:39:31 -0800 Repro: 1) Run the attached file in Chrome 21 or later, or Webkit Nightly. Actual Result: You will see the alert "BUG: offsetWidth is smaller than clientWidth". Expected Result: You will see the alert "NO BUG: unable to repro" Tested in: Firefox 17.0.1: PASS Chrome 20: PASS Safari 6.0.2 (7536.26.17): PASS Chrome 21: FAIL Chrome Canary 26.0.1374.1: FAIL Webkit Nightly Version 6.0.2 (7536.26.17, 537+): FAIL Notes: Per the W3C spec, offsetWidth should never be smaller than clientWidth. If you change the attached repro case to use "margin: 1.2em" instead of "margin: 1.1em", it will not repro the bug. Impact: This breaks scripts that use the following code to check if an element is scrollable: var isScrollable = el.offsetWidth < el.scrollWidth; because if the bug is reproducing, offsetWidth will be smaller than clientWidth, but scrollWidth will equal clientWidth. 800371 1 181330 bradavogel 2013-01-04 10:40:17 -0800 Created attachment 181330 Original repro case 801374 2 ap 2013-01-07 10:13:55 -0800 Regressed in <http://trac.webkit.org/changeset/133351>. 801593 3 eae 2013-01-07 13:25:49 -0800 Looking into this now. 801730 4 181577 eae 2013-01-07 15:33:46 -0800 Created attachment 181577 Patch 801738 5 181577 leviw 2013-01-07 15:39:36 -0800 Comment on attachment 181577 Patch LGTM. 801754 6 bradavogel 2013-01-07 15:51:56 -0800 LGTM! 801764 7 leviw 2013-01-07 15:56:53 -0800 You may want to merge this into m25 given it's super low risk and high return. 801815 8 181577 webkit.review.bot 2013-01-07 16:44:18 -0800 Comment on attachment 181577 Patch Clearing flags on attachment: 181577 Committed r139013: <http://trac.webkit.org/changeset/139013> 801816 9 webkit.review.bot 2013-01-07 16:44:22 -0800 All reviewed patches have been landed. Closing bug. 801827 10 rniwa 2013-01-07 16:50:31 -0800 This patch caused a build failure on Windows: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/60388/steps/compile-webkit/logs/stdio 7>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/LTCG' specification 7>WebCore.lib(RenderRegionSet.obj) : error LNK2005: "public: virtual int __thiscall WebCore::RenderBox::pixelSnappedOffsetWidth(void)const " (?pixelSnappedOffsetWidth@RenderBox@WebCore@@UBEHXZ) already defined in WebCore.lib(RenderingAllInOne.obj) 7>WebCore.lib(RenderRegionSet.obj) : error LNK2005: "public: virtual int __thiscall WebCore::RenderBox::pixelSnappedOffsetHeight(void)const " (?pixelSnappedOffsetHeight@RenderBox@WebCore@@UBEHXZ) already defined in WebCore.lib(RenderingAllInOne.obj) 7>WebCore.lib(MathMLInlineContainerElement.obj) : error LNK2005: "public: virtual int __thiscall WebCore::RenderBox::pixelSnappedOffsetWidth(void)const " (?pixelSnappedOffsetWidth@RenderBox@WebCore@@UBEHXZ) already defined in WebCore.lib(RenderingAllInOne.obj) 7>WebCore.lib(MathMLInlineContainerElement.obj) : error LNK2005: "public: virtual int __thiscall WebCore::RenderBox::pixelSnappedOffsetHeight(void)const " (?pixelSnappedOffsetHeight@RenderBox@WebCore@@UBEHXZ) already defined in WebCore.lib(RenderingAllInOne.obj) 7> Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\WebKit.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\WebKit.exp 7>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\WebKit.dll : fatal error LNK1169: one or more multiply defined symbols found 7>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\obj\WebKitLib\BuildLog.htm" It's probably a dependency problem though because I don't see RenderBox.cpp being recompiled. 181330 2013-01-04 10:40:17 -0800 2013-01-04 10:40:17 -0800 Original repro case reprocase.html text/html 348 bradavogel PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGRpdiBzdHlsZT0ibWFyZ2luOiAxLjFlbTsi PgogICAgPGRpdj48L2Rpdj4KPC9kaXY+CjxzY3JpcHQ+CiAgICB2YXIgaW5uZXJEaXYgPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCdkaXYgPiBkaXYnKTsKICAgIGlmIChpbm5lckRpdi5vZmZzZXRX aWR0aCA8IGlubmVyRGl2LmNsaWVudFdpZHRoKXsKICAgICAgICBhbGVydCgnQlVHOiBvZmZzZXRX aWR0aCBpcyBzbWFsbGVyIHRoYW4gY2xpZW50V2lkdGgnKQogICAgfSBlbHNlIHsKICAgICAgICBh bGVydCgnTk8gQlVHOiB1bmFibGUgdG8gcmVwcm8nKQogICAgfQo8L3NjcmlwdD4KPC9ib2R5Pgo8 L2h0bWw+ 181577 2013-01-07 15:33:46 -0800 2013-01-07 16:44:18 -0800 Patch bug-106107-20130107153051.patch text/plain 5894 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAxLTA3ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKFNVQlBJWEVM X0xBWU9VVCk6IGVsLm9mZnNldFdpZHRoIDwgZWwuY2xpZW50V2lkdGggZm9yIGVsZW1lbnRzIG9m IGEgY2VydGFpbiBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDYxMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAg ICAgICAgCisgICAgICAgIEFkZCBvdmVybG9hZGVkIHBpeGVsU25hcHBlZE9mZnNldFdpZHRofEhl aWdodCBtZXRob2RzIHRvCisgICAgICAgIFJlbmRlckJveCB0aGF0IGRvIHBpeGVsIHNuYXBwaW5n IHdpdGggdGhlIHNhbWUgb2Zmc2V0CisgICAgICAgIGFzIGNsaWVudFdpZHRoL2hlaWdodCB0byBl bnN1cmUgY29uc2lzdGVudCByb3VuZGluZy4KKworICAgICAgICBUZXN0OiBmYXN0L3N1Yi1waXhl bC9jbGllbnQtYW5kLW9mZnNldC13aWR0aC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6cGl4ZWxTbmFwcGVkT2Zm c2V0V2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpwaXhlbFNuYXBwZWRPZmZz ZXRIZWlnaHQpOgorICAgICAgICBTbmFwIHVzaW5nIHRoZSBzYW1lIG9mZnNldCBhcyB0aGUgY2xp ZW50V2lkdGgvaGVpZ2h0IHZlcnNpb25zLgorICAgICAgICAKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyQm94Lmg6CisgICAgICAgIFJlbW92ZSBvdXQgb2YgZGF0ZSBGSVhNRSBhbmQgYWRkIE9W RVJSSURFIGtleXdvcmQuCisgICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hN b2RlbE9iamVjdC5oOgorICAgICAgICBNYXJrIHBpeGVsU25hcHBlZE9mZnNldFdpZHRofEhlaWdo dCBhcyB2aXJ0dWFsLgorCiAyMDEzLTAxLTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25A YXBwbGUuY29tPgogCiAgICAgICAgIFRpbGVkLWxheWVyIFRpbGVDYWNoZXMgc2hvdWxkbid0IHVu cGFyZW50IG9mZnNjcmVlbiB0aWxlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveC5jcHAJKHJldmlzaW9uIDEzODk5MykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTIsNiArMzkyLDE2IEBAIGludCBSZW5k ZXJCb3g6OnBpeGVsU25hcHBlZENsaWVudEhlaWdodCgKICAgICByZXR1cm4gc25hcFNpemVUb1Bp eGVsKGNsaWVudEhlaWdodCgpLCB5KCkgKyBjbGllbnRUb3AoKSk7CiB9CiAKK2ludCBSZW5kZXJC b3g6OnBpeGVsU25hcHBlZE9mZnNldFdpZHRoKCkgY29uc3QKK3sKKyAgICByZXR1cm4gc25hcFNp emVUb1BpeGVsKG9mZnNldFdpZHRoKCksIHgoKSArIGNsaWVudExlZnQoKSk7Cit9CisKK2ludCBS ZW5kZXJCb3g6OnBpeGVsU25hcHBlZE9mZnNldEhlaWdodCgpIGNvbnN0Cit7CisgICAgcmV0dXJu IHNuYXBTaXplVG9QaXhlbChvZmZzZXRIZWlnaHQoKSwgeSgpICsgY2xpZW50VG9wKCkpOworfQor CiBpbnQgUmVuZGVyQm94OjpzY3JvbGxXaWR0aCgpIGNvbnN0CiB7CiAgICAgaWYgKGhhc092ZXJm bG93Q2xpcCgpKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAkocmV2aXNp b24gMTM4OTkzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMDUsOSArMjA1LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgTGF5b3V0 VW5pdCBvZmZzZXRXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIHdpZHRoKCk7IH0KICAgICB2aXJ0dWFs IExheW91dFVuaXQgb2Zmc2V0SGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gaGVpZ2h0KCk7IH0KIAot ICAgIC8vIEZJWE1FOiBUaGUgaW1wbGVtZW50YXRpb24gZm9yIHRoZXNlIGZ1bmN0aW9ucyB3aWxs IGNoYW5nZSBvbmNlIHdlIG1vdmUgdG8gc3VicGl4ZWwgbGF5b3V0LiBTZWUgYnVnIDYwMzE4Lgot ICAgIHZpcnR1YWwgaW50IHBpeGVsU25hcHBlZE9mZnNldFdpZHRoKCkgY29uc3QgeyByZXR1cm4g cGl4ZWxTbmFwcGVkV2lkdGgoKTsgfQotICAgIHZpcnR1YWwgaW50IHBpeGVsU25hcHBlZE9mZnNl dEhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIHBpeGVsU25hcHBlZEhlaWdodCgpOyB9CisgICAgdmly dHVhbCBpbnQgcGl4ZWxTbmFwcGVkT2Zmc2V0V2lkdGgoKSBjb25zdCBPVkVSUklERTsKKyAgICB2 aXJ0dWFsIGludCBwaXhlbFNuYXBwZWRPZmZzZXRIZWlnaHQoKSBjb25zdCBPVkVSUklERTsKIAog ICAgIC8vIE1vcmUgSUUgZXh0ZW5zaW9ucy4gIGNsaWVudFdpZHRoIGFuZCBjbGllbnRIZWlnaHQg cmVwcmVzZW50IHRoZSBpbnRlcmlvciBvZiBhbiBvYmplY3QKICAgICAvLyBleGNsdWRpbmcgYm9y ZGVyIGFuZCBzY3JvbGxiYXIuICBjbGllbnRMZWZ0L1RvcCBhcmUganVzdCB0aGUgYm9yZGVyTGVm dFdpZHRoIGFuZCBib3JkZXJUb3BXaWR0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCShyZXZpc2lvbiAxMzg5OTMpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaAkod29ya2luZyBjb3B5 KQpAQCAtODAsOCArODAsOCBAQCBwdWJsaWM6CiAKICAgICBpbnQgcGl4ZWxTbmFwcGVkT2Zmc2V0 TGVmdCgpIGNvbnN0IHsgcmV0dXJuIHJvdW5kVG9JbnQob2Zmc2V0TGVmdCgpKTsgfQogICAgIGlu dCBwaXhlbFNuYXBwZWRPZmZzZXRUb3AoKSBjb25zdCB7IHJldHVybiByb3VuZFRvSW50KG9mZnNl dFRvcCgpKTsgfQotICAgIGludCBwaXhlbFNuYXBwZWRPZmZzZXRXaWR0aCgpIGNvbnN0OwotICAg IGludCBwaXhlbFNuYXBwZWRPZmZzZXRIZWlnaHQoKSBjb25zdDsKKyAgICB2aXJ0dWFsIGludCBw aXhlbFNuYXBwZWRPZmZzZXRXaWR0aCgpIGNvbnN0OworICAgIHZpcnR1YWwgaW50IHBpeGVsU25h cHBlZE9mZnNldEhlaWdodCgpIGNvbnN0OwogCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21T dHlsZSgpIE9WRVJSSURFOwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzkwMDApCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMS0w NyAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TihTVUJQSVhFTF9MQVlPVVQpOiBlbC5vZmZzZXRXaWR0aCA8IGVsLmNsaWVudFdpZHRoIGZvciBl bGVtZW50cyBvZiBhIGNlcnRhaW4gc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBBZGQgdGVzdCBmb3IgY2xpZW50V2lkdGgvb2Zmc2V0 V2lkdGggcm91bmRpbmcuCisKKyAgICAgICAgKiBmYXN0L3N1Yi1waXhlbC9jbGllbnQtYW5kLW9m ZnNldC13aWR0aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc3ViLXBpeGVs L2NsaWVudC1hbmQtb2Zmc2V0LXdpZHRoLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAxLTA3ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQSBjb3VwbGUgbW9yZSByZWJh c2VsaW5lcyBmb3IgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTM4ODM4LgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9zdWItcGl4ZWwvY2xpZW50LWFuZC1vZmZzZXQtd2lkdGgtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc3ViLXBpeGVsL2NsaWVu dC1hbmQtb2Zmc2V0LXdpZHRoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3Qvc3ViLXBpeGVsL2NsaWVudC1hbmQtb2Zmc2V0LXdpZHRoLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitQQVNTIG9mZnNldFdpZHRoIGFuZCBjbGllbnRX aWR0aCBhcmUgdGhlIHNhbWUKK1Rlc3RzIHRoYXQgYSBibG9jayB3aXRob3V0IG92ZXJmbG93LCBi b3JkZXJzLCBtYXJnaW4gb3IgcGFkZGluZyByZXBvcnRzIHRoZSBzYW1lIGNsaWVudFdpZHRoIGFz IG9mZnNldFdpZHRoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zdWItcGl4ZWwvY2xpZW50LWFu ZC1vZmZzZXQtd2lkdGguaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3N1Yi1w aXhlbC9jbGllbnQtYW5kLW9mZnNldC13aWR0aC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9zdWItcGl4ZWwvY2xpZW50LWFuZC1vZmZzZXQtd2lkdGguaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVh ZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+CisgICAgPC9oZWFkPgorCisgICAgPGJvZHk+CisgICAgICAgIDxkaXYgc3R5bGU9 Im1hcmdpbjogMS4xZW07Ij4KKyAgICAgICAgICAgIDxkaXYgaWQ9InRlc3QiPjwvZGl2PgorICAg ICAgICA8L2Rpdj4KKyAgICAgICAgCisgICAgICAgIDxwPgorICAgICAgICAgICAgVGVzdHMgdGhh dCBhIGJsb2NrIHdpdGhvdXQgb3ZlcmZsb3csIGJvcmRlcnMsIG1hcmdpbiBvciBwYWRkaW5nIHJl cG9ydHMgdGhlIHNhbWUgY2xpZW50V2lkdGggYXMgb2Zmc2V0V2lkdGguCisgICAgICAgIDwvcD4K KworICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgdmFyIGVsID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInRlc3QiKTsKKyAgICAgICAgICAgIGlmIChlbC5vZmZzZXRXaWR0aCA9PSBlbC5j bGllbnRXaWR0aCkKKyAgICAgICAgICAgICAgICB0ZXN0UGFzc2VkKCdvZmZzZXRXaWR0aCBhbmQg Y2xpZW50V2lkdGggYXJlIHRoZSBzYW1lJyk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAg ICAgICAgdGVzdEZhaWxlZCgnb2Zmc2V0V2lkdGggaXMgJyArIGVsLm9mZnNldFdpZHRoICsgJyBi dXQgY2xpZW50V2lkdGggaXMgJyArIGVsLmNsaWVudFdpZHRoKTsKKyAgICAgICAgPC9zY3JpcHQ+ CisgICAgPC9ib2R5PgorPC9odG1sPgo=