106105 2013-01-04 10:09:58 -0800 Can't compile MathExtras.h using MinGW-w64 2013-01-05 12:04:12 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106099 0 net147 webkit-unassigned benjamin dglazkov hausmann ojan.autocc sam webkit.review.bot oldest_to_newest 800321 0 net147 2013-01-04 10:09:58 -0800 r138705 caused MathExtras.h to fail to compile as wtf_pow need isfinite and isinf. isfinite and isinf is defined after wtf_pow with "using std::isfinite" and "using std::isinf". 800328 1 181323 net147 2013-01-04 10:17:12 -0800 Created attachment 181323 Patch 800332 2 webkit.review.bot 2013-01-04 10:20:34 -0800 Attachment 181323 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1 Source/WTF/wtf/MathExtras.h:351: wtf_pow is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 800465 3 181323 webkit.review.bot 2013-01-04 11:53:17 -0800 Comment on attachment 181323 Patch Attachment 181323 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15699223 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 800949 4 181323 webkit.review.bot 2013-01-05 12:04:08 -0800 Comment on attachment 181323 Patch Clearing flags on attachment: 181323 Committed r138894: <http://trac.webkit.org/changeset/138894> 800950 5 webkit.review.bot 2013-01-05 12:04:12 -0800 All reviewed patches have been landed. Closing bug. 181323 2013-01-04 10:17:12 -0800 2013-01-05 12:04:08 -0800 Patch bug-106105.patch text/plain 2741 net147 SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzg4MDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTA0ICBKb25hdGhhbiBMaXUgIDxuZXQx NDdAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBvZiBNYXRoRXh0cmFzLmgg d2l0aCBNaW5HVy13NjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjEwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBpc2Zpbml0ZSBhbmQgaXNpbmYgZnVuY3Rpb25zIGFyZSByZXF1aXJlZCBieSB3 dGZfcG93IGJ1dAorICAgICAgICBub3QgZGVmaW5lZCB1bnRpbCBhZnRlciB3dGZfcG93LiBNb3Zl IHd0Zl9wb3cgdG8gYWZ0ZXIKKyAgICAgICAgInVzaW5nIHN0ZDo6aXNmaW5pdGUiIGFuZCAidXNp bmcgc3RkOjppc2luZiIgdG8gZml4IGNvbXBpbGF0aW9uLgorCisgICAgICAgICogd3RmL01hdGhF eHRyYXMuaDoKKyAgICAgICAgKHd0Zl9wb3cpOgorCiAyMDEzLTAxLTAzICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2FsbExpbmtTdGF0dXMgc2hvdWxkIGJlIGF3 YXJlIG9mIGNsb3N1cmUgY2FsbHMsIGFuZCB0aGUgREZHIGJ5dGVjb2RlIHBhcnNlciBzaG91bGQg dXNlIHRoYXQgYXMgaXRzIHNvbGUgaW50ZXJuYWwgbm90aW9uIG9mIGhvdyB0byBvcHRpbWl6ZSBj YWxscwpJbmRleDogU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAkocmV2aXNpb24gMTM4ODAyKQorKysgU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjYsMjggKzIyNiw2IEBAIGlu bGluZSBsb25nIGludCBscmludChkb3VibGUgZmx0KQogCiAjZW5kaWYgLy8gQ09NUElMRVIoTVNW QykKIAotI2lmIENPTVBJTEVSKE1JTkdXNjQpCi1pbmxpbmUgZG91YmxlIHd0Zl9wb3coZG91Ymxl IHgsIGRvdWJsZSB5KQotewotICAgIC8vIE1pbkdXLXc2NCBoYXMgYSBjdXN0b20gaW1wbGVtZW50 YXRpb24gZm9yIHBvdy4KLSAgICAvLyBUaGlzIGhhbmRsZXMgY2VydGFpbiBzcGVjaWFsIGNhc2Vz IHRoYXQgYXJlIGRpZmZlcmVudC4KLSAgICBpZiAoKHggPT0gMC4wIHx8IGlzaW5mKHgpKSAmJiBp c2Zpbml0ZSh5KSkgewotICAgICAgICBkb3VibGUgZjsKLSAgICAgICAgaWYgKG1vZGYoeSwgJmYp ICE9IDAuMCkKLSAgICAgICAgICAgIHJldHVybiAoKHggPT0gMC4wKSBeICh5ID4gMC4wKSkgPyBz dGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCkgOiAwLjA7Ci0gICAgfQotCi0g ICAgaWYgKHggPT0gMi4wKSB7Ci0gICAgICAgIGludCB5SW50ID0gc3RhdGljX2Nhc3Q8aW50Pih5 KTsKLSAgICAgICAgaWYgKHkgPT0geUludCkKLSAgICAgICAgICAgIHJldHVybiBsZGV4cCgxLjAs IHlJbnQpOwotICAgIH0KLQotICAgIHJldHVybiBwb3coeCwgeSk7Ci19Ci0jZGVmaW5lIHBvdyh4 LCB5KSB3dGZfcG93KHgsIHkpCi0jZW5kaWYgLy8gQ09NUElMRVIoTUlOR1c2NCkKLQogaW5saW5l IGRvdWJsZSBkZWcycmFkKGRvdWJsZSBkKSAgeyByZXR1cm4gZCAqIHBpRG91YmxlIC8gMTgwLjA7 IH0KIGlubGluZSBkb3VibGUgcmFkMmRlZyhkb3VibGUgcikgIHsgcmV0dXJuIHIgKiAxODAuMCAv IHBpRG91YmxlOyB9CiBpbmxpbmUgZG91YmxlIGRlZzJncmFkKGRvdWJsZSBkKSB7IHJldHVybiBk ICogNDAwLjAgLyAzNjAuMDsgfQpAQCAtMzY5LDYgKzM0NywyOCBAQCB1c2luZyBzdGQ6Ond0Zl9p c25hbjsKICNlbmRpZgogI2VuZGlmCiAKKyNpZiBDT01QSUxFUihNSU5HVzY0KQoraW5saW5lIGRv dWJsZSB3dGZfcG93KGRvdWJsZSB4LCBkb3VibGUgeSkKK3sKKyAgICAvLyBNaW5HVy13NjQgaGFz IGEgY3VzdG9tIGltcGxlbWVudGF0aW9uIGZvciBwb3cuCisgICAgLy8gVGhpcyBoYW5kbGVzIGNl cnRhaW4gc3BlY2lhbCBjYXNlcyB0aGF0IGFyZSBkaWZmZXJlbnQuCisgICAgaWYgKCh4ID09IDAu MCB8fCBpc2luZih4KSkgJiYgaXNmaW5pdGUoeSkpIHsKKyAgICAgICAgZG91YmxlIGY7CisgICAg ICAgIGlmIChtb2RmKHksICZmKSAhPSAwLjApCisgICAgICAgICAgICByZXR1cm4gKCh4ID09IDAu MCkgXiAoeSA+IDAuMCkpID8gc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjppbmZpbml0eSgp IDogMC4wOworICAgIH0KKworICAgIGlmICh4ID09IDIuMCkgeworICAgICAgICBpbnQgeUludCA9 IHN0YXRpY19jYXN0PGludD4oeSk7CisgICAgICAgIGlmICh5ID09IHlJbnQpCisgICAgICAgICAg ICByZXR1cm4gbGRleHAoMS4wLCB5SW50KTsKKyAgICB9CisKKyAgICByZXR1cm4gcG93KHgsIHkp OworfQorI2RlZmluZSBwb3coeCwgeSkgd3RmX3Bvdyh4LCB5KQorI2VuZGlmIC8vIENPTVBJTEVS KE1JTkdXNjQpCisKIAogLy8gZGVjb21wb3NlICdudW1iZXInIHRvIGl0cyBzaWduLCBleHBvbmVu dCwgYW5kIG1hbnRpc3NhIGNvbXBvbmVudHMuCiAvLyBUaGUgcmVzdWx0IGlzIGludGVycHJldGVk IGFzOgo=