106099 2013-01-04 09:11:09 -0800 Only enable MinGW-w64 pow() workaround if needed 2013-01-05 12:51:36 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106105 0 net147 webkit-unassigned benjamin dglazkov hausmann ojan.autocc rniwa sam webkit.review.bot oldest_to_newest 800244 0 net147 2013-01-04 09:11:09 -0800 The pow() workaround in Source/WTF/wtf/MathExtras.h for MinGW-w64 is no longer required in the latest version of MinGW-w64. Only enable the workaround if it is required. 800249 1 181312 net147 2013-01-04 09:15:19 -0800 Created attachment 181312 Patch 800755 2 181412 net147 2013-01-04 16:58:54 -0800 Created attachment 181412 Patch 800764 3 net147 2013-01-04 17:11:54 -0800 There is a warning generated if __MINGW64_VERSION_RC is not defined and compiling with -Wundef so I added another check if it is defined. 800814 4 181412 webkit.review.bot 2013-01-04 18:50:25 -0800 Comment on attachment 181412 Patch Attachment 181412 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15708445 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 800971 5 181412 webkit.review.bot 2013-01-05 12:51:32 -0800 Comment on attachment 181412 Patch Clearing flags on attachment: 181412 Committed r138903: <http://trac.webkit.org/changeset/138903> 800972 6 webkit.review.bot 2013-01-05 12:51:36 -0800 All reviewed patches have been landed. Closing bug. 181312 2013-01-04 09:15:19 -0800 2013-01-04 17:02:46 -0800 Patch bug-106099.patch text/plain 1530 net147 SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzg4MDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA0ICBKb25hdGhhbiBMaXUgIDxuZXQx NDdAZ21haWwuY29tPgorCisgICAgICAgIE9ubHkgZW5hYmxlIE1pbkdXLXc2NCBwb3coKSB3b3Jr YXJvdW5kIGlmIG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA2MDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHBvdygpIHdvcmthcm91bmQgaXMgbm8gbG9uZ2VyIG5lZWRlZCBpbiB0aGUg bGF0ZXN0IHZlcnNpb24KKyAgICAgICAgb2YgTWluR1ctdzY0LgorCisgICAgICAgICogd3RmL01h dGhFeHRyYXMuaDoKKwogMjAxMy0wMS0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIENhbGxMaW5rU3RhdHVzIHNob3VsZCBiZSBhd2FyZSBvZiBjbG9zdXJlIGNh bGxzLCBhbmQgdGhlIERGRyBieXRlY29kZSBwYXJzZXIgc2hvdWxkIHVzZSB0aGF0IGFzIGl0cyBz b2xlIGludGVybmFsIG5vdGlvbiBvZiBob3cgdG8gb3B0aW1pemUgY2FsbHMKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL01hdGhFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9NYXRo RXh0cmFzLmgJKHJldmlzaW9uIDEzODgwMikKKysrIFNvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMu aAkod29ya2luZyBjb3B5KQpAQCAtMjI2LDcgKzIyNiw3IEBAIGlubGluZSBsb25nIGludCBscmlu dChkb3VibGUgZmx0KQogCiAjZW5kaWYgLy8gQ09NUElMRVIoTVNWQykKIAotI2lmIENPTVBJTEVS KE1JTkdXNjQpCisjaWYgQ09NUElMRVIoTUlOR1c2NCkgJiYgX19NSU5HVzY0X1ZFUlNJT05fUkMg PCAxCiBpbmxpbmUgZG91YmxlIHd0Zl9wb3coZG91YmxlIHgsIGRvdWJsZSB5KQogewogICAgIC8v IE1pbkdXLXc2NCBoYXMgYSBjdXN0b20gaW1wbGVtZW50YXRpb24gZm9yIHBvdy4KQEAgLTI0Niw3 ICsyNDYsNyBAQCBpbmxpbmUgZG91YmxlIHd0Zl9wb3coZG91YmxlIHgsIGRvdWJsZSB5CiAgICAg cmV0dXJuIHBvdyh4LCB5KTsKIH0KICNkZWZpbmUgcG93KHgsIHkpIHd0Zl9wb3coeCwgeSkKLSNl bmRpZiAvLyBDT01QSUxFUihNSU5HVzY0KQorI2VuZGlmIC8vIENPTVBJTEVSKE1JTkdXNjQpICYm IF9fTUlOR1c2NF9WRVJTSU9OX1JDIDwgMQogCiBpbmxpbmUgZG91YmxlIGRlZzJyYWQoZG91Ymxl IGQpICB7IHJldHVybiBkICogcGlEb3VibGUgLyAxODAuMDsgfQogaW5saW5lIGRvdWJsZSByYWQy ZGVnKGRvdWJsZSByKSAgeyByZXR1cm4gciAqIDE4MC4wIC8gcGlEb3VibGU7IH0K 181412 2013-01-04 16:58:54 -0800 2013-01-05 12:51:32 -0800 Patch bug-106099.patch text/plain 1602 net147 SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzg4MDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA0ICBKb25hdGhhbiBMaXUgIDxuZXQx NDdAZ21haWwuY29tPgorCisgICAgICAgIE9ubHkgZW5hYmxlIE1pbkdXLXc2NCBwb3coKSB3b3Jr YXJvdW5kIGlmIG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA2MDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHBvdygpIHdvcmthcm91bmQgaXMgbm8gbG9uZ2VyIG5lZWRlZCBpbiB0aGUg bGF0ZXN0IHZlcnNpb24KKyAgICAgICAgb2YgTWluR1ctdzY0LgorCisgICAgICAgICogd3RmL01h dGhFeHRyYXMuaDoKKwogMjAxMy0wMS0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIENhbGxMaW5rU3RhdHVzIHNob3VsZCBiZSBhd2FyZSBvZiBjbG9zdXJlIGNh bGxzLCBhbmQgdGhlIERGRyBieXRlY29kZSBwYXJzZXIgc2hvdWxkIHVzZSB0aGF0IGFzIGl0cyBz b2xlIGludGVybmFsIG5vdGlvbiBvZiBob3cgdG8gb3B0aW1pemUgY2FsbHMKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL01hdGhFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9NYXRo RXh0cmFzLmgJKHJldmlzaW9uIDEzODgwMikKKysrIFNvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMu aAkod29ya2luZyBjb3B5KQpAQCAtMjI2LDcgKzIyNiw3IEBAIGlubGluZSBsb25nIGludCBscmlu dChkb3VibGUgZmx0KQogCiAjZW5kaWYgLy8gQ09NUElMRVIoTVNWQykKIAotI2lmIENPTVBJTEVS KE1JTkdXNjQpCisjaWYgQ09NUElMRVIoTUlOR1c2NCkgJiYgKCFkZWZpbmVkKF9fTUlOR1c2NF9W RVJTSU9OX1JDKSB8fCBfX01JTkdXNjRfVkVSU0lPTl9SQyA8IDEpCiBpbmxpbmUgZG91YmxlIHd0 Zl9wb3coZG91YmxlIHgsIGRvdWJsZSB5KQogewogICAgIC8vIE1pbkdXLXc2NCBoYXMgYSBjdXN0 b20gaW1wbGVtZW50YXRpb24gZm9yIHBvdy4KQEAgLTI0Niw3ICsyNDYsNyBAQCBpbmxpbmUgZG91 YmxlIHd0Zl9wb3coZG91YmxlIHgsIGRvdWJsZSB5CiAgICAgcmV0dXJuIHBvdyh4LCB5KTsKIH0K ICNkZWZpbmUgcG93KHgsIHkpIHd0Zl9wb3coeCwgeSkKLSNlbmRpZiAvLyBDT01QSUxFUihNSU5H VzY0KQorI2VuZGlmIC8vIENPTVBJTEVSKE1JTkdXNjQpICYmICghZGVmaW5lZChfX01JTkdXNjRf VkVSU0lPTl9SQykgfHwgX19NSU5HVzY0X1ZFUlNJT05fUkMgPCAxKQogCiBpbmxpbmUgZG91Ymxl IGRlZzJyYWQoZG91YmxlIGQpICB7IHJldHVybiBkICogcGlEb3VibGUgLyAxODAuMDsgfQogaW5s aW5lIGRvdWJsZSByYWQyZGVnKGRvdWJsZSByKSAgeyByZXR1cm4gciAqIDE4MC4wIC8gcGlEb3Vi bGU7IH0K