106081 2013-01-04 03:34:12 -0800 REGRESSION(r138544): [GTK] Clicking on selected text in a text editable deletes the selection 2013-03-01 02:49:23 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 106045 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 800127 0 cgarcia 2013-01-04 03:34:12 -0800 The problem is that GtkInputMethodFilter::notifyMouseButtonPress() in WebKit2 always confirms a text composition, instead of the current composition. 800128 1 181286 cgarcia 2013-01-04 03:37:34 -0800 Created attachment 181286 Patch 800129 2 webkit.review.bot 2013-01-04 03:41:55 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 800215 3 mrobinson 2013-01-04 08:34:17 -0800 I think the patch I posted yesterday might be more complete. *** This bug has been marked as a duplicate of bug 106045 *** 800220 4 181286 mrobinson 2013-01-04 08:37:22 -0800 Comment on attachment 181286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181286&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:626 > - priv->inputMethodFilter.notifyMouseButtonPress(); > - > if (!priv->clickCounter.shouldProcessButtonEvent(buttonEvent)) > return TRUE; > > // If it's a right click event save it as a possible context menu event. > if (buttonEvent->button == 3) > priv->contextMenuEvent.set(gdk_event_copy(reinterpret_cast<GdkEvent*>(buttonEvent))); > + > + priv->inputMethodFilter.notifyMouseButtonPress(); I think either way, it makes sense to cancel the composition. clickCounter.shouldProcessButtonEvent just discards "extra" events that happen during the process of multi-clicking, so the chances of this making a difference are pretty small. 844976 5 181286 eric 2013-03-01 02:49:23 -0800 Comment on attachment 181286 Patch Cleared review? from attachment 181286 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 181286 2013-01-04 03:37:34 -0800 2013-03-01 02:49:23 -0800 Patch wk2-ime-regression.diff text/plain 2778 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Mzg0MTVkLi4zMjdiZDY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTMtMDEtMDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJFR1JFU1NJT04ocjEzODU0NCk6IFtHVEtdIENsaWNraW5nIG9uIHNlbGVj dGVkIHRleHQgaW4gYSB0ZXh0IGVkaXRhYmxlIGRlbGV0ZXMgdGhlIHNlbGVjdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MDgxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUJ1 dHRvblByZXNzRXZlbnQpOiBEbyBub3QgY2FsbAorICAgICAgICBHdGtJbnB1dE1ldGhvZEZpbHRl cjo6bm90aWZ5TW91c2VCdXR0b25QcmVzcygpIGlmIHRoZSBldmVudCBpcyBub3QKKyAgICAgICAg Z29pbmcgdG8gYmUgaGFuZGxlZC4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNvbmZpcm1Db21wb3NpdGlvbik6IENo ZWNrIHdoZXRoZXIgdGhlIGdpdmVuCisgICAgICAgIFN0cmluZyBpcyBOVUxMIHRvIGNvbnNpZGVy IGl0IGFzIGEgY3VycmVudCBjb21wb3NpdGlvbiBjb25maXJtYXRpb24uCisKKzIwMTMtMDEtMDQg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtT T1VQXSBDb252ZXJ0IFdlYlNvdXBSZXF1ZXN0TWFuYWdlclByb3h5IHRvIGJlIFdlYkNvbnRleHRT dXBwbGVtZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDYwMTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDI5MGY0NGYuLmYwNjlmYzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKQEAgLTYxNiwxNCArNjE2LDE0IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFz ZUJ1dHRvblByZXNzRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50QnV0CiAKICAgICBn dGtfd2lkZ2V0X2dyYWJfZm9jdXMod2lkZ2V0KTsKIAotICAgIHByaXYtPmlucHV0TWV0aG9kRmls dGVyLm5vdGlmeU1vdXNlQnV0dG9uUHJlc3MoKTsKLQogICAgIGlmICghcHJpdi0+Y2xpY2tDb3Vu dGVyLnNob3VsZFByb2Nlc3NCdXR0b25FdmVudChidXR0b25FdmVudCkpCiAgICAgICAgIHJldHVy biBUUlVFOwogCiAgICAgLy8gSWYgaXQncyBhIHJpZ2h0IGNsaWNrIGV2ZW50IHNhdmUgaXQgYXMg YSBwb3NzaWJsZSBjb250ZXh0IG1lbnUgZXZlbnQuCiAgICAgaWYgKGJ1dHRvbkV2ZW50LT5idXR0 b24gPT0gMykKICAgICAgICAgcHJpdi0+Y29udGV4dE1lbnVFdmVudC5zZXQoZ2RrX2V2ZW50X2Nv cHkocmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGJ1dHRvbkV2ZW50KSkpOworCisgICAgcHJp di0+aW5wdXRNZXRob2RGaWx0ZXIubm90aWZ5TW91c2VCdXR0b25QcmVzcygpOwogICAgIHByaXYt PnBhZ2VQcm94eS0+aGFuZGxlTW91c2VFdmVudChOYXRpdmVXZWJNb3VzZUV2ZW50KHJlaW50ZXJw cmV0X2Nhc3Q8R2RrRXZlbnQqPihidXR0b25FdmVudCksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByaXYtPmNsaWNrQ291bnRlci5jbGlja0Nv dW50Rm9yR2RrQnV0dG9uRXZlbnQod2lkZ2V0LCBidXR0b25FdmVudCkpKTsKICAgICByZXR1cm4g VFJVRTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApp bmRleCA5M2FjZTYyLi4wMjRmY2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0zNzA0LDcgKzM3MDQsMTAgQEAgdm9pZCBXZWJQYWdlOjpj b25maXJtQ29tcG9zaXRpb24oY29uc3QgU3RyaW5nJiBjb21wb3NpdGlvblN0cmluZywgaW50NjRf dCBzZWxlY3QKICAgICB9CiAKICAgICBFZGl0b3IqIGVkaXRvciA9IHRhcmdldEZyYW1lLT5lZGl0 b3IoKTsKLSAgICBlZGl0b3ItPmNvbmZpcm1Db21wb3NpdGlvbihjb21wb3NpdGlvblN0cmluZyk7 CisgICAgaWYgKGNvbXBvc2l0aW9uU3RyaW5nLmlzTnVsbCgpKQorICAgICAgICBlZGl0b3ItPmNv bmZpcm1Db21wb3NpdGlvbigpOworICAgIGVsc2UKKyAgICAgICAgZWRpdG9yLT5jb25maXJtQ29t cG9zaXRpb24oY29tcG9zaXRpb25TdHJpbmcpOwogCiAgICAgaWYgKHNlbGVjdGlvblN0YXJ0ID09 IC0xKSB7CiAgICAgICAgIG5ld1N0YXRlID0gZWRpdG9yU3RhdGUoKTsK