106050 2013-01-03 15:17:19 -0800 REGRESSION(r136152): [WK2] [GTK] Web inspector is not visible 2013-01-10 01:00:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 106052 1 a.renevier webkit-unassigned cgarcia mrobinson webkit.review.bot oldest_to_newest 799728 0 a.renevier 2013-01-03 15:17:19 -0800 Hi, with MiniBrowser, web inspector is not visible. I launch MiniBrowser (with --enable-developer-extras) flag; I right-click/inspect element. And I can see that web inspector is active, because I can select an element, and its layout overlay appears. But inspector widget is not attached to the page. That happens because inspector widget is not registered as inspectorView of the webViewBase. So, it would be better to call webkitWebViewBaseAddWebInspector instead of just gtk_container_add Additionaly, it is better to call gtk_container_add instead of webkitWebViewBaseAddWebInspector when inspector has its own window (because m_inspectorWindow is not a WEBKIT_WEB_VIEW_BASE). 799740 1 181233 a.renevier 2013-01-03 15:21:05 -0800 Created attachment 181233 patch proposal 800082 2 181233 cgarcia 2013-01-04 01:34:56 -0800 Comment on attachment 181233 patch proposal Thanks! 804143 3 181233 webkit.review.bot 2013-01-10 01:00:24 -0800 Comment on attachment 181233 patch proposal Clearing flags on attachment: 181233 Committed r139293: <http://trac.webkit.org/changeset/139293> 804145 4 webkit.review.bot 2013-01-10 01:00:28 -0800 All reviewed patches have been landed. Closing bug. 181233 2013-01-03 15:21:05 -0800 2013-01-10 01:00:23 -0800 patch proposal bug-106050-20130103151802.patch text/plain 2284 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTdmNDdmMDZkNTM4N2Ri ZThmNWVjODZkNTM4NTc2MWExZDA5YWYxYi4uNjZiYjg5MzY2NjVlODA4MzcyZTg2NzQ4OWNlOWEy OGJjOWFlZDMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTAzICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dL Ml0gW0d0a10gd2ViIGluc3BlY3RvciBpcyBub3QgdmlzaWJsZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjA1MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB3ZWJraXRXZWJWaWV3QmFzZUFkZFdl Ykluc3BlY3RvciB3aGVuIGFkZGluZyB3ZWIgaW5zcGVjdG9yIHRvCisgICAgICAgIHdlYnZpZXcg aW4gb3JkZXIgdG8gbWFrZSB3ZWJ2aWV3IGF3YXJlIG9mIGl0cyBleGlzdGVuY2UuCisKKyAgICAg ICAgVXNlIGd0a19jb250YWluZXJfYWRkIHdoZW4gYWRkaW5nIHdlYiBpbnNwZWN0b3Igd2lldyB0 byBpdHMgb3duIHdpbmRvdworICAgICAgICBiZWNhdXNlIG1faW5zcGVjdG9yV2luZG93IGlzIG5v dCBhIFdlYktpdFdlYlZpZXdCYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJJbnNw ZWN0b3JQcm94eUd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5Ojpj cmVhdGVJbnNwZWN0b3JXaW5kb3cpOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94 eTo6cGxhdGZvcm1BdHRhY2gpOgorCiAyMDEyLTEyLTIwICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJl bmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9y IGNvbG9yIGlucHV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dl Ykluc3BlY3RvclByb3h5R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2Vi SW5zcGVjdG9yUHJveHlHdGsuY3BwCmluZGV4IDJiNDExZmRlMDdjN2MyMzE5OTZlNTliNmRiMGMy N2EyNzU2NDhiNzAuLmViYTNjYWI0MmZlOGExMDVlNjZjOTY3ZWFjOGUyNGZjNTM3NWY4NGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJv eHlHdGsuY3BwCkBAIC05Myw3ICs5Myw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmNyZWF0 ZUluc3BlY3RvcldpbmRvdygpCiAgICAgZ3RrX3dpbmRvd19zZXRfdGl0bGUoR1RLX1dJTkRPVyht X2luc3BlY3RvcldpbmRvdyksIF8oIldlYiBJbnNwZWN0b3IiKSk7CiAgICAgZ3RrX3dpbmRvd19z ZXRfZGVmYXVsdF9zaXplKEdUS19XSU5ET1cobV9pbnNwZWN0b3JXaW5kb3cpLCBpbml0aWFsV2lu ZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQpOwogCi0gICAgd2Via2l0V2ViVmlld0Jhc2VB ZGRXZWJJbnNwZWN0b3IoV0VCS0lUX1dFQl9WSUVXX0JBU0UobV9pbnNwZWN0b3JXaW5kb3cpLCBt X2luc3BlY3RvclZpZXcpOworICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIobV9p bnNwZWN0b3JXaW5kb3cpLCBtX2luc3BlY3RvclZpZXcpOwogICAgIGd0a193aWRnZXRfc2hvdyht X2luc3BlY3RvclZpZXcpOwogCiAgICAgZ19vYmplY3RfYWRkX3dlYWtfcG9pbnRlcihHX09CSkVD VChtX2luc3BlY3RvcldpbmRvdyksIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmbV9pbnNwZWN0 b3JXaW5kb3cpKTsKQEAgLTE5MSw3ICsxOTEsNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5Ojpw bGF0Zm9ybUF0dGFjaCgpCiAgICAgaWYgKG1fY2xpZW50LmF0dGFjaCh0aGlzKSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUihtX3BhZ2UtPnZp ZXdXaWRnZXQoKSksIG1faW5zcGVjdG9yVmlldyk7CisgICAgd2Via2l0V2ViVmlld0Jhc2VBZGRX ZWJJbnNwZWN0b3IoV0VCS0lUX1dFQl9WSUVXX0JBU0UobV9wYWdlLT52aWV3V2lkZ2V0KCkpLCBt X2luc3BlY3RvclZpZXcpOwogICAgIGd0a193aWRnZXRfc2hvdyhtX2luc3BlY3RvclZpZXcpOwog fQogCg==