106043 2013-01-03 14:48:13 -0800 Dashboard cleanup: remove usage of global g_defaultBuilderName 2013-01-03 16:27:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth dpranke ojan tony webkit.review.bot oldest_to_newest 799702 0 jparent 2013-01-03 14:48:13 -0800 Dashboard cleanup: remove usage of global g_defaultBuilderName 799709 1 181226 jparent 2013-01-03 14:56:20 -0800 Created attachment 181226 Patch 799777 2 181226 abarth 2013-01-03 15:43:06 -0800 Comment on attachment 181226 Patch LGTM, but we can ask Ojan if you'd like a second opinion. 799784 3 181226 ojan 2013-01-03 15:49:50 -0800 Comment on attachment 181226 Patch lgtm 799824 4 181226 webkit.review.bot 2013-01-03 16:27:44 -0800 Comment on attachment 181226 Patch Clearing flags on attachment: 181226 Committed r138762: <http://trac.webkit.org/changeset/138762> 799825 5 webkit.review.bot 2013-01-03 16:27:47 -0800 All reviewed patches have been landed. Closing bug. 181226 2013-01-03 14:56:20 -0800 2013-01-03 16:27:43 -0800 Patch bug-106043-20130103145328.patch text/plain 7501 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NzQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGM3YzA3MjY5OTVjMjI0N2NjZTNjZjUxNjU3ODgzYjBk MjFhYjQxMS4uM2Y3OGU1MTdkYmVmOGJmYmY3ZDQ2YjM4OGU5M2M3ZmJiOTNkMDY1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDEzLTAxLTAzICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBEYXNoYm9hcmQgY2xlYW51cDogcmVtb3ZlIHVzYWdlIG9mIGdsb2JhbCBnX2RlZmF1 bHRCdWlsZGVyTmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA2MDQzCisKKyAgICAgICAgVXNlIG5vdyBwdWJsaWMgZGVmYXVsdEJ1aWxkZXIoKSBm cm9tIHRoZSBCdWlsZGVyR3JvdXAsIHJhdGhlcgorICAgICAgICB0aGFuIGdsb2JhbCB2YXJpYWJs ZS4KKworICAgICAgICBBbHNvIGVsaW1pbmF0ZXMgdGhlIHNldHVwKCkgYW5kIGluaXRCdWlsZGVy cygpIGZ1bmN0aW9ucyBzaW5jZSB3ZQorICAgICAgICBubyBsb25nZXIgbmVlZCB0byB0cmFjayB0 aGUgZ2xvYmFsLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qczoKKyAg ICAgICAgKEJ1aWxkZXJHcm91cC5wcm90b3R5cGUuZGVmYXVsdEJ1aWxkZXIpOgorICAgICAgICAo QnVpbGRlckdyb3VwLnByb3RvdHlwZS5tYXN0ZXIpOgorICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanM6CisgICAgICAgIChwYXJzZVBh cmFtZXRlcnMpOgorICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMv Zmxha2luZXNzX2Rhc2hib2FyZC5qczoKKyAgICAgICAgKHVwZGF0ZURlZmF1bHRCdWlsZGVyU3Rh dGUpOgorICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVy LmpzOgorICAgICAgICAoLik6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFz aGJvYXJkcy9sb2FkZXJfdW5pdHRlc3RzLmpzOgorCiAyMDEzLTAxLTAzICBFbWlsIEEgRWtsdW5k ICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggb3ZlcmZsb3cgaW4gTGF5b3V0VW5p dDo6Y2VpbCBhbmQgZmxvb3IgZm9yIFNBVFVSQVRFRF9MQVlPVVRfQVJJVEhNRVRJQwpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5q cyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMK aW5kZXggMzI3MzFlYTE2OGI1YjNkMjI0YTAyYjdiZmNjNjU3Njg3ODg2OWFjNy4uZjk3MWE2NTFl MWM3MWE3YWJhOGEwYWQ4OGYwYzMzYTgwZWQwODljNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcworKysgYi9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCkBAIC0xMjIsMTQgKzEy Miw3IEBAIEJ1aWxkZXJHcm91cC5wcm90b3R5cGUuYXBwZW5kID0gZnVuY3Rpb24oYnVpbGRlcnMp IHsKICAgICB9LCB0aGlzKTsKIH07CiAKLUJ1aWxkZXJHcm91cC5wcm90b3R5cGUuc2V0dXAgPSBm dW5jdGlvbigpCi17Ci0gICAgLy8gRklYTUU6IGluc3RlYWQgb2YgY29weWluZyB0aGVzZSB0byBn bG9iYWxzLCBpdCB3b3VsZCBiZSBiZXR0ZXIgaWYKLSAgICAvLyB0aGUgcmVzdCBvZiB0aGUgY29k ZSByZWFkIHRoaW5ncyBmcm9tIHRoZSBCdWlsZGVyR3JvdXAgaW5zdGFuY2UgZGlyZWN0bHkKLSAg ICBnX2RlZmF1bHRCdWlsZGVyTmFtZSA9IHRoaXMuX2RlZmF1bHRCdWlsZGVyKCk7Ci19OwotCi1C dWlsZGVyR3JvdXAucHJvdG90eXBlLl9kZWZhdWx0QnVpbGRlciA9IGZ1bmN0aW9uKCkKK0J1aWxk ZXJHcm91cC5wcm90b3R5cGUuZGVmYXVsdEJ1aWxkZXIgPSBmdW5jdGlvbigpCiB7CiAgICAgZm9y ICh2YXIgYnVpbGRlciBpbiB0aGlzLmJ1aWxkZXJzKQogICAgICAgICByZXR1cm4gYnVpbGRlcjsK QEAgLTEzOCw3ICsxMzEsNyBAQCBCdWlsZGVyR3JvdXAucHJvdG90eXBlLl9kZWZhdWx0QnVpbGRl ciA9IGZ1bmN0aW9uKCkKIAogQnVpbGRlckdyb3VwLnByb3RvdHlwZS5tYXN0ZXIgPSBmdW5jdGlv bigpCiB7Ci0gICAgcmV0dXJuIGJ1aWxkZXJNYXN0ZXIodGhpcy5fZGVmYXVsdEJ1aWxkZXIoKSk7 CisgICAgcmV0dXJuIGJ1aWxkZXJNYXN0ZXIodGhpcy5kZWZhdWx0QnVpbGRlcigpKTsKIH0KIAog QnVpbGRlckdyb3VwLlRPVF9XRUJLSVQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcyBiL1Rvb2xzL1Rl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMKaW5kZXgg ZTUxNzY4YThhMjYyMjVkZDU4YzE4YTNiMjM1YjI3MjIyY2Y3MWE3OC4uNTRiMDc3YWZhMzVkZDY2 MjZhZmU2ZjU4NDhjODBiODg4N2ZhOTkwMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcworKysgYi9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzCkBAIC0zMjgs OCArMzI4LDkgQEAgZnVuY3Rpb24gcGFyc2VQYXJhbWV0ZXJzKCkKICAgICB2YXIgZGFzaGJvYXJk U3BlY2lmaWNEaWZmU3RhdGUgPSBkaWZmU3RhdGVzKG9sZERhc2hib2FyZFNwZWNpZmljU3RhdGUs IGdfY3VycmVudFN0YXRlKTsKIAogICAgIGZpbGxNaXNzaW5nVmFsdWVzKGdfY3VycmVudFN0YXRl LCBnX2RlZmF1bHREYXNoYm9hcmRTcGVjaWZpY1N0YXRlVmFsdWVzKTsKKwogICAgIGlmICghZ19j cm9zc0Rhc2hib2FyZFN0YXRlLnVzZVRlc3REYXRhKQotICAgICAgICBmaWxsTWlzc2luZ1ZhbHVl cyhnX2N1cnJlbnRTdGF0ZSwgeydidWlsZGVyJzogZ19kZWZhdWx0QnVpbGRlck5hbWV9KTsKKyAg ICAgICAgZmlsbE1pc3NpbmdWYWx1ZXMoZ19jdXJyZW50U3RhdGUsIHsnYnVpbGRlcic6IGN1cnJl bnRCdWlsZGVyR3JvdXAoKS5kZWZhdWx0QnVpbGRlcigpfSk7CiAKICAgICAvLyBGSVhNRTogZGFz aGJvYXJkX2Jhc2Ugc2hvdWxkbid0IGtub3cgYW55dGhpbmcgYWJvdXQgc3BlY2lmaWMgZGFzaGJv YXJkIHNwZWNpZmljIGtleXMuCiAgICAgaWYgKGRhc2hib2FyZFNwZWNpZmljRGlmZlN0YXRlLmJ1 aWxkZXIpCkBAIC00MjYsMTIgKzQyNyw2IEBAIGZ1bmN0aW9uIGlzVGlwT2ZUcmVlV2ViS2l0QnVp bGRlcigpCiAgICAgcmV0dXJuIGN1cnJlbnRCdWlsZGVyR3JvdXAoKS5pc1RvVFdlYktpdDsKIH0K IAotdmFyIGdfZGVmYXVsdEJ1aWxkZXJOYW1lOwotZnVuY3Rpb24gaW5pdEJ1aWxkZXJzKCkKLXsK LSAgICBjdXJyZW50QnVpbGRlckdyb3VwKCkuc2V0dXAoKTsKLX0KLQogdmFyIGdfcmVzdWx0c0J5 QnVpbGRlciA9IHt9OwogdmFyIGdfZXhwZWN0YXRpb25zQnlQbGF0Zm9ybSA9IHt9OwogdmFyIGdf c3RhbGVCdWlsZGVycyA9IFtdOwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmpzIGIvVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmpzCmluZGV4IGMz NzcxMWIzY2Q2Njk4ZDczZjg3NGMwNjlmZDM3ZDVhMTk2NmY2OTIuLjU5MmY1M2VmMjMxYzFkZWY2 YzA4YWUyMmQ5M2EzMzc5NDI1OWMzZDUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5qcworKysgYi9Ub29scy9U ZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuanMK QEAgLTI0ODksNyArMjQ4OSw3IEBAIGZ1bmN0aW9uIHVwZGF0ZURlZmF1bHRCdWlsZGVyU3RhdGUo KQogICAgIGlmIChpc0Nyb3NzQnVpbGRlclZpZXcoKSkKICAgICAgICAgZGVsZXRlIGdfZGVmYXVs dERhc2hib2FyZFNwZWNpZmljU3RhdGVWYWx1ZXMuYnVpbGRlcjsKICAgICBlbHNlCi0gICAgICAg IGdfZGVmYXVsdERhc2hib2FyZFNwZWNpZmljU3RhdGVWYWx1ZXMuYnVpbGRlciA9IGdfZGVmYXVs dEJ1aWxkZXJOYW1lOworICAgICAgICBnX2RlZmF1bHREYXNoYm9hcmRTcGVjaWZpY1N0YXRlVmFs dWVzLmJ1aWxkZXIgPSBjdXJyZW50QnVpbGRlckdyb3VwKCkuZGVmYXVsdEJ1aWxkZXIoKTsKIH0K IAogLy8gU2V0cyB0aGUgcGFnZSBzdGF0ZSB0byByZWdlbmVyYXRlIHRoZSBwYWdlLgpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXIuanMg Yi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlci5qcwppbmRl eCBhNmQ4NTQzMDYwODkyZTIwNDhiYWRjM2U3MzEwMDVhZTUzMDEzMTIyLi44NDljOWM5YWU5MDc0 YjZkZGFjNjYwMWQzYmM5Y2IyZTk1OGJjNDAzIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlci5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlci5qcwpAQCAtODMsNyArODMsNiBAQCBsb2Fk ZXIuTG9hZGVyLnByb3RvdHlwZSA9IHsKICAgICBfbG9hZEJ1aWxkZXJzTGlzdDogZnVuY3Rpb24o KQogICAgIHsKICAgICAgICAgbG9hZEJ1aWxkZXJzTGlzdChnX2Nyb3NzRGFzaGJvYXJkU3RhdGUu Z3JvdXAsIGdfY3Jvc3NEYXNoYm9hcmRTdGF0ZS50ZXN0VHlwZSk7Ci0gICAgICAgIGluaXRCdWls ZGVycygpOwogICAgICAgICB0aGlzLl9sb2FkTmV4dCgpOwogICAgIH0sCiAgICAgX2xvYWRSZXN1 bHRzRmlsZXM6IGZ1bmN0aW9uKCkKQEAgLTE3MCwxOSArMTY5LDE1IEBAIGxvYWRlci5Mb2FkZXIu cHJvdG90eXBlID0gewogICAgICAgICBkZWxldGUgY3VycmVudEJ1aWxkZXJzKClbYnVpbGRlck5h bWVdOwogCiAgICAgICAgIC8vIENoYW5nZSB0aGUgZGVmYXVsdCBidWlsZGVyIG5hbWUgaWYgaXQg aGFzIGJlZW4gZGVsZXRlZC4KLSAgICAgICAgaWYgKGdfZGVmYXVsdEJ1aWxkZXJOYW1lID09IGJ1 aWxkZXJOYW1lKSB7Ci0gICAgICAgICAgICBnX2RlZmF1bHRCdWlsZGVyTmFtZSA9IG51bGw7Ci0g ICAgICAgICAgICBmb3IgKHZhciBhdmFpbGFibGVCdWlsZGVyTmFtZSBpbiBjdXJyZW50QnVpbGRl cnMoKSkgewotICAgICAgICAgICAgICAgIGdfZGVmYXVsdEJ1aWxkZXJOYW1lID0gYXZhaWxhYmxl QnVpbGRlck5hbWU7Ci0gICAgICAgICAgICAgICAgZ19kZWZhdWx0RGFzaGJvYXJkU3BlY2lmaWNT dGF0ZVZhbHVlcy5idWlsZGVyID0gYXZhaWxhYmxlQnVpbGRlck5hbWU7Ci0gICAgICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAoIWdfZGVmYXVsdEJ1aWxk ZXJOYW1lKSB7CisgICAgICAgIGlmIChnX2RlZmF1bHREYXNoYm9hcmRTcGVjaWZpY1N0YXRlVmFs dWVzLmJ1aWxkZXIgPT0gYnVpbGRlck5hbWUpIHsKKyAgICAgICAgICAgIHZhciBkZWZhdWx0QnVp bGRlck5hbWUgPSBjdXJyZW50QnVpbGRlckdyb3VwKCkuZGVmYXVsdEJ1aWxkZXIoKTsKKyAgICAg ICAgICAgIGdfZGVmYXVsdERhc2hib2FyZFNwZWNpZmljU3RhdGVWYWx1ZXMuYnVpbGRlciA9IGRl ZmF1bHRCdWlsZGVyTmFtZTsKKyAgICAgICAgICAgIGlmICghZGVmYXVsdEJ1aWxkZXJOYW1lKSB7 CiAgICAgICAgICAgICAgICAgdmFyIGVycm9yID0gJ05vIHRlc3RzIHJlc3VsdHMgZm91bmQgZm9y ICcgKyBnX2Nyb3NzRGFzaGJvYXJkU3RhdGUudGVzdFR5cGUgKyAnLiBSZWxvYWQgdGhlIHBhZ2Ug dG8gdHJ5IGZldGNoaW5nIGl0IGFnYWluLic7CiAgICAgICAgICAgICAgICAgY29uc29sZS5lcnJv cihlcnJvcik7CiAgICAgICAgICAgICAgICAgYWRkRXJyb3IoZXJyb3IpOwogICAgICAgICAgICAg fQotICAgICAgICB9CisgICAgICAgfQogCiAgICAgICAgIC8vIFByb2NlZWQgYXMgaWYgdGhlIHJl c291cmNlIGhhZCBsb2FkZWQuCiAgICAgICAgIHRoaXMuX2hhbmRsZVJlc291cmNlTG9hZCgpOwpk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2Fk ZXJfdW5pdHRlc3RzLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk cy9sb2FkZXJfdW5pdHRlc3RzLmpzCmluZGV4IGQ3YTkwZGZiNTI1ZGRlNjkzNjU0ZWNmMWVhODk2 NzRiYTY0MTM5NGQuLmNiNWI3OGI2ZmYzYjRjNDM3ZDliNDNiZjhjOTkyMTc2ZDNmNDdiNjMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVy X3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL2xvYWRlcl91bml0dGVzdHMuanMKQEAgLTEzOSwxNCArMTM5LDE0IEBAIHRlc3QoJ0RlZmF1 bHQgYnVpbGRlciBnZXRzIHNldC4nLCAzLCBmdW5jdGlvbigpIHsKICAgICByZXNldEdsb2JhbHMo KTsKICAgICBsb2FkQnVpbGRlcnNMaXN0KCdAVG9UIC0gY2hyb21pdW0ub3JnJywgJ2xheW91dC10 ZXN0cycpOwogICAgIAotICAgIHZhciBkZWZhdWx0QnVpbGRlciA9IGdfZGVmYXVsdEJ1aWxkZXJO YW1lOworICAgIHZhciBkZWZhdWx0QnVpbGRlciA9IGN1cnJlbnRCdWlsZGVyR3JvdXAoKS5kZWZh dWx0QnVpbGRlcigpOwogICAgIG9rKGRlZmF1bHRCdWlsZGVyLCAiRGVmYXVsdCBidWlsZGVyIHNo b3VsZCBleGlzdC4iKTsKICAgIAogICAgIC8vIFNpbXVsYXRlIGVycm9yIGxvYWRpbmcgdGhlIGRl ZmF1bHQgYnVpbGRlciBkYXRhLCB0aGVuIG1ha2Ugc3VyZQogICAgIC8vIGEgbmV3IGRlZmF1bHRC dWlsZGVyIGlzIHNldCwgYW5kIGlzbid0IHRoZSBub3cgaW52YWxpZCBvbmUuCiAgICAgdmFyIHJl c291cmNlTG9hZGVyID0gbmV3IGxvYWRlci5Mb2FkZXIoKTsKICAgICByZXNvdXJjZUxvYWRlci5f aGFuZGxlUmVzdWx0c0ZpbGVMb2FkRXJyb3IoZGVmYXVsdEJ1aWxkZXIpOwotICAgIHZhciBuZXdE ZWZhdWx0QnVpbGRlciA9IGdfZGVmYXVsdEJ1aWxkZXJOYW1lOworICAgIHZhciBuZXdEZWZhdWx0 QnVpbGRlciA9IGN1cnJlbnRCdWlsZGVyR3JvdXAoKS5kZWZhdWx0QnVpbGRlcigpOwogICAgIG9r KG5ld0RlZmF1bHRCdWlsZGVyLCAiVGhlcmUgc2hvdWxkIHN0aWxsIGJlIGEgZGVmYXVsdCBidWls ZGVyLiIpOwogICAgIG5vdEVxdWFsKG5ld0RlZmF1bHRCdWlsZGVyLCBkZWZhdWx0QnVpbGRlciwg IkRlZmF1bHQgYnVpbGRlciBzaG91bGQgbm90IGJlIHRoZSBvbGQgZGVmYXVsdCBidWlsZGVyIik7 CiB9KTsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==