106037 2013-01-03 13:58:37 -0800 [chromium] Remove the contents of WebVideoFrame class 2013-03-06 10:48:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107297 1 danakj danakj abarth dglazkov eric.carlson feature-media-reviews fischman fishd jamesr peter+ews sheu tkent+wkapi webkit.review.bot oldest_to_newest 799657 0 danakj 2013-01-03 13:58:37 -0800 [chromium] Remove the contents of WebVideoFrame class 799659 1 181216 danakj 2013-01-03 13:59:38 -0800 Created attachment 181216 Patch 799660 2 danakj 2013-01-03 14:00:08 -0800 This depends on https://codereview.chromium.org/11754003/ 799663 3 webkit.review.bot 2013-01-03 14:02:01 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 799695 4 181216 webkit.review.bot 2013-01-03 14:42:00 -0800 Comment on attachment 181216 Patch Attachment 181216 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15635947 799738 5 181216 peter+ews 2013-01-03 15:21:03 -0800 Comment on attachment 181216 Patch Attachment 181216 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15638940 799806 6 181216 jamesr 2013-01-03 16:05:35 -0800 Comment on attachment 181216 Patch R=me, but this won't compile until the chromium side lands. 810630 7 181216 webkit.review.bot 2013-01-18 08:25:26 -0800 Comment on attachment 181216 Patch Rejecting attachment 181216 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15946462 810636 8 183467 danakj 2013-01-18 08:31:53 -0800 Created attachment 183467 Patch for landing 810668 9 183467 webkit.review.bot 2013-01-18 09:02:29 -0800 Comment on attachment 183467 Patch for landing Clearing flags on attachment: 183467 Committed r140158: <http://trac.webkit.org/changeset/140158> 810669 10 webkit.review.bot 2013-01-18 09:02:34 -0800 All reviewed patches have been landed. Closing bug. 810731 11 danakj 2013-01-18 09:45:34 -0800 Something is android is using the WebVideoFrame members still. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/10613/steps/compile/logs/stdio#error1 webkit/media/android/webmediaplayer_android.cc: In member function 'virtual WebKit::WebVideoFrame* webkit_media::WebMediaPlayerAndroid::getCurrentFrame()': webkit/media/android/webmediaplayer_android.cc:393:35:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'width' webkit/media/android/webmediaplayer_android.cc:393:58:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'height' 810735 12 webkit.review.bot 2013-01-18 09:46:55 -0800 Re-opened since this is blocked by bug 107297 849057 13 183467 webkit.review.bot 2013-03-06 10:48:23 -0800 Comment on attachment 183467 Patch for landing Clearing flags on attachment: 183467 Committed r144946: <http://trac.webkit.org/changeset/144946> 849058 14 webkit.review.bot 2013-03-06 10:48:28 -0800 All reviewed patches have been landed. Closing bug. 181216 2013-01-03 13:59:38 -0800 2013-01-18 08:31:49 -0800 Patch bug-106037-20130103165645.patch text/plain 2445 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA2ZThkOGZlZDNlZDli ZjZiMTY4MDZkYjM0OTk3MTEwNDIyZjE1NTM4Li5hNDM3ODgyOWY2YjdmNzI5MDMxNjZhZTMxOGQy OGZmOTZjMjliMTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wMS0wMyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB0aGUgY29udGVudHMgb2YgV2ViVmlkZW9GcmFtZSBjbGFzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MDM3CisKKyAgICAgICAgVGhp cyBjbGFzcyBiZWNvbWVzIGFuIGVtcHR5IGJhc2UgY2xhc3Mgbm93LCB1c2VkIG9ubHkgZm9yIHRo ZSBBUEkKKyAgICAgICAgYm91bmRhcnkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi VmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMy0wMS0wMiAgSmFtZXMgUm9i aW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3Zl IHVudXNlZCB0cmFuc2l0aW9uYWwgI2RlZmluZXMgZnJvbSBQbGF0Zm9ybSBBUEkKZGlmZiAtLWdp dCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oIGIvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKaW5kZXggOTA4MDA5 NTkxMTllMWNiMjg4NWNhYmUyYzQyOGFkN2NjMWI5ODNmMS4uMGNmM2U3Y2ViMDEzZmE3Y2ZmOGM2 ZDc0N2FiZTU2MzFlOGQ0ZDAzNiAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJWaWRlb0ZyYW1lLmgKQEAgLTM2LDQ0ICszNiwxMCBAQAogCiBuYW1lc3BhY2UgV2Vi S2l0IHsKIAotLy8gQSBwcm94eSB2aWRlbyBmcmFtZSBpbnRlcmZhY2UgdG8gY29tbXVuaWNhdGUg ZnJhbWUgZGF0YSBiZXR3ZWVuIGNocm9taXVtCi0vLyBhbmQgV2ViS2l0LgotLy8gS2VlcCBpbiBz eW5jIHdpdGggY2hyb21pdW0ncyBtZWRpYTo6VmlkZW9GcmFtZTo6Rm9ybWF0LgorLy8gQSBiYXNl IGNsYXNzIGZvciB0aGUgY29udGFpbmVyIHdoaWNoIGhvbGRzIGEgbWVkaWE6OlZpZGVvRnJhbWUu CiBjbGFzcyBXZWJWaWRlb0ZyYW1lIHsKIHB1YmxpYzoKLSAgICBlbnVtIHsKLSAgICAgICAgcmdi UGxhbmUgPSAwLAotICAgICAgICBudW1SR0JQbGFuZXMgPSAxCi0gICAgfTsKLSAgICBlbnVtIHsK LSAgICAgICAgeVBsYW5lID0gMCwKLSAgICAgICAgdVBsYW5lID0gMSwKLSAgICAgICAgdlBsYW5l ID0gMiwKLSAgICAgICAgbnVtWVVWUGxhbmVzID0gMwotICAgIH07Ci0gICAgZW51bSB7IG1heFBs YW5lcyA9IDMgfTsKLQotICAgIGVudW0gRm9ybWF0IHsKLSAgICAgICAgRm9ybWF0SW52YWxpZCA9 IDAsCi0gICAgICAgIEZvcm1hdFJHQjMyID0gNCwKLSAgICAgICAgRm9ybWF0WVYxMiA9IDYsCi0g ICAgICAgIEZvcm1hdFlWMTYgPSA3LAotICAgICAgICBGb3JtYXRFbXB0eSA9IDksCi0gICAgICAg IEZvcm1hdEk0MjAgPSAxMSwKLSAgICAgICAgRm9ybWF0TmF0aXZlVGV4dHVyZSA9IDEyLAotICAg IH07Ci0KICAgICB2aXJ0dWFsIH5XZWJWaWRlb0ZyYW1lKCkgeyB9Ci0gICAgdmlydHVhbCBGb3Jt YXQgZm9ybWF0KCkgY29uc3QgeyByZXR1cm4gRm9ybWF0SW52YWxpZDsgfQotICAgIHZpcnR1YWwg dW5zaWduZWQgd2lkdGgoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25l ZCBoZWlnaHQoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25lZCBwbGFu ZXMoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCBpbnQgc3RyaWRlKHVuc2lnbmVk IHBsYW5lKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCBjb25zdCB2b2lkKiBkYXRh KHVuc2lnbmVkIHBsYW5lKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25l ZCB0ZXh0dXJlSWQoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25lZCB0 ZXh0dXJlVGFyZ2V0KCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwgV2ViS2l0OjpX ZWJSZWN0IHZpc2libGVSZWN0KCkgY29uc3QgeyByZXR1cm4gV2ViS2l0OjpXZWJSZWN0KCk7IH0K LSAgICB2aXJ0dWFsIFdlYktpdDo6V2ViU2l6ZSB0ZXh0dXJlU2l6ZSgpIGNvbnN0IHsgcmV0dXJu IFdlYktpdDo6V2ViU2l6ZSgpOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 183467 2013-01-18 08:31:53 -0800 2013-03-06 10:48:23 -0800 Patch for landing bug-106037-20130118112852.patch text/plain 2501 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBmODlhMmE4YjcyNjA1 NTI5MGNkZmE3MmM0NjMzMzUxZDg5NjJhMTdjLi42ZWRiMTJhMzE3MDkxOGYyZjFiMDZjNGQ1ZWJi MGU5ZWQ4ZTliMWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMS0wMyAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB0aGUgY29udGVudHMgb2YgV2ViVmlkZW9GcmFtZSBjbGFzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2MDM3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCisKKyAgICAgICAgVGhpcyBjbGFzcyBiZWNvbWVzIGFu IGVtcHR5IGJhc2UgY2xhc3Mgbm93LCB1c2VkIG9ubHkgZm9yIHRoZSBBUEkKKyAgICAgICAgYm91 bmRhcnkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oOgorICAg ICAgICAoV2ViS2l0KToKKwogMjAxMy0wMS0xMCAgVG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdA Z29vZ2xlLmNvbT4KIAogICAgICAgICBNZWRpYVN0cmVhbSBBUEk6IEFkZGluZyB0aGUgbmV3IGlk IGF0dHJpYnV0ZSB0byBNZWRpYVN0cmVhbSBhbmQgTWVkaWFTdHJlYW1UcmFjawpkaWZmIC0tZ2l0 IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmggYi9Tb3Vy Y2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlZpZGVvRnJhbWUuaAppbmRleCA5MDgwMDk1 OTExOWUxY2IyODg1Y2FiZTJjNDI4YWQ3Y2MxYjk4M2YxLi4wY2YzZTdjZWIwMTNmYTdjZmY4YzZk NzQ3YWJlNTYzMWU4ZDRkMDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0v cHVibGljL1dlYlZpZGVvRnJhbWUuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYlZpZGVvRnJhbWUuaApAQCAtMzYsNDQgKzM2LDEwIEBACiAKIG5hbWVzcGFjZSBXZWJL aXQgewogCi0vLyBBIHByb3h5IHZpZGVvIGZyYW1lIGludGVyZmFjZSB0byBjb21tdW5pY2F0ZSBm cmFtZSBkYXRhIGJldHdlZW4gY2hyb21pdW0KLS8vIGFuZCBXZWJLaXQuCi0vLyBLZWVwIGluIHN5 bmMgd2l0aCBjaHJvbWl1bSdzIG1lZGlhOjpWaWRlb0ZyYW1lOjpGb3JtYXQuCisvLyBBIGJhc2Ug Y2xhc3MgZm9yIHRoZSBjb250YWluZXIgd2hpY2ggaG9sZHMgYSBtZWRpYTo6VmlkZW9GcmFtZS4K IGNsYXNzIFdlYlZpZGVvRnJhbWUgewogcHVibGljOgotICAgIGVudW0gewotICAgICAgICByZ2JQ bGFuZSA9IDAsCi0gICAgICAgIG51bVJHQlBsYW5lcyA9IDEKLSAgICB9OwotICAgIGVudW0gewot ICAgICAgICB5UGxhbmUgPSAwLAotICAgICAgICB1UGxhbmUgPSAxLAotICAgICAgICB2UGxhbmUg PSAyLAotICAgICAgICBudW1ZVVZQbGFuZXMgPSAzCi0gICAgfTsKLSAgICBlbnVtIHsgbWF4UGxh bmVzID0gMyB9OwotCi0gICAgZW51bSBGb3JtYXQgewotICAgICAgICBGb3JtYXRJbnZhbGlkID0g MCwKLSAgICAgICAgRm9ybWF0UkdCMzIgPSA0LAotICAgICAgICBGb3JtYXRZVjEyID0gNiwKLSAg ICAgICAgRm9ybWF0WVYxNiA9IDcsCi0gICAgICAgIEZvcm1hdEVtcHR5ID0gOSwKLSAgICAgICAg Rm9ybWF0STQyMCA9IDExLAotICAgICAgICBGb3JtYXROYXRpdmVUZXh0dXJlID0gMTIsCi0gICAg fTsKLQogICAgIHZpcnR1YWwgfldlYlZpZGVvRnJhbWUoKSB7IH0KLSAgICB2aXJ0dWFsIEZvcm1h dCBmb3JtYXQoKSBjb25zdCB7IHJldHVybiBGb3JtYXRJbnZhbGlkOyB9Ci0gICAgdmlydHVhbCB1 bnNpZ25lZCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIHVuc2lnbmVk IGhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIHVuc2lnbmVkIHBsYW5l cygpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIGludCBzdHJpZGUodW5zaWduZWQg cGxhbmUpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIGNvbnN0IHZvaWQqIGRhdGEo dW5zaWduZWQgcGxhbmUpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIHVuc2lnbmVk IHRleHR1cmVJZCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KLSAgICB2aXJ0dWFsIHVuc2lnbmVkIHRl eHR1cmVUYXJnZXQoKSBjb25zdCB7IHJldHVybiAwOyB9Ci0gICAgdmlydHVhbCBXZWJLaXQ6Oldl YlJlY3QgdmlzaWJsZVJlY3QoKSBjb25zdCB7IHJldHVybiBXZWJLaXQ6OldlYlJlY3QoKTsgfQot ICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJTaXplIHRleHR1cmVTaXplKCkgY29uc3QgeyByZXR1cm4g V2ViS2l0OjpXZWJTaXplKCk7IH0KIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=