106032 2013-01-03 13:40:59 -0800 r138413 caused 8 http/tests/security/cookies tests to fail on Win7 2013-01-16 08:55:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 roger_fong webkit-unassigned ap roger_fong oldest_to_newest 799630 0 roger_fong 2013-01-03 13:40:59 -0800 Results: http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r138513%20(31211)/results.html An assertion failure is hit ASSERT(privateBrowsingStorageSession()) in WebFrameNetworkingContext::storageSession() Stack Trace: > WebKit.dll!WebFrameNetworkingContext::storageSession() Line 99 + 0x36 bytes C++ WebKit.dll!WebCore::ResourceHandle::start(WebCore::NetworkingContext * context=0x009b6f40) Line 509 + 0xf bytes C++ WebKit.dll!WebCore::ResourceHandle::create(WebCore::NetworkingContext * context=0x009b6f40, const WebCore::ResourceRequest & request={...}, WebCore::ResourceHandleClient * client=0x07872830, bool defersLoading=false, bool shouldContentSniff=true) Line 82 + 0x13 bytes C++ WebKit.dll!WebCore::ResourceLoader::start() Line 171 + 0x49 bytes C++ WebKit.dll!WebCore::ResourceLoadScheduler::servePendingRequests(WebCore::ResourceLoadScheduler::HostInformation * host=0x0785c6a8, WebCore::ResourceLoadPriority minimumPriority=ResourceLoadPriorityVeryHigh) Line 243 C++ WebKit.dll!WebCore::ResourceLoadScheduler::scheduleLoad(WebCore::ResourceLoader * resourceLoader=0x07872830, WebCore::ResourceLoadPriority priority=ResourceLoadPriorityVeryHigh) Line 158 C++ WebKit.dll!WebCore::ResourceLoadScheduler::scheduleSubresourceLoad(WebCore::Frame * frame=0x009a52f0, WebCore::CachedResource * resource=0x078722c8, const WebCore::ResourceRequest & request={...}, WebCore::ResourceLoadPriority priority=ResourceLoadPriorityVeryHigh, const WebCore::ResourceLoaderOptions & options={...}) Line 124 C++ WebKit.dll!WebCore::CachedResource::load(WebCore::CachedResourceLoader * cachedResourceLoader=0x00a7f168, const WebCore::ResourceLoaderOptions & options={...}) Line 316 + 0x72 bytes C++ WebKit.dll!WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type type=MainResource, WebCore::CachedResourceRequest & request={...}) Line 466 + 0x30 bytes C++ WebKit.dll!WebCore::CachedResourceLoader::requestMainResource(WebCore::CachedResourceRequest & request={...}) Line 256 + 0x12 bytes C++ WebKit.dll!WebCore::MainResourceLoader::load(const WebCore::ResourceRequest & initialRequest={...}, const WebCore::SubstituteData & substituteData={...}) Line 656 + 0x24 bytes C++ WebKit.dll!WebCore::DocumentLoader::startLoadingMainResource() Line 890 C++ WebKit.dll!WebCore::FrameLoader::continueLoadAfterWillSubmitForm() Line 2218 C++ WebKit.dll!WebCore::PolicyChecker::continueLoadAfterWillSubmitForm(WebCore::PolicyAction __formal=PolicyUse) Line 135 C++ WebKit.dll!WebFrame::dispatchWillSubmitForm(void (WebCore::PolicyAction)* function=0x5bbe4660, WTF::PassRefPtr<WebCore::FormState> formState={...}) Line 1526 + 0x18 bytes C++ WebKit.dll!WebCore::FrameLoader::continueLoadAfterNavigationPolicy(const WebCore::ResourceRequest & __formal={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, bool shouldContinue=true) Line 2817 C++ WebKit.dll!WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void * argument=0x009a5340, const WebCore::ResourceRequest & request={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, bool shouldContinue=true) Line 2689 C++ WebKit.dll!WebCore::PolicyCallback::call(bool shouldContinue=true) Line 103 + 0x34 bytes C++ WebKit.dll!WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction policy=PolicyUse) Line 168 C++ WebKit.dll!WebFrame::receivedPolicyDecision(WebCore::PolicyAction action=PolicyUse) Line 1728 + 0x1a bytes C++ WebKit.dll!WebFramePolicyListener::receivedPolicyDecision(WebCore::PolicyAction action=PolicyUse) Line 126 C++ WebKit.dll!WebFramePolicyListener::use() Line 97 C++ WebKit.dll!DefaultPolicyDelegate::decidePolicyForNavigationAction(IWebView * webView=0x009a04c8, IPropertyBag * actionInformation=0x00a7fbb0, IWebURLRequest * request=0x00a7f9e8, IWebFrame * __formal=0x009a5208, IWebPolicyDecisionListener * listener=0x07851810) Line 118 + 0x10 bytes C++ WebKit.dll!WebFrame::dispatchDecidePolicyForNavigationAction(void (WebCore::PolicyAction)* function=0x5bbe4690, const WebCore::NavigationAction & action={...}, const WebCore::ResourceRequest & request={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}) Line 1778 + 0x59 bytes C++ WebKit.dll!WebCore::PolicyChecker::checkNavigationPolicy(const WebCore::ResourceRequest & request={...}, WebCore::DocumentLoader * loader=0x078929d0, WTF::PassRefPtr<WebCore::FormState> formState={...}, void (void *, const WebCore::ResourceRequest &, WTF::PassRefPtr<WebCore::FormState>, bool)* function=0x5afe7250, void * argument=0x009a5340) Line 90 C++ WebKit.dll!WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader * loader=0x078929d0, WebCore::FrameLoadType type=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::FormState> prpFormState={...}) Line 1400 C++ WebKit.dll!WebCore::FrameLoader::loadWithNavigationAction(const WebCore::ResourceRequest & request={...}, const WebCore::NavigationAction & action={...}, bool lockHistory=true, WebCore::FrameLoadType type=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::FormState> formState={...}) Line 1303 C++ WebKit.dll!WebCore::FrameLoader::loadPostRequest(const WebCore::ResourceRequest & inRequest={...}, const WTF::String & referrer={}, const WTF::String & frameName={}, bool lockHistory=true, WebCore::FrameLoadType loadType=FrameLoadTypeRedirectWithLockedBackForwardList, WTF::PassRefPtr<WebCore::Event> event={...}, WTF::PassRefPtr<WebCore::FormState> prpFormState={...}) Line 2542 C++ WebKit.dll!WebCore::FrameLoader::loadFrameRequest(const WebCore::FrameLoadRequest & request={...}, bool lockHistory=true, bool lockBackForwardList=true, WTF::PassRefPtr<WebCore::Event> event={...}, WTF::PassRefPtr<WebCore::FormState> formState={...}, WebCore::ShouldSendReferrer shouldSendReferrer=MaybeSendReferrer) Line 1166 C++ WebKit.dll!WebCore::ScheduledFormSubmission::fire(WebCore::Frame * frame=0x009a52f0) Line 236 C++ WebKit.dll!WebCore::NavigationScheduler::timerFired(WebCore::Timer<WebCore::NavigationScheduler> * __formal=0x009a5620) Line 418 + 0x20 bytes C++ WebKit.dll!WebCore::Timer<WebCore::NavigationScheduler>::fired() Line 106 + 0x23 bytes C++ WebKit.dll!WebCore::ThreadTimers::sharedTimerFiredInternal() Line 116 + 0xf bytes C++ WebKit.dll!WebCore::ThreadTimers::sharedTimerFired() Line 94 C++ WebKit.dll!WebCore::TimerWindowWndProc(HWND__ * hWnd=0x0025051c, unsigned int message=49827, unsigned int wParam=0, long lParam=0) Line 103 + 0x8 bytes C++ 800687 1 181395 roger_fong 2013-01-04 15:31:51 -0800 Created attachment 181395 patch 800712 2 181395 ap 2013-01-04 16:04:26 -0800 Comment on attachment 181395 patch View in context: https://bugs.webkit.org/attachment.cgi?id=181395&action=review Sorry about this! > Source/WebKit/win/WebView.cpp:4683 > settings->setPrivateBrowsingEnabled(!!enabled); I think that this line should be after the block you added. 800717 3 roger_fong 2013-01-04 16:20:15 -0800 fixed and committed r138865 808406 4 181395 darin 2013-01-16 08:55:44 -0800 Comment on attachment 181395 patch View in context: https://bugs.webkit.org/attachment.cgi?id=181395&action=review > Source/WebKit/win/WebView.cpp:4684 > +#if PLATFORM(WIN) || USE(CFNETWORK) Why both PLATFORM(WIN) and USE(CFNETWORK)? Doesn’t just USE(CFNETWORK) suffice? 181395 2013-01-04 15:31:51 -0800 2013-01-16 08:55:44 -0800 patch private_brownsing.patch text/plain 1395 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODg1NykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTA0 ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBwcml2 YXRlIGJyb3dzaW5nIHdvcmsgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjAzMi4KKworICAgICAgICBDb2RlIHBhdGggbmV2ZXIg Y2FsbGVkIGVuc3VyZVByaXZhdGVCcm93c2luZ1Nlc3Npb24gd2hpY2ggaXMgd2hhdCBzdGFydHMg dXAgdGhlIHByaXZhdGUgYnJvd3Npbmcgc2Vzc2lvbi4KKyAgICAgICAgVGhpcyB3YXMgY2F1c2lu ZyBtYW55IHRlc3RzIHRvIGludm9sdmluZyBwcml2YXRlIGJyb3dzaW5nIHRvIGZhaWwuCisKKyAg ICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6Om5vdGlmeVByZWZlcmVuY2Vz Q2hhbmdlZCk6CisKIDIwMTMtMDEtMDMgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdmUgYWxsIHRyYWNlcyBvZiBXaW5kb3dzIGZyb20gV2ViS2l0MiBm b2xkZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTM4NzU5KQorKysgU291 cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2ODEsNiArNDY4 MSwxMiBAQCBIUkVTVUxUIFdlYlZpZXc6Om5vdGlmeVByZWZlcmVuY2VzQ2hhbmdlCiAgICAgaWYg KEZBSUxFRChocikpCiAgICAgICAgIHJldHVybiBocjsKICAgICBzZXR0aW5ncy0+c2V0UHJpdmF0 ZUJyb3dzaW5nRW5hYmxlZCghIWVuYWJsZWQpOworI2lmIFBMQVRGT1JNKFdJTikgfHwgVVNFKENG TkVUV09SSykKKyAgICBpZiAoZW5hYmxlZCkKKyAgICAgICAgV2ViRnJhbWVOZXR3b3JraW5nQ29u dGV4dDo6ZW5zdXJlUHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpOworICAgIGVsc2UKKyAgICAgICAg V2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dDo6ZGVzdHJveVByaXZhdGVCcm93c2luZ1Nlc3Npb24o KTsKKyNlbmRpZgogCiAgICAgaHIgPSBwcmVmZXJlbmNlcy0+c2Fuc1NlcmlmRm9udEZhbWlseSgm c3RyKTsKICAgICBpZiAoRkFJTEVEKGhyKSkK