106023 2013-01-03 11:21:01 -0800 [Microdata] Fix build failure after r137003 2013-01-03 12:00:31 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arko arko abarth haraken japhet rniwa webkit.review.bot oldest_to_newest 799507 0 arko 2013-01-03 11:21:01 -0800 After revision 137003 microdata enabled build is failing in Chromium port with below errors : Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp: In static member function ‘static v8::Handle<v8::Value> WebCore::V8HTMLCollection::namedPropertyGetter(v8::Local<v8::String>, const v8::AccessorInfo&)’: Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:58:123: error: cannot convert ‘WTF::PassRefPtr<WebCore::PropertyNodeList>’ to ‘WebCore::PropertyNodeList*’ in initialization Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:61:59: error: no matching function for call to ‘toV8(WebCore::PropertyNodeList*&, v8::Local<v8::Object>, v8::Isolate*)’ Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:61:59: note: candidates are: In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:32:0: out/Release/obj/gen/webkit/bindings/V8HTMLCollection.h:60:30: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::HTMLCollection*, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLCollection.h:60:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WebCore::HTMLCollection*’ out/Release/obj/gen/webkit/bindings/V8HTMLCollection.h:87:30: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::HTMLCollection>, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLCollection.h:87:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WTF::PassRefPtr<WebCore::HTMLCollection>’ In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:38:0: out/Release/obj/gen/webkit/bindings/V8HTMLAllCollection.h:68:30: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::HTMLAllCollection*, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLAllCollection.h:68:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WebCore::HTMLAllCollection*’ out/Release/obj/gen/webkit/bindings/V8HTMLAllCollection.h:95:30: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::HTMLAllCollection>, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLAllCollection.h:95:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WTF::PassRefPtr<WebCore::HTMLAllCollection>’ In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:39:0: out/Release/obj/gen/webkit/bindings/V8HTMLFormControlsCollection.h:66:30: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::HTMLFormControlsCollection*, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLFormControlsCollection.h:66:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WebCore::HTMLFormControlsCollection*’ out/Release/obj/gen/webkit/bindings/V8HTMLFormControlsCollection.h:93:30: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::HTMLFormControlsCollection>, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLFormControlsCollection.h:93:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WTF::PassRefPtr<WebCore::HTMLFormControlsCollection>’ In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:40:0: out/Release/obj/gen/webkit/bindings/V8HTMLOptionsCollection.h:70:30: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::HTMLOptionsCollection*, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLOptionsCollection.h:70:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WebCore::HTMLOptionsCollection*’ out/Release/obj/gen/webkit/bindings/V8HTMLOptionsCollection.h:97:30: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::HTMLOptionsCollection>, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8HTMLOptionsCollection.h:97:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WTF::PassRefPtr<WebCore::HTMLOptionsCollection>’ In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:42:0: out/Release/obj/gen/webkit/bindings/V8Node.h:61:30: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::Node*, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8Node.h:61:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WebCore::Node*’ In file included from Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp:42:0: out/Release/obj/gen/webkit/bindings/V8Node.h:88:30: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::Node>, v8::Handle<v8::Object>, v8::Isolate*) out/Release/obj/gen/webkit/bindings/V8Node.h:88:30: note: no known conversion for argument 1 from ‘WebCore::PropertyNodeList*’ to ‘WTF::PassRefPtr<WebCore::Node>’ CXX(target) out/Release/obj.target/webcore_remaining/Source/WebCore/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.o make: *** [out/Release/obj.target/webcore_remaining/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.o] Error 1 make: *** Waiting for unfinished jobs.... ============================= LINK(target) out/Release/TestWebKitAPI out/Release/../../Source/WebKit/chromium/third_party/gold/gold64: out/Release/obj.target/Source/WebCore/WebCore.gyp/libwebcore_bindings.a(out/Release/obj.target/Source/WebCore/WebCore.gyp/../../../webcore_bindings/gen/webkit/bindings/V8DerivedSources18.o): in function WebCore::V8HTMLPropertiesCollection::GetTemplate():V8DerivedSources18.cpp(.text._ZN7WebCore26V8HTMLPropertiesCollection11GetTemplateEv+0x127): error: undefined reference to 'WebCore::V8HTMLPropertiesCollection::namedPropertyGetter(v8::Local<v8::String>, v8::AccessorInfo const&)' collect2: error: ld returned 1 exit status make: *** [out/Release/webkit_unit_tests] Error 1 make: *** Waiting for unfinished jobs.... out/Release/../../Source/WebKit/chromium/third_party/gold/gold64: out/Release/obj.target/Source/WebCore/WebCore.gyp/libwebcore_bindings.a(out/Release/obj.target/Source/WebCore/WebCore.gyp/../../../webcore_bindings/gen/webkit/bindings/V8DerivedSources18.o): in function WebCore::V8HTMLPropertiesCollection::GetTemplate():V8DerivedSources18.cpp(.text._ZN7WebCore26V8HTMLPropertiesCollection11GetTemplateEv+0x127): error: undefined reference to 'WebCore::V8HTMLPropertiesCollection::namedPropertyGetter(v8::Local<v8::String>, v8::AccessorInfo const&)' collect2: error: ld returned 1 exit status make: *** [out/Release/TestWebKitAPI] Error 1 799519 1 181196 arko 2013-01-03 11:38:13 -0800 Created attachment 181196 Patch 799529 2 181196 rniwa 2013-01-03 11:54:22 -0800 Comment on attachment 181196 Patch Okay. rs=me. 799535 3 arko 2013-01-03 12:00:31 -0800 Committed r138725: <http://trac.webkit.org/changeset/138725> 181196 2013-01-03 11:38:13 -0800 2013-01-03 11:54:22 -0800 Patch bug-106023-20130103113515.patch text/plain 3041 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODcyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTAzICAgQXJrbyBT YWhhICA8YXJrb0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgTWljcm9kYXRhOiBGaXggYnVpbGQg ZmFpbHVyZSBhZnRlciByMTM3MDAzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDYwMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTZXQgSFRNTENvbGxlY3Rpb246Om5hbWVkUHJvcGVydHlHZXR0ZXIgYXMg bmFtZWQgcHJvcGVydHkgZ2V0dGVyIGZvcgorICAgICAgICBIVE1MUHJvcGVydGllc0NvbGxlY3Rp b24gaW4gR2VuZXJhdGVJbXBsZW1lbnRhdGlvbk5hbWVkUHJvcGVydHlHZXR0ZXIuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVy YXRlSW1wbGVtZW50YXRpb25OYW1lZFByb3BlcnR5R2V0dGVyKToKKyAgICAgICAgKiBiaW5kaW5n cy92OC9jdXN0b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOEhUTUxDb2xsZWN0aW9uOjpuYW1lZFByb3BlcnR5R2V0dGVyKToKKwogMjAxMy0wMS0wMyAg VmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNhbmRib3gt YmxvY2tlZCBwb2ludGVyIGxvY2sgc2hvdWxkIGxvZyB0byB0aGUgY29uc29sZS4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt CShyZXZpc2lvbiAxMzg3MjIpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQkod29ya2luZyBjb3B5KQpAQCAtMjU2NSw3ICsyNTY1LDExIEBAIEVO RAogICAgICAgICAkaGFzRW51bWVyYXRvciA9IDA7CiAgICAgfQogCi0gICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgZGVzYy0+JHtzZXRPbn1UZW1wbGF0ZSgpLT5TZXROYW1lZFByb3BlcnR5SGFu ZGxlcigke3Y4SW50ZXJmYWNlTmFtZX06Om5hbWVkUHJvcGVydHlHZXR0ZXIsICIpOworICAgIGlm ICgkaW50ZXJmYWNlTmFtZSBlcSAiSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uIikgeworICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBkZXNjLT4ke3NldE9ufVRlbXBsYXRlKCktPlNldE5h bWVkUHJvcGVydHlIYW5kbGVyKFY4SFRNTENvbGxlY3Rpb246Om5hbWVkUHJvcGVydHlHZXR0ZXIs ICIpOworICAgIH0gZWxzZSB7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGRlc2Mt PiR7c2V0T259VGVtcGxhdGUoKS0+U2V0TmFtZWRQcm9wZXJ0eUhhbmRsZXIoJHt2OEludGVyZmFj ZU5hbWV9OjpuYW1lZFByb3BlcnR5R2V0dGVyLCAiKTsKKyAgICB9CiAgICAgcHVzaChAaW1wbENv bnRlbnQsICRoYXNDdXN0b21OYW1lZFNldHRlciA/ICIke3Y4SW50ZXJmYWNlTmFtZX06Om5hbWVk UHJvcGVydHlTZXR0ZXIsICIgOiAiMCwgIik7CiAgICAgIyBJZiB0aGVyZSBpcyBhIGN1c3RvbSBl bnVtZXJhdG9yLCB0aGVyZSBNVVNUIGJlIGN1c3RvbSBxdWVyeSB0byBwcm9wZXJseSBjb21tdW5p Y2F0ZSBwcm9wZXJ0eSBhdHRyaWJ1dGVzLgogICAgIHB1c2goQGltcGxDb250ZW50LCAkaGFzRW51 bWVyYXRvciA/ICIke3Y4SW50ZXJmYWNlTmFtZX06Om5hbWVkUHJvcGVydHlRdWVyeSwgIiA6ICIw LCAiKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxDb2xs ZWN0aW9uQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9uIDEzODcyMikKKysr IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxDb2xsZWN0aW9uQ3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAsNyBAQAogI2luY2x1ZGUgIlY4SFRNTE9w dGlvbnNDb2xsZWN0aW9uLmgiCiAjaW5jbHVkZSAiVjhOYW1lZE5vZGVzQ29sbGVjdGlvbi5oIgog I2luY2x1ZGUgIlY4Tm9kZS5oIgorI2luY2x1ZGUgIlY4UHJvcGVydHlOb2RlTGlzdC5oIgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTUzLDcgKzU0LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFs dWU+IFY4SFRNTENvbGxlY3Rpb246OgogICAgIEhUTUxDb2xsZWN0aW9uKiBpbXAgPSBWOEhUTUxD b2xsZWN0aW9uOjp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsKICNpZiBFTkFCTEUoTUlDUk9EQVRB KQogICAgIGlmIChpbXAtPnR5cGUoKSA9PSBJdGVtUHJvcGVydGllcykgewotICAgICAgICBQcm9w ZXJ0eU5vZGVMaXN0KiBpdGVtID0gc3RhdGljX2Nhc3Q8SFRNTFByb3BlcnRpZXNDb2xsZWN0aW9u Kj4oaW1wKS0+cHJvcGVydHlOb2RlTGlzdCh0b1dlYkNvcmVBdG9taWNTdHJpbmcobmFtZSkpOwor ICAgICAgICBQcm9wZXJ0eU5vZGVMaXN0KiBpdGVtID0gc3RhdGljX2Nhc3Q8SFRNTFByb3BlcnRp ZXNDb2xsZWN0aW9uKj4oaW1wKS0+cHJvcGVydHlOb2RlTGlzdCh0b1dlYkNvcmVBdG9taWNTdHJp bmcobmFtZSkpLmdldCgpOwogICAgICAgICBpZiAoIWl0ZW0pCiAgICAgICAgICAgICByZXR1cm4g djhVbmRlZmluZWQoKTsKICAgICAgICAgcmV0dXJuIHRvVjgoaXRlbSwgaW5mby5Ib2xkZXIoKSwg aW5mby5HZXRJc29sYXRlKCkpOwo=