106010 2013-01-03 05:51:42 -0800 [EFL][WK2] Remove unneeded EwkViewImpl::informLoadCommitted() 2013-01-04 00:05:53 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 799338 0 mikhail.pozdnyakov 2013-01-03 05:51:42 -0800 EwkViewImpl::informLoadCommitted() is invoked from only from PageLoadClientEfl::didCommitLoadForFrame() and it contains only 'm_pageClient->didCommitLoad();' inside. It would be much simpler if PageClient::didCommitLoad() was invoked directly from PageLoadClientEfl. Moreover 'informLoadCommitted' name is misleading, as this function does not inform actually. 799345 1 181168 mikhail.pozdnyakov 2013-01-03 06:14:19 -0800 Created attachment 181168 patch 799351 2 181168 cdumez 2013-01-03 06:19:46 -0800 Comment on attachment 181168 patch Makes sense. LGTM. 799965 3 181168 webkit.review.bot 2013-01-04 00:05:47 -0800 Comment on attachment 181168 patch Clearing flags on attachment: 181168 Committed r138780: <http://trac.webkit.org/changeset/138780> 799966 4 webkit.review.bot 2013-01-04 00:05:53 -0800 All reviewed patches have been landed. Closing bug. 181168 2013-01-03 06:14:19 -0800 2013-01-04 00:05:47 -0800 patch bug106010 text/plain 3594 mikhail.pozdnyakov Y29tbWl0IDZhNzVkNjY1NDg3ZDU3MmI2YzE0YjliZGU5ODk4MWI1OWNlNTY0MWUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IEphbiAzIDE2OjA0OjE4IDIwMTMgKzAyMDAKCiAgICBidWcxMDYwMTAKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggNTk1MWU1YS4uYjgwZTdhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAx LTAzICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gUmVtb3ZlIHVubmVlZGVkIEV3a1ZpZXdJbXBsOjppbmZvcm1M b2FkQ29tbWl0dGVkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjAxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZWQgRXdrVmlld0ltcGw6OmluZm9ybUxvYWRDb21taXR0ZWQoKSBtZXRob2Qg dG8gc2ltcGxpZnkgdGhlIGNvZGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tW aWV3SW1wbC5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaDoK KyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1BhZ2VDbGllbnRCYXNlLmg6CisgICAgICAgIChQYWdl Q2xpZW50QmFzZSk6CisgICAgICAgICogVUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VMb2FkQ2xpZW50RWZsOjpkaWRDb21taXRMb2FkRm9y RnJhbWUpOgorCiAyMDEzLTAxLTAyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgU3RvcCBwcmV0ZW5kaW5nIGl0cyBwb3NzaWJsZSB0byBydW4gdGhlIFdlYlByb2Nlc3Mg aW4gdGhyZWFkZWQgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv RXdrVmlld0ltcGwuY3BwCmluZGV4IDY3YmY1MjQuLjBlYmU1ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKQEAgLTQ5OSwxMyArNDk5 LDYgQEAgdm9pZCBFd2tWaWV3SW1wbDo6c2V0SW1hZ2VEYXRhKHZvaWQqIGltYWdlRGF0YSwgY29u c3QgSW50U2l6ZSYgc2l6ZSkKICAgICBldmFzX29iamVjdF9pbWFnZV9kYXRhX2NvcHlfc2V0KHNk LT5pbWFnZSwgaW1hZ2VEYXRhKTsKIH0KIAotI2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQot dm9pZCBFd2tWaWV3SW1wbDo6aW5mb3JtTG9hZENvbW1pdHRlZCgpCi17Ci0gICAgbV9wYWdlQ2xp ZW50LT5kaWRDb21taXRMb2FkKCk7Ci19Ci0jZW5kaWYKLQogSW50U2l6ZSBFd2tWaWV3SW1wbDo6 c2l6ZSgpIGNvbnN0CiB7CiAgICAgaW50IHdpZHRoLCBoZWlnaHQ7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaAppbmRleCAxOGZhNDk1Li5iY2QxYzVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1w bC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgK QEAgLTE5NCw5ICsxOTQsNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBFd2tWaWV3Q2FsbGJh Y2tzOjpDYWxsQmFjazxjYWxsYmFja1R5cGU+KG1fdmlldyk7CiAgICAgfQogCi0jaWYgVVNFKFRJ TEVEX0JBQ0tJTkdfU1RPUkUpCi0gICAgdm9pZCBpbmZvcm1Mb2FkQ29tbWl0dGVkKCk7Ci0jZW5k aWYKICAgICB1bnNpZ25lZCBsb25nIGxvbmcgaW5mb3JtRGF0YWJhc2VRdW90YVJlYWNoZWQoY29u c3QgU3RyaW5nJiBkYXRhYmFzZU5hbWUsIGNvbnN0IFN0cmluZyYgZGlzcGxheU5hbWUsIHVuc2ln bmVkIGxvbmcgbG9uZyBjdXJyZW50UXVvdGEsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50T3Jp Z2luVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50RGF0YWJhc2VVc2FnZSwgdW5zaWdu ZWQgbG9uZyBsb25nIGV4cGVjdGVkVXNhZ2UpOwogCiAjaWYgVVNFKFRJTEVEX0JBQ0tJTkdfU1RP UkUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VDbGllbnRC YXNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VDbGllbnRCYXNlLmgKaW5k ZXggZDMwMjU0Mi4uZjkyOTE2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2VmbC9QYWdlQ2xpZW50QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwv UGFnZUNsaWVudEJhc2UuaApAQCAtMzgsNyArMzgsNiBAQCBjbGFzcyBQYWdlQ2xpZW50QmFzZSA6 IHB1YmxpYyBQYWdlQ2xpZW50IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5QYWdlQ2xpZW50QmFz ZSgpOwogCi0gICAgLy8gQ2FsbGVkIGZyb20gdGhlIHZpZXcKICAgICB2aXJ0dWFsIHZvaWQgZGlk Q29tbWl0TG9hZCgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlVmlld3BvcnRTaXplKCkg PSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VDb250ZW50c1NpemUoY29uc3QgV2ViQ29y ZTo6SW50U2l6ZSYpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9l ZmwvUGFnZUxvYWRDbGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9Q YWdlTG9hZENsaWVudEVmbC5jcHAKaW5kZXggOTdlZTU2Mi4uYmIyNzUxZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5jcHAKQEAgLTI3 LDYgKzI3LDcgQEAKICNpbmNsdWRlICJQYWdlTG9hZENsaWVudEVmbC5oIgogCiAjaW5jbHVkZSAi RXdrVmlld0ltcGwuaCIKKyNpbmNsdWRlICJQYWdlQ2xpZW50QmFzZS5oIgogI2luY2x1ZGUgIldL QVBJQ2FzdC5oIgogI2luY2x1ZGUgIldLRnJhbWUuaCIKICNpbmNsdWRlICJXS1BhZ2UuaCIKQEAg LTEzNyw3ICsxMzgsNyBAQCB2b2lkIFBhZ2VMb2FkQ2xpZW50RWZsOjpkaWRDb21taXRMb2FkRm9y RnJhbWUoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cAogICAgICAgICByZXR1cm47 CiAKICAgICBFd2tWaWV3SW1wbCogdmlld0ltcGwgPSB0b1BhZ2VMb2FkQ2xpZW50RWZsKGNsaWVu dEluZm8pLT52aWV3SW1wbCgpOwotICAgIHZpZXdJbXBsLT5pbmZvcm1Mb2FkQ29tbWl0dGVkKCk7 CisgICAgdmlld0ltcGwtPnBhZ2VDbGllbnQoKS0+ZGlkQ29tbWl0TG9hZCgpOwogfQogI2VuZGlm CiAK