105997 2013-01-02 22:03:21 -0800 Add 'float FloatPoint::slopeAngleRadians()' 2013-01-04 09:32:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 steveblock steveblock dglazkov d-r eric fmalita krit ojan.autocc pdr schenney senorblanco steveblock webkit.review.bot oldest_to_newest 799257 0 steveblock 2013-01-02 22:03:21 -0800 Add 'float FloatPoint::theta()' 799258 1 181149 steveblock 2013-01-02 22:04:50 -0800 Created attachment 181149 Patch 799264 2 steveblock 2013-01-02 22:15:32 -0800 There are several places where we calculate the angle between a FloatPoint/Size and the x/horizontal axis, so it seems like a helper method would be useful. FloatPoint seems the more natural location, and it goes well with the existing 'length()' method. Open to suggestions for naming. 799288 3 181149 webkit.review.bot 2013-01-02 23:38:18 -0800 Comment on attachment 181149 Patch Attachment 181149 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15628806 New failing tests: fast/frames/removal-before-attach-crash.html 799355 4 181149 schenney 2013-01-03 06:25:59 -0800 Comment on attachment 181149 Patch I fine with the change, but not real happy about the name. I see how you came to choose it (radial coordinates) but the cognitive load to figure out what it means seems high. The SVG spec refers to this as the "slope" of a curve, so I think I would prefer "slopeAngleRadians". 799921 5 181266 steveblock 2013-01-03 19:42:51 -0800 Created attachment 181266 Patch 799923 6 steveblock 2013-01-03 19:43:43 -0800 Renamed to slopeAngleRadians 800201 7 181266 senorblanco 2013-01-04 07:41:43 -0800 Comment on attachment 181266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181266&action=review OK. r=me > Source/WebCore/rendering/svg/SVGMarkerData.h:88 > + double inslope = rad2deg(inslopeChange.slopeAngleRadians()); There is a slight change of precision here (calling atan2f()/rad2deg() on the floats directly instead of promoting the floats to doubles, and calling atan2()/rad2deg() (double flavour), then downcasting to float). Luckily, it doesn't seem to have an impact on pixel results. 800209 8 181266 webkit.review.bot 2013-01-04 08:15:29 -0800 Comment on attachment 181266 Patch Clearing flags on attachment: 181266 Committed r138800: <http://trac.webkit.org/changeset/138800> 800210 9 webkit.review.bot 2013-01-04 08:15:33 -0800 All reviewed patches have been landed. Closing bug. 800278 10 krit 2013-01-04 09:32:24 -0800 I don't understand why it needs to go into FloatPoint for such a rare usage? (just two file IIRC). 181149 2013-01-02 22:04:50 -0800 2013-01-03 19:42:45 -0800 Patch bug-105997-20130103170157.patch text/plain 5246 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U4MGJkM2ZkZGJiYTQ2 NzkzYTBiYTFiYjU0MzU2MjA4YWE0OWQxMC4uMWFmZGFiODU4YmE2ZjA1YzEzZWE1MzBiNWMyNzMx ODJkZjc0OTMzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTAyICBTdGV2 ZSBCbG9jayAgPHN0ZXZlYmxvY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCAnZmxvYXQg RmxvYXRQb2ludDo6dGhldGEoKScKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTk5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlZmFjdG9yaW5nIG9ubHksIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGbG9hdFBvaW50Ojp0aGV0YSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50Lmg6CisgICAgICAgIEFkZCAnZmxvYXQgRmxvYXRQ b2ludDo6dGhldGEoKScKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9QYXRoVHJhdmVyc2Fs U3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aFRyYXZlcnNhbFN0YXRlOjpwcm9jZXNz U2VnbWVudCk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9TVkdNYXJrZXJEYXRhLmg6CisgICAg ICAgIChXZWJDb3JlOjpTVkdNYXJrZXJEYXRhOjpjdXJyZW50QW5nbGUpOgorICAgICAgICAqIHN2 Zy9TVkdQYXRoUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1BhdGhQYXJzZXI6OmRl Y29tcG9zZUFyY1RvQ3ViaWMpOgorCiAyMDEyLTEyLTIzICBUb255IENoYW5nICA8dG9ueUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW1F0XVtNYWNdIFVucmV2aWV3ZWQgZml4IHRoZSBidWlsZCBh ZnRlciByMTM4NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9GbG9hdFBvaW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0 UG9pbnQuY3BwCmluZGV4IGQ3YTAwZWE1YjNjMGFjN2UzZDM0MmNkNjNiMzI0ZDA0MjViOTkzYmEu LjFkODVmMjAwZjQ1NjcxYWZmNDEyMTUyMjdmY2Y0OTU3MTJlMmYwODEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuY3BwCkBAIC01Niw2ICs1Niwx MSBAQCB2b2lkIEZsb2F0UG9pbnQ6Om5vcm1hbGl6ZSgpCiAgICAgfQogfQogCitmbG9hdCBGbG9h dFBvaW50Ojp0aGV0YSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGF0YW4yZihtX3ksIG1feCk7Cit9 CisKIGZsb2F0IEZsb2F0UG9pbnQ6Omxlbmd0aCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIHNxcnRm KGxlbmd0aFNxdWFyZWQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9GbG9hdFBvaW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G bG9hdFBvaW50LmgKaW5kZXggNzBkNjJiYmNmMjJhMDFlMDY4YTYwMTIxMWNlZDIwZTA3M2NhNTFh Ni4uZjJjZDIyNzczN2ExMWQ0NzRhZjZmMWUzZTM5NTIxMDcwNGM2ODRmMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaApAQCAtMTMzLDYgKzEzMyw3 IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1feCAqIGEueCgpICsgbV95ICogYS55KCk7CiAg ICAgfQogCisgICAgZmxvYXQgdGhldGEoKSBjb25zdDsKICAgICBmbG9hdCBsZW5ndGgoKSBjb25z dDsKICAgICBmbG9hdCBsZW5ndGhTcXVhcmVkKCkgY29uc3QKICAgICB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoVHJhdmVyc2FsU3RhdGUuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aFRyYXZlcnNhbFN0YXRlLmNwcApp bmRleCAxMzljNWFkZjE3Y2I0NWNmMzk1OWEzNmY0ZDllZGFlZTFlNGM3ZDRkLi5mYzZjNDJlZDJl N2I5MGFiMGYwZjI2ZGY4YjYxZTg1MWJhNjU0MDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoVHJhdmVyc2FsU3RhdGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGhUcmF2ZXJzYWxTdGF0ZS5jcHAKQEAgLTIwOSw4 ICsyMDksNyBAQCB2b2lkIFBhdGhUcmF2ZXJzYWxTdGF0ZTo6cHJvY2Vzc1NlZ21lbnQoKQogICAg ICAgICBtX3N1Y2Nlc3MgPSB0cnVlOwogICAgICAgICAKICAgICBpZiAoKG1fYWN0aW9uID09IFRy YXZlcnNhbFBvaW50QXRMZW5ndGggfHwgbV9hY3Rpb24gPT0gVHJhdmVyc2FsTm9ybWFsQW5nbGVB dExlbmd0aCkgJiYgbV90b3RhbExlbmd0aCA+PSBtX2Rlc2lyZWRMZW5ndGgpIHsKLSAgICAgICAg RmxvYXRTaXplIGNoYW5nZSA9IG1fY3VycmVudCAtIG1fcHJldmlvdXM7Ci0gICAgICAgIGZsb2F0 IHNsb3BlID0gYXRhbjJmKGNoYW5nZS5oZWlnaHQoKSwgY2hhbmdlLndpZHRoKCkpOworICAgICAg ICBmbG9hdCBzbG9wZSA9IEZsb2F0UG9pbnQobV9jdXJyZW50IC0gbV9wcmV2aW91cykudGhldGEo KTsKICAgICAgICAgaWYgKG1fYWN0aW9uID09IFRyYXZlcnNhbFBvaW50QXRMZW5ndGgpIHsKICAg ICAgICAgICAgIGZsb2F0IG9mZnNldCA9IG1fZGVzaXJlZExlbmd0aCAtIG1fdG90YWxMZW5ndGg7 CiAgICAgICAgICAgICBtX2N1cnJlbnQubW92ZShvZmZzZXQgKiBjb3NmKHNsb3BlKSwgb2Zmc2V0 ICogc2luZihzbG9wZSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9TVkdNYXJrZXJEYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR01hcmtl ckRhdGEuaAppbmRleCA3ZTJjZTBlZGNiODgzY2IwM2U0Mjg4NDE3MzdhNTIwMmQ2MThlY2I0Li5m YWVlMjgxMjZiNjA2MzUxOGE0ZGU2ODU2MzNjM2MzZDc3ZWFmNTdhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR01hcmtlckRhdGEuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3ZnL1NWR01hcmtlckRhdGEuaApAQCAtODIsMTEgKzgyLDExIEBAIHB1 YmxpYzoKIHByaXZhdGU6CiAgICAgZmxvYXQgY3VycmVudEFuZ2xlKFNWR01hcmtlclR5cGUgdHlw ZSkgY29uc3QKICAgICB7Ci0gICAgICAgIEZsb2F0U2l6ZSBpbnNsb3BlQ2hhbmdlID0gbV9pbnNs b3BlUG9pbnRzWzFdIC0gbV9pbnNsb3BlUG9pbnRzWzBdOwotICAgICAgICBGbG9hdFNpemUgb3V0 c2xvcGVDaGFuZ2UgPSBtX291dHNsb3BlUG9pbnRzWzFdIC0gbV9vdXRzbG9wZVBvaW50c1swXTsK KyAgICAgICAgRmxvYXRQb2ludCBpbnNsb3BlQ2hhbmdlKG1faW5zbG9wZVBvaW50c1sxXSAtIG1f aW5zbG9wZVBvaW50c1swXSk7CisgICAgICAgIEZsb2F0UG9pbnQgb3V0c2xvcGVDaGFuZ2UobV9v dXRzbG9wZVBvaW50c1sxXSAtIG1fb3V0c2xvcGVQb2ludHNbMF0pOwogCi0gICAgICAgIGRvdWJs ZSBpbnNsb3BlID0gcmFkMmRlZyhhdGFuMihpbnNsb3BlQ2hhbmdlLmhlaWdodCgpLCBpbnNsb3Bl Q2hhbmdlLndpZHRoKCkpKTsKLSAgICAgICAgZG91YmxlIG91dHNsb3BlID0gcmFkMmRlZyhhdGFu MihvdXRzbG9wZUNoYW5nZS5oZWlnaHQoKSwgb3V0c2xvcGVDaGFuZ2Uud2lkdGgoKSkpOworICAg ICAgICBkb3VibGUgaW5zbG9wZSA9IHJhZDJkZWcoaW5zbG9wZUNoYW5nZS50aGV0YSgpKTsKKyAg ICAgICAgZG91YmxlIG91dHNsb3BlID0gcmFkMmRlZyhvdXRzbG9wZUNoYW5nZS50aGV0YSgpKTsK IAogICAgICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICAgICAgY2FzZSBTdGFydE1hcmtlcjoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRoUGFyc2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3N2Zy9TVkdQYXRoUGFyc2VyLmNwcAppbmRleCBkYzQ4OTJhYWI0NGUyODVhN2ZhNjU1 NDE0MTAzOGM3YjUzZDEwNWFjLi44NTU5ZTAxMmU5OTRkMjAyZjJjNjUwOTY3ZmViZTk1N2I3OTJh YzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGF0aFBhcnNlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdGhQYXJzZXIuY3BwCkBAIC00NDgsMTEgKzQ0OCwx MiBAQCBib29sIFNWR1BhdGhQYXJzZXI6OmRlY29tcG9zZUFyY1RvQ3ViaWMoZmxvYXQgYW5nbGUs IGZsb2F0IHJ4LCBmbG9hdCByeSwgRmxvYXRQbwogICAgICAgICBzY2FsZUZhY3RvciA9IC1zY2Fs ZUZhY3RvcjsKIAogICAgIGRlbHRhLnNjYWxlKHNjYWxlRmFjdG9yKTsKLSAgICBGbG9hdFBvaW50 IGNlbnRlclBvaW50ID0gRmxvYXRQb2ludCgwLjVmICogKHBvaW50MS54KCkgKyBwb2ludDIueCgp KSAtIGRlbHRhLmhlaWdodCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDAuNWYgKiAocG9pbnQxLnkoKSArIHBvaW50Mi55KCkpICsgZGVsdGEud2lkdGgoKSk7Cisg ICAgRmxvYXRQb2ludCBjZW50ZXJQb2ludCA9IHBvaW50MSArIHBvaW50MjsKKyAgICBjZW50ZXJQ b2ludC5zY2FsZSgwLjVmLCAwLjVmKTsKKyAgICBjZW50ZXJQb2ludC5tb3ZlKC1kZWx0YS5oZWln aHQoKSwgZGVsdGEud2lkdGgoKSk7CiAKLSAgICBmbG9hdCB0aGV0YTEgPSBhdGFuMmYocG9pbnQx LnkoKSAtIGNlbnRlclBvaW50LnkoKSwgcG9pbnQxLngoKSAtIGNlbnRlclBvaW50LngoKSk7Ci0g ICAgZmxvYXQgdGhldGEyID0gYXRhbjJmKHBvaW50Mi55KCkgLSBjZW50ZXJQb2ludC55KCksIHBv aW50Mi54KCkgLSBjZW50ZXJQb2ludC54KCkpOworICAgIGZsb2F0IHRoZXRhMSA9IEZsb2F0UG9p bnQocG9pbnQxIC0gY2VudGVyUG9pbnQpLnRoZXRhKCk7CisgICAgZmxvYXQgdGhldGEyID0gRmxv YXRQb2ludChwb2ludDIgLSBjZW50ZXJQb2ludCkudGhldGEoKTsKIAogICAgIGZsb2F0IHRoZXRh QXJjID0gdGhldGEyIC0gdGhldGExOwogICAgIGlmICh0aGV0YUFyYyA8IDAgJiYgc3dlZXBGbGFn KQo= 181266 2013-01-03 19:42:51 -0800 2013-01-04 08:15:28 -0800 Patch bug-105997-20130104143957.patch text/plain 5398 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJmOGNmZjgzYzA3ZGNh MWFlNTUwYTExZjE3YjA1MzExYjcxZmQyMC4uMDVjMmVkMjczNGQ5NzY2NmE1ODY3NmMxMWNhYmU3 NmU0NGUxNzBlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTAyICBTdGV2 ZSBCbG9jayAgPHN0ZXZlYmxvY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCAnZmxvYXQg RmxvYXRQb2ludDo6c2xvcGVBbmdsZVJhZGlhbnMoKScKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yaW5nIG9ubHksIG5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGbG9hdFBvaW50OjpzbG9wZUFuZ2xlUmFkaWFucyk6CisgICAgICAg IChXZWJDb3JlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50Lmg6Cisg ICAgICAgIEFkZCAnZmxvYXQgRmxvYXRQb2ludDo6c2xvcGVBbmdsZVJhZGlhbnMoKSBjb25zdCcK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9QYXRoVHJhdmVyc2FsU3RhdGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGF0aFRyYXZlcnNhbFN0YXRlOjpwcm9jZXNzU2VnbWVudCk6CisgICAg ICAgICogcmVuZGVyaW5nL3N2Zy9TVkdNYXJrZXJEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpT VkdNYXJrZXJEYXRhOjpjdXJyZW50QW5nbGUpOgorICAgICAgICAqIHN2Zy9TVkdQYXRoUGFyc2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1BhdGhQYXJzZXI6OmRlY29tcG9zZUFyY1RvQ3Vi aWMpOgorCiAyMDEzLTAxLTAzICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgaW5jb3JyZWN0IGZsZXhib3ggcmVsYXlvdXQgd2l0aCBvdmVyZmxvdywgcGFkZGluZyBh bmQgYWJzb2x1dGUgcG9zaXRpb25pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvRmxvYXRQb2ludC5jcHAKaW5kZXggZDdhMDBlYTViM2MwYWM3ZTNkMzQyY2Q2M2IzMjRk MDQyNWI5OTNiYS4uNjcwNjUxYmFkMWU0ZTRkNWRlM2I1NTYzOGY5Nzk5NjJjNGNhNDI5MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5jcHAKQEAg LTU2LDYgKzU2LDExIEBAIHZvaWQgRmxvYXRQb2ludDo6bm9ybWFsaXplKCkKICAgICB9CiB9CiAK K2Zsb2F0IEZsb2F0UG9pbnQ6OnNsb3BlQW5nbGVSYWRpYW5zKCkgY29uc3QKK3sKKyAgICByZXR1 cm4gYXRhbjJmKG1feSwgbV94KTsKK30KKwogZmxvYXQgRmxvYXRQb2ludDo6bGVuZ3RoKCkgY29u c3QKIHsKICAgICByZXR1cm4gc3FydGYobGVuZ3RoU3F1YXJlZCgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaAppbmRleCA3MGQ2MmJiY2YyMmEwMWUw NjhhNjAxMjExY2VkMjBlMDczY2E1MWE2Li45NjczNzgzMGZkZmMyNGFlYjBkYzk5OTNlMjg1Mjhh ZTY0NDIyZDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G bG9hdFBvaW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQ b2ludC5oCkBAIC0xMzMsNiArMTMzLDcgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gbV94ICog YS54KCkgKyBtX3kgKiBhLnkoKTsKICAgICB9CiAKKyAgICBmbG9hdCBzbG9wZUFuZ2xlUmFkaWFu cygpIGNvbnN0OwogICAgIGZsb2F0IGxlbmd0aCgpIGNvbnN0OwogICAgIGZsb2F0IGxlbmd0aFNx dWFyZWQoKSBjb25zdAogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1BhdGhUcmF2ZXJzYWxTdGF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9QYXRoVHJhdmVyc2FsU3RhdGUuY3BwCmluZGV4IDEzOWM1YWRmMTdjYjQ1Y2Yz OTU5YTM2ZjRkOWVkYWVlMWU0YzdkNGQuLmNmNTM3MTcyNzIzMzY1ZGIwYzZkYjhjZGM5Y2MyOWMy NzUwNDcxNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1Bh dGhUcmF2ZXJzYWxTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvUGF0aFRyYXZlcnNhbFN0YXRlLmNwcApAQCAtMjA5LDggKzIwOSw3IEBAIHZvaWQgUGF0aFRy YXZlcnNhbFN0YXRlOjpwcm9jZXNzU2VnbWVudCgpCiAgICAgICAgIG1fc3VjY2VzcyA9IHRydWU7 CiAgICAgICAgIAogICAgIGlmICgobV9hY3Rpb24gPT0gVHJhdmVyc2FsUG9pbnRBdExlbmd0aCB8 fCBtX2FjdGlvbiA9PSBUcmF2ZXJzYWxOb3JtYWxBbmdsZUF0TGVuZ3RoKSAmJiBtX3RvdGFsTGVu Z3RoID49IG1fZGVzaXJlZExlbmd0aCkgewotICAgICAgICBGbG9hdFNpemUgY2hhbmdlID0gbV9j dXJyZW50IC0gbV9wcmV2aW91czsKLSAgICAgICAgZmxvYXQgc2xvcGUgPSBhdGFuMmYoY2hhbmdl LmhlaWdodCgpLCBjaGFuZ2Uud2lkdGgoKSk7CisgICAgICAgIGZsb2F0IHNsb3BlID0gRmxvYXRQ b2ludChtX2N1cnJlbnQgLSBtX3ByZXZpb3VzKS5zbG9wZUFuZ2xlUmFkaWFucygpOwogICAgICAg ICBpZiAobV9hY3Rpb24gPT0gVHJhdmVyc2FsUG9pbnRBdExlbmd0aCkgewogICAgICAgICAgICAg ZmxvYXQgb2Zmc2V0ID0gbV9kZXNpcmVkTGVuZ3RoIC0gbV90b3RhbExlbmd0aDsKICAgICAgICAg ICAgIG1fY3VycmVudC5tb3ZlKG9mZnNldCAqIGNvc2Yoc2xvcGUpLCBvZmZzZXQgKiBzaW5mKHNs b3BlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR01hcmtl ckRhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHTWFya2VyRGF0YS5oCmlu ZGV4IDdlMmNlMGVkY2I4ODNjYjAzZTQyODg0MTczN2E1MjAyZDYxOGVjYjQuLjA5YTU0MmIyMTA5 NzU3Yzk2MmQyMzU5YmI5OTA1MGQ0OTE0ZDA1ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdmcvU1ZHTWFya2VyRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvU1ZHTWFya2VyRGF0YS5oCkBAIC04MiwxMSArODIsMTEgQEAgcHVibGljOgogcHJp dmF0ZToKICAgICBmbG9hdCBjdXJyZW50QW5nbGUoU1ZHTWFya2VyVHlwZSB0eXBlKSBjb25zdAog ICAgIHsKLSAgICAgICAgRmxvYXRTaXplIGluc2xvcGVDaGFuZ2UgPSBtX2luc2xvcGVQb2ludHNb MV0gLSBtX2luc2xvcGVQb2ludHNbMF07Ci0gICAgICAgIEZsb2F0U2l6ZSBvdXRzbG9wZUNoYW5n ZSA9IG1fb3V0c2xvcGVQb2ludHNbMV0gLSBtX291dHNsb3BlUG9pbnRzWzBdOworICAgICAgICBG bG9hdFBvaW50IGluc2xvcGVDaGFuZ2UobV9pbnNsb3BlUG9pbnRzWzFdIC0gbV9pbnNsb3BlUG9p bnRzWzBdKTsKKyAgICAgICAgRmxvYXRQb2ludCBvdXRzbG9wZUNoYW5nZShtX291dHNsb3BlUG9p bnRzWzFdIC0gbV9vdXRzbG9wZVBvaW50c1swXSk7CiAKLSAgICAgICAgZG91YmxlIGluc2xvcGUg PSByYWQyZGVnKGF0YW4yKGluc2xvcGVDaGFuZ2UuaGVpZ2h0KCksIGluc2xvcGVDaGFuZ2Uud2lk dGgoKSkpOwotICAgICAgICBkb3VibGUgb3V0c2xvcGUgPSByYWQyZGVnKGF0YW4yKG91dHNsb3Bl Q2hhbmdlLmhlaWdodCgpLCBvdXRzbG9wZUNoYW5nZS53aWR0aCgpKSk7CisgICAgICAgIGRvdWJs ZSBpbnNsb3BlID0gcmFkMmRlZyhpbnNsb3BlQ2hhbmdlLnNsb3BlQW5nbGVSYWRpYW5zKCkpOwor ICAgICAgICBkb3VibGUgb3V0c2xvcGUgPSByYWQyZGVnKG91dHNsb3BlQ2hhbmdlLnNsb3BlQW5n bGVSYWRpYW5zKCkpOwogCiAgICAgICAgIHN3aXRjaCAodHlwZSkgewogICAgICAgICBjYXNlIFN0 YXJ0TWFya2VyOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdGhQYXJzZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdGhQYXJzZXIuY3BwCmluZGV4IGRjNDg5MmFh YjQ0ZTI4NWE3ZmE2NTU0MTQxMDM4YzdiNTNkMTA1YWMuLmY5MDhlMGRiMzQwZThjZWVlM2JiNGZm ZWJhMmU2ZjhlZDlmOWFlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXRo UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGF0aFBhcnNlci5jcHAKQEAg LTQ0OCwxMSArNDQ4LDEyIEBAIGJvb2wgU1ZHUGF0aFBhcnNlcjo6ZGVjb21wb3NlQXJjVG9DdWJp YyhmbG9hdCBhbmdsZSwgZmxvYXQgcngsIGZsb2F0IHJ5LCBGbG9hdFBvCiAgICAgICAgIHNjYWxl RmFjdG9yID0gLXNjYWxlRmFjdG9yOwogCiAgICAgZGVsdGEuc2NhbGUoc2NhbGVGYWN0b3IpOwot ICAgIEZsb2F0UG9pbnQgY2VudGVyUG9pbnQgPSBGbG9hdFBvaW50KDAuNWYgKiAocG9pbnQxLngo KSArIHBvaW50Mi54KCkpIC0gZGVsdGEuaGVpZ2h0KCksCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgMC41ZiAqIChwb2ludDEueSgpICsgcG9pbnQyLnkoKSkgKyBkZWx0 YS53aWR0aCgpKTsKKyAgICBGbG9hdFBvaW50IGNlbnRlclBvaW50ID0gcG9pbnQxICsgcG9pbnQy OworICAgIGNlbnRlclBvaW50LnNjYWxlKDAuNWYsIDAuNWYpOworICAgIGNlbnRlclBvaW50Lm1v dmUoLWRlbHRhLmhlaWdodCgpLCBkZWx0YS53aWR0aCgpKTsKIAotICAgIGZsb2F0IHRoZXRhMSA9 IGF0YW4yZihwb2ludDEueSgpIC0gY2VudGVyUG9pbnQueSgpLCBwb2ludDEueCgpIC0gY2VudGVy UG9pbnQueCgpKTsKLSAgICBmbG9hdCB0aGV0YTIgPSBhdGFuMmYocG9pbnQyLnkoKSAtIGNlbnRl clBvaW50LnkoKSwgcG9pbnQyLngoKSAtIGNlbnRlclBvaW50LngoKSk7CisgICAgZmxvYXQgdGhl dGExID0gRmxvYXRQb2ludChwb2ludDEgLSBjZW50ZXJQb2ludCkuc2xvcGVBbmdsZVJhZGlhbnMo KTsKKyAgICBmbG9hdCB0aGV0YTIgPSBGbG9hdFBvaW50KHBvaW50MiAtIGNlbnRlclBvaW50KS5z bG9wZUFuZ2xlUmFkaWFucygpOwogCiAgICAgZmxvYXQgdGhldGFBcmMgPSB0aGV0YTIgLSB0aGV0 YTE7CiAgICAgaWYgKHRoZXRhQXJjIDwgMCAmJiBzd2VlcEZsYWcpCg==