<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>105976</bug_id>
          
          <creation_ts>2013-01-02 17:24:11 -0800</creation_ts>
          <short_desc>Work around flakyness during autoinstall</short_desc>
          <delta_ts>2013-01-09 19:17:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim &apos;mithro&apos; Ansell">mithro</reporter>
          <assigned_to name="Tim &apos;mithro&apos; Ansell">mithro</assigned_to>
          <cc>abarth</cc>
    
    <cc>dbates</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>799123</commentid>
    <comment_count>0</comment_count>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-02 17:24:11 -0800</bug_when>
    <thetext>Work around SourceForge flakyness.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799158</commentid>
    <comment_count>1</comment_count>
      <attachid>181127</attachid>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-02 18:26:41 -0800</bug_when>
    <thetext>Created attachment 181127
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799605</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-01-03 13:30:11 -0800</bug_when>
    <thetext>@eric: Thoughts?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799625</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 13:40:05 -0800</bug_when>
    <thetext>What do you mean &quot;Flaky&quot;?  Could we list a different SF mirror which is not flaky instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799748</commentid>
    <comment_count>4</comment_count>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 15:25:58 -0800</bug_when>
    <thetext>The download link is 
 http://downloads.sourceforge.net/project/python-irclib/python-irclib/0.4.8/python-irclib-0.4.8.zip

Which is the SourceForge redirector that sends you to a local mirror.

This redirector very occasionally (like 1 in 100) sends you to a broken mirror and you get an error. The crappy mirrors seem to be mostly in Asia pacific, so you probably don&apos;t seen them in the US.

Maybe we should retry all failed requests multiple times?

Tim</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799761</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 15:31:59 -0800</bug_when>
    <thetext>I think it&apos;s OK for the autoinstaller to have retry behavior, yes.  I don&apos;t think the retry behavior should be limited to sourceforge.  I&apos;m surprised we dont&apos; already have some sort of retry-behavior-aware fetch function for you to use?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799766</commentid>
    <comment_count>6</comment_count>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 15:35:31 -0800</bug_when>
    <thetext>If you can find one, I&apos;d be happy to use it. Will upload a patch without the SourceForge specific nature.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799772</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 15:42:02 -0800</bug_when>
    <thetext>I think NetworkTransaction in common.system.net is what you want. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799870</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 17:23:26 -0800</bug_when>
    <thetext>I should note that (despite having created it) I don&apos;t know the current autoinstaller &quot;policies&quot;.  it&apos;s possible that autoinstaller tries not to include other parts of webkitpy, and thus it may not be able to use NetworkTransaction.  I do not know.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799917</commentid>
    <comment_count>9</comment_count>
      <attachid>181264</attachid>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 19:37:21 -0800</bug_when>
    <thetext>Created attachment 181264
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799918</commentid>
    <comment_count>10</comment_count>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 19:40:33 -0800</bug_when>
    <thetext>I wasn&apos;t sure if autoinstall should depend on the common.system.net, so I upload a patch with the SF specific bits removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799919</commentid>
    <comment_count>11</comment_count>
      <attachid>181264</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 19:40:59 -0800</bug_when>
    <thetext>Comment on attachment 181264
Patch

OK.  We should probably log with each retry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799928</commentid>
    <comment_count>12</comment_count>
      <attachid>181269</attachid>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 19:48:00 -0800</bug_when>
    <thetext>Created attachment 181269
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799929</commentid>
    <comment_count>13</comment_count>
    <who name="Tim &apos;mithro&apos; Ansell">mithro</who>
    <bug_when>2013-01-03 19:48:16 -0800</bug_when>
    <thetext>Added logging.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799930</commentid>
    <comment_count>14</comment_count>
      <attachid>181269</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-03 19:51:10 -0800</bug_when>
    <thetext>Comment on attachment 181269
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799937</commentid>
    <comment_count>15</comment_count>
      <attachid>181269</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-03 20:22:27 -0800</bug_when>
    <thetext>Comment on attachment 181269
Patch

Clearing flags on attachment: 181269

Committed r138776: &lt;http://trac.webkit.org/changeset/138776&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799938</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-03 20:22:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803929</commentid>
    <comment_count>17</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-01-09 18:51:33 -0800</bug_when>
    <thetext>For the record, I would be very nervous if we tried to use anything else from webkitpy in autoinstall.py; this function gets called very early on when loading files and I could see us easily triggering circular dependencies if networktransaction.py then tried to import something from webkitpy.thirdparty.

I think it was good to make this standalone and we should probably document this accordingly somewhere.

Or maybe just have a general rule that webkitpy.common.system isn&apos;t allowed to import anything else from webkitpy (don&apos;t know if it tries to today or not).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803951</commentid>
    <comment_count>18</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-09 19:13:21 -0800</bug_when>
    <thetext>webkitpy.common certainly imports from layout_tests.port, sadly.  My goal would be that layout_tests.port move to webkitpy.common eventually. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803955</commentid>
    <comment_count>19</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-01-09 19:17:33 -0800</bug_when>
    <thetext>(In reply to comment #18)
&gt; webkitpy.common certainly imports from layout_tests.port, sadly.  My goal would be that layout_tests.port move to webkitpy.common eventually. :)

Sure, we should move port, but I&apos;m not actually bothered by webkitpy.common including  webkitpy.layout_tests.port ... it&apos;s webkitpy.common.*system* that I&apos;m concerned about, since it&apos;s the lowest layer in the stack.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181127</attachid>
            <date>2013-01-02 18:26:41 -0800</date>
            <delta_ts>2013-01-03 19:37:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-105976-20130103132348.patch</filename>
            <type>text/plain</type>
            <size>2657</size>
            <attacher name="Tim &apos;mithro&apos; Ansell">mithro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2I0YzQzNGE3ZmE0OWQ2NmQzMWQ4OTRiNDQwZWZhMDMx
MTllM2MwNy4uMzQxYThiZjNiZjM4MDMxZjI5MGUzNTU5YjAyZmIwNTBhNzFiNDZkMSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEzLTAxLTAyICBUaW0gJ21pdGhybycgQW5zZWxsICA8bWl0aHJvQG1pdGhpcy5jb20+
CisKKyAgICAgICAgU291cmNlRm9yZ2UgY2FuIGJlIGZsYWt5LCBzbyB0cnkgZG93bmxvYWRpbmcg
bXVsdGlwbGUgdGltZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMDU5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weToK
KyAgICAgICAgKEF1dG9JbnN0YWxsZXIuX2Rvd25sb2FkX3RvX3N0cmVhbSk6CisKIDIwMTItMTIt
MTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGVyZlRlc3Qu
cGFyc2Vfb3V0cHV0IGRvZXMgdG9vIG11Y2gKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQppbmRleCAwZDcyOTc3NjdlYTVhMGI3YWFh
MDE3YmI1MGFjNzA2ODJkNGI3OTljLi41OTMwMmVhMmJlYTc4Nzg2MjMzNjdjNTUyYWUxNGRmMGJi
Yjk1Njg4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v
YXV0b2luc3RhbGwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt
L2F1dG9pbnN0YWxsLnB5CkBAIC0yODQsMTcgKzI4NCwyNSBAQCBjbGFzcyBBdXRvSW5zdGFsbGVy
KG9iamVjdCk6CiAgICAgICAgIHJldHVybiBuZXdfcGF0aAogCiAgICAgZGVmIF9kb3dubG9hZF90
b19zdHJlYW0oc2VsZiwgdXJsLCBzdHJlYW0pOgotICAgICAgICB0cnk6Ci0gICAgICAgICAgICBu
ZXRzdHJlYW0gPSB1cmxsaWIudXJsb3Blbih1cmwpCi0gICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBl
cnI6Ci0gICAgICAgICAgICAjIEFwcGVuZCBleGlzdGluZyBFcnJvciBtZXNzYWdlIHRvIG5ldyBF
cnJvci4KLSAgICAgICAgICAgIG1lc3NhZ2UgPSAoJ0NvdWxkIG5vdCBkb3dubG9hZCBQeXRob24g
bW9kdWxlcyBmcm9tIFVSTCAiJXMiLlxuJwotICAgICAgICAgICAgICAgICAgICAgICAiIE1ha2Ug
c3VyZSB5b3UgYXJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQuXG4iCi0gICAgICAgICAgICAg
ICAgICAgICAgICIgWW91IG11c3QgYmUgY29ubmVjdGVkIHRvIHRoZSBpbnRlcm5ldCB3aGVuICIK
LSAgICAgICAgICAgICAgICAgICAgICAgImRvd25sb2FkaW5nIG5lZWRlZCBtb2R1bGVzIGZvciB0
aGUgZmlyc3QgdGltZS5cbiIKLSAgICAgICAgICAgICAgICAgICAgICAgIiAtLT4gSW5uZXIgbWVz
c2FnZTogJXMiCi0gICAgICAgICAgICAgICAgICAgICAgICUgKHVybCwgZXJyKSkKLSAgICAgICAg
ICAgIHJhaXNlIElPRXJyb3IobWVzc2FnZSkKKyAgICAgICAgZmFpbHVyZXMgPSAwCisgICAgICAg
IHdoaWxlIFRydWU6CisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgbmV0c3RyZWFt
ID0gdXJsbGliLnVybG9wZW4odXJsKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAg
ICBleGNlcHQgSU9FcnJvciwgZXJyOgorICAgICAgICAgICAgICAgICMgU291cmNlZm9yZ2UgaXMg
YSBiaXQgZmxha3ksIHRyeSBtdWx0aXBsZSB0aW1lcworICAgICAgICAgICAgICAgIGlmICJzb3Vy
Y2Vmb3JnZS5uZXQiIGluIHVybCBhbmQgZmFpbHVyZXMgPCA1OgorICAgICAgICAgICAgICAgICAg
ICBmYWlsdXJlcyArPSAxCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCisKKyAgICAgICAg
ICAgICAgICAjIEFwcGVuZCBleGlzdGluZyBFcnJvciBtZXNzYWdlIHRvIG5ldyBFcnJvci4KKyAg
ICAgICAgICAgICAgICBtZXNzYWdlID0gKCdDb3VsZCBub3QgZG93bmxvYWQgUHl0aG9uIG1vZHVs
ZXMgZnJvbSBVUkwgIiVzIi5cbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICIgTWFrZSBz
dXJlIHlvdSBhcmUgY29ubmVjdGVkIHRvIHRoZSBpbnRlcm5ldC5cbiIKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICIgWW91IG11c3QgYmUgY29ubmVjdGVkIHRvIHRoZSBpbnRlcm5ldCB3aGVu
ICIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICJkb3dubG9hZGluZyBuZWVkZWQgbW9kdWxl
cyBmb3IgdGhlIGZpcnN0IHRpbWUuXG4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAiIC0t
PiBJbm5lciBtZXNzYWdlOiAlcyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICUgKHVybCwg
ZXJyKSkKKyAgICAgICAgICAgICAgICByYWlzZSBJT0Vycm9yKG1lc3NhZ2UpCiAgICAgICAgIGNv
ZGUgPSAyMDAKICAgICAgICAgaWYgaGFzYXR0cihuZXRzdHJlYW0sICJnZXRjb2RlIik6CiAgICAg
ICAgICAgICBjb2RlID0gbmV0c3RyZWFtLmdldGNvZGUoKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181264</attachid>
            <date>2013-01-03 19:37:21 -0800</date>
            <delta_ts>2013-01-03 19:47:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-105976-20130104143427.patch</filename>
            <type>text/plain</type>
            <size>2598</size>
            <attacher name="Tim &apos;mithro&apos; Ansell">mithro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2I0YzQzNGE3ZmE0OWQ2NmQzMWQ4OTRiNDQwZWZhMDMx
MTllM2MwNy4uMWNkMjYyMDA4ODlhN2E4ODY1YjgwNzljODUzOGY0OGM0YTA3NzJiYyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEzLTAxLTAyICBUaW0gJ21pdGhybycgQW5zZWxsICA8bWl0aHJvQG1pdGhpcy5jb20+
CisKKyAgICAgICAgRG93bmxvYWRzIGNhbiBiZSBmbGFreSwgc28gdHJ5IGRvd25sb2FkaW5nIG11
bHRpcGxlIHRpbWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTA1OTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHk6Cisg
ICAgICAgIChBdXRvSW5zdGFsbGVyLl9kb3dubG9hZF90b19zdHJlYW0pOgorCiAyMDEyLTEyLTE5
ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFBlcmZUZXN0LnBh
cnNlX291dHB1dCBkb2VzIHRvbyBtdWNoCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkKaW5kZXggMGQ3Mjk3NzY3ZWE1YTBiN2FhYTAx
N2JiNTBhYzcwNjgyZDRiNzk5Yy4uMThjYWI3Y2Y2ZTM3M2ViMTdiMTYxZjU1YjVjZTEyYzM2YmRk
M2JiZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2F1
dG9pbnN0YWxsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9h
dXRvaW5zdGFsbC5weQpAQCAtMjg0LDE3ICsyODQsMjUgQEAgY2xhc3MgQXV0b0luc3RhbGxlcihv
YmplY3QpOgogICAgICAgICByZXR1cm4gbmV3X3BhdGgKIAogICAgIGRlZiBfZG93bmxvYWRfdG9f
c3RyZWFtKHNlbGYsIHVybCwgc3RyZWFtKToKLSAgICAgICAgdHJ5OgotICAgICAgICAgICAgbmV0
c3RyZWFtID0gdXJsbGliLnVybG9wZW4odXJsKQotICAgICAgICBleGNlcHQgSU9FcnJvciwgZXJy
OgotICAgICAgICAgICAgIyBBcHBlbmQgZXhpc3RpbmcgRXJyb3IgbWVzc2FnZSB0byBuZXcgRXJy
b3IuCi0gICAgICAgICAgICBtZXNzYWdlID0gKCdDb3VsZCBub3QgZG93bmxvYWQgUHl0aG9uIG1v
ZHVsZXMgZnJvbSBVUkwgIiVzIi5cbicKLSAgICAgICAgICAgICAgICAgICAgICAgIiBNYWtlIHN1
cmUgeW91IGFyZSBjb25uZWN0ZWQgdG8gdGhlIGludGVybmV0LlxuIgotICAgICAgICAgICAgICAg
ICAgICAgICAiIFlvdSBtdXN0IGJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQgd2hlbiAiCi0g
ICAgICAgICAgICAgICAgICAgICAgICJkb3dubG9hZGluZyBuZWVkZWQgbW9kdWxlcyBmb3IgdGhl
IGZpcnN0IHRpbWUuXG4iCi0gICAgICAgICAgICAgICAgICAgICAgICIgLS0+IElubmVyIG1lc3Nh
Z2U6ICVzIgotICAgICAgICAgICAgICAgICAgICAgICAlICh1cmwsIGVycikpCi0gICAgICAgICAg
ICByYWlzZSBJT0Vycm9yKG1lc3NhZ2UpCisgICAgICAgIGZhaWx1cmVzID0gMAorICAgICAgICB3
aGlsZSBUcnVlOgorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIG5ldHN0cmVhbSA9
IHVybGxpYi51cmxvcGVuKHVybCkKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAg
ZXhjZXB0IElPRXJyb3IsIGVycjoKKyAgICAgICAgICAgICAgICAjIFRyeSBtdWx0aXBsZSB0aW1l
cworICAgICAgICAgICAgICAgIGlmIGZhaWx1cmVzIDwgNToKKyAgICAgICAgICAgICAgICAgICAg
ZmFpbHVyZXMgKz0gMQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgICAg
ICAgICAgIyBBcHBlbmQgZXhpc3RpbmcgRXJyb3IgbWVzc2FnZSB0byBuZXcgRXJyb3IuCisgICAg
ICAgICAgICAgICAgbWVzc2FnZSA9ICgnQ291bGQgbm90IGRvd25sb2FkIFB5dGhvbiBtb2R1bGVz
IGZyb20gVVJMICIlcyIuXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAiIE1ha2Ugc3Vy
ZSB5b3UgYXJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQuXG4iCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiIFlvdSBtdXN0IGJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQgd2hlbiAi
CisgICAgICAgICAgICAgICAgICAgICAgICAgICAiZG93bmxvYWRpbmcgbmVlZGVkIG1vZHVsZXMg
Zm9yIHRoZSBmaXJzdCB0aW1lLlxuIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIiAtLT4g
SW5uZXIgbWVzc2FnZTogJXMiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAlICh1cmwsIGVy
cikpCisgICAgICAgICAgICAgICAgcmFpc2UgSU9FcnJvcihtZXNzYWdlKQogICAgICAgICBjb2Rl
ID0gMjAwCiAgICAgICAgIGlmIGhhc2F0dHIobmV0c3RyZWFtLCAiZ2V0Y29kZSIpOgogICAgICAg
ICAgICAgY29kZSA9IG5ldHN0cmVhbS5nZXRjb2RlKCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181269</attachid>
            <date>2013-01-03 19:48:00 -0800</date>
            <delta_ts>2013-01-03 20:22:27 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-105976-20130104144506.patch</filename>
            <type>text/plain</type>
            <size>2709</size>
            <attacher name="Tim &apos;mithro&apos; Ansell">mithro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2I0YzQzNGE3ZmE0OWQ2NmQzMWQ4OTRiNDQwZWZhMDMx
MTllM2MwNy4uMWNkMjYyMDA4ODlhN2E4ODY1YjgwNzljODUzOGY0OGM0YTA3NzJiYyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEzLTAxLTAyICBUaW0gJ21pdGhybycgQW5zZWxsICA8bWl0aHJvQG1pdGhpcy5jb20+
CisKKyAgICAgICAgRG93bmxvYWRzIGNhbiBiZSBmbGFreSwgc28gdHJ5IGRvd25sb2FkaW5nIG11
bHRpcGxlIHRpbWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTA1OTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHk6Cisg
ICAgICAgIChBdXRvSW5zdGFsbGVyLl9kb3dubG9hZF90b19zdHJlYW0pOgorCiAyMDEyLTEyLTE5
ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFBlcmZUZXN0LnBh
cnNlX291dHB1dCBkb2VzIHRvbyBtdWNoCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkKaW5kZXggMGQ3Mjk3NzY3ZWE1YTBiN2FhYTAx
N2JiNTBhYzcwNjgyZDRiNzk5Yy4uZTVmMWI1NGEzN2U1MTIxMGYxNjc4NzhkMDJlZjU2YjE3ZDlj
MTY5NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2F1
dG9pbnN0YWxsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9h
dXRvaW5zdGFsbC5weQpAQCAtMjg0LDE3ICsyODQsMjcgQEAgY2xhc3MgQXV0b0luc3RhbGxlcihv
YmplY3QpOgogICAgICAgICByZXR1cm4gbmV3X3BhdGgKIAogICAgIGRlZiBfZG93bmxvYWRfdG9f
c3RyZWFtKHNlbGYsIHVybCwgc3RyZWFtKToKLSAgICAgICAgdHJ5OgotICAgICAgICAgICAgbmV0
c3RyZWFtID0gdXJsbGliLnVybG9wZW4odXJsKQotICAgICAgICBleGNlcHQgSU9FcnJvciwgZXJy
OgotICAgICAgICAgICAgIyBBcHBlbmQgZXhpc3RpbmcgRXJyb3IgbWVzc2FnZSB0byBuZXcgRXJy
b3IuCi0gICAgICAgICAgICBtZXNzYWdlID0gKCdDb3VsZCBub3QgZG93bmxvYWQgUHl0aG9uIG1v
ZHVsZXMgZnJvbSBVUkwgIiVzIi5cbicKLSAgICAgICAgICAgICAgICAgICAgICAgIiBNYWtlIHN1
cmUgeW91IGFyZSBjb25uZWN0ZWQgdG8gdGhlIGludGVybmV0LlxuIgotICAgICAgICAgICAgICAg
ICAgICAgICAiIFlvdSBtdXN0IGJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQgd2hlbiAiCi0g
ICAgICAgICAgICAgICAgICAgICAgICJkb3dubG9hZGluZyBuZWVkZWQgbW9kdWxlcyBmb3IgdGhl
IGZpcnN0IHRpbWUuXG4iCi0gICAgICAgICAgICAgICAgICAgICAgICIgLS0+IElubmVyIG1lc3Nh
Z2U6ICVzIgotICAgICAgICAgICAgICAgICAgICAgICAlICh1cmwsIGVycikpCi0gICAgICAgICAg
ICByYWlzZSBJT0Vycm9yKG1lc3NhZ2UpCisgICAgICAgIGZhaWx1cmVzID0gMAorICAgICAgICB3
aGlsZSBUcnVlOgorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIG5ldHN0cmVhbSA9
IHVybGxpYi51cmxvcGVuKHVybCkKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAg
ZXhjZXB0IElPRXJyb3IsIGVycjoKKyAgICAgICAgICAgICAgICAjIFRyeSBtdWx0aXBsZSB0aW1l
cworICAgICAgICAgICAgICAgIGlmIGZhaWx1cmVzIDwgNToKKyAgICAgICAgICAgICAgICAgICAg
X2xvZy53YXJuaW5nKCJGYWlsZWQgdG8gZG93bmxvYWQgJXMsICVzIHJldHJ5aW5nIiAlICgKKyAg
ICAgICAgICAgICAgICAgICAgICAgIHVybCwgZXJyKSkKKyAgICAgICAgICAgICAgICAgICAgZmFp
bHVyZXMgKz0gMQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgICAgICAg
ICAgIyBBcHBlbmQgZXhpc3RpbmcgRXJyb3IgbWVzc2FnZSB0byBuZXcgRXJyb3IuCisgICAgICAg
ICAgICAgICAgbWVzc2FnZSA9ICgnQ291bGQgbm90IGRvd25sb2FkIFB5dGhvbiBtb2R1bGVzIGZy
b20gVVJMICIlcyIuXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAiIE1ha2Ugc3VyZSB5
b3UgYXJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQuXG4iCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAiIFlvdSBtdXN0IGJlIGNvbm5lY3RlZCB0byB0aGUgaW50ZXJuZXQgd2hlbiAiCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAiZG93bmxvYWRpbmcgbmVlZGVkIG1vZHVsZXMgZm9y
IHRoZSBmaXJzdCB0aW1lLlxuIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIiAtLT4gSW5u
ZXIgbWVzc2FnZTogJXMiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAlICh1cmwsIGVycikp
CisgICAgICAgICAgICAgICAgcmFpc2UgSU9FcnJvcihtZXNzYWdlKQogICAgICAgICBjb2RlID0g
MjAwCiAgICAgICAgIGlmIGhhc2F0dHIobmV0c3RyZWFtLCAiZ2V0Y29kZSIpOgogICAgICAgICAg
ICAgY29kZSA9IG5ldHN0cmVhbS5nZXRjb2RlKCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>