105975 2013-01-02 17:11:31 -0800 PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods. 2013-01-03 10:50:02 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Trivial --- 1 tsepez webkit-unassigned abarth japhet mkwst tsepez webkit.review.bot oldest_to_newest 799106 0 tsepez 2013-01-02 17:11:31 -0800 Small style nit. 799460 1 181186 tsepez 2013-01-03 10:25:12 -0800 Created attachment 181186 Patch. I believe this brings us more in line with the style guide. thanks. 799485 2 181186 webkit.review.bot 2013-01-03 10:49:59 -0800 Comment on attachment 181186 Patch. Clearing flags on attachment: 181186 Committed r138720: <http://trac.webkit.org/changeset/138720> 799486 3 webkit.review.bot 2013-01-03 10:50:02 -0800 All reviewed patches have been landed. Closing bug. 181186 2013-01-03 10:25:12 -0800 2013-01-03 10:49:59 -0800 Patch. patch_105975.txt text/plain 2263 tsepez SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODcxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTAzICBUb20gU2Vw ZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFBpbmdMb2FkZXIuaCBtaXNzaW5n IHZpcnR1YWwgYW5kIE9WRVJSSURFIGtleXdvcmRzIG9uIGl0cyBpbmhlcml0ZWQgbWV0aG9kcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk3NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBh ZGRzIGNvbXBpbGUtdGltZSBjaGVja3Mgb25seSwgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogbG9hZGVyL1BpbmdMb2FkZXIuaDoKKyAgICAgICAgKFBpbmdMb2FkZXIpOgorICAgICAgICAo V2ViQ29yZTo6UGluZ0xvYWRlcjo6dGltZW91dCk6CisKIDIwMTMtMDEtMDMgIFRpYW5jaGVuZyBK aWFuZyAgPHRpamlhbmdAcmltLmNvbT4KIAogICAgICAgICBVcGRhdGUgQkIxMCBtZWRpYSByZW5k ZXIgdGhlbWUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUGluZ0xvYWRlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9QaW5nTG9hZGVyLmgJKHJldmlzaW9uIDEz ODY0NykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9QaW5nTG9hZGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTU4LDE3ICs1OCwxNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2VuZFBpbmco RnJhbWUqLCBjb25zdCBLVVJMJiBwaW5nVVJMLCBjb25zdCBLVVJMJiBkZXN0aW5hdGlvblVSTCk7 CiAgICAgc3RhdGljIHZvaWQgc2VuZFZpb2xhdGlvblJlcG9ydChGcmFtZSosIGNvbnN0IEtVUkwm IHJlcG9ydFVSTCwgUGFzc1JlZlB0cjxGb3JtRGF0YT4gcmVwb3J0KTsKIAotICAgIH5QaW5nTG9h ZGVyKCk7CisgICAgdmlydHVhbCB+UGluZ0xvYWRlcigpOwogCiBwcml2YXRlOgogICAgIFBpbmdM b2FkZXIoRnJhbWUqLCBSZXNvdXJjZVJlcXVlc3QmKTsKIAotICAgIHZvaWQgZGlkUmVjZWl2ZVJl c3BvbnNlKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpIHsgZGVsZXRl IHRoaXM7IH0KLSAgICB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlc291cmNlSGFuZGxlKiwgY29uc3Qg Y2hhciosIGludCwgaW50KSB7IGRlbGV0ZSB0aGlzOyB9Ci0gICAgdm9pZCBkaWRGaW5pc2hMb2Fk aW5nKFJlc291cmNlSGFuZGxlKiwgZG91YmxlKSB7IGRlbGV0ZSB0aGlzOyB9Ci0gICAgdm9pZCBk aWRGYWlsKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VFcnJvciYpIHsgZGVsZXRlIHRo aXM7IH0KKyAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlSGFuZGxl KiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpIE9WRVJSSURFIHsgZGVsZXRlIHRoaXM7IH0KKyAg ICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBjaGFy KiwgaW50LCBpbnQpIE9WRVJSSURFIHsgZGVsZXRlIHRoaXM7IH0KKyAgICB2aXJ0dWFsIHZvaWQg ZGlkRmluaXNoTG9hZGluZyhSZXNvdXJjZUhhbmRsZSosIGRvdWJsZSkgT1ZFUlJJREUgeyBkZWxl dGUgdGhpczsgfQorICAgIHZpcnR1YWwgdm9pZCBkaWRGYWlsKFJlc291cmNlSGFuZGxlKiwgY29u c3QgUmVzb3VyY2VFcnJvciYpIE9WRVJSSURFIHsgZGVsZXRlIHRoaXM7IH0KKyAgICB2aXJ0dWFs IGJvb2wgc2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoUmVzb3VyY2VIYW5kbGUqKSAgT1ZFUlJJ REUgeyByZXR1cm4gbV9zaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZTsgfQogICAgIHZvaWQgdGlt ZW91dChUaW1lcjxQaW5nTG9hZGVyPiopIHsgZGVsZXRlIHRoaXM7IH0KLSAgICBib29sIHNob3Vs ZFVzZUNyZWRlbnRpYWxTdG9yYWdlKFJlc291cmNlSGFuZGxlKikgeyByZXR1cm4gbV9zaG91bGRV c2VDcmVkZW50aWFsU3RvcmFnZTsgfQogCiAgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBtX2hh bmRsZTsKICAgICBUaW1lcjxQaW5nTG9hZGVyPiBtX3RpbWVvdXQ7Cg==