<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>105974</bug_id>
          
          <creation_ts>2013-01-02 17:06:21 -0800</creation_ts>
          <short_desc>[chromium] Remove unused transitional #defines from WebKit Client API</short_desc>
          <delta_ts>2013-01-02 18:06:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="James Robinson">jamesr</reporter>
          <assigned_to name="James Robinson">jamesr</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>fishd</cc>
    
    <cc>tkent+wkapi</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>799096</commentid>
    <comment_count>0</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2013-01-02 17:06:21 -0800</bug_when>
    <thetext>[chromium] Remove unused transitional #defines from WebKit Client API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799100</commentid>
    <comment_count>1</comment_count>
      <attachid>181114</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2013-01-02 17:07:50 -0800</bug_when>
    <thetext>Created attachment 181114
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799102</commentid>
    <comment_count>2</comment_count>
      <attachid>181114</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2013-01-02 17:08:19 -0800</bug_when>
    <thetext>Comment on attachment 181114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181114&amp;action=review

&gt; Source/WebKit/chromium/public/WebWidget.h:43
&gt;  #define WEBWIDGET_HAS_SETCOMPOSITORSURFACEREADY 1
&gt;  #define WEBWIDGET_HAS_PAINT_OPTIONS 1

These two are still checked on the chromium side, so I&apos;ll have to remove the checks, roll forward, then remove the #defines</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799104</commentid>
    <comment_count>3</comment_count>
      <attachid>181114</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-01-02 17:08:49 -0800</bug_when>
    <thetext>Comment on attachment 181114
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799110</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-02 17:12:12 -0800</bug_when>
    <thetext>Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799152</commentid>
    <comment_count>5</comment_count>
      <attachid>181114</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-02 18:06:33 -0800</bug_when>
    <thetext>Comment on attachment 181114
Patch

Clearing flags on attachment: 181114

Committed r138690: &lt;http://trac.webkit.org/changeset/138690&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>799153</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-02 18:06:37 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181114</attachid>
            <date>2013-01-02 17:07:50 -0800</date>
            <delta_ts>2013-01-02 18:06:33 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-105974-20130102170458.patch</filename>
            <type>text/plain</type>
            <size>3433</size>
            <attacher name="James Robinson">jamesr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDVmMzlhMTQ0ZGQ3NGQ1ODQ5MjVkYWZjY2QyYWQ4NGIyNGM5YzQ5MzEuLjhjNzM5ZGFmZTgyOWRh
NTQyOGNjOGVjNDFmYzZjNWNmNWMxNTQwNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTkgQEAKKzIwMTMtMDEtMDIgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t
aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSB1bnVzZWQgdHJhbnNpdGlvbmFs
ICNkZWZpbmVzIGZyb20gV2ViS2l0IENsaWVudCBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0cmFuc2l0aW9ucyB0aGVzZSAjZGVmaW5lcyBo
ZWxwZWQgd2l0aCBoYXZlIGNvbXBsZXRlZC4KKworICAgICAgICAqIHB1YmxpYy9XZWJGaWxlU3lz
dGVtQ2FsbGJhY2tzLmg6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIHB1YmxpYy9XZWJL
aXQuaDoKKyAgICAgICAgKiBwdWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmg6CisgICAgICAgICog
cHVibGljL1dlYlNldHRpbmdzLmg6CisgICAgICAgICogcHVibGljL1dlYldpZGdldC5oOgorCiAy
MDEyLTEyLTE5ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAg
ICAgIFN1cHBvcnQgdGl0bGVVSUVsZW1lbnQgaW4gY2hyb21pdW0gRFJUCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGaWxlU3lzdGVtQ2FsbGJhY2tzLmggYi9T
b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGaWxlU3lzdGVtQ2FsbGJhY2tzLmgKaW5k
ZXggM2Y2NjUwN2ZlNzkwZTMwMzNlZTAyMmQwYWZjMDdhZWUxYzM5MzE2MC4uZjRhMTJhYjU5NjIy
ZjlmYmY5YzUyYmM0ZDY0MWMxZWQxZjk4Y2Q0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViRmlsZVN5c3RlbUNhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vcHVibGljL1dlYkZpbGVTeXN0ZW1DYWxsYmFja3MuaApAQCAtNDEsOSArNDEs
NiBAQCBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBzdHJ1Y3QgV2ViRmlsZUluZm87
CiAKLS8vIFRlbXBvcmFyeSBoYWNrIHRvIGVhc2UgYSA0LXBoYXNlIENocm9taXVtL1dlYktpdCBj
b21taXQuCi0jZGVmaW5lIFdFQkZJTEVTWVNURU1DQUxMQkFDS1NfVVNFX1VSTF9OT1RfU1RSSU5H
IDEKLQogY2xhc3MgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyB7CiBwdWJsaWM6CiAgICAgLy8gQ2Fs
bGJhY2sgZm9yIFdlYkZpbGVTeXN0ZW0ncyB2YXJpb3VzIG9wZXJhdGlvbnMgdGhhdCBkb24ndCBy
ZXF1aXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQu
aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCmluZGV4IGE4OWQ0Nzg1
ZjUzOGEyZGYzN2UwN2RjZGE3ZTc4MzNlM2JmNzA5ZGEuLmNmNDQ1MTVjMGJlOGZjYjI5ZmM4MzJh
NWIzMWI3MDIyODk5MWU5YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi
bGljL1dlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5o
CkBAIC0zMyw4ICszMyw2IEBACiAKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJDb21tb24uaCIKIAot
I2RlZmluZSBIQVZFX1dFQkNPTVBPU0lUT1IKLQogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNz
IFdlYktpdFBsYXRmb3JtU3VwcG9ydDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p
dW0vcHVibGljL1dlYlJ1bnRpbWVGZWF0dXJlcy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w
dWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmgKaW5kZXggNzFjZGU3NWNhM2VhYTE3ODBjMDU0NmY0
MTE0ZjBiODE4NDA1Mzk5YS4uM2JkOTM4MGE0ZmRlZjA0NzM0MjAyODg5MTNjMzgzYjczZTE4YmJj
ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUnVudGltZUZl
YXR1cmVzLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUnVudGltZUZl
YXR1cmVzLmgKQEAgLTMxLDggKzMxLDYgQEAKICNpZm5kZWYgV2ViUnVudGltZUZlYXR1cmVzX2gK
ICNkZWZpbmUgV2ViUnVudGltZUZlYXR1cmVzX2gKIAotI2RlZmluZSBIQVNfV0VCQVVESU9fUlVO
VElNRUZFQVRVUkVTIDEKLQogI2luY2x1ZGUgInBsYXRmb3JtL1dlYkNvbW1vbi5oIgogCiBuYW1l
c3BhY2UgV2ViS2l0IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj
L1dlYlNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5n
cy5oCmluZGV4IDBjMzA3Y2IwOWJjMGNmODNkZDc4N2Y2NzYxYzIzZGQ3MGZiOTU3YzQuLmRkODA0
ZjViMDcwNzA5YWQyMjExMWY0OWMwNDExNTQ1NGI0Zjg2OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaApAQCAtMzUsOCArMzUsNiBAQAogI2luY2x1ZGUg
InBsYXRmb3JtL1dlYlNpemUuaCIKICNpbmNsdWRlIDx1bmljb2RlL3VzY3JpcHQuaD4KIAotI2Rl
ZmluZSBIQVNfV0VCQVVESU9fRkVBVFVSRV9FTkFCTEUgMQotCiBuYW1lc3BhY2UgV2ViS2l0IHsK
IAogY2xhc3MgV2ViU3RyaW5nOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w
dWJsaWMvV2ViV2lkZ2V0LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRn
ZXQuaAppbmRleCBiMjFhMzE2Mzc5OGE1NmNmMTgyNDE3NmE2MTdiODcyMzFhMmQ0ZTRiLi4yYzJk
YTQwNTM1OWJiNjNkZDM4MjczNTZmYmQ2MDhlMGI5M2JiZDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL3B1YmxpYy9XZWJXaWRnZXQuaApAQCAtMzksNyArMzksNiBAQAogI2luY2x1ZGUgInBs
YXRmb3JtL1dlYlJlY3QuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJTaXplLmgiCiAKLSNkZWZp
bmUgV0VCS0lUX0hBU19ORVdfRlVMTFNDUkVFTl9BUEkgMQogI2RlZmluZSBXRUJXSURHRVRfSEFT
X1NFVENPTVBPU0lUT1JTVVJGQUNFUkVBRFkgMQogI2RlZmluZSBXRUJXSURHRVRfSEFTX1BBSU5U
X09QVElPTlMgMQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>