105958 2013-01-02 15:22:22 -0800 [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails 2013-01-04 02:20:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa sail ap sail tony viettrungluu webkit.review.bot oldest_to_newest 798969 0 rniwa 2013-01-02 15:22:22 -0800 We’re seeing failure like this one: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138643%20(4408)/platform/mac/fast/events/numpad-keycode-mapping-pretty-diff.html --- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/platform/mac/fast/events/numpad-keycode-mapping-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/platform/mac/fast/events/numpad-keycode-mapping-actual.txt @@ -3,24 +3,24 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS getKeyCode('.') is 0x6E -PASS getKeyCode('*') is 0x6A -PASS getKeyCode('+') is 0x6B -PASS getKeyCode('clear') is 0x0C -PASS getKeyCode('/') is 0x6F -PASS getKeyCode('enter') is 0x0D -PASS getKeyCode('-') is 0x6D -PASS getKeyCode('=') is 0xBB -PASS getKeyCode('0') is 0x60 -PASS getKeyCode('1') is 0x61 -PASS getKeyCode('2') is 0x62 -PASS getKeyCode('3') is 0x63 -PASS getKeyCode('4') is 0x64 -PASS getKeyCode('5') is 0x65 -PASS getKeyCode('6') is 0x66 -PASS getKeyCode('7') is 0x67 -PASS getKeyCode('8') is 0x68 -PASS getKeyCode('9') is 0x69 +FAIL getKeyCode('.') should be 110. Was 65. +FAIL getKeyCode('*') should be 106. Was 65. +FAIL getKeyCode('+') should be 107. Was 65. +FAIL getKeyCode('clear') should be 12. Was 65. +FAIL getKeyCode('/') should be 111. Was 65. +FAIL getKeyCode('enter') should be 13. Was 65. +FAIL getKeyCode('-') should be 109. Was 65. +FAIL getKeyCode('=') should be 187. Was 65. +FAIL getKeyCode('0') should be 96. Was 48. +FAIL getKeyCode('1') should be 97. Was 65. +FAIL getKeyCode('2') should be 98. Was 65. +FAIL getKeyCode('3') should be 99. Was 65. +FAIL getKeyCode('4') should be 100. Was 65. +FAIL getKeyCode('5') should be 101. Was 53. +FAIL getKeyCode('6') should be 102. Was 65. +FAIL getKeyCode('7') should be 103. Was 55. +FAIL getKeyCode('8') should be 104. Was 65. +FAIL getKeyCode('9') should be 105. Was 57. PASS successfullyParsed is true TEST COMPLETE 798975 1 rniwa 2013-01-02 15:26:24 -0800 Added a test expectation in http://trac.webkit.org/changeset/138662. 798980 2 sail 2013-01-02 15:28:17 -0800 Will fix, sorry for the failure. 799598 3 181209 sail 2013-01-03 13:18:42 -0800 Created attachment 181209 Patch 799600 4 sail 2013-01-03 13:21:09 -0800 Uploaded patch to fix the WebKitTestRunner failure. Alexey and Ryosuke, could you please take a look? Thanks. 799602 5 181209 ap 2013-01-03 13:29:25 -0800 Comment on attachment 181209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181209&action=review > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:370 > + eventCharacter = currentCharacterString; I'm not sure why this assignment is needed. We were not assigning to eventCharacter in the code that you remove. 799796 6 181209 sail 2013-01-03 15:58:29 -0800 Comment on attachment 181209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181209&action=review >> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:370 >> + eventCharacter = currentCharacterString; > > I'm not sure why this assignment is needed. We were not assigning to eventCharacter in the code that you remove. For the characters I removed eventCharacter is already set to the correct value. The only cases where it needs to be changed is for for the Clear and Enter keys. 800112 7 181209 webkit.review.bot 2013-01-04 02:20:28 -0800 Comment on attachment 181209 Patch Clearing flags on attachment: 181209 Committed r138787: <http://trac.webkit.org/changeset/138787> 800114 8 webkit.review.bot 2013-01-04 02:20:33 -0800 All reviewed patches have been landed. Closing bug. 181209 2013-01-03 13:18:42 -0800 2013-01-04 02:20:28 -0800 Patch bug-105958-20130103131550.patch text/plain 5034 sail U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjY3MzEyZmJlN2Y5YjM1NDI1NzE0MDc1MTYyMTEwZmZk NWI0Nzk1Yy4uYTYzMjk4ODY5NzhiZDFlMDYxMGM2MTk0ZTdiNmZkZmE5ODFjMTYyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAxLTAzICBTYWlsZXNoIEFncmF3YWwgIDxzYWlsQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbTWFjXSBbV0syXSBwbGF0Zm9ybS9tYWMvZmFzdC9ldmVudHMvbnVtcGFkLWtleWNv ZGUtbWFwcGluZy5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDU5NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQb3J0ZWQgY29kZSBmcm9tIER1bXBSZW5kZXJUcmVlIHRvIFdlYktpdFRl c3RSdW5uZXIgdG8gbWFwIGFsbCBudW1wYWQga2V5cy4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvbWFjL0V2ZW50U2VuZGVyUHJveHkubW06CisgICAgICAgIChLZXlNYXBwaW5nRW50cnkp OgorICAgICAgICAoV1RSKToKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6a2V5RG93 bik6IEFkZGVkIGFsbCBudW1wYWQga2V5cy4KKwogMjAxMy0wMS0wMyAgVG9ueSBDaGFuZyAgPHRv bnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEdlbmVyYXRlIGludGVybmFsLnNldHRpbmdzIGZy b20gU2V0dGluZ3MuaW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL0V2 ZW50U2VuZGVyUHJveHkubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9FdmVudFNlbmRl clByb3h5Lm1tCmluZGV4IGVjZTViNTIzZTI5M2ZiZDFhZjhhMzEzZmEyNDI0NWRiMTBiYTRlMDQu Ljg3YzFjZjcwZjY2YWNkMDYyNzNmMDcyZDIzZTE5Nzg0YWJmMzkwNmEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL0V2ZW50U2VuZGVyUHJveHkubW0KKysrIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94eS5tbQpAQCAtNDksNiArNDksMTMg QEAgZW51bSBNb3VzZUJ1dHRvbiB7CiAgICAgTm9Nb3VzZUJ1dHRvbiA9IC0xCiB9OwogCitzdHJ1 Y3QgS2V5TWFwcGluZ0VudHJ5IHsKKyAgICBpbnQgbWFjS2V5Q29kZTsKKyAgICBpbnQgbWFjTnVt cGFkS2V5Q29kZTsKKyAgICB1bmljaGFyIGNoYXJhY3RlcjsKKyAgICBOU1N0cmluZyogY2hhcmFj dGVyTmFtZTsKK307CisKIHN0YXRpYyBOU0V2ZW50VHlwZSBldmVudFR5cGVGb3JNb3VzZUJ1dHRv bkFuZEFjdGlvbihpbnQgYnV0dG9uLCBNb3VzZUFjdGlvbiBhY3Rpb24pCiB7CiAgICAgc3dpdGNo IChidXR0b24pIHsKQEAgLTMyNCwxNCArMzMxLDYgQEAgdm9pZCBFdmVudFNlbmRlclByb3h5Ojpr ZXlEb3duKFdLU3RyaW5nUmVmIGtleSwgV0tFdmVudE1vZGlmaWVycyBtb2RpZmllcnMsIHVuc2kK ICAgICAgICAga2V5Q29kZSA9IDB4NEM7CiAgICAgZWxzZSBpZiAoW2NoYXJhY3RlciBpc0VxdWFs VG9TdHJpbmc6QCJceDgiXSkKICAgICAgICAga2V5Q29kZSA9IDB4MzM7Ci0gICAgZWxzZSBpZiAo W2NoYXJhY3RlciBpc0VxdWFsVG9TdHJpbmc6QCI3Il0pCi0gICAgICAgIGtleUNvZGUgPSAweDFB OwotICAgIGVsc2UgaWYgKFtjaGFyYWN0ZXIgaXNFcXVhbFRvU3RyaW5nOkAiNSJdKQotICAgICAg ICBrZXlDb2RlID0gMHgxNzsKLSAgICBlbHNlIGlmIChbY2hhcmFjdGVyIGlzRXF1YWxUb1N0cmlu ZzpAIjkiXSkKLSAgICAgICAga2V5Q29kZSA9IDB4MTk7Ci0gICAgZWxzZSBpZiAoW2NoYXJhY3Rl ciBpc0VxdWFsVG9TdHJpbmc6QCIwIl0pCi0gICAgICAgIGtleUNvZGUgPSAweDFEOwogICAgIGVs c2UgaWYgKFtjaGFyYWN0ZXIgaXNFcXVhbFRvU3RyaW5nOkAiYSJdKQogICAgICAgICBrZXlDb2Rl ID0gMHgwMDsKICAgICBlbHNlIGlmIChbY2hhcmFjdGVyIGlzRXF1YWxUb1N0cmluZzpAImIiXSkK QEAgLTM0MSw2ICszNDAsMzggQEAgdm9pZCBFdmVudFNlbmRlclByb3h5OjprZXlEb3duKFdLU3Ry aW5nUmVmIGtleSwgV0tFdmVudE1vZGlmaWVycyBtb2RpZmllcnMsIHVuc2kKICAgICBlbHNlIGlm IChbY2hhcmFjdGVyIGlzRXF1YWxUb1N0cmluZzpAImUiXSkKICAgICAgICAga2V5Q29kZSA9IDB4 MEU7CiAKKyAgICBLZXlNYXBwaW5nRW50cnkgdGFibGVbXSA9IHsKKyAgICAgICAgezB4MkYsIDB4 NDEsICcuJywgbmlsfSwKKyAgICAgICAgezAsICAgIDB4NDMsICcqJywgbmlsfSwKKyAgICAgICAg ezAsICAgIDB4NDUsICcrJywgbmlsfSwKKyAgICAgICAgezAsICAgIDB4NDcsIE5TQ2xlYXJMaW5l RnVuY3Rpb25LZXksIEAiY2xlYXIifSwKKyAgICAgICAgezB4MkMsIDB4NEIsICcvJywgbmlsfSwK KyAgICAgICAgezAsICAgIDB4NEMsIDMsIEAiZW50ZXIiIH0sCisgICAgICAgIHsweDFCLCAweDRF LCAnLScsIG5pbH0sCisgICAgICAgIHsweDE4LCAweDUxLCAnPScsIG5pbH0sCisgICAgICAgIHsw eDFELCAweDUyLCAnMCcsIG5pbH0sCisgICAgICAgIHsweDEyLCAweDUzLCAnMScsIG5pbH0sCisg ICAgICAgIHsweDEzLCAweDU0LCAnMicsIG5pbH0sCisgICAgICAgIHsweDE0LCAweDU1LCAnMycs IG5pbH0sCisgICAgICAgIHsweDE1LCAweDU2LCAnNCcsIG5pbH0sCisgICAgICAgIHsweDE3LCAw eDU3LCAnNScsIG5pbH0sCisgICAgICAgIHsweDE2LCAweDU4LCAnNicsIG5pbH0sCisgICAgICAg IHsweDFBLCAweDU5LCAnNycsIG5pbH0sCisgICAgICAgIHsweDFDLCAweDVCLCAnOCcsIG5pbH0s CisgICAgICAgIHsweDE5LCAweDVDLCAnOScsIG5pbH0sCisgICAgfTsKKyAgICBmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgV1RGX0FSUkFZX0xFTkdUSCh0YWJsZSk7ICsraSkgeworICAgICAgICBO U1N0cmluZyogY3VycmVudENoYXJhY3RlclN0cmluZyA9IFtOU1N0cmluZyBzdHJpbmdXaXRoQ2hh cmFjdGVyczomdGFibGVbaV0uY2hhcmFjdGVyIGxlbmd0aDoxXTsKKyAgICAgICAgaWYgKFtjaGFy YWN0ZXIgaXNFcXVhbFRvU3RyaW5nOmN1cnJlbnRDaGFyYWN0ZXJTdHJpbmddIHx8IFtjaGFyYWN0 ZXIgaXNFcXVhbFRvU3RyaW5nOnRhYmxlW2ldLmNoYXJhY3Rlck5hbWVdKSB7CisgICAgICAgICAg ICBpZiAoa2V5TG9jYXRpb24gPT0gMHgwMyAvKkRPTV9LRVlfTE9DQVRJT05fTlVNUEFEKi8pCisg ICAgICAgICAgICAgICAga2V5Q29kZSA9IHRhYmxlW2ldLm1hY051bXBhZEtleUNvZGU7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAga2V5Q29kZSA9IHRhYmxlW2ldLm1hY0tleUNv ZGU7CisgICAgICAgICAgICBldmVudENoYXJhY3RlciA9IGN1cnJlbnRDaGFyYWN0ZXJTdHJpbmc7 CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgIH0KKwogICAgIE5TU3RyaW5nICpj aGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgPSBldmVudENoYXJhY3RlcjsKIAogICAgIGludCBt b2RpZmllckZsYWdzID0gMDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhYjE5NjNlMTNjYjM2OGQwZWQxYzg2YTM3N2YwZjRm MjZhOTY5ZGY1Li5lMDEwMDZhMmRhNGNlMzFiNmQ0OTc0N2IyNjFlODQzZWM0ZGQxYjQ0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEtMDMgIFNhaWxlc2ggQWdyYXdhbCAgPHNhaWxAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtNYWNdIFtXSzJdIHBsYXRmb3JtL21hYy9mYXN0L2V2ZW50 cy9udW1wYWQta2V5Y29kZS1tYXBwaW5nLmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIG51bXBhZC1rZXljb2RlLW1hcHBpbmcu aHRtbCBmYWlsdXJlIGluIFdlYktpdFRlc3RSdW5uZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDEtMDMgIEFsZXhpcyBNZW5hcmQgIDxh bGV4aXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBRdWVyeWluZyB0cmFuc2l0aW9uLXRpbWluZy1m dW5jdGlvbiB2YWx1ZSBvbiB0aGUgY29tcHV0ZWQgc3R5bGUgZG9lcyBub3QgcmV0dXJuIGtleXdv cmRzIHdoZW4gaXQgc2hvdWxkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0 RXhwZWN0YXRpb25zCmluZGV4IGM4MWI4N2I5MjFmYzc5ZDJkZWJhZThjYjMyYjI2YzYxMGViNmQx MWYuLmRkMjNlNzdmYzczYTRlNDNhZWI3MTUzOTJmMjNjZTQzMjgzNDFjNzggMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI3OSw4ICsyNzks NiBAQCB3ZWJraXQub3JnL2IvMTA1OTU0IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxvYWQtc3Vi ZnJhbWUtb2JqZWN0Lmh0bWwgWyBGYWlsdXJlCiAKIHdlYmtpdC5vcmcvYi8xMDU5NTYgaW5zcGVj dG9yL2dlb2xvY2F0aW9uLXdhdGNoUG9zaXRpb24uaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdl YmtpdC5vcmcvYi8xMDU5NTggcGxhdGZvcm0vbWFjL2Zhc3QvZXZlbnRzL251bXBhZC1rZXljb2Rl LW1hcHBpbmcuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTA1OTYwIHBsdWdpbnMv bmF2aWdhdG9yLXBsdWdpbnMuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTA1OTg4 IFsgRGVidWcgXSBpbnNwZWN0b3IvZGVidWdnZXIvcGF1c2UtaW4taW50ZXJuYWwtc2NyaXB0Lmh0 bWwgWyBQYXNzIENyYXNoIF0K