105955 2013-01-02 15:12:26 -0800 [Chromium] Add Platform/chromium to include_dirs 2013-01-02 16:10:11 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pilgrim pilgrim abarth fishd jamesr webkit.review.bot oldest_to_newest 798954 0 pilgrim 2013-01-02 15:12:26 -0800 [Chromium] Add Platform/chromium to include_dirs 798957 1 181077 pilgrim 2013-01-02 15:15:41 -0800 Created attachment 181077 Patch 798965 2 181077 jamesr 2013-01-02 15:20:40 -0800 Comment on attachment 181077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181077&action=review Close! > Source/WebKit/chromium/WebKit.gyp:702 > + 'include_dirs': [ > + '../../Platform/chromium/', > + ], I don't think you need to add this in the 'component=="shared_library"' conditional since it applies equally to component and non-component builds. > Source/WebKit/chromium/WebKit.gyp:777 > + '../../Platform/chromium/', similarly, this include path doesn't depend on the value of 'inside_chromium_build' so it shouldn't be inside a conditional block. could you add a new 'direct_dependent_settings' block outside the conditionals? 798985 3 181084 pilgrim 2013-01-02 15:30:17 -0800 Created attachment 181084 Patch 798986 4 181084 pilgrim 2013-01-02 15:30:34 -0800 Comment on attachment 181084 Patch Feedback addressed. 799044 5 181084 webkit.review.bot 2013-01-02 16:10:08 -0800 Comment on attachment 181084 Patch Clearing flags on attachment: 181084 Committed r138673: <http://trac.webkit.org/changeset/138673> 799045 6 webkit.review.bot 2013-01-02 16:10:11 -0800 All reviewed patches have been landed. Closing bug. 181077 2013-01-02 15:15:41 -0800 2013-01-02 15:30:14 -0800 Patch bug-105955-20130102181150.patch text/plain 2564 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzg2NTkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTAxLTAyICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIEFkZCBQbGF0Zm9ybS9jaHJvbWl1bSB0byBpbmNsdWRlX2RpcnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk1NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRs eSB0aGUgaGVhZGVycyBpbiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYiouaCBjYW4gbm90Cisg ICAgICAgIGluY2x1ZGUgaGVhZGVycyBmcm9tIHRoZSBuZXcgUGxhdGZvcm0vY2hyb21pdW0vIGRp cmVjdG9yeSB3aXRoIHRoZQorICAgICAgICAiI2luY2x1ZGUgPHB1YmxpYy9XZWJGb28uaD4iIHN5 bnRheCwgYmVjYXVzZSB0aGUgaW5jbHVkZV9kaXJzIGZvcgorICAgICAgICBkZXBlbmRlbnQgYnVp bGRzIChsaWtlIENocm9taXVtLXdpdGhpbi1XZWJLaXQpIGRvIG5vdCBpbmNsdWRlIHRoZQorICAg ICAgICBuZXcgUGxhdGZvcm0vY2hyb21pdW0vIGRpcmVjdG9yeS4gVGhpcyBwYXRjaCBhZGRzIHRo YXQgY2FwYWJpbGl0eQorICAgICAgICB3aXRob3V0IG1hbmFnaW5nIHRvIGJyZWFrIGFueXRoaW5n IGVsc2UuCisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorCiAyMDEzLTAxLTAyICBSb2JlcnQgS3Jv ZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVzZSB0 b3AgbGV2ZWwgZmllbGQgZm9yIGdlc3R1cmUgZXZlbnQgc291cmNlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL1dlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiAxMzg2NDkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL1dlYktpdC5neXAJKHdvcmtpbmcgY29weSkKQEAgLTY5Nyw2ICs2OTcsOSBAQAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnZGVmaW5lcyc6IFsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdXRUJLSVRfRExMJywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2luY2x1ZGVfZGly cyc6IFsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcuLi8uLi9QbGF0Zm9y bS9jaHJvbWl1bS8nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBdLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2V4 cG9ydF9kZXBlbmRlbnRfc2V0dGluZ3MnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICc8KGNocm9taXVtX3NyY19kaXIpL2J1aWxkL3RlbXBfZ3lwL2dvb2dsZXVybC5neXA6Z29v Z2xldXJsJywKQEAgLTc3MSw2ICs3NzQsNyBAQAogICAgICAgICAgICAgICAgICAgICAnZGlyZWN0 X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsKICAgICAgICAgICAgICAgICAgICAgICAgICdpbmNsdWRl X2RpcnMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVE SUFURV9ESVIpL3dlYmtpdCcsICMgaW4gYSBjaHJvbWl1bS1pbnNpZGUtV2ViS2l0IGJ1aWxkLCBo ZWFkZXJzIGluIHRoZSBwdWJsaWMgV2ViS2l0IEFQSSBhcmUgY29waWVkIGJlbmVhdGggdGhpcyBk aXJlY3Rvcnkgc28gaW5jbHVkZXMgcmVmZXJlbmNpbmcgdGhpcmRfcGFydHkvV2ViS2l0IHdvcmsu CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgJy4uLy4uL1BsYXRmb3JtL2Nocm9taXVtLycs CiAgICAgICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICAgICB9LAogICAg ICAgICAgICAgICAgIH1dLApAQCAtOTAyLDYgKzkwNiw3IEBACiAgICAgICAgICAgICAgICAgICAg ICdpbmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAncHVibGljJywKICAg ICAgICAgICAgICAgICAgICAgICAgICcuLi8uLi9XZWJDb3JlL3Rlc3RpbmcvdjgnLCAjIGZvciBX ZWJDb3JlVGVzdFN1cHBvcnQuaCwgbmVlZGVkIHRvIGxpbmsgaW4gd2luZG93LmludGVybmFscyBj b2RlLgorICAgICAgICAgICAgICAgICAgICAgICAgJy4uLy4uL1BsYXRmb3JtL2Nocm9taXVtLycs CiAgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzJzog WwogICAgICAgICAgICAgICAgICAgICAgICAgJ3NyYy9XZWJUZXN0aW5nU3VwcG9ydC5jcHAnLAo= 181084 2013-01-02 15:30:17 -0800 2013-01-02 16:10:08 -0800 Patch bug-105955-20130102182626.patch text/plain 1962 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzg2NTkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTAxLTAyICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIEFkZCBQbGF0Zm9ybS9jaHJvbWl1bSB0byBpbmNsdWRlX2RpcnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTk1NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRs eSB0aGUgaGVhZGVycyBpbiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYiouaCBjYW4gbm90Cisg ICAgICAgIGluY2x1ZGUgaGVhZGVycyBmcm9tIHRoZSBuZXcgUGxhdGZvcm0vY2hyb21pdW0vIGRp cmVjdG9yeSB3aXRoIHRoZQorICAgICAgICAiI2luY2x1ZGUgPHB1YmxpYy9XZWJGb28uaD4iIHN5 bnRheCwgYmVjYXVzZSB0aGUgaW5jbHVkZV9kaXJzIGZvcgorICAgICAgICBkZXBlbmRlbnQgYnVp bGRzIChsaWtlIENocm9taXVtLXdpdGhpbi1XZWJLaXQpIGRvIG5vdCBpbmNsdWRlIHRoZQorICAg ICAgICBuZXcgUGxhdGZvcm0vY2hyb21pdW0vIGRpcmVjdG9yeS4gVGhpcyBwYXRjaCBhZGRzIHRo YXQgY2FwYWJpbGl0eQorICAgICAgICB3aXRob3V0IG1hbmFnaW5nIHRvIGJyZWFrIGFueXRoaW5n IGVsc2UuCisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorCiAyMDEzLTAxLTAyICBSb2JlcnQgS3Jv ZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVzZSB0 b3AgbGV2ZWwgZmllbGQgZm9yIGdlc3R1cmUgZXZlbnQgc291cmNlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL1dlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiAxMzg2NDkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL1dlYktpdC5neXAJKHdvcmtpbmcgY29weSkKQEAgLTg1NCw2ICs4NTQsMTEgQEAKICAgICAg ICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAgIF0sCisg ICAgICAgICAgICAnZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsKKyAgICAgICAgICAgICAg ICAnaW5jbHVkZV9kaXJzJzogWworICAgICAgICAgICAgICAgICAgICAnLi4vLi4vUGxhdGZvcm0v Y2hyb21pdW0vJywKKyAgICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgfSwKICAgICAgICAg ICAgICd0YXJnZXRfY29uZGl0aW9ucyc6IFsKICAgICAgICAgICAgICAgICBbJ09TPT0iYW5kcm9p ZCInLCB7CiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsKQEAgLTkwMiw2ICs5MDcs NyBAQAogICAgICAgICAgICAgICAgICAgICAnaW5jbHVkZV9kaXJzJzogWwogICAgICAgICAgICAg ICAgICAgICAgICAgJ3B1YmxpYycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vV2Vi Q29yZS90ZXN0aW5nL3Y4JywgIyBmb3IgV2ViQ29yZVRlc3RTdXBwb3J0LmgsIG5lZWRlZCB0byBs aW5rIGluIHdpbmRvdy5pbnRlcm5hbHMgY29kZS4KKyAgICAgICAgICAgICAgICAgICAgICAgICcu Li8uLi9QbGF0Zm9ybS9jaHJvbWl1bS8nLAogICAgICAgICAgICAgICAgICAgICBdLAogICAgICAg ICAgICAgICAgICAgICAnc291cmNlcyc6IFsKICAgICAgICAgICAgICAgICAgICAgICAgICdzcmMv V2ViVGVzdGluZ1N1cHBvcnQuY3BwJywK