105925 2013-01-02 08:14:17 -0800 [MinGW-w64] Centralize workaround for pow() implementation 2013-01-03 01:56:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hausmann hausmann benjamin net147 ojan.autocc sam webkit.review.bot oldest_to_newest 798671 0 hausmann 2013-01-02 08:14:17 -0800 [MinGW-w64] Centralize workaround for pow() implementation 798673 1 181031 hausmann 2013-01-02 08:16:20 -0800 Created attachment 181031 Patch 798674 2 webkit.review.bot 2013-01-02 08:18:30 -0800 Attachment 181031 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/MathExtras.h:230: wtf_pow is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 798844 3 net147 2013-01-02 13:37:14 -0800 Missing blank line before "return pow(x, y);". 799315 4 hausmann 2013-01-03 01:56:37 -0800 Committed r138705: <http://trac.webkit.org/changeset/138705> 181031 2013-01-02 08:16:20 -0800 2013-01-02 15:51:38 -0800 Patch bug-105925-20130102171402.patch text/plain 3596 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZGZhYjhiNGRiOThmMjJjOWIxNDA4YmQ0OWM3N2QzMDg2NjM1YWNjLi5lOTc4OTBmYWMzMzczZWUx MjA1ZjI4ZTk4YzcyZmI1N2ViNTI2NjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wMS0wMiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBk aWdpYS5jb20+CisKKyAgICAgICAgW01pbkdXLXc2NF0gQ2VudHJhbGl6ZSB3b3JrYXJvdW5kIGZv ciBwb3coKSBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXMgc3VnZ2VzdGVkIGJ5IFNhbSwgbW92ZSB0aGUgTWluR1ctdzY0IHdv cmthcm91bmQgaW50byBNYXRoRXh0cmFzLmgKKyAgICAgICAgYXdheSBmcm9tIHRoZSBKU0MgdXNh Z2UuCisKKyAgICAgICAgKiBydW50aW1lL01hdGhPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpt YXRoUG93KToKKwogMjAxMy0wMS0wMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCiAgICAgICAgIE9uZSBtb3JlIHVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjEzODYw OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VM b2cKaW5kZXggODVhYmRiZGU5OTI4ZjJlZGYyMmFmNzhhOWJhMzU5NmIxNTFiZTYxZC4uMDQzZTU0 NDRmZDA0OTkwYzcyZjE2Y2FjYTQ5OWRlNzA4MmE2ZGNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxMy0wMS0wMiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBkaWdpYS5jb20+CisK KyAgICAgICAgW01pbkdXLXc2NF0gQ2VudHJhbGl6ZSB3b3JrYXJvdW5kIGZvciBwb3coKSBpbXBs ZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQXMgc3VnZ2VzdGVkIGJ5IFNhbSwgbW92ZSB0aGUgTWluR1ctdzY0IHdvcmthcm91bmQgaW50 byBNYXRoRXh0cmFzLmgKKyAgICAgICAgYXdheSBmcm9tIHRoZSBKU0MgdXNhZ2UuCisKKyAgICAg ICAgKiB3dGYvTWF0aEV4dHJhcy5oOgorICAgICAgICAod3RmX3Bvdyk6CisKIDIwMTItMTItMzEg IEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIE9i amVjdGl2ZS1DIEFQSSBmb3IgSmF2YVNjcmlwdENvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvTWF0aE9iamVjdC5jcHAKaW5kZXggZjkzOWI4ZGQ0Mjc1NWQ0ZjBiZWFiMzE1Mjk0 OTRiOTU3OWY3ODgwMS4uNzYzNDQ4N2FkY2RlMTZjY2Y0NzhmYzNhYjZlMGFiMGI4ZjM1YWE5NCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aE9iamVjdC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aE9iamVjdC5jcHAKQEAgLTIz MiwyMiArMjMyLDYgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgZG91YmxlIG1hdGhQb3coZG91Ymxl IHgsIGRvdWJsZSB5KQogCiBBTFdBWVNfSU5MSU5FIGRvdWJsZSBtYXRoUG93KGRvdWJsZSB4LCBk b3VibGUgeSkKIHsKLSNpZiBDT01QSUxFUihNSU5HVzY0KQotICAgIC8vIE1pbkdXLXc2NCBoYXMg YSBjdXN0b20gaW1wbGVtZW50YXRpb24gZm9yIHBvdy4KLSAgICAvLyBUaGlzIGhhbmRsZXMgY2Vy dGFpbiBzcGVjaWFsIGNhc2VzIHRoYXQgYXJlIGRpZmZlcmVudC4KLSAgICBpZiAoKHggPT0gMC4w IHx8IGlzaW5mKHgpKSAmJiBpc2Zpbml0ZSh5KSkgewotICAgICAgICBkb3VibGUgZjsKLSAgICAg ICAgaWYgKG1vZGYoeSwgJmYpICE9IDAuMCkKLSAgICAgICAgICAgIHJldHVybiAoKHggPT0gMC4w KSBeICh5ID4gMC4wKSkgPyBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCkg OiAwLjA7Ci0gICAgfQotCi0gICAgaWYgKHggPT0gMi4wKSB7Ci0gICAgICAgIGludCB5SW50ID0g c3RhdGljX2Nhc3Q8aW50Pih5KTsKLSAgICAgICAgaWYgKHkgPT0geUludCkKLSAgICAgICAgICAg IHJldHVybiBsZGV4cCgxLjAsIHlJbnQpOwotICAgIH0KLSNlbmRpZgotCiAgICAgcmV0dXJuIHBv dyh4LCB5KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oIGIv U291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCmluZGV4IGRmMWIyMzY1ODY4ZGQ4ZGQ4Yzc1M2Rj ZWFkZDY3MmRmMzM2YmM0MDQuLjBhOTc5NTMzODI2MTIzY2I1MDA3ZmRjMTE3YzY0OWZiZDgxZGRi ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAorKysgYi9Tb3VyY2Uv V1RGL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTIyNiw2ICsyMjYsMjcgQEAgaW5saW5lIGxvbmcgaW50 IGxyaW50KGRvdWJsZSBmbHQpCiAKICNlbmRpZiAvLyBDT01QSUxFUihNU1ZDKQogCisjaWYgQ09N UElMRVIoTUlOR1c2NCkKK2lubGluZSBkb3VibGUgd3RmX3Bvdyhkb3VibGUgeCwgZG91YmxlIHkp Cit7CisgICAgLy8gTWluR1ctdzY0IGhhcyBhIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBmb3IgcG93 LgorICAgIC8vIFRoaXMgaGFuZGxlcyBjZXJ0YWluIHNwZWNpYWwgY2FzZXMgdGhhdCBhcmUgZGlm ZmVyZW50LgorICAgIGlmICgoeCA9PSAwLjAgfHwgaXNpbmYoeCkpICYmIGlzZmluaXRlKHkpKSB7 CisgICAgICAgIGRvdWJsZSBmOworICAgICAgICBpZiAobW9kZih5LCAmZikgIT0gMC4wKQorICAg ICAgICAgICAgcmV0dXJuICgoeCA9PSAwLjApIF4gKHkgPiAwLjApKSA/IHN0ZDo6bnVtZXJpY19s aW1pdHM8ZG91YmxlPjo6aW5maW5pdHkoKSA6IDAuMDsKKyAgICB9CisKKyAgICBpZiAoeCA9PSAy LjApIHsKKyAgICAgICAgaW50IHlJbnQgPSBzdGF0aWNfY2FzdDxpbnQ+KHkpOworICAgICAgICBp ZiAoeSA9PSB5SW50KQorICAgICAgICAgICAgcmV0dXJuIGxkZXhwKDEuMCwgeUludCk7CisgICAg fQorICAgIHJldHVybiBwb3coeCwgeSk7Cit9CisjZGVmaW5lIHBvdyh4LCB5KSB3dGZfcG93KHgs IHkpCisjZW5kaWYgLy8gQ09NUElMRVIoTUlOR1c2NCkKKwogaW5saW5lIGRvdWJsZSBkZWcycmFk KGRvdWJsZSBkKSAgeyByZXR1cm4gZCAqIHBpRG91YmxlIC8gMTgwLjA7IH0KIGlubGluZSBkb3Vi bGUgcmFkMmRlZyhkb3VibGUgcikgIHsgcmV0dXJuIHIgKiAxODAuMCAvIHBpRG91YmxlOyB9CiBp bmxpbmUgZG91YmxlIGRlZzJncmFkKGRvdWJsZSBkKSB7IHJldHVybiBkICogNDAwLjAgLyAzNjAu MDsgfQo=