<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>105919</bug_id>
          
          <creation_ts>2013-01-02 04:47:58 -0800</creation_ts>
          <short_desc>Stylesheets that don&apos;t match current viewport etc. are no longer deferred</short_desc>
          <delta_ts>2013-04-08 15:31:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.8</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andy Davies">dajdavies</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>dglazkov</cc>
    
    <cc>japhet</cc>
    
    <cc>koivisto</cc>
    
    <cc>psolanki</cc>
    
    <cc>schenney</cc>
    
    <cc>simonjam</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yoav</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>798630</commentid>
    <comment_count>0</comment_count>
    <who name="Andy Davies">dajdavies</who>
    <bug_when>2013-01-02 04:47:58 -0800</bug_when>
    <thetext>Previous versions of WebKit deferred loading stylesheets where the media query didn&apos;t match viewport, orientation etc.

This waterfall illustrates the behaviour in Chrome 23 - http://www.webpagetest.org/result/130102_CQ_0f4cca3d4aa1dff79941bb64eda548c9/1/details/ - where big.css is deferred, due to  media=&quot;screen and (min-width : 1200px)&quot;

In Chrome 26, big.css is no longer deferred and so is competing for the network with other resources - http://www.webpagetest.org/result/130102_KJ_2079b3c622753c392584f48052d8a01c/1/details/

Also tested in r138591</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801073</commentid>
    <comment_count>1</comment_count>
      <attachid>181459</attachid>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2013-01-06 08:03:31 -0800</bug_when>
    <thetext>Created attachment 181459
Re-enabling the ResourceLoadScheduler

This issue started in the disabling of the ResourceLoadScheduler for Chromium at the git commit 46e22591a4adb6bb42530b2f52e4517cd3b226bf.
This patch reverses part of that commit.
The reasoning for disabling the renderer&apos;s load scheduler is explained at https://insouciant.org/tech/throttling-subresources-before-first-paint/ and in short it is destined to move resource scheduling out of the rendering engine and into the browser. Since Chrome&apos;s resource scheduling is not yet in place (at least as I can tell), this results in obvious performance regressions, especially when it comes to external CSS files that are not necessary for first paint.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801101</commentid>
    <comment_count>2</comment_count>
    <who name="Yoav Weiss">yoav</who>
    <bug_when>2013-01-06 14:16:45 -0800</bug_when>
    <thetext>I&apos;ve opened a slightly related bug regarding the PreloadScanner - https://bugs.webkit.org/show_bug.cgi?id=106198</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801362</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-01-07 10:03:03 -0800</bug_when>
    <thetext>From the analysis above, this looks like a chromium-only issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801523</commentid>
    <comment_count>4</comment_count>
    <who name="Andy Davies">dajdavies</who>
    <bug_when>2013-01-07 12:02:35 -0800</bug_when>
    <thetext>I used webpagetest as it was the easiest way to provide waterfalls

I also tested in WebKit r138591 and Safari 6.0.2 (8536.26.17) - Safari behaves the same a Chrome 23, WebKit nightly behaves as Chrome 26

That&apos;s why I raised it against WebKit rather than Chromium</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801526</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-01-07 12:03:25 -0800</bug_when>
    <thetext>This patch appears to be in the inverse of http://trac.webkit.org/changeset/129070

Perhaps you and simonjam should discuss this issue at bit.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801528</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-01-07 12:03:51 -0800</bug_when>
    <thetext>Actually CC the folks from http://trac.webkit.org/changeset/129070</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801529</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-01-07 12:04:35 -0800</bug_when>
    <thetext>&gt; That&apos;s why I raised it against WebKit rather than Chromium

It&apos;s correct to raise this issue in bugs.webkit.org.  Alexey is just marking the bug as only affecting Chromium so that he can ignore it.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801542</commentid>
    <comment_count>8</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-01-07 12:23:11 -0800</bug_when>
    <thetext>&gt; Safari behaves the same a Chrome 23, WebKit nightly behaves as Chrome 26

If it&apos;s also broken in nightlies, then perhaps we have multiple issues. A fix that changes REQUEST_MANAGEMENT_ENABLED for Chromium won&apos;t fix Safari nightlies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>801837</commentid>
    <comment_count>9</comment_count>
    <who name="James Simonsen">simonjam</who>
    <bug_when>2013-01-07 16:57:33 -0800</bug_when>
    <thetext>As Alexey says, it&apos;s really only an issue if WebKit nightlies are affected.

For Chrome, we have a browser based scheduler in the works and this bug doesn&apos;t affect stable or beta channel users.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817517</commentid>
    <comment_count>10</comment_count>
      <attachid>181459</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-27 22:00:36 -0800</bug_when>
    <thetext>Comment on attachment 181459
Re-enabling the ResourceLoadScheduler

Attachment 181459 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16156460

New failing tests:
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817532</commentid>
    <comment_count>11</comment_count>
      <attachid>181459</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-27 22:58:34 -0800</bug_when>
    <thetext>Comment on attachment 181459
Re-enabling the ResourceLoadScheduler

Attachment 181459 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16150608

New failing tests:
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181459</attachid>
            <date>2013-01-06 08:03:31 -0800</date>
            <delta_ts>2013-01-27 22:58:34 -0800</delta_ts>
            <desc>Re-enabling the ResourceLoadScheduler</desc>
            <filename>enable_load_scheduler.patch</filename>
            <type>text/plain</type>
            <size>467</size>
            <attacher name="Yoav Weiss">yoav</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNw
cCBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAppbmRleCBm
YTNjMDk2Li4wNzI1NTIzIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNl
TG9hZFNjaGVkdWxlci5jcHAKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRT
Y2hlZHVsZXIuY3BwCkBAIC00MiwxMSArNDIsNyBAQAogI2luY2x1ZGUgPHd0Zi9UZW1wb3JhcnlD
aGFuZ2UuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKLSNpZiBQTEFURk9STShD
SFJPTUlVTSkKLSNkZWZpbmUgUkVRVUVTVF9NQU5BR0VNRU5UX0VOQUJMRUQgMAotI2Vsc2UKICNk
ZWZpbmUgUkVRVUVTVF9NQU5BR0VNRU5UX0VOQUJMRUQgMQotI2VuZGlmCiAKIG5hbWVzcGFjZSBX
ZWJDb3JlIHsKIAo=
</data>
<flag name="commit-queue"
          id="203833"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
      

    </bug>

</bugzilla>