105918 2013-01-02 04:38:34 -0800 [GTK] Disable deprecation warnings for GStaticRecMutex 2013-01-07 10:36:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned eric.carlson feature-media-reviews levin+threading pnormand webkit.review.bot oldest_to_newest 798625 0 berto 2013-01-02 04:38:34 -0800 WebKitWebAudioSourceGStreamer uses a GStaticRecMutex, which is deprecated since glib 2.32 in favor of GRecMutex, and hence produces a compilation warning with -Wdeprecated-declarations. ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: In function ‘void webkit_web_audio_src_init(WebKitWebAudioSrc*)’: ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:193:5: warning: ‘void g_static_rec_mutex_init(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:170): Use 'g_rec_mutex_init' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:193:41: warning: ‘void g_static_rec_mutex_init(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:170): Use 'g_rec_mutex_init' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: In function ‘void webKitWebAudioSrcFinalize(GObject*)’: ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:266:5: warning: ‘void g_static_rec_mutex_free(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:189): Use 'g_rec_mutex_free' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:266:41: warning: ‘void g_static_rec_mutex_free(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:189): Use 'g_rec_mutex_free' instead [-Wdeprecated-declarations] However, we cannot change that since it's needed by gst_task_set_lock() in GStreamer 0.10. So we should disable the deprecation warning for those function calls. 798628 1 181025 berto 2013-01-02 04:44:16 -0800 Created attachment 181025 Patch 798631 2 181025 cgarcia 2013-01-02 05:16:00 -0800 Comment on attachment 181025 Patch I think this is a lot of preprocessor code just to fix a compile warning that is harmless. 798633 3 181026 berto 2013-01-02 05:52:13 -0800 Created attachment 181026 Patch v2 (In reply to comment #2) > I think this is a lot of preprocessor code just to fix a compile > warning that is harmless. Here's a much simpler and readable version. The difference is that it would disable the deprecation warnings in the whole file (which is anyway less than 400 lines of code). 801263 4 pnormand 2013-01-07 06:48:46 -0800 I don't think this patch is needed now that the webaudio backend is ported to gst 1.0 801271 5 berto 2013-01-07 07:00:13 -0800 (In reply to comment #4) > I don't think this patch is needed now that the webaudio backend is ported to gst 1.0 I see, we could still keep it if we're using the old API, but I guess it's not so important. Feel free to close this bug then. 801275 6 181025 pnormand 2013-01-07 07:12:38 -0800 Comment on attachment 181025 Patch Obsoleted by v2 801277 7 181026 pnormand 2013-01-07 07:14:18 -0800 Comment on attachment 181026 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=181026&action=review > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:34 > +#if (COMPILER(GCC) && GCC_VERSION_AT_LEAST(4, 6, 0)) Alright maybe another condition can be added there? !defined(GST_API_VERSION_1) So later on when we remove the 0.10 support we'll make sure to remove this code as well. 801354 8 181516 berto 2013-01-07 09:53:54 -0800 Created attachment 181516 Patch v3 801407 9 181516 webkit.review.bot 2013-01-07 10:35:57 -0800 Comment on attachment 181516 Patch v3 Clearing flags on attachment: 181516 Committed r138960: <http://trac.webkit.org/changeset/138960> 801408 10 webkit.review.bot 2013-01-07 10:36:01 -0800 All reviewed patches have been landed. Closing bug. 181025 2013-01-02 04:44:16 -0800 2013-01-07 09:53:54 -0800 Patch deprecation.diff text/plain 2493 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjkxZmJmLi4wM2Q1MDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDEtMDIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIERpc2FibGUgZGVwcmVjYXRpb24gd2FybmluZ3MgZm9yIEdTdGF0aWNSZWNN dXRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1N0 YXRpY1JlY011dGV4IGlzIGRlcHJlY2F0ZWQgc2luY2UgZ2xpYiAyLjMyLCBidXQgd2UgY2FuJ3Qg cmVtb3ZlCisgICAgICAgIGl0IGJlY2F1c2UgaXQncyBuZWVkZWQgYnkgR1N0cmVhbWVyIDAuMTAu IFRoZSBzb2x1dGlvbiBpcyB0bworICAgICAgICBkaXNhYmxlIHRoZSBkZXByZWNhdGlvbiB3YXJu aW5ncyBmb3IgdGhhdCBjb2RlIGFsb25lLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfYXVkaW9fc3JjX2luaXQpOgorICAgICAgICAod2ViS2l0V2ViQXVkaW9TcmNGaW5hbGl6 ZSk6CisKIDIwMTMtMDEtMDEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTI5NDIyMzk+IFVwZGF0ZSBjb3B5cmlnaHQgc3RyaW5ncwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktp dFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggNzcx ODQxZC4uMzA4MzQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3Ry ZWFtZXIuY3BwCkBAIC0xODUsNyArMTg1LDE1IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfYXVk aW9fc3JjX2luaXQoV2ViS2l0V2ViQXVkaW9TcmMqIHNyYykKICAgICBwcml2LT5wcm92aWRlciA9 IDA7CiAgICAgcHJpdi0+YnVzID0gMDsKIAorLy8gR1N0YXRpY1JlY011dGV4IGlzIGRlcHJlY2F0 ZWQgaW4gR2xpYiwgYnV0IHJlcXVpcmVkIGluIEdTdHJlYW1lciAwLjEwCisjaWYgKENPTVBJTEVS KEdDQykgJiYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNiwgMCkpCisjcHJhZ21hIEdDQyBkaWFn bm9zdGljIHB1c2gKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVdkZXByZWNhdGVk LWRlY2xhcmF0aW9ucyIKKyNlbmRpZgogICAgIGdfc3RhdGljX3JlY19tdXRleF9pbml0KCZwcml2 LT5tdXRleCk7CisjaWYgKENPTVBJTEVSKEdDQykgJiYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwg NiwgMCkpCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcAorI2VuZGlmCiAKICAgICBwcml2LT50 YXNrID0gZ3N0X3Rhc2tfY3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VGFza0Z1bmN0aW9uPih3 ZWJLaXRXZWJBdWRpb1NyY0xvb3ApLCBzcmMpOwogICAgIGdzdF90YXNrX3NldF9sb2NrKHByaXYt PnRhc2suZ2V0KCksICZwcml2LT5tdXRleCk7CkBAIC0yNTAsNyArMjU4LDE1IEBAIHN0YXRpYyB2 b2lkIHdlYktpdFdlYkF1ZGlvU3JjRmluYWxpemUoR09iamVjdCogb2JqZWN0KQogICAgIFdlYktp dFdlYkF1ZGlvU3JjKiBzcmMgPSBXRUJLSVRfV0VCX0FVRElPX1NSQyhvYmplY3QpOwogICAgIFdl YktpdFdlYkF1ZGlvU291cmNlUHJpdmF0ZSogcHJpdiA9IHNyYy0+cHJpdjsKIAorLy8gR1N0YXRp Y1JlY011dGV4IGlzIGRlcHJlY2F0ZWQgaW4gR2xpYiwgYnV0IHJlcXVpcmVkIGluIEdTdHJlYW1l ciAwLjEwCisjaWYgKENPTVBJTEVSKEdDQykgJiYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNiwg MCkpCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMg aWdub3JlZCAiLVdkZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIKKyNlbmRpZgogICAgIGdfc3RhdGlj X3JlY19tdXRleF9mcmVlKCZwcml2LT5tdXRleCk7CisjaWYgKENPTVBJTEVSKEdDQykgJiYgR0ND X1ZFUlNJT05fQVRfTEVBU1QoNCwgNiwgMCkpCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcAor I2VuZGlmCiAKICAgICBnX3NsaXN0X2ZyZWVfZnVsbChwcml2LT5wYWRzLCByZWludGVycHJldF9j YXN0PEdEZXN0cm95Tm90aWZ5Pihnc3Rfb2JqZWN0X3VucmVmKSk7CiAK 181026 2013-01-02 05:52:13 -0800 2013-01-07 09:53:54 -0800 Patch v2 deprecation.diff text/plain 1515 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjkxZmJmLi5hMzRlZjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDEtMDIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIERpc2FibGUgZGVwcmVjYXRpb24gd2FybmluZ3MgZm9yIEdTdGF0aWNSZWNN dXRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1N0 YXRpY1JlY011dGV4IGlzIGRlcHJlY2F0ZWQgc2luY2UgZ2xpYiAyLjMyLCBidXQgd2UgY2FuJ3Qg cmVtb3ZlCisgICAgICAgIGl0IGJlY2F1c2UgaXQncyBuZWVkZWQgYnkgR1N0cmVhbWVyIDAuMTAu IFRoZSBzb2x1dGlvbiBpcyB0bworICAgICAgICBkaXNhYmxlIHRoZSBkZXByZWNhdGlvbiB3YXJu aW5ncyBmb3IgdGhhdCBjb2RlIGFsb25lLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKwogMjAxMy0wMS0wMSAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xMjk0MjIzOT4gVXBkYXRlIGNvcHlyaWdodCBzdHJpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3Ry ZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktp dFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCA3NzE4NDFkLi4yNzBlMzI2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2Vi QXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTMwLDYg KzMwLDExIEBACiAjaW5jbHVkZSA8Z3N0L2F1ZGlvL211bHRpY2hhbm5lbC5oPgogI2luY2x1ZGUg PGdzdC9wYnV0aWxzL3BidXRpbHMuaD4KIAorLy8gR1N0YXRpY1JlY011dGV4IGlzIGRlcHJlY2F0 ZWQgaW4gR2xpYiwgYnV0IHJlcXVpcmVkIGluIEdTdHJlYW1lciAwLjEwCisjaWYgKENPTVBJTEVS KEdDQykgJiYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNiwgMCkpCisjcHJhZ21hIEdDQyBkaWFn bm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCisjZW5kaWYKKwogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIHR5cGVkZWYgc3RydWN0IF9XZWJLaXRXZWJBdWRpb1Ny Y0NsYXNzICAgV2ViS2l0V2ViQXVkaW9TcmNDbGFzczsK 181516 2013-01-07 09:53:54 -0800 2013-01-07 10:35:57 -0800 Patch v3 deprecated.diff text/plain 1553 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxODM1MDgwLi42MzkxODkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDEtMDcgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIERpc2FibGUgZGVwcmVjYXRpb24gd2FybmluZ3MgZm9yIEdTdGF0aWNSZWNN dXRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1N0 YXRpY1JlY011dGV4IGlzIGRlcHJlY2F0ZWQgc2luY2UgZ2xpYiAyLjMyLCBidXQgd2UgY2FuJ3Qg cmVtb3ZlCisgICAgICAgIGl0IGJlY2F1c2UgaXQncyBuZWVkZWQgYnkgR1N0cmVhbWVyIDAuMTAu IFRoZSBzb2x1dGlvbiBpcyB0bworICAgICAgICBkaXNhYmxlIHRoZSBkZXByZWNhdGlvbiB3YXJu aW5ncyBmb3IgdGhhdCBjb2RlIGFsb25lLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKwogMjAxMy0wMS0wNyAg R2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CiAKICAgICAgICAgT3B0aW1pemlu ZyBSR0JBMTYsIFJHQjE2LCBBUkdCMTYsIEJHUkExNiB1bnBhY2tpbmcgZnVuY3Rpb25zIHdpdGgg TkVPTiBpbnRyaW5zaWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVh bWVyLmNwcAppbmRleCA5MDQ5MjU1Li43MTk4NTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRX ZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTM0LDYgKzM0LDExIEBACiAjZW5kaWYKICNp bmNsdWRlIDxnc3QvcGJ1dGlscy9wYnV0aWxzLmg+CiAKKy8vIEdTdGF0aWNSZWNNdXRleCBpcyBk ZXByZWNhdGVkIGluIEdsaWIsIGJ1dCByZXF1aXJlZCBpbiBHU3RyZWFtZXIgMC4xMAorI2lmIChD T01QSUxFUihHQ0MpICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDYsIDApICYmICFkZWZpbmVk KEdTVF9BUElfVkVSU0lPTl8xKSkKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVdk ZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIKKyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKIAogdHlwZWRlZiBzdHJ1Y3QgX1dlYktpdFdlYkF1ZGlvU3JjQ2xhc3MgICBXZWJLaXRXZWJB dWRpb1NyY0NsYXNzOwo=