105915 2013-01-02 03:51:24 -0800 [GTK] Add WebP image support 2015-03-20 17:08:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.html5rocks.com/en/tutorials/filters/understanding-css/ Gtk, Soup P2 Normal --- 47512 1 svillar svillar changseok gustavo mathias mrobinson philn plaes s.choi svillar waldyrious webkit.review.bot xan.lopez zan oldest_to_newest 798609 0 svillar 2013-01-02 03:51:24 -0800 I didn't have time to take a look at it, but at first sight looks like the network connections are retrieving the resources properly (just checked the inspector). 798681 1 svillar 2013-01-02 08:36:48 -0800 OK, so all of them are webp images, maybe it's just some issue with my setup... 798683 2 mrobinson 2013-01-02 08:38:11 -0800 We don't have support for WebP yet. Perhaps the site is sending them because of our Chromium-esque user agent. 798688 3 svillar 2013-01-02 08:58:30 -0800 (In reply to comment #2) > We don't have support for WebP yet. Perhaps the site is sending them because of our Chromium-esque user agent. Isn't there a generic WebP decoder in platform/image-decoders? What else do we need? 798692 4 mrobinson 2013-01-02 09:05:48 -0800 There's a platform-independent decoder, but it has a dependency on some external library. Take a look in Source/WebCore/platform/image-decoders/webp for more details. It'd be great to add WebP support. It might be as simple as compiling this library into ours. 798697 5 svillar 2013-01-02 09:25:40 -0800 It should be a matter of correctly detecting and linking against the libwebp library 798761 6 181040 svillar 2013-01-02 11:38:00 -0800 Created attachment 181040 Patch 798801 7 181040 mrobinson 2013-01-02 12:28:45 -0800 Comment on attachment 181040 Patch Instead of a configuration option, we should always turn this on. I don't think it should be configurable. 799318 8 181160 svillar 2013-01-03 02:12:58 -0800 Created attachment 181160 Patch 799353 9 zan 2013-01-03 06:22:50 -0800 The bots require libwebp. Should it be included in the Jhbuild moduleset? 799368 10 svillar 2013-01-03 07:13:48 -0800 (In reply to comment #9) > The bots require libwebp. Should it be included in the Jhbuild moduleset? As we don't need any special version, I'd say that we could simply install the distro version in the bots... 799401 11 mrobinson 2013-01-03 09:15:14 -0800 (In reply to comment #9) > The bots require libwebp. Should it be included in the Jhbuild moduleset? Right now we only use the JHBuild for dependencies where you need the correct version to have correct test results. I think it would be nice to have an alternate JHBuild moduleset with many hard-to-get dependencies, but probably not in this patch. 799403 12 181160 mrobinson 2013-01-03 09:19:39 -0800 Comment on attachment 181160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181160&action=review Thanks! Perhaps you could investigate a small change before landing: > configure.ac:278 > +# Check for WEBP Image support > +have_webp=no > +AC_CHECK_HEADERS([webp/decode.h], [have_webp="yes"], [have_webp="no"]) > +if test "$have_webp" = "yes"; then > + WEBP_LIBS='-lwebp' > +else > + AC_MSG_ERROR([WebP library (libwebp) not found]) > +fi > +AC_SUBST([WEBP_LIBS]) I don't mean to be nitpicky, but I think you can probably simplify this a bit by getting rid of the have_webp variable. That would be more useful if you were actually using it later. Instead I think you could just keep what you need here inline in the macro. For instance, something like this should work: AC_CHECK_HEADERS([webp/decode.h], [WEBP_LIBS="-lwebp'], AC_MSG_ERROR([WebP library (libwebp) not found]) AC_SUBST([WEBP_LIBS]) 799404 13 svillar 2013-01-03 09:26:27 -0800 (In reply to comment #12) > (From update of attachment 181160 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181160&action=review > > Thanks! Perhaps you could investigate a small change before landing: > > > configure.ac:278 > > +# Check for WEBP Image support > > +have_webp=no > > +AC_CHECK_HEADERS([webp/decode.h], [have_webp="yes"], [have_webp="no"]) > > +if test "$have_webp" = "yes"; then > > + WEBP_LIBS='-lwebp' > > +else > > + AC_MSG_ERROR([WebP library (libwebp) not found]) > > +fi > > +AC_SUBST([WEBP_LIBS]) > > I don't mean to be nitpicky, but I think you can probably simplify this a bit by getting rid of the have_webp variable. That would be more useful if you were actually using it later. > > Instead I think you could just keep what you need here inline in the macro. For instance, something like this should work: > > AC_CHECK_HEADERS([webp/decode.h], [WEBP_LIBS="-lwebp'], AC_MSG_ERROR([WebP library (libwebp) not found]) > AC_SUBST([WEBP_LIBS]) Absolutely true, I should have removed it because I only defined it for using it later in the AM_CONDITIONAL. 799474 14 svillar 2013-01-03 10:41:58 -0800 I had updated Igalia bots, kov, philn, could you please install libwebp-dev in your machines? 800132 15 svillar 2013-01-04 03:59:25 -0800 The patch to land will unskip also these two tests: http/tests/images/webp-partial-load.html http/tests/images/webp-progressive-load.html We cannot unskip the WebP decoding test (fast/images/webp-image-decoding.html) just because it requires version 0.2 of the library which is still not available for bots distros. 802134 16 svillar 2013-01-08 01:33:30 -0800 Committed r139046: <http://trac.webkit.org/changeset/139046> 803188 17 plaes 2013-01-09 03:11:39 -0800 Is there a reason of not using pkg-config for lookup? 803215 18 svillar 2013-01-09 04:05:59 -0800 (In reply to comment #17) > Is there a reason of not using pkg-config for lookup? Yes, the library does not provide a .pc 803221 19 plaes 2013-01-09 04:22:33 -0800 (In reply to comment #18) > (In reply to comment #17) > > Is there a reason of not using pkg-config for lookup? > > Yes, the library does not provide a .pc Seems to be 0.2.x+ feature :( 803230 20 svillar 2013-01-09 04:43:38 -0800 (In reply to comment #19) > (In reply to comment #18) > > (In reply to comment #17) > > > Is there a reason of not using pkg-config for lookup? > > > > Yes, the library does not provide a .pc > > Seems to be 0.2.x+ feature :( Yeah, apart from that, 0.2 will allow us to unskip the webp-decode test which requires some features not present in 0.1.x 808369 21 svillar 2013-01-16 07:38:48 -0800 *** Bug 98939 has been marked as a duplicate of this bug. *** 181040 2013-01-02 11:38:00 -0800 2013-01-03 02:12:54 -0800 Patch bug-105915-20130102203507.patch text/plain 6815 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI3MjZkYTRjODMxODk5 NWZlZDJiOTk4YWFkOWUyZTExMzNkMWYzOS4uNmQ3ODE3NGY5MTEwM2JmMDdjMTNiYTYxNTA2NDQx MWRlMWUwM2IyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTAyICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFk ZCBXZWJQIGltYWdlIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTkxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogR05VbWFrZWZpbGUubGlz dC5hbTogYnVpbGQgdGhlIFdlYlAgZGVjb2RlciBvbmx5IHdoZW4gZW5hYmxlZAorCiAyMDEzLTAx LTAyICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29tPgog CiAgICAgICAgIFtBQ10gTWVtb3J5IGxlYWsgaW4gR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZTo6Zmlu ZEZCQ29uZmlnV2l0aEFscGhhKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBiN2E3ZWNkZTA2OGEwZjE3 ZjQ1ZGM4M2Q1NmU4YmY5M2JmZWRmN2E5Li42OGJhMjExOTQ3MzFhMGRkNzJmNDkyNGI1ODM0NDE4 OTVmMDg5YTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDEtMDIg IFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gQWRkIFdlYlAgaW1hZ2Ugc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1OTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogbGluayBhZ2FpbnN0IFdlYlAgbGli cmFyaWVzIGlmIHVzZWQKKwogMjAxMi0xMi0yOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV0syXSBBZGQgc3VwcG9ydCBmb3IgSU1FIENv bXBvc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWQxOTgxYmM2ZDViOGRhMzIxMmMyM2M5MGIzY2VmN2Zh ODhlNjJlYy4uZTQyMDNjMTk1NjY5ZjA5NTM3ZGRiMDAxMTA2NDc1MDUzMTFhZThlYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTAyICBTZXJnaW8gVmlsbGFyIFNlbmluICA8 c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBXZWJQIGltYWdlIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTkx NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05V bWFrZWZpbGUuYW06IGxpbmsgYWdhaW5zdCBXZWJQIGxpYnJhcmllcyBpZiB1c2VkCisKIDIwMTMt MDEtMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAog ICAgICAgICBSZWdyZXNzaW9uKHIxMzg2MDcpOiBDYXVzZXMgY3Jhc2hlcyByZWxhdGVkIHRvIFdl Ykljb25EYXRhYmFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0g Yi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCA2ODk4ODZjZTI5Mzg3ZDQyNWEw OGE2NzlmMjZjNjVmYTI0ZTU5Yjc0Li42YmY0Yjg0ZmNmMTEwNDQxY2VkYWYwNDI2YWMzNTQyYWEx YmI2NTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQorKysgYi9T b3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtNzIsNyArNzIsNiBAQCB3ZWJjb3JlX2Nw cGZsYWdzICs9IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9naWYgXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL2ljbyBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvanBlZyBcCi0JLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvd2VicCBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW1hZ2UtZGVjb2RlcnMvcG5nIFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9sZXZlbGRiIFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9saW51 eCBcCkBAIC0zNDIsNiArMzQxLDExIEBAIGVsc2UKIGZlYXR1cmVfZGVmaW5lc19vdmVycmlkZXMg Kz0gRU5BQkxFX1NQRUxMQ0hFQ0s9MAogZW5kaWYgICMgRU5EIEVOQUJMRV9TUEVMTENIRUNLCiAK K2lmIFVTRV9XRUJQCit3ZWJjb3JlX2NwcGZsYWdzICs9IFwKKwktRFdURl9VU0VfV0VCUD0xIFwK KwktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJw CitlbmRpZgogCiAjIEZpbGwgdGhlIGZlYXR1cmVfZGVmaW5lcyB2YXJpYWJsZSB3aXRoIGFsbCB0 aGUgZGVmaW5lcywgbWFraW5nIGl0IHBvc3NpYmxlCiAjIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0 IGRlZmluZSB2YWx1ZSAoYXMgc2V0IGluIGZlYXR1cmVfZGVmaW5lc19kZWZhdWx0cykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9Tb3VyY2UvV2ViQ29y ZS9HTlVtYWtlZmlsZS5saXN0LmFtCmluZGV4IGUwYzkwMzVhMmNjNjFmZjk0MDUyNDkwZWZjYjU4 ZTFhMzA4MDY5M2YuLjM2YjlkM2FhMjMxMGMyMTY5YzE4NGViYWY3NTBjNTBkNGM4NjZkOGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KKysrIGIvU291cmNl L1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQpAQCAtNTY5NSw4ICs1Njk1LDYgQEAgd2ViY29y ZV9wbGF0Zm9ybV9zb3VyY2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9JbWFnZURlY29kZXIuaCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmggXAotCVNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5jcHAg XAotCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdl RGVjb2Rlci5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcv UE5HSW1hZ2VEZWNvZGVyLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVj b2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9M YXlvdXRUZXN0U3VwcG9ydC5jcHAgXApAQCAtNjIxMyw2ICs2MjExLDEzIEBAIHdlYmNvcmVndGtf c291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lclZlcnNpb25pbmcuaAogZW5kaWYKIAorCitpZiBVU0VfV0VCUAord2ViY29yZWd0 a19zb3VyY2VzICs9IFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93 ZWJwL1dFQlBJbWFnZURlY29kZXIuY3BwIFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuaAorZW5kaWYKKwogIyAtLS0KICMgM0Qg Y2FudmFzIChXZWJHTCkgc3VwcG9ydAogIyAtLS0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Z3RrL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0KaW5k ZXggZTBkOGNlYTg5N2RlZDk3NjUxYWY4NDU0YzhlNWYyYjVlYjNkNjMxMi4uYWIwNmQ1Y2JkN2Q4 YWU5ZDM4ZmEzYmQxOTBmNjNkZDI3NDkxNGVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9n dGsvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0K QEAgLTExNSw2ICsxMTUsNyBAQCBsaWJ3ZWJraXRndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVS U0lPTkBfQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkBfbGFfTElCQQogCSQoUE5HX0xJQlMp IFwKIAkkKFNRTElURTNfTElCUykgXAogCSQoVU5JQ09ERV9MSUJTKSBcCisJJChXRUJQX0xJQlMp IFwKIAkkKFhDT01QT1NJVEVfTElCUykgXAogCSQoWERBTUFHRV9MSUJTKSBcCiAJJChYUkVOREVS X0xJQlMpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtIGIvU291 cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KaW5kZXggM2E1ZjdiOTQ3MGZjNjY1ODA2MGJkN2Jl ZDZlMGY4OWU0MDVjNzhlNS4uM2JlN2JlMjYzYWMzNzY4OTg1MmY4MTEyNDY4YzJhZGZkZDcyY2I2 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNl L1dlYktpdDIvR05VbWFrZWZpbGUuYW0KQEAgLTIwMCw2ICsyMDAsNyBAQCBsaWJ3ZWJraXQyZ3Rr X0BXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05AX0BXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJ T05AX2xhX0xJQgogCSQoUE5HX0xJQlMpIFwKIAkkKFNRTElURTNfTElCUykgXAogCSQoVU5JQ09E RV9MSUJTKSBcCisJJChXRUJQX0xJQlMpIFwKIAkkKFhSRU5ERVJfTElCUykgXAogCSQoWENPTVBP U0lURV9MSUJTKSBcCiAJJChYREFNQUdFX0xJQlMpIFwKQEAgLTU2Niw2ICs1NjcsNyBAQCBQcm9n cmFtc19XZWJLaXRQbHVnaW5Qcm9jZXNzX0xEQUREICs9IFwKIAkkKFNITV9MSUJTKSBcCiAJJChT UUxJVEUzX0xJQlMpIFwKIAkkKFVOSUNPREVfTElCUykgXAorCSQoV0VCUF9MSUJTKSBcCiAJJChY UkVOREVSX0xJQlMpIFwKIAkkKFhUX0xJQlMpIFwKIAkkKFdJTk1NX0xJQlMpIFwKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4ZWU4ZTBlMTNkZDg0ZjFiZDk5ODY4OTMx MDE1ZGUxNDcwY2QyZTg4Li44MGZkZTU0NzYxODJlNjUyNmIyNWU5NGQxZDI4M2RmZTc2ZDdhNjQw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTMtMDEtMDIgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gQWRkIFdlYlAgaW1hZ2Ugc3VwcG9ydAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1OTE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6IGFkZGVkIFdlYlAg ZGV0ZWN0aW9uIGNvZGUKKwogMjAxMy0wMS0wMSAgS3dhbmdZb25nIENob2kgIDxreTAuY2hvaUBz YW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBFbmFibGUgTUhUTUwgZmVhdHVyZQpkaWZmIC0t Z2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDQyMzMzZTFiYzQxMGFjYzE0 YjNlZDc2MmJkYjIwNjRiMTM1MjJlMGUuLmE4MTVmNTAwYmZlNDA0OGFjOTg5MWMzZmRkM2NmY2Yz OWQ5NGE2NDQgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAg LTI2Nyw2ICsyNjcsMTMgQEAgaWYgdGVzdCAiJHBuZ19vayIgIT0geWVzOyB0aGVuCiBmaQogQUNf U1VCU1QoW1BOR19MSUJTXSkKIAorIyBDaGVjayBmb3IgV0VCUCBJbWFnZSBzdXBwb3J0CitoYXZl X3dlYnA9bm8KK0FDX0NIRUNLX0hFQURFUlMoW3dlYnAvZGVjb2RlLmhdLCBbaGF2ZV93ZWJwPSJ5 ZXMiXSwgW2hhdmVfd2VicD0ibm8iXSkKK2lmIHRlc3QgIiRoYXZlX3dlYnAiID0gInllcyI7IHRo ZW4KKyAgIFdFQlBfTElCUz0nLWx3ZWJwJworZmkKK0FDX1NVQlNUKFtXRUJQX0xJQlNdKQogCiBp ZiB0ZXN0ICIkb3Nfd2luMzIiID0gInllcyI7IHRoZW4KICAgV0lOTU1fTElCUz0tbHdpbm1tCkBA IC0xMTQwLDYgKzExNDcsOSBAQCBBTV9DT05ESVRJT05BTChbVVNFX0dMWF0sIFt0ZXN0ICIkZW5h YmxlX2dseCIgPSAieWVzIl0pCiAjIEZhcnN0cmVhbSBmZWF0dXJlIGNvbmRpdGlvbmFsCiBBTV9D T05ESVRJT05BTChbVVNFX0ZBUlNUUkVBTV0sIFt0ZXN0ICIkaGF2ZV9mYXJzdHJlYW0iID0gInll cyJdKQogCisjIFdlYlAgZmVhdHVyZSBjb25kaXRpb25hbAorQU1fQ09ORElUSU9OQUwoW1VTRV9X RUJQXSwgW3Rlc3QgIiRoYXZlX3dlYnAiID0gInllcyJdKQorCiAjIFdlYktpdCBmZWF0dXJlIGNv bmRpdGlvbmFscwogQU1fQ09ORElUSU9OQUwoW0VOQUJMRV9ERUJVR10sW3Rlc3QgIiRlbmFibGVf ZGVidWdfZmVhdHVyZXMiID0gInllcyJdKQogQU1fQ09ORElUSU9OQUwoW0VOQUJMRV9XRUJHTF0s W3Rlc3QgIiRlbmFibGVfd2ViZ2wiID0gInllcyJdKQo= 181160 2013-01-03 02:12:58 -0800 2013-01-03 09:19:39 -0800 Patch bug-105915-20130103111005.patch text/plain 6466 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI3MjZkYTRjODMxODk5 NWZlZDJiOTk4YWFkOWUyZTExMzNkMWYzOS4uODg5MmQ2YjE3YWM4NmI5ZDkwZDlmZTkxOTNhZDUx ZWY4ZjA5NWQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTAzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFk ZCBXZWJQIGltYWdlIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTkxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06IGFkZCBXVEZfVVNFX1dFQlAgZGVmaW5pdGlv bi4KKyAgICAgICAgKiBHTlVtYWtlZmlsZS5saXN0LmFtOiBwcm9wZXJseSBzb3J0IGltYWdlIGRl Y29kZXJzIGluIHRoZSBzb3VyY2VzIGxpc3QuCisKIDIwMTMtMDEtMDIgIFN1ZGFyc2FuYSBOYWdp bmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CiAKICAgICAgICAgW0FDXSBNZW1v cnkgbGVhayBpbiBHcmFwaGljc1N1cmZhY2VQcml2YXRlOjpmaW5kRkJDb25maWdXaXRoQWxwaGEo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9ndGsvQ2hhbmdlTG9nCmluZGV4IGI3YTdlY2RlMDY4YTBmMTdmNDVkYzgzZDU2ZThiZjkzYmZl ZGY3YTkuLmM0MWY5ZmU2ZmJkYWE0YzM4OWVmZjUzYTMzYWRmMmI4N2RhOWQ0NDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMS0wMyAgU2VyZ2lvIFZpbGxhciBTZW5p biAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgV2ViUCBpbWFnZSBz dXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDU5MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEdOVW1ha2VmaWxlLmFtOiBsaW5rIGFnYWluc3QgV2ViUCBsaWJyYXJ5LgorCiAyMDEyLTEyLTI4 ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XVtXSzJdIEFkZCBzdXBwb3J0IGZvciBJTUUgQ29tcG9zaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxZDE5 ODFiYzZkNWI4ZGEzMjEyYzIzYzkwYjNjZWY3ZmE4OGU2MmVjLi5iMjU2NGJhODhhMDZiZTEyYzQ2 ZjNlOTA3ZDAyMjlkYWUxYzI2YWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMt MDEtMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dUS10gQWRkIFdlYlAgaW1hZ2Ugc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1OTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogbGluayBhZ2FpbnN0IFdl YlAgbGlicmFyeS4KKwogMjAxMy0wMS0wMiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUu ZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjEzODYwNyk6IENhdXNlcyBj cmFzaGVzIHJlbGF0ZWQgdG8gV2ViSWNvbkRhdGFiYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCmluZGV4 IDY4OTg4NmNlMjkzODdkNDI1YTA4YTY3OWYyNmM2NWZhMjRlNTliNzQuLjcyYmEzYzNhMTlhMzQ2 NjQyMWIxZTdiOWUxMzZiZTZmODIxYjhlZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dO VW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCkBAIC03LDYg KzcsNyBAQCBXRUJDT1JFX0NTU19WQUxVRV9LRVlXT1JEUyA6PSAkKFdlYkNvcmUpL2Nzcy9DU1NW YWx1ZUtleXdvcmRzLmluCiB3ZWJjb3JlX2NwcGZsYWdzICs9IFwKIAktRFdURl9VU0VfRlJFRVRZ UEU9MSBcCiAJLURXVEZfVVNFX0hBUkZCVVpaX05HPTEgXAorCS1EV1RGX1VTRV9XRUJQPTEgXAog CS1JJChzcmNkaXIpL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYyBcCiAJLUkkKHNyY2Rpcikv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZSBcCiAJLUkkKHNyY2RpcikvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvaW5jbHVkZS9HTFNMQU5HIFwKQEAgLTcyLDggKzczLDggQEAgd2ViY29y ZV9jcHBmbGFncyArPSBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvZ2lmIFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9pY28gXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2ltYWdlLWRlY29kZXJzL2pwZWcgXAotCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWRlY29kZXJzL3dlYnAgXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL3BuZyBcCisJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicCBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbGV2ZWxkYiBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbGludXggXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9T b3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCmluZGV4IGUwYzkwMzVhMmNjNjFmZjk0 MDUyNDkwZWZjYjU4ZTFhMzA4MDY5M2YuLmU1YThmMjhlYWZlODk1ZGVkMDE4MzUxNDJiMmQyYzFi YmMwZTdkNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0K KysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQpAQCAtNTY5NSwxMCArNTY5 NSwxMCBAQCB3ZWJjb3JlX3BsYXRmb3JtX3NvdXJjZXMgKz0gXAogCVNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oIFwKIAlTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIFwKIAlTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIu aCBcCi0JU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1h Z2VEZWNvZGVyLmNwcCBcCi0JU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv d2VicC9XRUJQSW1hZ2VEZWNvZGVyLmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmggXAorCVNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5jcHAgXAor CVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVj b2Rlci5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MYXlvdXRUZXN0U3VwcG9ydC5jcHAg XAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFRlc3RTdXBwb3J0LmggXAogCVNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L0dhbWVwYWREZXZpY2VMaW51eC5jcHAgXApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0L2d0 ay9HTlVtYWtlZmlsZS5hbQppbmRleCBlMGQ4Y2VhODk3ZGVkOTc2NTFhZjg0NTRjOGU1ZjJiNWVi M2Q2MzEyLi5hYjA2ZDVjYmQ3ZDhhZTlkMzhmYTNiZDE5MGY2M2RkMjc0OTE0ZWRlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0 L2d0ay9HTlVtYWtlZmlsZS5hbQpAQCAtMTE1LDYgKzExNSw3IEBAIGxpYndlYmtpdGd0a19AV0VC S0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQF9AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9OQF9s YV9MSUJBCiAJJChQTkdfTElCUykgXAogCSQoU1FMSVRFM19MSUJTKSBcCiAJJChVTklDT0RFX0xJ QlMpIFwKKwkkKFdFQlBfTElCUykgXAogCSQoWENPTVBPU0lURV9MSUJTKSBcCiAJJChYREFNQUdF X0xJQlMpIFwKIAkkKFhSRU5ERVJfTElCUykgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv R05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQppbmRleCAzYTVm N2I5NDcwZmM2NjU4MDYwYmQ3YmVkNmUwZjg5ZTQwNWM3OGU1Li4zYmU3YmUyNjNhYzM3Njg5ODUy ZjgxMTI0NjhjMmFkZmRkNzJjYjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtl ZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQpAQCAtMjAwLDYgKzIw MCw3IEBAIGxpYndlYmtpdDJndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkBfQFdFQktJ VEdUS19BUElfTUlOT1JfVkVSU0lPTkBfbGFfTElCCiAJJChQTkdfTElCUykgXAogCSQoU1FMSVRF M19MSUJTKSBcCiAJJChVTklDT0RFX0xJQlMpIFwKKwkkKFdFQlBfTElCUykgXAogCSQoWFJFTkRF Ul9MSUJTKSBcCiAJJChYQ09NUE9TSVRFX0xJQlMpIFwKIAkkKFhEQU1BR0VfTElCUykgXApAQCAt NTY2LDYgKzU2Nyw3IEBAIFByb2dyYW1zX1dlYktpdFBsdWdpblByb2Nlc3NfTERBREQgKz0gXAog CSQoU0hNX0xJQlMpIFwKIAkkKFNRTElURTNfTElCUykgXAogCSQoVU5JQ09ERV9MSUJTKSBcCisJ JChXRUJQX0xJQlMpIFwKIAkkKFhSRU5ERVJfTElCUykgXAogCSQoWFRfTElCUykgXAogCSQoV0lO TU1fTElCUykgXApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDhlZThl MGUxM2RkODRmMWJkOTk4Njg5MzEwMTVkZTE0NzBjZDJlODguLjFiNGJjZTk1NGMxZjAxM2M0NWUz OGU2NTE4NjkzYTc1ZDZhY2U5YTEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wMS0wMyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgV2ViUCBpbWFnZSBzdXBwb3J0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU5MTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJQIGlz IGZyb20gbm93IG9uIGEgZGVwZW5kZW5jeSBmb3IgV2ViS2l0R3RrKy4KKworICAgICAgICAqIGNv bmZpZ3VyZS5hYzogYWRkZWQgV2ViUCBsaWJyYXJ5IGRldGVjdGlvbi4KKwogMjAxMy0wMS0wMSAg S3dhbmdZb25nIENob2kgIDxreTAuY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBF bmFibGUgTUhUTUwgZmVhdHVyZQpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJl LmFjCmluZGV4IDQyMzMzZTFiYzQxMGFjYzE0YjNlZDc2MmJkYjIwNjRiMTM1MjJlMGUuLmI2NWJk MzY3MDg2MDcwOTAzZGRlZjM5MjkyMzBkOTk0Y2MzMWQ5OTIgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3Vy ZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTI2Nyw2ICsyNjcsMTUgQEAgaWYgdGVzdCAiJHBu Z19vayIgIT0geWVzOyB0aGVuCiBmaQogQUNfU1VCU1QoW1BOR19MSUJTXSkKIAorIyBDaGVjayBm b3IgV0VCUCBJbWFnZSBzdXBwb3J0CitoYXZlX3dlYnA9bm8KK0FDX0NIRUNLX0hFQURFUlMoW3dl YnAvZGVjb2RlLmhdLCBbaGF2ZV93ZWJwPSJ5ZXMiXSwgW2hhdmVfd2VicD0ibm8iXSkKK2lmIHRl c3QgIiRoYXZlX3dlYnAiID0gInllcyI7IHRoZW4KKyAgV0VCUF9MSUJTPSctbHdlYnAnCitlbHNl CisgIEFDX01TR19FUlJPUihbV2ViUCBsaWJyYXJ5IChsaWJ3ZWJwKSBub3QgZm91bmRdKQorZmkK K0FDX1NVQlNUKFtXRUJQX0xJQlNdKQogCiBpZiB0ZXN0ICIkb3Nfd2luMzIiID0gInllcyI7IHRo ZW4KICAgV0lOTU1fTElCUz0tbHdpbm1tCg==