105909 2013-01-02 01:04:18 -0800 Regression(r138607): Causes crashes related to WebIconDatabase 2013-01-02 08:32:09 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 105890 1 cdumez cdumez andersca ap kenneth mitz ossy ostap73 sam zan oldest_to_newest 798555 0 cdumez 2013-01-02 01:04:18 -0800 After <http://trac.webkit.org/changeset/138607>, we started to experience a lot of crashes such as: 20:33:03.001 19851 worker/1 http/tests/css/border-image-loading.html crashed, (stderr lines): 20:33:03.002 19851 1 0x7f88965a05e8 20:33:03.002 19851 2 0x7f8893ccb4a0 20:33:03.002 19851 3 0x7f8895d7d690 WebKit::WebIconDatabase::isOpen() 20:33:03.002 19851 4 0x7f8895d7d6d3 WebKit::WebIconDatabase::setDatabasePath(WTF::String const&) 20:33:03.002 19851 5 0x410c0e WTR::TestController::initialize(int, char const**) 20:33:03.002 19851 6 0x411a86 WTR::TestController::TestController(int, char const**) 20:33:03.002 19851 7 0x40bf44 main 20:33:03.002 19851 8 0x7f8893cb676d __libc_start_main 20:33:03.002 19851 9 0x40bf91 798572 1 181013 cdumez 2013-01-02 01:40:30 -0800 Created attachment 181013 Patch Uploading a patch in case someone is able to test it before I can. Sadly, I did not have a fresh build and it is taking a while here.. 798574 2 181014 cdumez 2013-01-02 01:44:49 -0800 Created attachment 181014 Patch 798576 3 181015 cdumez 2013-01-02 01:48:36 -0800 Created attachment 181015 Patch 798577 4 181015 cdumez 2013-01-02 01:51:52 -0800 Comment on attachment 181015 Patch Ok, this patch seems to resolve the issue for me. 798579 5 181017 cdumez 2013-01-02 01:56:51 -0800 Created attachment 181017 Patch Fix typo in Changelog. 798583 6 181017 gyuyoung.kim 2013-01-02 02:05:47 -0800 Comment on attachment 181017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181017&action=review rs=me > Source/WebKit2/ChangeLog:3 > + Regression(r138607) Causes crashes related to WebIconDatabase Missing ":" in Regression(r138607) ? 798586 7 cdumez 2013-01-02 02:10:34 -0800 Committed r138613: <http://trac.webkit.org/changeset/138613> 798655 8 laszlo.gombos 2013-01-02 07:10:10 -0800 *** Bug 105911 has been marked as a duplicate of this bug. *** 798680 9 ap 2013-01-02 08:32:09 -0800 <rdar://problem/12942594> 181013 2013-01-02 01:40:30 -0800 2013-01-02 01:44:49 -0800 Patch 105909_WebIconDatabase_fix.patch text/plain 1435 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZjA0NjAxLi4xNzhkOGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg2MDcpIENhdXNlcyBjcmFzaGVzIHJlbGF0 ZWQgdG8gV2ViSWNvbkRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDU5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbWlzc2luZyBhZGRTdXBwbGVtZW50PFdlYkljb25EYXRhYmFzZT4o KSBzdGF0ZW1lbnQKKyAgICAgICAgaW4gV2ViQ29udGV4dCBjb25zdHJ1Y3Rvci4gSXQgd2FzIGNh dXNpbmcgbWlzc2luZyBpbgorICAgICAgICByMTM4NjA3IGFuZCBjYXVzaW5nIGEgbG90IG9mIGNy YXNoZXMgb24gV2ViS2l0Mi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6V2ViQ29udGV4dCk6CisKIDIwMTItMTItMzEg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBDb252ZXJ0IG1vcmUgY2xh c3NlcyB0byBiZSBXZWJDb250ZXh0U3VwcGxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJDb250ZXh0LmNwcAppbmRleCA0YmI3ZDlkLi4zMGJmYmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYkNvbnRleHQuY3BwCkBAIC0xNzMsNiArMTczLDcgQEAgV2ViQ29udGV4dDo6V2Vi Q29udGV4dChQcm9jZXNzTW9kZWwgcHJvY2Vzc01vZGVsLCBjb25zdCBTdHJpbmcmIGluamVjdGVk QnVuZGxlUGEKICAgICBhZGRTdXBwbGVtZW50PFdlYkFwcGxpY2F0aW9uQ2FjaGVNYW5hZ2VyUHJv eHk+KCk7CiAgICAgYWRkU3VwcGxlbWVudDxXZWJDb29raWVNYW5hZ2VyUHJveHk+KCk7CiAgICAg YWRkU3VwcGxlbWVudDxXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eT4oKTsKKyAgICBhZGRTdXBw bGVtZW50PFdlYkljb25EYXRhYmFzZT4oKTsKICAgICBhZGRTdXBwbGVtZW50PFdlYktleVZhbHVl U3RvcmFnZU1hbmFnZXJQcm94eT4oKTsKICAgICBhZGRTdXBwbGVtZW50PFdlYk1lZGlhQ2FjaGVN YW5hZ2VyUHJveHk+KCk7CiAgICAgYWRkU3VwcGxlbWVudDxXZWJOb3RpZmljYXRpb25NYW5hZ2Vy UHJveHk+KCk7Cg== 181014 2013-01-02 01:44:49 -0800 2013-01-02 01:48:36 -0800 Patch 105909_WebIconDatabase_fix.patch text/plain 1440 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZjA0NjAxLi4xNzhkOGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg2MDcpIENhdXNlcyBjcmFzaGVzIHJlbGF0 ZWQgdG8gV2ViSWNvbkRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDU5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbWlzc2luZyBhZGRTdXBwbGVtZW50PFdlYkljb25EYXRhYmFzZT4o KSBzdGF0ZW1lbnQKKyAgICAgICAgaW4gV2ViQ29udGV4dCBjb25zdHJ1Y3Rvci4gSXQgd2FzIGNh dXNpbmcgbWlzc2luZyBpbgorICAgICAgICByMTM4NjA3IGFuZCBjYXVzaW5nIGEgbG90IG9mIGNy YXNoZXMgb24gV2ViS2l0Mi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6V2ViQ29udGV4dCk6CisKIDIwMTItMTItMzEg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBDb252ZXJ0IG1vcmUgY2xh c3NlcyB0byBiZSBXZWJDb250ZXh0U3VwcGxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJDb250ZXh0LmNwcAppbmRleCA0YmI3ZDlkLi5lYThkYjIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYkNvbnRleHQuY3BwCkBAIC0xNzMsNiArMTczLDcgQEAgV2ViQ29udGV4dDo6V2Vi Q29udGV4dChQcm9jZXNzTW9kZWwgcHJvY2Vzc01vZGVsLCBjb25zdCBTdHJpbmcmIGluamVjdGVk QnVuZGxlUGEKICAgICBhZGRTdXBwbGVtZW50PFdlYkFwcGxpY2F0aW9uQ2FjaGVNYW5hZ2VyUHJv eHk+KCk7CiAgICAgYWRkU3VwcGxlbWVudDxXZWJDb29raWVNYW5hZ2VyUHJveHk+KCk7CiAgICAg YWRkU3VwcGxlbWVudDxXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eT4oKTsKKyAgICBhZGRTdXBw bGVtZW50PFdlYkljb25EYXRhYmFzZVByb3h5PigpOwogICAgIGFkZFN1cHBsZW1lbnQ8V2ViS2V5 VmFsdWVTdG9yYWdlTWFuYWdlclByb3h5PigpOwogICAgIGFkZFN1cHBsZW1lbnQ8V2ViTWVkaWFD YWNoZU1hbmFnZXJQcm94eT4oKTsKICAgICBhZGRTdXBwbGVtZW50PFdlYk5vdGlmaWNhdGlvbk1h bmFnZXJQcm94eT4oKTsK 181015 2013-01-02 01:48:36 -0800 2013-01-02 01:56:51 -0800 Patch 105909_WebIconDatabase_fix.patch text/plain 1352 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZjA0NjAxLi4wNzlhMDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg2MDcpIENhdXNlcyBjcmFzaGVzIHJlbGF0 ZWQgdG8gV2ViSWNvbkRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDU5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgYmFjayBXZWJJY29uRGF0YWJhc2UgaW5pdGlhbGl6YXRpb24gc3Rh dGVtZW50CisgICAgICAgIGluIFdlYkNvbnRleHQgY29uc3RydWN0b3IuIEl0IHdhcyBjYXVzaW5n IG1pc3NpbmcgaW4KKyAgICAgICAgcjEzODYwNyBhbmQgY2F1c2luZyBhIGxvdCBvZiBjcmFzaGVz IG9uIFdlYktpdDIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OldlYkNvbnRleHQpOgorCiAyMDEyLTEyLTMxICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ29udmVydCBtb3JlIGNsYXNzZXMg dG8gYmUgV2ViQ29udGV4dFN1cHBsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5jcHAKaW5kZXggNGJiN2Q5ZC4uMWRmNWI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJDb250ZXh0LmNwcApAQCAtMTYwLDYgKzE2MCw3IEBAIFdlYkNvbnRleHQ6OldlYkNvbnRl eHQoUHJvY2Vzc01vZGVsIHByb2Nlc3NNb2RlbCwgY29uc3QgU3RyaW5nJiBpbmplY3RlZEJ1bmRs ZVBhCiAjaWYgRU5BQkxFKEJBVFRFUllfU1RBVFVTKQogICAgIG1fYmF0dGVyeU1hbmFnZXJQcm94 eSA9IFdlYkJhdHRlcnlNYW5hZ2VyUHJveHk6OmNyZWF0ZSh0aGlzKTsKICNlbmRpZgorICAgIG1f aWNvbkRhdGFiYXNlID0gV2ViSWNvbkRhdGFiYXNlOjpjcmVhdGUodGhpcyk7CiAjaWYgRU5BQkxF KE5FVFdPUktfSU5GTykKICAgICBtX25ldHdvcmtJbmZvTWFuYWdlclByb3h5ID0gV2ViTmV0d29y a0luZm9NYW5hZ2VyUHJveHk6OmNyZWF0ZSh0aGlzKTsKICNlbmRpZgo= 181017 2013-01-02 01:56:51 -0800 2013-01-02 02:11:01 -0800 Patch 105909_WebIconDatabase_fix.patch text/plain 1344 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZjA0NjAxLi44NDhhZmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDEtMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg2MDcpIENhdXNlcyBjcmFzaGVzIHJlbGF0 ZWQgdG8gV2ViSWNvbkRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDU5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgYmFjayBXZWJJY29uRGF0YWJhc2UgaW5pdGlhbGl6YXRpb24gc3Rh dGVtZW50CisgICAgICAgIGluIFdlYkNvbnRleHQgY29uc3RydWN0b3IuIEl0IHdhcyByZW1vdmVk IGluCisgICAgICAgIHIxMzg2MDcgYW5kIGNhdXNpbmcgYSBsb3Qgb2YgY3Jhc2hlcyBvbiBXZWJL aXQyLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJDb250ZXh0OjpXZWJDb250ZXh0KToKKwogMjAxMi0xMi0zMSAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIENvbnZlcnQgbW9yZSBjbGFzc2VzIHRvIGJlIFdl YkNvbnRleHRTdXBwbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3Bw CmluZGV4IDRiYjdkOWQuLjFkZjViODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5jcHAKQEAgLTE2MCw2ICsxNjAsNyBAQCBXZWJDb250ZXh0OjpXZWJDb250ZXh0KFByb2Nl c3NNb2RlbCBwcm9jZXNzTW9kZWwsIGNvbnN0IFN0cmluZyYgaW5qZWN0ZWRCdW5kbGVQYQogI2lm IEVOQUJMRShCQVRURVJZX1NUQVRVUykKICAgICBtX2JhdHRlcnlNYW5hZ2VyUHJveHkgPSBXZWJC YXR0ZXJ5TWFuYWdlclByb3h5OjpjcmVhdGUodGhpcyk7CiAjZW5kaWYKKyAgICBtX2ljb25EYXRh YmFzZSA9IFdlYkljb25EYXRhYmFzZTo6Y3JlYXRlKHRoaXMpOwogI2lmIEVOQUJMRShORVRXT1JL X0lORk8pCiAgICAgbV9uZXR3b3JrSW5mb01hbmFnZXJQcm94eSA9IFdlYk5ldHdvcmtJbmZvTWFu YWdlclByb3h5OjpjcmVhdGUodGhpcyk7CiAjZW5kaWYK