105906 2013-01-01 22:04:13 -0800 [BlackBerry] Handle re-entrant destruction of MediaPlayerPrivate while a dialog is up 2013-01-04 09:31:32 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 798534 0 mfeil 2013-01-01 22:04:13 -0800 Now that dialogs are not truly modal anymore, we need to handle the case where MediaPlayerPrivate gets destroyed by re-entrant calls while a dialog is up. The re-entrant calls come via the nested event handler that is set up by the dialog code. This nested event handler does defer page loads, but this is not enough to ensure that MediaPlayerPrivate objects don't get destroyed. They can be destroyed by simply changing the source of an audio or video element, for example in a canplaythrough event handler. This patch covers only the WebCore side of the changes required. Most of the work is in the platform repository. See PR272949. 798536 1 181008 mfeil 2013-01-01 22:14:58 -0800 Created attachment 181008 Patch 798537 2 181008 mfeil 2013-01-01 22:17:03 -0800 Comment on attachment 181008 Patch BlackBerry Specific patch, already reviewed by George Staikos. 798538 3 181008 webkit.review.bot 2013-01-01 22:20:33 -0800 Comment on attachment 181008 Patch Rejecting attachment 181008 from review queue. mfeil@rim.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 798539 4 181008 webkit.review.bot 2013-01-01 22:21:10 -0800 Comment on attachment 181008 Patch Rejecting attachment 181008 from commit-queue. mfeil@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 798540 5 181008 mfeil 2013-01-01 22:22:22 -0800 Comment on attachment 181008 Patch Alrighty then. 799822 6 mfeil 2013-01-03 16:25:50 -0800 I'd like to upstream this change, which is already reviewed and landed downstream... 800276 7 181008 webkit.review.bot 2013-01-04 09:31:28 -0800 Comment on attachment 181008 Patch Clearing flags on attachment: 181008 Committed r138805: <http://trac.webkit.org/changeset/138805> 800277 8 webkit.review.bot 2013-01-04 09:31:32 -0800 All reviewed patches have been landed. Closing bug. 181008 2013-01-01 22:14:58 -0800 2013-01-04 09:31:28 -0800 Patch bug-105906-20130102011205.patch text/plain 4967 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI5MWZiZjFjOGQyYjk4 OThhOWVjMWI5NGE2ZWY0ZDNmNGY5NDc1Yy4uNmVjNmU5ZDFiYWI4MDgyZmUyODhhNGIyNWYzYTRi YTU0NmU3ODY3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTAxICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEhhbmRsZSByZS1l bnRyYW50IGRlc3RydWN0aW9uIG9mIE1lZGlhUGxheWVyUHJpdmF0ZSB3aGlsZSBhIGRpYWxvZyBp cyB1cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1 OTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCisKKyAgICAgICAgTm93 IHRoYXQgZGlhbG9ncyBhcmUgbm90IHRydWx5IG1vZGFsIGFueW1vcmUsIHdlIG5lZWQgdG8KKyAg ICAgICAgaGFuZGxlIHRoZSBjYXNlIHdoZXJlIE1lZGlhUGxheWVyUHJpdmF0ZSBnZXRzIGRlc3Ry b3llZCBieQorICAgICAgICByZS1lbnRyYW50IGNhbGxzIHdoaWxlIGEgZGlhbG9nIGlzIHVwLiBX ZSBkbyB0aGlzIGJ5IGRlZmVycmluZworICAgICAgICB0aGUgZGVzdHJ1Y3Rpb24gb2YgTU1SUGxh eWVyIHVudGlsIHRoZSB1c2VyIGRpc21pc3NlcyB0aGUgZGlhbG9nLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIHVzZXIgZGlhbG9nIGlucHV0IGlzIG5vdCB5ZXQgcGFydCBvZiB0aGUK KyAgICAgICAgbGF5b3V0dGVzdCBmcmFtZXdvcmsuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjp+TWVkaWFQbGF5ZXJQcml2YXRlKToKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6d2FpdE1ldGFkYXRhVGltZXJGaXJl ZCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6Om9uU2hvd0Vycm9yRGlh bG9nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVy UHJpdmF0ZUJsYWNrQmVycnkuaDoKKyAgICAgICAgKE1lZGlhUGxheWVyUHJpdmF0ZSk6CisKIDIw MTMtMDEtMDEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTI5NDIyMzk+IFVwZGF0ZSBjb3B5cmlnaHQgc3RyaW5ncwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXll clByaXZhdGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKaW5kZXggMzMzZTMy NjdlZDQxOTAyYjI3ZTkxZDA1YTBmOWIzMWY0ZGU5ZDllYy4uNTYxODI1YWE2NGQzNzRlNGJjNGQ1 M2M1M2UzOWI5NmUyYzcyMWY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVy UHJpdmF0ZUJsYWNrQmVycnkuY3BwCkBAIC0xMzgsNyArMTM4LDEzIEBAIE1lZGlhUGxheWVyUHJp dmF0ZTo6fk1lZGlhUGxheWVyUHJpdmF0ZSgpCiAgICAgICAgIHN0YXRpY19jYXN0PFZpZGVvTGF5 ZXJXZWJLaXRUaHJlYWQqPihtX3BsYXRmb3JtTGF5ZXIuZ2V0KCkpLT5zZXRNZWRpYVBsYXllcigw KTsKICNlbmRpZgogCi0gICAgZGVsZXRlR3VhcmRlZE9iamVjdChtX3BsYXRmb3JtUGxheWVyKTsK KyAgICBpZiAobV9wbGF0Zm9ybVBsYXllcikgeworICAgICAgICBpZiAobV9wbGF0Zm9ybVBsYXll ci0+ZGlhbG9nU3RhdGUoKSA9PSBQbGF0Zm9ybVBsYXllcjo6RGlhbG9nU2hvd24pIHsKKyAgICAg ICAgICAgIG1fcGxhdGZvcm1QbGF5ZXItPnNldERpYWxvZ1N0YXRlKFBsYXRmb3JtUGxheWVyOjpN ZWRpYVBsYXllclByaXZhdGVEZXN0cm95ZWQpOworICAgICAgICAgICAgbV9wbGF0Zm9ybVBsYXll ci0+c3RvcCgpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGRlbGV0ZUd1YXJkZWRPYmpl Y3QobV9wbGF0Zm9ybVBsYXllcik7CisgICAgfQogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZTo6bG9hZChjb25zdCBXVEY6OlN0cmluZyYgdXJsKQpAQCAtNjkyLDkgKzY5OCw5IEBAIHZvaWQg TWVkaWFQbGF5ZXJQcml2YXRlOjpvbldhaXRNZXRhZGF0YU5vdGlmaWVkKGJvb2wgaGFzRmluaXNo ZWQsIGludCB0aW1lV2FpdGVkCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6d2FpdE1ldGFkYXRh VGltZXJGaXJlZChUaW1lcjxNZWRpYVBsYXllclByaXZhdGU+KikKIHsKICAgICBpZiAobV9wbGF0 Zm9ybVBsYXllci0+aXNNZXRhZGF0YVJlYWR5KCkpIHsKLSAgICAgICAgbV9wbGF0Zm9ybVBsYXll ci0+cGxheVdpdGhNZXRhZGF0YVJlYWR5KCk7CiAgICAgICAgIGNvbmRpdGlvbmFsbHlHb0Z1bGxz Y3JlZW5BZnRlclBsYXkoKTsKICAgICAgICAgbV93YWl0TWV0YWRhdGFQb3BEaWFsb2dDb3VudGVy ID0gMDsKKyAgICAgICAgbV9wbGF0Zm9ybVBsYXllci0+cGxheVdpdGhNZXRhZGF0YVJlYWR5KCk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTcwNiwxMiArNzEyLDEwIEBAIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlOjp3YWl0TWV0YWRhdGFUaW1lckZpcmVkKFRpbWVyPE1lZGlhUGxheWVy UHJpdmF0ZT4qKQogICAgIH0KICAgICBtX3dhaXRNZXRhZGF0YVBvcERpYWxvZ0NvdW50ZXIgPSAw OwogCi0gICAgLy8gTmVlZCB0byBwcmV2ZW50IHJlLWVudHJhbnQgcGxheSBoZXJlCi0gICAgbV9w bGF0Zm9ybVBsYXllci0+c2V0UHJldmVudFJlZW50cmFudFBsYXkodHJ1ZSk7Ci0gICAgaW50IHdh aXQgPSBzaG93RXJyb3JEaWFsb2coUGxhdGZvcm1QbGF5ZXI6Ok1lZGlhTWV0YURhdGFUaW1lb3V0 RXJyb3IpOwotICAgIG1fcGxhdGZvcm1QbGF5ZXItPnNldFByZXZlbnRSZWVudHJhbnRQbGF5KGZh bHNlKTsKLQotICAgIGlmICghd2FpdCkKKyAgICBQbGF0Zm9ybVBsYXllcjo6RGlhbG9nUmVzdWx0 IHdhaXQgPSBtX3BsYXRmb3JtUGxheWVyLT5zaG93RXJyb3JEaWFsb2coUGxhdGZvcm1QbGF5ZXI6 Ok1lZGlhTWV0YURhdGFUaW1lb3V0RXJyb3IpOworICAgIGlmICh3YWl0ID09IFBsYXRmb3JtUGxh eWVyOjpEaWFsb2dFbWVyZ2VuY3lFeGl0KQorICAgICAgICByZXR1cm47CisgICAgaWYgKHdhaXQg PT0gUGxhdGZvcm1QbGF5ZXI6OkRpYWxvZ1Jlc3BvbnNlMCkKICAgICAgICAgb25QYXVzZU5vdGlm aWVkKCk7CiAgICAgZWxzZSB7CiAgICAgICAgIGlmIChtX3BsYXRmb3JtUGxheWVyLT5pc01ldGFk YXRhUmVhZHkoKSkgewpAQCAtNzg1LDcgKzc4OSw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl OjpvbkF1dGhlbnRpY2F0aW9uQWNjZXB0ZWQoY29uc3QgTU1SQXV0aENoYWxsZW5nZSYgYXV0aENo CiAgICAgICAgIENyZWRlbnRpYWxTdG9yYWdlOjpzZXQoQ3JlZGVudGlhbChhdXRoQ2hhbGxlbmdl LnVzZXJuYW1lKCkuY19zdHIoKSwgYXV0aENoYWxsZW5nZS5wYXNzd29yZCgpLmNfc3RyKCksIHN0 YXRpY19jYXN0PENyZWRlbnRpYWxQZXJzaXN0ZW5jZT4oYXV0aENoYWxsZW5nZS5wZXJzaXN0ZW5j ZSgpKSksIHByb3RlY3Rpb25TcGFjZSwgdXJsKTsKIH0KIAotaW50IE1lZGlhUGxheWVyUHJpdmF0 ZTo6c2hvd0Vycm9yRGlhbG9nKFBsYXRmb3JtUGxheWVyOjpFcnJvciB0eXBlKQoraW50IE1lZGlh UGxheWVyUHJpdmF0ZTo6b25TaG93RXJyb3JEaWFsb2coUGxhdGZvcm1QbGF5ZXI6OkVycm9yIHR5 cGUpCiB7CiAgICAgdXNpbmcgbmFtZXNwYWNlIEJsYWNrQmVycnk6OldlYktpdDsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBs YXllclByaXZhdGVCbGFja0JlcnJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuaAppbmRleCAwZDNkOWJl ZWIyYTY1Y2UzNTg0NDYxNGMzNDRlYTIwNzM0ZDg2ZDhiLi5iYTRjNmEzYWQwZTVkZDEwNjE5ODc0 YmU4ZGFiOGI2NWU5OGE2ZWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJp dmF0ZUJsYWNrQmVycnkuaApAQCAtMTQ4LDcgKzE0OCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IGJvb2wgaXNGdWxsc2NyZWVuKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzRWxlbWVudFBh dXNlZCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc1RhYlZpc2libGUoKSBjb25zdDsKLSAg ICB2aXJ0dWFsIGludCBzaG93RXJyb3JEaWFsb2coQmxhY2tCZXJyeTo6UGxhdGZvcm06OlBsYXRm b3JtUGxheWVyOjpFcnJvcik7CisgICAgdmlydHVhbCBpbnQgb25TaG93RXJyb3JEaWFsb2coQmxh Y2tCZXJyeTo6UGxhdGZvcm06OlBsYXRmb3JtUGxheWVyOjpFcnJvcik7CiAgICAgdmlydHVhbCBC bGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OldpbmRvdyogcGxhdGZvcm1XaW5kb3coKTsK ICAgICB2aXJ0dWFsIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpXZWJNZWRpYVN0cmVhbURlc2NyaXB0 b3IgbG9va3VwTWVkaWFTdHJlYW0oY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYg dXJsKTsKIAo=