105869 2012-12-30 06:23:31 -0800 Regression(r138545): Makes WebAudio tests crash 2012-12-30 06:58:39 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105292 1 cdumez cdumez eric.carlson feature-media-reviews mrobinson pnormand webkit.review.bot oldest_to_newest 798223 0 cdumez 2012-12-30 06:23:31 -0800 http://trac.webkit.org/changeset/138545 wrongly calls adoptGRef() on the object returned by gst_pipeline_get_bus(). This causes the following assertion hit: crash log for WebProcess (pid <unknown>): STDOUT: <empty> STDERR: ASSERTION FAILED: !gstObjectIsFloating(GST_OBJECT(ptr)) STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp(130) : WTF::GRefPtr<T> WTF::adoptGRef(T*) [with T = _GstBus] STDERR: 1 0x7fd7d388adde WTF::GRefPtr<_GstBus> WTF::adoptGRef<_GstBus>(_GstBus*) STDERR: 2 0x7fd7d38bc9b1 WebCore::AudioFileReader::decodeAudioForBusCreation() STDERR: 3 0x7fd7d38bbd63 WebCore::enteredMainLoopCallback(void*) STDERR: 4 0x7fd7ce0c7a1b STDERR: 5 0x7fd7ce0c6e53 g_main_context_dispatch STDERR: 6 0x7fd7ce0c71a0 STDERR: 7 0x7fd7ce0c759a g_main_loop_run STDERR: 8 0x7fd7d38bcd88 WebCore::AudioFileReader::createBus(float, bool) STDERR: 9 0x7fd7d38bcf5f WebCore::createBusFromAudioFile(char const*, bool, float) STDERR: 10 0x7fd7d38baad7 WebCore::AudioBus::loadPlatformResource(char const*, float) STDERR: 11 0x7fd7d2d92589 STDERR: 12 0x7fd7d2d92a6e WebCore::HRTFElevation::calculateKernelsForAzimuthElevation(int, int, float, WTF::String const&, WTF::RefPtr<WebCore::HRTFKernel>&, WTF::RefPtr<WebCore::HRTFKernel>&) STDERR: 13 0x7fd7d2d92f3c WebCore::HRTFElevation::createForSubject(WTF::String const&, int, float) STDERR: 14 0x7fd7d2d8fd54 WebCore::HRTFDatabase::HRTFDatabase(float) STDERR: 15 0x7fd7d2d8fc8e WebCore::HRTFDatabase::create(float) STDERR: 16 0x7fd7d2d91b31 WebCore::HRTFDatabaseLoader::load() STDERR: 17 0x7fd7d2d91ab0 STDERR: 18 0x7fd7d39682f5 STDERR: 19 0x7fd7d398fdea STDERR: 20 0x7fd7ccfffe9a STDERR: 21 0x7fd7d643dcbd clone 798224 1 180955 cdumez 2012-12-30 06:31:08 -0800 Created attachment 180955 Patch Let me know if you prefer to keep using smart pointers here. 798227 2 180955 webkit.review.bot 2012-12-30 06:58:36 -0800 Comment on attachment 180955 Patch Clearing flags on attachment: 180955 Committed r138576: <http://trac.webkit.org/changeset/138576> 798228 3 webkit.review.bot 2012-12-30 06:58:39 -0800 All reviewed patches have been landed. Closing bug. 180955 2012-12-30 06:31:08 -0800 2012-12-30 06:58:36 -0800 Patch 105869_webaudio_assert.patch text/plain 5425 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOWZlYjhkLi42NDc0NjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTItMTItMzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg1NDUpOiBNYWtlcyBXZWJBdWRpbyB0ZXN0 cyBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA1ODY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RvcCB1c2luZyBzbWFydCBwb2ludGVycyBhbmQgYWRvcHRHUmVmKCkgZm9yIHRoZQorICAgICAg ICBHc3RCdXMgb2JqZWN0IGFuZCBjYWxsIGdzdF9vYmplY3RfdW5yZWYoKSBtYW51YWxseS4KKyAg ICAgICAgVGhpcyBmaXhlcyBhc3NlcnRpb25zIGhpdHMgd2hlbiBjYWxsaW5nIGFkb3B0R1JlZigp CisgICAgICAgIHNpbmNlIHRoZSBHc3RCdXMgb2JqZWN0IGhhcyBhIGZsb2F0aW5nIHJlZmVyZW5j ZS4KKworICAgICAgICBBbHRlcm5hdGl2ZWx5LCB3ZSBjb3VsZCBrZWVwIHVzaW5nIHNtYXJ0IHBv aW50ZXJzCisgICAgICAgIGFuZCBzdG9wIGNhbGxpbmcgYWRvcHRHUmVmKCkgc28gdGhhdAorICAg ICAgICBnc3Rfb2JqZWN0X3JlZl9zaW5rKCkgaXMgY2FsbGVkIGFuZCB0aGUgZmxvYXRpbmcKKyAg ICAgICAgZmxhZyBpcyBjbGVhcmVkIGJ1dCBJIHRoaW5rIGl0IGlzIGNsZWFyZXIgdG8gZG8KKyAg ICAgICAgaXQgbWFudWFsbHkgaGVyZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkg Y292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL2dz dHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Om1lc3NhZ2VDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0aW9uR1N0 cmVhbWVyOjpBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkF1 ZGlvRGVzdGluYXRpb25HU3RyZWFtZXI6On5BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvRmlsZVJlYWRlcjo6fkF1ZGlvRmlsZVJlYWRl cik6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0ZpbGVSZWFkZXI6OmRlY29kZUF1ZGlvRm9yQnVz Q3JlYXRpb24pOgorCiAyMDEyLTEyLTI5ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmVuYW1lIFN0eWxlUmVzb2x2ZXIncyBtZW1iZXIgdmFyaWFi bGUgdGhhdCBob2xkcyBTZWxlY3RvckNoZWNrZXIgdG8gYSBwcm9wZXIgbmFtZS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0 aW9uR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1l ci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyLmNwcAppbmRleCA0Mzg2YzRmLi4xN2ZjMDQzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9E ZXN0aW5hdGlvbkdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vZ3N0cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwCkBAIC0zNiw3ICszNiw3 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vIG5lZWRzIHRvIGhhbmRsZSB0aGlzIG51bWJlciBv ZiBmcmFtZXMgcGVyIGN5Y2xlIGFzIHdlbGwuCiBjb25zdCB1bnNpZ25lZCBmcmFtZXNUb1B1bGwg PSAxMjg7CiAKLWdib29sZWFuIG1lc3NhZ2VDYWxsYmFjayhHc3RCdXMqIGJ1cywgR3N0TWVzc2Fn ZSogbWVzc2FnZSwgQXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lciogZGVzdGluYXRpb24pCitnYm9v bGVhbiBtZXNzYWdlQ2FsbGJhY2soR3N0QnVzKiwgR3N0TWVzc2FnZSogbWVzc2FnZSwgQXVkaW9E ZXN0aW5hdGlvbkdTdHJlYW1lciogZGVzdGluYXRpb24pCiB7CiAgICAgcmV0dXJuIGRlc3RpbmF0 aW9uLT5oYW5kbGVNZXNzYWdlKG1lc3NhZ2UpOwogfQpAQCAtNjMsOSArNjMsMTEgQEAgQXVkaW9E ZXN0aW5hdGlvbkdTdHJlYW1lcjo6QXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lcihBdWRpb0lPQ2Fs bGJhY2smIGNhbGxiYWNrLAogICAgICwgbV9pc1BsYXlpbmcoZmFsc2UpCiB7CiAgICAgbV9waXBl bGluZSA9IGdzdF9waXBlbGluZV9uZXcoInBsYXkiKTsKLSAgICBHUmVmUHRyPEdzdEJ1cz4gYnVz ID0gYWRvcHRHUmVmKGdzdF9waXBlbGluZV9nZXRfYnVzKEdTVF9QSVBFTElORShtX3BpcGVsaW5l KSkpOwotICAgIGdzdF9idXNfYWRkX3NpZ25hbF93YXRjaChidXMuZ2V0KCkpOwotICAgIGdfc2ln bmFsX2Nvbm5lY3QoYnVzLmdldCgpLCAibWVzc2FnZSIsIEdfQ0FMTEJBQ0sobWVzc2FnZUNhbGxi YWNrKSwgdGhpcyk7CisgICAgR3N0QnVzKiBidXMgPSBnc3RfcGlwZWxpbmVfZ2V0X2J1cyhHU1Rf UElQRUxJTkUobV9waXBlbGluZSkpOworICAgIEFTU0VSVChidXMpOworICAgIGdzdF9idXNfYWRk X3NpZ25hbF93YXRjaChidXMpOworICAgIGdfc2lnbmFsX2Nvbm5lY3QoYnVzLCAibWVzc2FnZSIs IEdfQ0FMTEJBQ0sobWVzc2FnZUNhbGxiYWNrKSwgdGhpcyk7CisgICAgZ3N0X29iamVjdF91bnJl ZihidXMpOwogCiAgICAgR3N0RWxlbWVudCogd2Via2l0QXVkaW9TcmMgPSByZWludGVycHJldF9j YXN0PEdzdEVsZW1lbnQqPihnX29iamVjdF9uZXcoV0VCS0lUX1RZUEVfV0VCX0FVRElPX1NSQywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAicmF0ZSIsIHNhbXBsZVJhdGUsCkBAIC04Nyw4ICs4OSwxMCBA QCBBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyOjpBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKEF1 ZGlvSU9DYWxsYmFjayYgY2FsbGJhY2ssCiAKIEF1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXI6On5B dWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKCkKIHsKLSAgICBHUmVmUHRyPEdzdEJ1cz4gYnVzID0g YWRvcHRHUmVmKGdzdF9waXBlbGluZV9nZXRfYnVzKEdTVF9QSVBFTElORShtX3BpcGVsaW5lKSkp OwotICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhidXMuZ2V0KCksIHJl aW50ZXJwcmV0X2Nhc3Q8Z3BvaW50ZXI+KG1lc3NhZ2VDYWxsYmFjayksIHRoaXMpOworICAgIEdz dEJ1cyogYnVzID0gZ3N0X3BpcGVsaW5lX2dldF9idXMoR1NUX1BJUEVMSU5FKG1fcGlwZWxpbmUp KTsKKyAgICBBU1NFUlQoYnVzKTsKKyAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5 X2Z1bmMoYnVzLCByZWludGVycHJldF9jYXN0PGdwb2ludGVyPihtZXNzYWdlQ2FsbGJhY2spLCB0 aGlzKTsKKyAgICBnc3Rfb2JqZWN0X3VucmVmKGJ1cyk7CiAgICAgZ3N0X2VsZW1lbnRfc2V0X3N0 YXRlKG1fcGlwZWxpbmUsIEdTVF9TVEFURV9OVUxMKTsKICAgICBnc3Rfb2JqZWN0X3VucmVmKG1f cGlwZWxpbmUpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAppbmRl eCAzNmRhNTQwLi42MWRhNjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVy LmNwcApAQCAtMTQ4LDggKzE0OCwxMCBAQCBBdWRpb0ZpbGVSZWFkZXI6OkF1ZGlvRmlsZVJlYWRl cihjb25zdCB2b2lkKiBkYXRhLCBzaXplX3QgZGF0YVNpemUpCiBBdWRpb0ZpbGVSZWFkZXI6On5B dWRpb0ZpbGVSZWFkZXIoKQogewogICAgIGlmIChtX3BpcGVsaW5lKSB7Ci0gICAgICAgIEdSZWZQ dHI8R3N0QnVzPiBidXMgPSBhZG9wdEdSZWYoZ3N0X3BpcGVsaW5lX2dldF9idXMoR1NUX1BJUEVM SU5FKG1fcGlwZWxpbmUpKSk7Ci0gICAgICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3Rf YnlfZnVuYyhidXMuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8Z3BvaW50ZXI+KG1lc3NhZ2VDYWxs YmFjayksIHRoaXMpOworICAgICAgICBHc3RCdXMqIGJ1cyA9IGdzdF9waXBlbGluZV9nZXRfYnVz KEdTVF9QSVBFTElORShtX3BpcGVsaW5lKSk7CisgICAgICAgIEFTU0VSVChidXMpOworICAgICAg ICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5X2Z1bmMoYnVzLCByZWludGVycHJldF9j YXN0PGdwb2ludGVyPihtZXNzYWdlQ2FsbGJhY2spLCB0aGlzKTsKKyAgICAgICAgZ3N0X29iamVj dF91bnJlZihidXMpOwogICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9waXBlbGluZSwg R1NUX1NUQVRFX05VTEwpOwogICAgICAgICBnc3Rfb2JqZWN0X3VucmVmKEdTVF9PQkpFQ1QobV9w aXBlbGluZSkpOwogICAgIH0KQEAgLTMzMSw5ICszMzMsMTEgQEAgdm9pZCBBdWRpb0ZpbGVSZWFk ZXI6OmRlY29kZUF1ZGlvRm9yQnVzQ3JlYXRpb24oKQogICAgIC8vIEEgZGVpbnRlcmxlYXZlIGVs ZW1lbnQgaXMgYWRkZWQgb25jZSBhIHNyYyBwYWQgYmVjb21lcyBhdmFpbGFibGUgaW4gZGVjb2Rl YmluLgogICAgIG1fcGlwZWxpbmUgPSBnc3RfcGlwZWxpbmVfbmV3KDApOwogCi0gICAgR1JlZlB0 cjxHc3RCdXM+IGJ1cyA9IGFkb3B0R1JlZihnc3RfcGlwZWxpbmVfZ2V0X2J1cyhHU1RfUElQRUxJ TkUobV9waXBlbGluZSkpKTsKLSAgICBnc3RfYnVzX2FkZF9zaWduYWxfd2F0Y2goYnVzLmdldCgp KTsKLSAgICBnX3NpZ25hbF9jb25uZWN0KGJ1cy5nZXQoKSwgIm1lc3NhZ2UiLCBHX0NBTExCQUNL KG1lc3NhZ2VDYWxsYmFjayksIHRoaXMpOworICAgIEdzdEJ1cyogYnVzID0gZ3N0X3BpcGVsaW5l X2dldF9idXMoR1NUX1BJUEVMSU5FKG1fcGlwZWxpbmUpKTsKKyAgICBBU1NFUlQoYnVzKTsKKyAg ICBnc3RfYnVzX2FkZF9zaWduYWxfd2F0Y2goYnVzKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KGJ1 cywgIm1lc3NhZ2UiLCBHX0NBTExCQUNLKG1lc3NhZ2VDYWxsYmFjayksIHRoaXMpOworICAgIGdz dF9vYmplY3RfdW5yZWYoYnVzKTsKIAogICAgIEdzdEVsZW1lbnQqIHNvdXJjZTsKICAgICBpZiAo bV9kYXRhKSB7Cg==