105868 2012-12-30 05:04:24 -0800 [EFL[WK2] Regression(r138574): Should not allocate memory in the fork 2012-12-31 08:32:44 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105867 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 798216 0 cdumez 2012-12-30 05:04:24 -0800 Thiago rightfully reported that my patch from http://trac.webkit.org/changeset/138574 may cause regressions (deadlocks) because it is allocating memory in the fork. There was a commenting explaining that we should not do that but I missed it (sorry). 798218 1 180953 cdumez 2012-12-30 05:11:38 -0800 Created attachment 180953 Patch 798366 2 180953 webkit.review.bot 2012-12-31 08:32:40 -0800 Comment on attachment 180953 Patch Clearing flags on attachment: 180953 Committed r138597: <http://trac.webkit.org/changeset/138597> 798367 3 webkit.review.bot 2012-12-31 08:32:44 -0800 All reviewed patches have been landed. Closing bug. 180953 2012-12-30 05:11:38 -0800 2012-12-31 08:32:40 -0800 Patch 105868_fastMalloc_fork.patch text/plain 2394 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMWFmZTUwLi5hNWEwY2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMTItMzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMW1dLMl0gUmVncmVzc2lvbihyMTM4NTc0KTogU2hvdWxkIG5v dCBhbGxvY2F0ZSBtZW1vcnkgaW4gdGhlIGZvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTg2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN0b3JlIHByZWZpeGVkIGV4ZWN1dGFibGUgcGF0aCBpbiBh IENTdHJpbmcgYmVmb3JlIHRoZSBmb3JrIHRvCisgICAgICAgIGF2b2lkIGFsbG9jYXRpbmcgbWVt b3J5IGluIHRoZSBmb3JrIGJ5IGNhbGxpbmcgU3RyaW5nOjp1dGY4KCkuCisgICAgICAgIEFsbG9j YXRpbmcgbWVtb3J5IGluIHRoZSBmb3JrIG1heSBsZWFkIHRvIGRlYWRsb2NrcyBkdWUgdG8KKyAg ICAgICAgRmFzdE1hbGxvYyBhbmQgdGhlIGZvcmsgbm90IGluaGVyaXRpbmcgdGhlIHRocmVhZHMu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZWZsL1Byb2Nlc3NMYXVuY2hlckVmbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6CisK KzIwMTItMTItMzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KKwogICAgICAgICBbRUZMXVtXSzJdIEludmFsaWQgdXNlIG9mIHRlbXBvcmFyeSBvYmplY3Qg aW4gUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKCkKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTg2NwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZWZsL1Byb2Nlc3NMYXVuY2hlckVmbC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZWZsL1Byb2Nlc3NMYXVuY2hlckVmbC5j cHAKaW5kZXggY2RkMDYwMS4uZDg5ZDhmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0xhdW5jaGVyL2VmbC9Qcm9jZXNzTGF1bmNoZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9lZmwvUHJvY2Vzc0xhdW5jaGVyRWZsLmNwcApAQCAt NjEsOSArNjEsMTAgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAg IHNucHJpbnRmKHNvY2tldCwgc2l6ZW9mKHNvY2tldCksICIlZCIsIHNvY2tldHNbMF0pOwogCiAj aWZuZGVmIE5ERUJVRwotICAgIFN0cmluZyBwcmVmaXhlZEV4ZWN1dGFibGVQYXRoOworICAgIENT dHJpbmcgcHJlZml4ZWRFeGVjdXRhYmxlUGF0aDsKICAgICBpZiAoIW1fbGF1bmNoT3B0aW9ucy5w cm9jZXNzQ21kUHJlZml4LmlzRW1wdHkoKSkgewotICAgICAgICBwcmVmaXhlZEV4ZWN1dGFibGVQ YXRoID0gbV9sYXVuY2hPcHRpb25zLnByb2Nlc3NDbWRQcmVmaXggKyAnICcgKyBTdHJpbmc6OmZy b21VVEY4KGV4ZWN1dGFibGVQYXRoLmRhdGEoKSkgKyAnICcgKyBzb2NrZXQ7CisgICAgICAgIFN0 cmluZyBwcmVmaXhlZEV4ZWN1dGFibGVQYXRoU3RyID0gbV9sYXVuY2hPcHRpb25zLnByb2Nlc3ND bWRQcmVmaXggKyAnICcgKyBTdHJpbmc6OmZyb21VVEY4KGV4ZWN1dGFibGVQYXRoLmRhdGEoKSkg KyAnICcgKyBzb2NrZXQ7CisgICAgICAgIHByZWZpeGVkRXhlY3V0YWJsZVBhdGggPSBwcmVmaXhl ZEV4ZWN1dGFibGVQYXRoU3RyLnV0ZjgoKTsKICAgICB9CiAjZW5kaWYKIApAQCAtNzgsNyArNzks NyBAQCB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2VzcygpCiAgICAgICAgICAgICAv LyBGSVhNRTogVGhpcyBpcyBub3QgY29ycmVjdCBiZWNhdXNlIGl0IGludm9rZXMgdGhlIHNoZWxs CiAgICAgICAgICAgICAvLyBhbmQga2VlcHMgdGhpcyBwcm9jZXNzIHdhaXRpbmcuIFNob3VsZCBi ZSBjaGFuZ2VkIHRvCiAgICAgICAgICAgICAvLyBzb21ldGhpbmcgbGlrZSBleGVjdnAoKS4KLSAg ICAgICAgICAgIGlmIChzeXN0ZW0ocHJlZml4ZWRFeGVjdXRhYmxlUGF0aC51dGY4KCkuZGF0YSgp KSA9PSAtMSkgeworICAgICAgICAgICAgaWYgKHN5c3RlbShwcmVmaXhlZEV4ZWN1dGFibGVQYXRo LmRhdGEoKSkgPT0gLTEpIHsKICAgICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICAgICAgICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7CiAgICAgICAgICAgICB9IGVsc2UK