105855 2012-12-29 03:24:17 -0800 Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members. 2012-12-29 03:39:33 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 798101 0 loislo 2012-12-29 03:24:17 -0800 Plugin scans all methods in the translation unit, visits methods with reportMemoryUsage name and collects all the reported class members into instrumentedMembers vector. Actually it visits all call expressions inside reportMemoryUsage method and only if the method name of call expression matches with predefined set of instrumentation methods, addMember, addRawPointer etc. then it scans all the arguments of the call expression. It expects that argument has type MemberExpr but for the mutable members the type of the expression is ImplicitCastExpr because it needs to be converted into const T& where T is a template argument of addMember method. 798103 1 180930 loislo 2012-12-29 03:28:48 -0800 Created attachment 180930 Patch 798106 2 loislo 2012-12-29 03:39:33 -0800 Committed r138563: <http://trac.webkit.org/changeset/138563> 180930 2012-12-29 03:28:48 -0800 2012-12-29 03:32:51 -0800 Patch bug-105855-20121229152558.patch text/plain 3838 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzJjYWRmMzI1ZDA5MjdiY2NhMjZlMDY0OTAyMmZiNDBk YTcyMWU4OC4uZDRjMDU3ZWZiZTg1YmI4ZjAwMTViMmQ5YTBkMzhiZDgxOGQyNDUxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTEyLTI5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K IAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBOYXRpdmUgTWVtb3J5IEluc3RydW1lbnRhdGlvbiBw bHVnaW46IGRvIG5vdCBnZW5lcmF0ZSAnbm90IGluc3RydW1lbnRlZCcgd2FybmluZyBmb3IgaW5z dHJ1bWVudGVkIG11dGFibGUgbWVtYmVycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNTg1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEV4dHJhY3QgTWVtYmVyRXhwciBmcm9tIEltcGxpY2l0Q2FzdEV4 cHIuIEl0IGhhcHBlbnMgd2hlbiB3ZSBpbnN0cnVtZW50IGEgbXV0YWJsZSBtZW1iZXIgYmVjYXVz ZQorICAgICAgICBhZGRNZW1iZXIgZXhwZWN0cyBjb25zdCBUJiBhbmQgdGhlIG11dGFibGUgcmVm IHRvIG1lbWJlciBpbXBsaWNpdGx5IGNvbnZlcnRzIGludG8gY29uc3QgcmVmIHRvIG1lbWJlci4K KworICAgICAgICAqIGNsYW5nL1JlcG9ydE1lbW9yeVVzYWdlUGx1Z2luL1JlcG9ydE1lbW9yeVVz YWdlLmNwcDoKKyAgICAgICAgKFJlcG9ydE1lbW9yeVVzYWdlVmlzaXRvcik6CisgICAgICAgIChj bGFuZzo6QWRkTWVtYmVyQ2FsbFZpc2l0b3I6OlZpc2l0Q2FsbEV4cHIpOgorICAgICAgICAoY2xh bmc6OlJlcG9ydE1lbW9yeVVzYWdlVmlzaXRvcjo6VmlzaXRDWFhNZXRob2REZWNsKToKKyAgICAg ICAgKGNsYW5nOjpSZXBvcnRNZW1vcnlVc2FnZVZpc2l0b3I6OmNoZWNrTWVtYmVyc0NvdmVyYWdl KToKKworMjAxMi0xMi0yOSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogTmF0aXZlIE1lbW9yeSBJbnN0cnVtZW50YXRpb24g cGx1Z2luOiBtb3ZlIGZ1bmN0aW9uIGJvZGllcyBvdXQgb2YgY2xhc3MgZGVjbGFyYXRpb25zLgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODUyCiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL2NsYW5nL1JlcG9ydE1lbW9yeVVzYWdlUGx1Z2luL1JlcG9ydE1l bW9yeVVzYWdlLmNwcCBiL1Rvb2xzL2NsYW5nL1JlcG9ydE1lbW9yeVVzYWdlUGx1Z2luL1JlcG9y dE1lbW9yeVVzYWdlLmNwcAppbmRleCBhZmMyMTdkYjJmNmJkMDFjNmY0NGE3YWE4Yzg1MDEwMzVk MjQ1ODkzLi5mMzA5OTQ3NjVjMWZiMDZlMzNhZGViMDk4M2Q4MDgxNGYyNGI2MDk5IDEwMDY0NAot LS0gYS9Ub29scy9jbGFuZy9SZXBvcnRNZW1vcnlVc2FnZVBsdWdpbi9SZXBvcnRNZW1vcnlVc2Fn ZS5jcHAKKysrIGIvVG9vbHMvY2xhbmcvUmVwb3J0TWVtb3J5VXNhZ2VQbHVnaW4vUmVwb3J0TWVt b3J5VXNhZ2UuY3BwCkBAIC02Nyw3ICs2Nyw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBlbWl0V2Fy bmluZyhTb3VyY2VMb2NhdGlvbiwgY29uc3QgY2hhciogcmF3RXJyb3IpOwogICAgIENYWE1ldGhv ZERlY2wqIGZpbmRJbnN0cnVtZW50YXRpb25NZXRob2QoQ1hYUmVjb3JkRGVjbCopOwogICAgIGJv b2wgbmVlZHNUb0JlSW5zdHJ1bWVudGVkKGNvbnN0IFR5cGUqKTsKLSAgICB2b2lkIENoZWNrTWVt YmVyc0NvdmVyYWdlKGNvbnN0IENYWFJlY29yZERlY2wqIGluc3RydW1lbnRlZENsYXNzLCBjb25z dCBTdHJpbmdzJiBpbnN0cnVtZW50ZWRNZW1iZXJzLCBTb3VyY2VMb2NhdGlvbik7CisgICAgdm9p ZCBjaGVja01lbWJlcnNDb3ZlcmFnZShjb25zdCBDWFhSZWNvcmREZWNsKiBpbnN0cnVtZW50ZWRD bGFzcywgY29uc3QgU3RyaW5ncyYgaW5zdHJ1bWVudGVkTWVtYmVycywgU291cmNlTG9jYXRpb24p OwogCiAgICAgQ29tcGlsZXJJbnN0YW5jZSYgbV9pbnN0YW5jZTsKICAgICBBU1RDb250ZXh0KiBt X2NvbnRleHQ7CkBAIC0xNDUsNyArMTQ1LDEwIEBAIGJvb2wgQWRkTWVtYmVyQ2FsbFZpc2l0b3I6 OlZpc2l0Q2FsbEV4cHIoQ2FsbEV4cHIqIGNhbGxFeHByKQogICAgIH0KICAgICBpZiAoaW5zdHJ1 bWVudGVkIHx8ICFtZXRob2RDYWxsRXhwcikgewogICAgICAgICBmb3IgKENhbGxFeHByOjphcmdf aXRlcmF0b3IgaSA9IGNhbGxFeHByLT5hcmdfYmVnaW4oKTsgaSAhPSBjYWxsRXhwci0+YXJnX2Vu ZCgpOyArK2kpIHsKLSAgICAgICAgICAgIGlmIChNZW1iZXJFeHByKiBtZW1iZXJFeHByID0gZHlu X2Nhc3Q8TWVtYmVyRXhwcj4oKmkpKQorICAgICAgICAgICAgRXhwciogZXhwciA9ICppOworICAg ICAgICAgICAgd2hpbGUgKEltcGxpY2l0Q2FzdEV4cHI6OmNsYXNzb2YoZXhwcikpCisgICAgICAg ICAgICAgICAgZXhwciA9IHN0YXRpY19jYXN0PEltcGxpY2l0Q2FzdEV4cHIqPihleHByKS0+Z2V0 U3ViRXhwcigpOworICAgICAgICAgICAgaWYgKE1lbWJlckV4cHIqIG1lbWJlckV4cHIgPSBkeW5f Y2FzdDxNZW1iZXJFeHByPihleHByKSkKICAgICAgICAgICAgICAgICBtX2luc3RydW1lbnRlZE1l bWJlcnMucHVzaF9iYWNrKG1lbWJlckV4cHItPmdldE1lbWJlck5hbWVJbmZvKCkuZ2V0QXNTdHJp bmcoKSk7CiAgICAgICAgIH0KICAgICB9CkBAIC0xNTksNyArMTYyLDcgQEAgYm9vbCBSZXBvcnRN ZW1vcnlVc2FnZVZpc2l0b3I6OlZpc2l0Q1hYTWV0aG9kRGVjbChjbGFuZzo6Q1hYTWV0aG9kRGVj bCogZGVjbCkKICAgICAgICAgaWYgKGZ1bGxMb2NhdGlvbi5pc1ZhbGlkKCkpIHsKICAgICAgICAg ICAgIEFkZE1lbWJlckNhbGxWaXNpdG9yIHZpc2l0b3I7CiAgICAgICAgICAgICB2aXNpdG9yLlRy YXZlcnNlU3RtdChkZWNsLT5nZXRCb2R5KCkpOwotICAgICAgICAgICAgQ2hlY2tNZW1iZXJzQ292 ZXJhZ2UoZGVjbC0+Z2V0UGFyZW50KCksIHZpc2l0b3IuaW5zdHJ1bWVudGVkTWVtYmVycygpLCBk ZWNsLT5nZXRMb2NTdGFydCgpKTsKKyAgICAgICAgICAgIGNoZWNrTWVtYmVyc0NvdmVyYWdlKGRl Y2wtPmdldFBhcmVudCgpLCB2aXNpdG9yLmluc3RydW1lbnRlZE1lbWJlcnMoKSwgZGVjbC0+Z2V0 TG9jU3RhcnQoKSk7CiAgICAgICAgIH0KICAgICB9CiAgICAgcmV0dXJuIHRydWU7CkBAIC0yMDgs NyArMjExLDcgQEAgYm9vbCBSZXBvcnRNZW1vcnlVc2FnZVZpc2l0b3I6Om5lZWRzVG9CZUluc3Ry dW1lbnRlZChjb25zdCBUeXBlKiB0eXBlKQogICAgIHJldHVybiB0cnVlOwogfQogCi12b2lkIFJl cG9ydE1lbW9yeVVzYWdlVmlzaXRvcjo6Q2hlY2tNZW1iZXJzQ292ZXJhZ2UoY29uc3QgQ1hYUmVj b3JkRGVjbCogaW5zdHJ1bWVudGVkQ2xhc3MsIGNvbnN0IFN0cmluZ3MmIGluc3RydW1lbnRlZE1l bWJlcnMsIFNvdXJjZUxvY2F0aW9uIGxvY2F0aW9uKQordm9pZCBSZXBvcnRNZW1vcnlVc2FnZVZp c2l0b3I6OmNoZWNrTWVtYmVyc0NvdmVyYWdlKGNvbnN0IENYWFJlY29yZERlY2wqIGluc3RydW1l bnRlZENsYXNzLCBjb25zdCBTdHJpbmdzJiBpbnN0cnVtZW50ZWRNZW1iZXJzLCBTb3VyY2VMb2Nh dGlvbiBsb2NhdGlvbikKIHsKICAgICBmb3IgKENYWFJlY29yZERlY2w6OmZpZWxkX2l0ZXJhdG9y IGkgPSBpbnN0cnVtZW50ZWRDbGFzcy0+ZmllbGRfYmVnaW4oKTsgaSAhPSBpbnN0cnVtZW50ZWRD bGFzcy0+ZmllbGRfZW5kKCk7ICsraSkgewogICAgICAgICBzdHJpbmcgZmllbGROYW1lID0gaS0+ Z2V0TmFtZUFzU3RyaW5nKCk7Cg==