105854 2012-12-29 02:56:47 -0800 Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time. 2012-12-29 04:42:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov caseq keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 798094 0 eustas 2012-12-29 02:56:47 -0800 Problem: CPU task indexes are already incremented before written to data structure. 798095 1 180928 eustas 2012-12-29 02:58:21 -0800 Created attachment 180928 Patch 798098 2 180928 caseq 2012-12-29 03:16:36 -0800 Comment on attachment 180928 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180928&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:955 > + lastElement._tasksInfo.lastTaskIndex = taskIndex - 1; just make it a for() loop and these -1s will go away. 798099 3 180928 eustas 2012-12-29 03:20:39 -0800 Comment on attachment 180928 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180928&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:955 >> + lastElement._tasksInfo.lastTaskIndex = taskIndex - 1; > > just make it a for() loop and these -1s will go away. Done 798100 4 180929 eustas 2012-12-29 03:23:02 -0800 Created attachment 180929 Patch 798108 5 180929 caseq 2012-12-29 04:10:23 -0800 Comment on attachment 180929 Patch LGTM 798115 6 180929 webkit.review.bot 2012-12-29 04:42:19 -0800 Comment on attachment 180929 Patch Clearing flags on attachment: 180929 Committed r138564: <http://trac.webkit.org/changeset/138564> 798116 7 webkit.review.bot 2012-12-29 04:42:23 -0800 All reviewed patches have been landed. Closing bug. 180928 2012-12-29 02:58:21 -0800 2012-12-29 03:22:57 -0800 Patch bug-105854-20121229145531.patch text/plain 2174 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4ODM1YzMyYjc2YjVk NWFjNmNjZmE5OTVhOTY5NWE0OWRmOTE3Yi4uM2JjNjQ3NDgyNWE5ZmI2NTgwNzUyNTk1ODYyOThl ZmE0ZmQ2ZWRjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTI5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtUaW1lbGluZV0gY3B1IGJhciBwb3BvdmVyIHNob3dzIHdyb25nIGR1cmF0aW9uIC8g Y3B1IHRpbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDU4NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQcm9ibGVtOiBDUFUgdGFzayBpbmRleGVzIGFyZSBhbHJlYWR5IGluY3JlbWVudGVkIGJlZm9y ZSB3cml0dGVuIHRvCisgICAgICAgIGRhdGEgc3RydWN0dXJlLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lUGFuZWwucHJvdG90eXBlLl9yZWZyZXNoTWFpblRocmVhZEJhcnMpOgorICAgICAgICBG aXhlZCBpbmRleGVzLgorCiAyMDEyLTEyLTI4ICBObydhbSBSb3NlbnRoYWwgIDxub2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW1RleG1hcF0gRWRnZSBhbnRpYWxpYXNpbmcgaW4gVGV4dHVyZU1h cHBlciBjb3VsZCBiZSBkb25lIHdpdGggbGVzcyBwZXItcGl4ZWwgY2FsbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwppbmRleCA2 ZWVhZTNjYTI2MTVkYzM4NjM3NmE3MGQxOWJlMTcyYWRjNzM4OTEyLi4zODVjNWNhYjIxNTY0Mzgz NzExYmY1ODU3MGM4M2QyMDk0M2NmZDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCkBAIC05NTIsNyArOTUyLDcgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHZh ciBnYXAgPSBNYXRoLmZsb29yKGxlZnQpIC0gTWF0aC5jZWlsKGxhc3RSaWdodCk7CiAgICAgICAg ICAgICAgICAgaWYgKGdhcCA8IG1pbkdhcCkgewogICAgICAgICAgICAgICAgICAgICBsYXN0Umln aHQgPSByaWdodDsKLSAgICAgICAgICAgICAgICAgICAgbGFzdEVsZW1lbnQuX3Rhc2tzSW5mby5s YXN0VGFza0luZGV4ID0gdGFza0luZGV4OworICAgICAgICAgICAgICAgICAgICBsYXN0RWxlbWVu dC5fdGFza3NJbmZvLmxhc3RUYXNrSW5kZXggPSB0YXNrSW5kZXggLSAxOwogICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgbGFz dEVsZW1lbnQuc3R5bGUud2lkdGggPSAobGFzdFJpZ2h0IC0gbGFzdExlZnQpICsgInB4IjsKQEAg LTk2Miw3ICs5NjIsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7 CiAgICAgICAgICAgICAgICAgZWxlbWVudCA9IGNvbnRhaW5lci5jcmVhdGVDaGlsZCgiZGl2Iiwg InRpbWVsaW5lLWdyYXBoLWJhciIpOwogCiAgICAgICAgICAgICBlbGVtZW50LnN0eWxlLmxlZnQg PSBsZWZ0ICsgInB4IjsKLSAgICAgICAgICAgIGVsZW1lbnQuX3Rhc2tzSW5mbyA9IHt0YXNrczog dGFza3MsIGZpcnN0VGFza0luZGV4OiB0YXNrSW5kZXgsIGxhc3RUYXNrSW5kZXg6IHRhc2tJbmRl eH07CisgICAgICAgICAgICBlbGVtZW50Ll90YXNrc0luZm8gPSB7dGFza3M6IHRhc2tzLCBmaXJz dFRhc2tJbmRleDogdGFza0luZGV4IC0gMSwgbGFzdFRhc2tJbmRleDogdGFza0luZGV4IC0gMX07 CiAgICAgICAgICAgICBsYXN0TGVmdCA9IGxlZnQ7CiAgICAgICAgICAgICBsYXN0UmlnaHQgPSBy aWdodDsKIAo= 180929 2012-12-29 03:23:02 -0800 2012-12-29 04:42:19 -0800 Patch bug-105854-20121229152012.patch text/plain 1840 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4ODM1YzMyYjc2YjVk NWFjNmNjZmE5OTVhOTY5NWE0OWRmOTE3Yi4uZjVmOTI0MmQ1Zjc4Mzc4YjJkY2M3Zjc4ODgwMmVk ZWJmOGM2ZGE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTI5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtUaW1lbGluZV0gY3B1IGJhciBwb3BvdmVyIHNob3dzIHdyb25nIGR1cmF0aW9uIC8g Y3B1IHRpbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDU4NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQcm9ibGVtOiBDUFUgdGFzayBpbmRleGVzIGFyZSBhbHJlYWR5IGluY3JlbWVudGVkIGJlZm9y ZSB3cml0dGVuIHRvCisgICAgICAgIGRhdGEgc3RydWN0dXJlLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lUGFuZWwucHJvdG90eXBlLl9yZWZyZXNoTWFpblRocmVhZEJhcnMpOgorICAgICAgICBV c2UgZm9yIGxvb3AgdG8gZ2V0IGNvcnJlY3QgaW5kZXhlcy4KKwogMjAxMi0xMi0yOCAgTm8nYW0g Um9zZW50aGFsICA8bm9hbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtUZXhtYXBdIEVkZ2UgYW50 aWFsaWFzaW5nIGluIFRleHR1cmVNYXBwZXIgY291bGQgYmUgZG9uZSB3aXRoIGxlc3MgcGVyLXBp eGVsIGNhbGxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rp bWVsaW5lUGFuZWwuanMKaW5kZXggNmVlYWUzY2EyNjE1ZGMzODYzNzZhNzBkMTliZTE3MmFkYzcz ODkxMi4uYTMzYmVlZTQ0NjQ2ZGFiYjhjOTQzOTBhZWM3Mjk4M2U3OTE0Y2YwYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwpA QCAtOTM5LDExICs5MzksMTAgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBl ID0gewogICAgICAgICB2YXIgbGFzdExlZnQ7CiAgICAgICAgIHZhciBsYXN0UmlnaHQ7CiAKLSAg ICAgICAgd2hpbGUgKHRhc2tJbmRleCA8IHRhc2tzLmxlbmd0aCkgeworICAgICAgICBmb3IgKDsg dGFza0luZGV4IDwgdGFza3MubGVuZ3RoOyArK3Rhc2tJbmRleCkgewogICAgICAgICAgICAgdmFy IHRhc2sgPSB0YXNrc1t0YXNrSW5kZXhdOwogICAgICAgICAgICAgaWYgKHRhc2suc3RhcnRUaW1l ID4gZW5kVGltZSkKICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIHRhc2tJbmRl eCsrOwogCiAgICAgICAgICAgICB2YXIgbGVmdCA9IE1hdGgubWF4KDAsIHRoaXMuX2NhbGN1bGF0 b3IuY29tcHV0ZVBvc2l0aW9uKHRhc2suc3RhcnRUaW1lKSArIGJhck9mZnNldCAtIHdpZHRoQWRq dXN0bWVudCk7CiAgICAgICAgICAgICB2YXIgcmlnaHQgPSBNYXRoLm1pbih3aWR0aCwgdGhpcy5f Y2FsY3VsYXRvci5jb21wdXRlUG9zaXRpb24odGFzay5lbmRUaW1lKSArIGJhck9mZnNldCArIHdp ZHRoQWRqdXN0bWVudCk7Cg==