105846 2012-12-28 21:05:22 -0800 [WK2][EFL] Add guard around NativeWebTouchEvent 2017-03-11 10:39:18 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 0 seokju webkit-unassigned abecsi benjamin cmarcelo gyuyoung.kim mcatanzaro menard rakuco webkit.review.bot oldest_to_newest 798035 0 seokju 2012-12-28 21:05:22 -0800 Build breaks when TOUCH_EVENTS is disabled. Source/WebKit2/Shared/NativeWebTouchEvent.h:41:50: error: expected class-name before ‘{’ token 798038 1 180913 seokju 2012-12-28 21:11:40 -0800 Created attachment 180913 Patch 801530 2 180913 benjamin 2013-01-07 12:05:16 -0800 Comment on attachment 180913 Patch With a few exceptions, the feature #ifdef should be on the #include side, not in the header. Why is this case different? 801741 3 seokju 2013-01-07 15:42:03 -0800 (In reply to comment #2) > (From update of attachment 180913 [details]) > With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > Why is this case different? NativeWebTouchEvent was derived from WebTouchEvent. But it is around ENABLE(TOUCH_EVENTS) in header file (WebEvent.h). It seems that build breaks when TOUCH_EVENTS is disabled. 801804 4 benjamin 2013-01-07 16:33:56 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 180913 [details] [details]) > > With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > > > Why is this case different? > > NativeWebTouchEvent was derived from WebTouchEvent. But it is around ENABLE(TOUCH_EVENTS) in header file (WebEvent.h). > It seems that build breaks when TOUCH_EVENTS is disabled. I understand that. But why #ifdef the header instead of in the code where the header is included? 801919 5 seokju 2013-01-07 18:35:59 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 180913 [details] [details] [details]) > > > With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > > > > > Why is this case different? > > > > NativeWebTouchEvent was derived from WebTouchEvent. But it is around ENABLE(TOUCH_EVENTS) in header file (WebEvent.h). > > It seems that build breaks when TOUCH_EVENTS is disabled. > > I understand that. But why #ifdef the header instead of in the code where the header is included? Sorry, I was confused. I will upload a new patch. 802729 6 181787 seokju 2013-01-08 15:30:37 -0800 Created attachment 181787 Patch 802741 7 181790 seokju 2013-01-08 15:37:44 -0800 Created attachment 181790 Patch 802753 8 181790 benjamin 2013-01-08 15:52:24 -0800 Comment on attachment 181790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181790&action=review > Source/WebKit2/ChangeLog:8 > + Add TOUCH_EVENTS guard. Please add a sentence to say this fixes EFL build without TOUCH_EVENTS. > Source/WebKit2/Shared/qt/NativeWebTouchEventQt.cpp:29 > +#if ENABLE(TOUCH_EVENTS) > #include "NativeWebTouchEvent.h" > +#endif This is not correct for Qt. For performance reason, Qt exclude such files through the project file. In this case, NativeWebTouchEventQt.cpp is excluded from Target.pri if TOUCH_EVENTS is not defined. 803004 9 181790 gyuyoung.kim 2013-01-08 21:29:48 -0800 Comment on attachment 181790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181790&action=review > Source/WebKit2/ChangeLog:3 > + Add guard around NativeWebTouchEvent It would be good if you add [WK2][EFL][QT] prefix. 803149 10 181876 seokju 2013-01-09 01:46:14 -0800 Created attachment 181876 Patch 803178 11 181876 gyuyoung.kim 2013-01-09 02:45:04 -0800 Comment on attachment 181876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27 > +#if ENABLE(TOUCH_EVENTS) NativeWebTouchEventEfl.cpp already uses this guard. I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h. 803405 12 181876 benjamin 2013-01-09 09:39:00 -0800 Comment on attachment 181876 Patch (In reply to comment #11) > (From update of attachment 181876 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review > > > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27 > > +#if ENABLE(TOUCH_EVENTS) > > NativeWebTouchEventEfl.cpp already uses this guard. You can just move that guard up under the #include of config.h. > I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h. See my previous comments. 804051 13 gyuyoung.kim 2013-01-09 22:05:16 -0800 (In reply to comment #12) > (From update of attachment 181876 [details]) > (In reply to comment #11) > > (From update of attachment 181876 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review > > > > > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27 > > > +#if ENABLE(TOUCH_EVENTS) > > > > NativeWebTouchEventEfl.cpp already uses this guard. > > You can just move that guard up under the #include of config.h. Seokju, please do that. Then, I will set cq+. > > I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h. > > See my previous comments. >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header. I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion. 804065 14 seokju 2013-01-09 22:25:55 -0800 (In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 181876 [details] [details]) > > (In reply to comment #11) > > > (From update of attachment 181876 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review > > > > > > > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27 > > > > +#if ENABLE(TOUCH_EVENTS) > > > > > > NativeWebTouchEventEfl.cpp already uses this guard. > > > > You can just move that guard up under the #include of config.h. > > Seokju, please do that. Then, I will set cq+. > > > > I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h. > > > > See my previous comments. > > >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion. Ok, Thanks. 804069 15 182066 seokju 2013-01-09 22:26:38 -0800 Created attachment 182066 Patch 804072 16 182066 gyuyoung.kim 2013-01-09 22:29:20 -0800 Comment on attachment 182066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182066&action=review > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:26 > #include "config.h" I prefer to add a new line below config.h, if possible. 804076 17 182068 seokju 2013-01-09 22:36:08 -0800 Created attachment 182068 Patch 804079 18 benjamin 2013-01-09 22:48:25 -0800 > >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion. You are right, I am thinking of touch events header in particular. If I am not mistaken, those use the style I mentioned above (right?). For me the difference ties into a feature in development, and optional features like touch events. (In reply to comment #16) > > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:26 > > #include "config.h" > > I prefer to add a new line below config.h, if possible. +1 :) 804094 19 182068 webkit.review.bot 2013-01-09 23:08:40 -0800 Comment on attachment 182068 Patch Clearing flags on attachment: 182068 Committed r139287: <http://trac.webkit.org/changeset/139287> 804095 20 webkit.review.bot 2013-01-09 23:08:45 -0800 All reviewed patches have been landed. Closing bug. 804100 21 gyuyoung.kim 2013-01-09 23:17:24 -0800 (In reply to comment #18) > > >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header. > > > > I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion. > > You are right, I am thinking of touch events header in particular. If I am not mistaken, those use the style I mentioned above (right?). > > For me the difference ties into a feature in development, and optional features like touch events. It looks there is no rule for this. However, I prefer to tie .h and .cpp together with #ifdef guard personally if there is #ifdef guard for those files. I think it will prevent unexpected build break on other ports. But, I'm not sure if this should become one of coding style. 1286405 22 mcatanzaro 2017-03-11 10:39:18 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 180913 2012-12-28 21:11:40 -0800 2013-01-08 15:30:30 -0800 Patch bug-105846-20121229140850.patch text/plain 1186 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDJjNjc4MGNmNWFjMDFh ZGZhZDZiZGMwN2EyMDk4Mzg2ZDk3MjMxYy4uMzQyN2ZhM2U5ZDU0ZmIyY2QwYzg4OTBmZDk3ODhl NTkzMjViMGQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTI4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgZ3VhcmQgYXJv dW5kIE5hdGl2ZVdlYlRvdWNoRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2hhcmVkL05hdGl2ZVdlYlRvdWNoRXZlbnQuaDogQWRkIFRPVUNI X0VWRU5UUyBndWFyZC4KKwogMjAxMi0xMi0yOCAgSm9vbmUgSHVyICA8am9vbmUuaHVyQGludGVs LmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBld2tfY29udGV4dF9yZXNvdXJj ZV9jYWNoZV9jbGVhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL05hdGl2ZVdl YlRvdWNoRXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9OYXRpdmVXZWJUb3VjaEV2ZW50 LmgKaW5kZXggYzYzZDFjZjA3MDViY2ExZWE1NGQzODRmM2YwZjViYzgzMTFhZDYyYS4uZWZmMDM4 MjFhOTVjYTZmNTY5YjJlYzRmMWExNmMwMzUzYzZjZmMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL05hdGl2ZVdlYlRvdWNoRXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvTmF0aXZlV2ViVG91Y2hFdmVudC5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIE5h dGl2ZVdlYlRvdWNoRXZlbnRfaAogI2RlZmluZSBOYXRpdmVXZWJUb3VjaEV2ZW50X2gKIAorI2lm IEVOQUJMRShUT1VDSF9FVkVOVFMpCiAjaW5jbHVkZSAiV2ViRXZlbnQuaCIKIAogI2lmIFBMQVRG T1JNKFFUKQpAQCAtNTgsNCArNTksNSBAQCBwcml2YXRlOgogCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQKIAorI2VuZGlmCiAjZW5kaWYgLy8gTmF0aXZlV2ViVG91Y2hFdmVudF9oCg== 181787 2013-01-08 15:30:37 -0800 2013-01-08 15:37:36 -0800 Patch bug-105846-20130109082741.patch text/plain 1686 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDU4MjQ3NjYxNjk2NmQ4 YWIzNDc3ZTNlMGY2YzkwYjkwZjk3YTRiZC4uZjkyNjZjZjRiOGI1OWFkMWY3YTQxNDhhZWM0MjY5 NmExZmE3OWFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgZ3VhcmQgYXJv dW5kIE5hdGl2ZVdlYlRvdWNoRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBUT1VDSF9FVkVOVFMgZ3VhcmQKKworICAgICAgICAqIFNoYXJl ZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHA6CisgICAgICAgICogU2hhcmVkL3F0L05h dGl2ZVdlYlRvdWNoRXZlbnRRdC5jcHA6CisKIDIwMTMtMDEtMDggIEtpaG9uZyBLd29uICA8a2lo b25nLmt3b25Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRkIERldmljZVByb3hpbWl0eUNvbnRy b2xsZXIgdG8gc3VwcG9ydCBEZXZpY2UgUHJveGltaXR5IEV2ZW50cy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwCmluZGV4IDAw NGNhMzUxNWU4YjBiN2M2MzMwMDdmYTNiMGRhNzE0N2I1OGZlMDEuLmU4YjM0NzMxOWZjNTE5NDMz MjNhMGRiYzA5ZDAyZjJmNmYzZDY4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcApAQCAtMjQsNyArMjQsOSBAQAogICov CiAKICNpbmNsdWRlICJjb25maWcuaCIKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogI2luY2x1 ZGUgIk5hdGl2ZVdlYlRvdWNoRXZlbnQuaCIKKyNlbmRpZgogCiAjaW5jbHVkZSAiV2ViRXZlbnRG YWN0b3J5LmgiCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9OYXRpdmVX ZWJUb3VjaEV2ZW50UXQuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L05hdGl2ZVdlYlRv dWNoRXZlbnRRdC5jcHAKaW5kZXggNzhjMDg4M2Q2ZTUwZGNhZmY5YTBhZDE5ZTI2YTgyNzRkMWM1 MjYyYS4uMjVlMWEwNDg0NGU1M2VlNWRlNmZjMDY1NzY1Y2Q2MzMzMWE0ZTMwYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L05hdGl2ZVdlYlRvdWNoRXZlbnRRdC5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L05hdGl2ZVdlYlRvdWNoRXZlbnRRdC5jcHAKQEAg LTI0LDcgKzI0LDkgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisjaWYgRU5BQkxFKFRP VUNIX0VWRU5UUykKICNpbmNsdWRlICJOYXRpdmVXZWJUb3VjaEV2ZW50LmgiCisjZW5kaWYKIAog I2luY2x1ZGUgIldlYkV2ZW50RmFjdG9yeVF0LmgiCiAK 181790 2013-01-08 15:37:44 -0800 2013-01-09 01:46:07 -0800 Patch bug-105846-20130109083447.patch text/plain 1687 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDU4MjQ3NjYxNjk2NmQ4 YWIzNDc3ZTNlMGY2YzkwYjkwZjk3YTRiZC4uMDI2OGJiZTFkMTU0YjFiYjY5NDBkZmY0MGIyYzlk NjI3ZGVjNWE5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgZ3VhcmQgYXJv dW5kIE5hdGl2ZVdlYlRvdWNoRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNTg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBUT1VDSF9FVkVOVFMgZ3VhcmQuCisKKyAgICAgICAgKiBTaGFy ZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwOgorICAgICAgICAqIFNoYXJlZC9xdC9O YXRpdmVXZWJUb3VjaEV2ZW50UXQuY3BwOgorCiAyMDEzLTAxLTA4ICBLaWhvbmcgS3dvbiAgPGtp aG9uZy5rd29uQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEFkZCBEZXZpY2VQcm94aW1pdHlDb250 cm9sbGVyIHRvIHN1cHBvcnQgRGV2aWNlIFByb3hpbWl0eSBFdmVudHMuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwIGIvU291 cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcAppbmRleCAw MDRjYTM1MTVlOGIwYjdjNjMzMDA3ZmEzYjBkYTcxNDdiNThmZTAxLi5lOGIzNDczMTlmYzUxOTQz MzIzYTBkYmMwOWQwMmYyZjZmM2Q2OGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAKQEAgLTI0LDcgKzI0LDkgQEAKICAq LwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICNpbmNs dWRlICJOYXRpdmVXZWJUb3VjaEV2ZW50LmgiCisjZW5kaWYKIAogI2luY2x1ZGUgIldlYkV2ZW50 RmFjdG9yeS5oIgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvTmF0aXZl V2ViVG91Y2hFdmVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9OYXRpdmVXZWJU b3VjaEV2ZW50UXQuY3BwCmluZGV4IDc4YzA4ODNkNmU1MGRjYWZmOWEwYWQxOWUyNmE4Mjc0ZDFj NTI2MmEuLjI1ZTFhMDQ4NDRlNTNlZTVkZTZmYzA2NTc2NWNkNjMzMzFhNGUzMGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9OYXRpdmVXZWJUb3VjaEV2ZW50UXQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9OYXRpdmVXZWJUb3VjaEV2ZW50UXQuY3BwCkBA IC0yNCw3ICsyNCw5IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2lmIEVOQUJMRShU T1VDSF9FVkVOVFMpCiAjaW5jbHVkZSAiTmF0aXZlV2ViVG91Y2hFdmVudC5oIgorI2VuZGlmCiAK ICNpbmNsdWRlICJXZWJFdmVudEZhY3RvcnlRdC5oIgogCg== 181876 2013-01-09 01:46:14 -0800 2013-01-09 22:26:30 -0800 Patch bug-105846-20130109184317.patch text/plain 1209 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDU4MjQ3NjYxNjk2NmQ4 YWIzNDc3ZTNlMGY2YzkwYjkwZjk3YTRiZC4uZjg5MjhlYTQxMTMyNzNlNjZjOWRiMTM3ZDI5NDk4 MDQ1Y2I3YTM1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTA4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBndWFyZCBhcm91bmQgTmF0aXZlV2ViVG91Y2hFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IEVGTCBidWlsZCB3aXRob3V0IFRPVUNIX0VW RU5UUy4KKworICAgICAgICAqIFNoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHA6 IEFkZCBUT1VDSF9FVkVOVFMgZ3VhcmQuCisKIDIwMTMtMDEtMDggIEtpaG9uZyBLd29uICA8a2lo b25nLmt3b25Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRkIERldmljZVByb3hpbWl0eUNvbnRy b2xsZXIgdG8gc3VwcG9ydCBEZXZpY2UgUHJveGltaXR5IEV2ZW50cy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwCmluZGV4IDAw NGNhMzUxNWU4YjBiN2M2MzMwMDdmYTNiMGRhNzE0N2I1OGZlMDEuLmU4YjM0NzMxOWZjNTE5NDMz MjNhMGRiYzA5ZDAyZjJmNmYzZDY4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcApAQCAtMjQsNyArMjQsOSBAQAogICov CiAKICNpbmNsdWRlICJjb25maWcuaCIKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogI2luY2x1 ZGUgIk5hdGl2ZVdlYlRvdWNoRXZlbnQuaCIKKyNlbmRpZgogCiAjaW5jbHVkZSAiV2ViRXZlbnRG YWN0b3J5LmgiCiAK 182066 2013-01-09 22:26:38 -0800 2013-01-09 22:35:59 -0800 Patch bug-105846-20130110152340.patch text/plain 1493 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDU4MjQ3NjYxNjk2NmQ4 YWIzNDc3ZTNlMGY2YzkwYjkwZjk3YTRiZC4uY2NhMzRhNzgxZjc1MDFjZjExYjhjMDY3MDIyNjhi MzViZGIxMjkwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTA4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBndWFyZCBhcm91bmQgTmF0aXZlV2ViVG91Y2hFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QmVuamFtaW4gUG91bGFpbi4KKworICAgICAgICBGaXggRUZMIGJ1aWxkIHdpdGhvdXQgVE9VQ0hf RVZFTlRTLgorCisgICAgICAgICogU2hhcmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNw cDogQWRkIFRPVUNIX0VWRU5UUyBndWFyZC4KKwogMjAxMy0wMS0wOCAgS2lob25nIEt3b24gIDxr aWhvbmcua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgRGV2aWNlUHJveGltaXR5Q29u dHJvbGxlciB0byBzdXBwb3J0IERldmljZSBQcm94aW1pdHkgRXZlbnRzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAKaW5kZXgg MDA0Y2EzNTE1ZThiMGI3YzYzMzAwN2ZhM2IwZGE3MTQ3YjU4ZmUwMS4uNzQ0YmUyYjVjZDNiYjE1 NThkOGZjY2I3MGY2MDVhOWNhODhiYzgyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hh cmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwCkBAIC0yNCwxMiArMjQsMTEgQEAK ICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICNp bmNsdWRlICJOYXRpdmVXZWJUb3VjaEV2ZW50LmgiCiAKICNpbmNsdWRlICJXZWJFdmVudEZhY3Rv cnkuaCIKIAotI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCi0KIG5hbWVzcGFjZSBXZWJLaXQgewog CiBOYXRpdmVXZWJUb3VjaEV2ZW50OjpOYXRpdmVXZWJUb3VjaEV2ZW50KEV3a19Ub3VjaF9FdmVu dF9UeXBlIHR5cGUsIGNvbnN0IEVpbmFfTGlzdCogcG9pbnRzLCBjb25zdCBFdmFzX01vZGlmaWVy KiBtb2RpZmllcnMsIGNvbnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSYgdG9XZWJDb250ZW50 LCBjb25zdCBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0mIHRvRGV2aWNlU2NyZWVuLCBkb3VibGUg dGltZXN0YW1wKQo= 182068 2013-01-09 22:36:08 -0800 2013-01-09 23:08:40 -0800 Patch bug-105846-20130110153310.patch text/plain 1495 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDU4MjQ3NjYxNjk2NmQ4 YWIzNDc3ZTNlMGY2YzkwYjkwZjk3YTRiZC4uY2NhMzRhNzgxZjc1MDFjZjExYjhjMDY3MDIyNjhi MzViZGIxMjkwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTA4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBndWFyZCBhcm91bmQgTmF0aXZlV2ViVG91Y2hFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QmVuamFtaW4gUG91bGFpbi4KKworICAgICAgICBGaXggRUZMIGJ1aWxkIHdpdGhvdXQgVE9VQ0hf RVZFTlRTLgorCisgICAgICAgICogU2hhcmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNw cDogQWRkIFRPVUNIX0VWRU5UUyBndWFyZC4KKwogMjAxMy0wMS0wOCAgS2lob25nIEt3b24gIDxr aWhvbmcua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgRGV2aWNlUHJveGltaXR5Q29u dHJvbGxlciB0byBzdXBwb3J0IERldmljZSBQcm94aW1pdHkgRXZlbnRzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5jcHAKaW5kZXgg MDA0Y2EzNTE1ZThiMGI3YzYzMzAwN2ZhM2IwZGE3MTQ3YjU4ZmUwMS4uNzI3OTY4MzVhNjY0N2Iw MjcyZGVmMjNlZTZjMjBiMTgxMzlhOTE2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hh cmVkL2VmbC9OYXRpdmVXZWJUb3VjaEV2ZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvZWZsL05hdGl2ZVdlYlRvdWNoRXZlbnRFZmwuY3BwCkBAIC0yNCwxMiArMjQsMTIgQEAK ICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQog I2luY2x1ZGUgIk5hdGl2ZVdlYlRvdWNoRXZlbnQuaCIKIAogI2luY2x1ZGUgIldlYkV2ZW50RmFj dG9yeS5oIgogCi0jaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKLQogbmFtZXNwYWNlIFdlYktpdCB7 CiAKIE5hdGl2ZVdlYlRvdWNoRXZlbnQ6Ok5hdGl2ZVdlYlRvdWNoRXZlbnQoRXdrX1RvdWNoX0V2 ZW50X1R5cGUgdHlwZSwgY29uc3QgRWluYV9MaXN0KiBwb2ludHMsIGNvbnN0IEV2YXNfTW9kaWZp ZXIqIG1vZGlmaWVycywgY29uc3QgV2ViQ29yZTo6QWZmaW5lVHJhbnNmb3JtJiB0b1dlYkNvbnRl bnQsIGNvbnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSYgdG9EZXZpY2VTY3JlZW4sIGRvdWJs ZSB0aW1lc3RhbXApCg==