105800 2012-12-27 06:47:16 -0800 Web Inspector: Native Memory Instrumentation. Update clang plugin according to current instrumentation state. 2012-12-28 01:50:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 797540 0 loislo 2012-12-27 06:47:16 -0800 The code of plugin is out of sync with current state of MemoryInstrumentation code. 797543 1 180798 loislo 2012-12-27 06:49:07 -0800 Created attachment 180798 Patch 797545 2 180798 yurys 2012-12-27 06:54:35 -0800 Comment on attachment 180798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180798&action=review > Tools/clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:201 > + " info.addRawBuffer(m_pointer, m_length);\n" You should also add m_length field. 797825 3 loislo 2012-12-28 01:50:43 -0800 Committed r138530: <http://trac.webkit.org/changeset/138530> 180798 2012-12-27 06:49:07 -0800 2012-12-27 06:54:35 -0800 Patch bug-105800-20121227184618.patch text/plain 3259 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmM4NjBkMGE1MjY1YTVlY2FlNTRjN2ZkM2ZkMzNmY2Rh ODVlYjY3My4uNDQzNjY1ZTUzMTNiZTc5YjNmZGQxYjhmYTRhY2M0ZmUzMTZjNjVmYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTEyLTI3ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBOYXRpdmUgTWVtb3J5IEluc3RydW1lbnRhdGlvbi4g VXBkYXRlIGNsYW5nIHBsdWdpbiBhY2NvcmRpbmcgdG8gdGhlIGN1cnJlbnQgc3RhdGUgb2YgbWVt b3J5IGluc3RydW1lbnRhdGlvbiBjb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBjbGFuZy9SZXBvcnRNZW1vcnlVc2FnZVBsdWdpbi9SZXBvcnRN ZW1vcnlVc2FnZS5jcHA6CisgICAgICAgIChjbGFuZzo6UmVwb3J0TWVtb3J5VXNhZ2VDb25zdW1l cjo6UmVwb3J0TWVtb3J5VXNhZ2VDb25zdW1lcik6CisgICAgICAgIChjbGFuZyk6CisKIDIwMTIt MTItMjYgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFJlcGxhY2UgZmluZCgiVG9vbHMiKSB3aXRoIHJmaW5kKCJUb29scyIpIGJl Y2F1c2UgYmFzZSBkaXIgb2YgV2ViS2l0IG1heSBoYXZlIFRvb2xzIHdvcmQuCmRpZmYgLS1naXQg YS9Ub29scy9jbGFuZy9SZXBvcnRNZW1vcnlVc2FnZVBsdWdpbi9SZXBvcnRNZW1vcnlVc2FnZS5j cHAgYi9Ub29scy9jbGFuZy9SZXBvcnRNZW1vcnlVc2FnZVBsdWdpbi9SZXBvcnRNZW1vcnlVc2Fn ZS5jcHAKaW5kZXggZjVkNDVmNTQ1NmMzZTk4Y2Y0YzRjYzZkOGVmOGZjYzM4MTYxMjY5Zi4uMjRj YjA4MmUyZmFjM2QzMzAyZTgwZDlmZmYxMGQyNDY5MGI2ZWE0YSAxMDA2NDQKLS0tIGEvVG9vbHMv Y2xhbmcvUmVwb3J0TWVtb3J5VXNhZ2VQbHVnaW4vUmVwb3J0TWVtb3J5VXNhZ2UuY3BwCisrKyBi L1Rvb2xzL2NsYW5nL1JlcG9ydE1lbW9yeVVzYWdlUGx1Z2luL1JlcG9ydE1lbW9yeVVzYWdlLmNw cApAQCAtMTU2LDE4ICsxNTYsOSBAQCBwdWJsaWM6CiAgICAgICAgIDogbV92aXNpdG9yKGluc3Rh bmNlLCBjb250ZXh0KQogICAgIHsKICAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5wdXNo X2JhY2soImFkZE1lbWJlciIpOwotICAgICAgICBpbnN0cnVtZW50YXRpb25NZXRob2RzLnB1c2hf YmFjaygiYWRkSW5zdHJ1bWVudGVkTWVtYmVyIik7Ci0gICAgICAgIGluc3RydW1lbnRhdGlvbk1l dGhvZHMucHVzaF9iYWNrKCJhZGRWZWN0b3IiKTsKLSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0 aG9kcy5wdXNoX2JhY2soImFkZFZlY3RvclB0ciIpOwotICAgICAgICBpbnN0cnVtZW50YXRpb25N ZXRob2RzLnB1c2hfYmFjaygiYWRkSW5zdHJ1bWVudGVkVmVjdG9yIik7Ci0gICAgICAgIGluc3Ry dW1lbnRhdGlvbk1ldGhvZHMucHVzaF9iYWNrKCJhZGRJbnN0cnVtZW50ZWRWZWN0b3JQdHIiKTsK LSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5wdXNoX2JhY2soImFkZEhhc2hTZXQiKTsK LSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5wdXNoX2JhY2soImFkZEluc3RydW1lbnRl ZEhhc2hTZXQiKTsKLSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5wdXNoX2JhY2soImFk ZEhhc2hNYXAiKTsKLSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5wdXNoX2JhY2soImFk ZEluc3RydW1lbnRlZEhhc2hNYXAiKTsKLSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0aG9kcy5w dXNoX2JhY2soImFkZExpc3RIYXNoU2V0Iik7CiAgICAgICAgIGluc3RydW1lbnRhdGlvbk1ldGhv ZHMucHVzaF9iYWNrKCJhZGRSYXdCdWZmZXIiKTsKLSAgICAgICAgaW5zdHJ1bWVudGF0aW9uTWV0 aG9kcy5wdXNoX2JhY2soImFkZFN0cmluZyIpOworICAgICAgICBpbnN0cnVtZW50YXRpb25NZXRo b2RzLnB1c2hfYmFjaygiYWRkV2Vha1BvaW50ZXIiKTsKKyAgICAgICAgaW5zdHJ1bWVudGF0aW9u TWV0aG9kcy5wdXNoX2JhY2soImlnbm9yZU1lbWJlciIpOwogICAgIH0KIAogICAgIHZpcnR1YWwg dm9pZCBIYW5kbGVUcmFuc2xhdGlvblVuaXQoY2xhbmc6OkFTVENvbnRleHQmIGNvbnRleHQpCkBA IC0yMDQsMTQgKzE5NSwxOCBAQCBjb25zdCBjaGFyKiBSZXBvcnRNZW1vcnlVc2FnZUFjdGlvbjo6 bV9oZWxwVGV4dCA9CiAgICAgInB1YmxpYzpcbiIKICAgICAiICAgIHZvaWQgcmVwb3J0TWVtb3J5 VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uc3RcbiIKICAgICAi ICAgIHtcbiIKLSAgICAiICAgICAgICBNZW1vcnlDbGFzc0luZm88SW5zdHJ1bWVudGVkQ2xhc3M+ IGluZm8obWVtb3J5T2JqZWN0SW5mbywgdGhpcywgTWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpET00p O1xuIgotICAgICIgICAgICAgIGluZm8uYWRkTWVtYmVyKG1fbm90SW5zdHJ1bWVudGVkUHRyKTtc biIKLSAgICAiICAgICAgICBpbmZvLmFkZEluc3RydW1lbnRlZE1lbWJlcihtX2luc3RydW1lbnRl ZE9iamVjdCk7XG4iCisgICAgIiAgICAgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2Jq ZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9yeVR5cGVzOjpET00pO1xuIgorICAgICIgICAgICAg IGluZm8uYWRkTWVtYmVyKG1fbm90SW5zdHJ1bWVudGVkT2JqZWN0KTtcbiIKKyAgICAiICAgICAg ICBpbmZvLmFkZE1lbWJlcihtX2luc3RydW1lbnRlZE9iamVjdCk7XG4iCisgICAgIiAgICAgICAg aW5mby5hZGRSYXdCdWZmZXIobV9wb2ludGVyLCBtX2xlbmd0aCk7XG4iCisgICAgIiAgICAgICAg aW5mby5pZ25vcmVNZW1iZXIobV9wb2ludGVyVG9JbnRlcm5hbEZpZWxkKTtcbiIKICAgICAiICAg IH1cbiIKICAgICAiXG4iCiAgICAgInByaXZhdGU6XG4iCiAgICAgIiAgICBOb3RJbnN0cnVtZW50 ZWRDbGFzcyogbV9ub3RJbnN0cnVtZW50ZWRQdHI7XG4iCiAgICAgIiAgICBJbnN0cnVtZW50ZWRD bGFzcyBtX2luc3RydW1lbnRlZE9iamVjdDtcbiIKKyAgICAiICAgIGRvdWJsZSogbV9wb2ludGVy O1xuIgorICAgICIgICAgRGF0YSogbV9wb2ludGVyVG9JbnRlcm5hbEZpZWxkO1xuIgogICAgICJ9 XG4iOwogCiB9Cg==